/Users/deen/code/yugabyte-db/src/yb/master/catalog_manager.cc

Source (jump to first uncovered line)
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements.  See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership.  The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License.  You may obtain a copy of the License at
//
//   http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied.  See the License for the
// specific language governing permissions and limitations
// under the License.
//
// The following only applies to changes made to this file as part of YugaByte development.
//
// Portions Copyright (c) YugaByte, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
// in compliance with the License.  You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software distributed under the License
// is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
// or implied.  See the License for the specific language governing permissions and limitations
// under the License.
//
// ================================================================================================
//
// The catalog manager handles the current list of tables
// and tablets in the cluster, as well as their current locations.
// Since most operations in the master go through these data
// structures, locking is carefully managed here to prevent unnecessary
// contention and deadlocks:
//
// - each structure has an internal spinlock used for operations that
//   are purely in-memory (eg the current status of replicas)
// - data that is persisted on disk is stored in separate PersistentTable(t)Info
//   structs. These are managed using copy-on-write so that writers may block
//   writing them back to disk while not impacting concurrent readers.
//
// Usage rules:
// - You may obtain READ locks in any order. READ locks should never block,
//   since they only conflict with COMMIT which is a purely in-memory operation.
//   Thus they are deadlock-free.
// - If you need a WRITE lock on both a table and one or more of its tablets,
//   acquire the lock on the table first. This strict ordering prevents deadlocks.
//
// ================================================================================================

#include "yb/master/catalog_manager.h"

#include <stdlib.h>

#include <algorithm>
#include <atomic>
#include <bitset>
#include <functional>
#include <memory>
#include <mutex>
#include <set>
#include <string>
#include <unordered_map>
#include <vector>

#include <boost/optional.hpp>
#include <glog/logging.h>

#include "yb/client/client-internal.h"
#include "yb/client/client.h"
#include "yb/client/schema.h"
#include "yb/client/universe_key_client.h"

#include "yb/common/common.pb.h"
#include "yb/common/common_flags.h"
#include "yb/common/constants.h"
#include "yb/common/key_encoder.h"
#include "yb/common/partial_row.h"
#include "yb/common/partition.h"
#include "yb/common/ql_type.h"
#include "yb/common/roles_permissions.h"
#include "yb/common/schema.h"
#include "yb/common/wire_protocol.h"

#include "yb/consensus/consensus.h"
#include "yb/consensus/consensus.pb.h"
#include "yb/consensus/consensus_util.h"
#include "yb/consensus/metadata.pb.h"
#include "yb/consensus/opid_util.h"
#include "yb/consensus/quorum_util.h"

#include "yb/docdb/doc_key.h"

#include "yb/gutil/atomicops.h"
#include "yb/gutil/bind.h"
#include "yb/gutil/casts.h"
#include "yb/gutil/map-util.h"
#include "yb/gutil/mathlimits.h"
#include "yb/gutil/stl_util.h"
#include "yb/gutil/strings/escaping.h"
#include "yb/gutil/strings/join.h"
#include "yb/gutil/strings/substitute.h"
#include "yb/gutil/sysinfo.h"
#include "yb/gutil/walltime.h"

#include "yb/master/master_fwd.h"
#include "yb/master/async_rpc_tasks.h"
#include "yb/master/backfill_index.h"
#include "yb/master/catalog_entity_info.h"
#include "yb/master/catalog_loaders.h"
#include "yb/master/catalog_manager-internal.h"
#include "yb/master/catalog_manager_bg_tasks.h"
#include "yb/master/catalog_manager_util.h"
#include "yb/master/cluster_balance.h"
#include "yb/master/encryption_manager.h"
#include "yb/master/master.h"
#include "yb/master/master_admin.pb.h"
#include "yb/master/master_client.pb.h"
#include "yb/master/master_cluster.proxy.h"
#include "yb/master/master_dcl.pb.h"
#include "yb/master/master_ddl.pb.h"
#include "yb/master/master_encryption.pb.h"
#include "yb/master/master_error.h"
#include "yb/master/master_heartbeat.pb.h"
#include "yb/master/master_replication.pb.h"
#include "yb/master/master_util.h"
#include "yb/master/permissions_manager.h"
#include "yb/master/scoped_leader_shared_lock-internal.h"
#include "yb/master/sys_catalog.h"
#include "yb/master/sys_catalog_constants.h"
#include "yb/master/ts_descriptor.h"
#include "yb/master/yql_aggregates_vtable.h"
#include "yb/master/yql_auth_resource_role_permissions_index.h"
#include "yb/master/yql_auth_role_permissions_vtable.h"
#include "yb/master/yql_auth_roles_vtable.h"
#include "yb/master/yql_columns_vtable.h"
#include "yb/master/yql_empty_vtable.h"
#include "yb/master/yql_functions_vtable.h"
#include "yb/master/yql_indexes_vtable.h"
#include "yb/master/yql_keyspaces_vtable.h"
#include "yb/master/yql_local_vtable.h"
#include "yb/master/yql_partitions_vtable.h"
#include "yb/master/yql_peers_vtable.h"
#include "yb/master/yql_size_estimates_vtable.h"
#include "yb/master/yql_tables_vtable.h"
#include "yb/master/yql_triggers_vtable.h"
#include "yb/master/yql_types_vtable.h"
#include "yb/master/yql_views_vtable.h"
#include "yb/master/ysql_transaction_ddl.h"

#include "yb/rpc/messenger.h"
#include "yb/rpc/rpc_controller.h"

#include "yb/tablet/operations/change_metadata_operation.h"
#include "yb/tablet/tablet.h"
#include "yb/tablet/tablet_metadata.h"
#include "yb/tablet/tablet_peer.h"
#include "yb/tablet/tablet_retention_policy.h"

#include "yb/tserver/remote_bootstrap_client.h"
#include "yb/tserver/ts_tablet_manager.h"
#include "yb/tserver/tserver_error.h"

#include "yb/util/atomic.h"
#include "yb/util/countdown_latch.h"
#include "yb/util/debug-util.h"
#include "yb/util/debug/trace_event.h"
#include "yb/util/flag_tags.h"
#include "yb/util/format.h"
#include "yb/util/hash_util.h"
#include "yb/util/locks.h"
#include "yb/util/math_util.h"
#include "yb/util/metrics.h"
#include "yb/util/monotime.h"
#include "yb/util/net/net_util.h"
#include "yb/util/oid_generator.h"
#include "yb/util/random_util.h"
#include "yb/util/rw_mutex.h"
#include "yb/util/semaphore.h"
#include "yb/util/shared_lock.h"
#include "yb/util/size_literals.h"
#include "yb/util/status.h"
#include "yb/util/status_format.h"
#include "yb/util/status_log.h"
#include "yb/util/stopwatch.h"
#include "yb/util/string_util.h"
#include "yb/util/sync_point.h"
#include "yb/util/thread.h"
#include "yb/util/threadpool.h"
#include "yb/util/trace.h"
#include "yb/util/tsan_util.h"
#include "yb/util/uuid.h"

#include "yb/yql/pgwrapper/pg_wrapper.h"
#include "yb/yql/redis/redisserver/redis_constants.h"

using namespace std::literals;
using namespace yb::size_literals;

DEFINE_int32(master_ts_rpc_timeout_ms, 30 * 1000,  // 30 sec
             "Timeout used for the Master->TS async rpc calls.");
TAG_FLAG(master_ts_rpc_timeout_ms, advanced);

DEFINE_int32(tablet_creation_timeout_ms, 30 * 1000,  // 30 sec
             "Timeout used by the master when attempting to create tablet "
             "replicas during table creation.");
TAG_FLAG(tablet_creation_timeout_ms, advanced);

DEFINE_test_flag(bool, disable_tablet_deletion, false,
                 "Whether catalog manager should disable tablet deletion.");

DEFINE_bool(catalog_manager_wait_for_new_tablets_to_elect_leader, true,
            "Whether the catalog manager should wait for a newly created tablet to "
            "elect a leader before considering it successfully created. "
            "This is disabled in some tests where we explicitly manage leader "
            "election.");
TAG_FLAG(catalog_manager_wait_for_new_tablets_to_elect_leader, hidden);

DEFINE_int32(catalog_manager_inject_latency_in_delete_table_ms, 0,
             "Number of milliseconds that the master will sleep in DeleteTable.");
TAG_FLAG(catalog_manager_inject_latency_in_delete_table_ms, hidden);

DECLARE_int32(catalog_manager_bg_task_wait_ms);

DEFINE_int32(replication_factor, 3,
             "Default number of replicas for tables that do not have the num_replicas set.");
TAG_FLAG(replication_factor, advanced);

DEFINE_int32(max_create_tablets_per_ts, 50,
             "The number of tablets per TS that can be requested for a new table.");
TAG_FLAG(max_create_tablets_per_ts, advanced);

DEFINE_int32(catalog_manager_report_batch_size, 1,
            "The max number of tablets evaluated in the heartbeat as a single SysCatalog update.");
TAG_FLAG(catalog_manager_report_batch_size, advanced);

DEFINE_int32(master_failover_catchup_timeout_ms, 30 * 1000 * yb::kTimeMultiplier,  // 30 sec
             "Amount of time to give a newly-elected leader master to load"
             " the previous master's metadata and become active. If this time"
             " is exceeded, the node crashes.");
TAG_FLAG(master_failover_catchup_timeout_ms, advanced);
TAG_FLAG(master_failover_catchup_timeout_ms, experimental);

DEFINE_bool(master_tombstone_evicted_tablet_replicas, true,
            "Whether the Master should tombstone (delete) tablet replicas that "
            "are no longer part of the latest reported raft config.");
TAG_FLAG(master_tombstone_evicted_tablet_replicas, hidden);
DECLARE_bool(master_ignore_deleted_on_load);

// Temporary.  Can be removed after long-run testing.
DEFINE_bool(master_ignore_stale_cstate, true,
            "Whether Master processes the raft config when the version is lower.");
TAG_FLAG(master_ignore_stale_cstate, hidden);

DEFINE_bool(catalog_manager_check_ts_count_for_create_table, true,
            "Whether the master should ensure that there are enough live tablet "
            "servers to satisfy the provided replication count before allowing "
            "a table to be created.");
TAG_FLAG(catalog_manager_check_ts_count_for_create_table, hidden);

DEFINE_test_flag(bool, catalog_manager_check_yql_partitions_exist_for_is_create_table_done, true,
                 "Whether the master should ensure that all of a table's tablets are "
                 "in the YQL system.partitions vtable during the IsCreateTableDone check.");

METRIC_DEFINE_gauge_uint32(cluster, num_tablet_servers_live,
                           "Number of live tservers in the cluster", yb::MetricUnit::kUnits,
                           "The number of tablet servers that have responded or done a heartbeat "
                           "in the time interval defined by the gflag "
                           "FLAGS_tserver_unresponsive_timeout_ms.");

METRIC_DEFINE_gauge_uint32(cluster, num_tablet_servers_dead,
                           "Number of dead tservers in the cluster", yb::MetricUnit::kUnits,
                           "The number of tablet servers that have not responded or done a "
                           "heartbeat in the time interval defined by the gflag "
                           "FLAGS_tserver_unresponsive_timeout_ms.");

DEFINE_test_flag(uint64, inject_latency_during_remote_bootstrap_secs, 0,
                 "Number of seconds to sleep during a remote bootstrap.");

DEFINE_test_flag(uint64, inject_latency_during_tablet_report_ms, 0,
                 "Number of milliseconds to sleep during the processing of a tablet batch.");

DEFINE_test_flag(bool, catalog_manager_simulate_system_table_create_failure, false,
                 "This is only used in tests to simulate a failure where the table information is "
                 "persisted in syscatalog, but the tablet information is not yet persisted and "
                 "there is a failure.");

DEFINE_string(cluster_uuid, "", "Cluster UUID to be used by this cluster");
TAG_FLAG(cluster_uuid, hidden);

DECLARE_int32(yb_num_shards_per_tserver);

DEFINE_int32(transaction_table_num_tablets, 0,
             "Number of tablets to use when creating the transaction status table."
             "0 to use transaction_table_num_tablets_per_tserver.");

DEFINE_int32(transaction_table_num_tablets_per_tserver, kAutoDetectNumShardsPerTServer,
    "The default number of tablets per tablet server for transaction status table. If the value is "
    "-1, the system automatically determines an appropriate value based on number of CPU cores.");

DEFINE_bool(auto_create_local_transaction_tables, true,
            "Whether or not to create local transaction status tables automatically on table "
            "creation with a tablespace with placement specified.");

DEFINE_test_flag(bool, name_transaction_tables_with_tablespace_id, false,
                 "This is only used in tests to make associating automatically created transaction "
                 "tables with their tablespaces easier, and causes transaction tables created "
                 "automatically for tablespaces to include the tablespace oid in their names.");

DEFINE_bool(master_enable_metrics_snapshotter, false, "Should metrics snapshotter be enabled");

DEFINE_int32(metrics_snapshots_table_num_tablets, 0,
             "Number of tablets to use when creating the metrics snapshots table."
             "0 to use the same default num tablets as for regular tables.");

DEFINE_bool(disable_index_backfill, false,
    "A kill switch to disable multi-stage backfill for YCQL indexes.");
TAG_FLAG(disable_index_backfill, runtime);
TAG_FLAG(disable_index_backfill, hidden);

DEFINE_bool(disable_index_backfill_for_non_txn_tables, true,
    "A kill switch to disable multi-stage backfill for user enforced YCQL indexes. "
    "Note that enabling this feature may cause the create index flow to be slow. "
    "This is needed to ensure the safety of the index backfill process. See also "
    "index_backfill_upperbound_for_user_enforced_txn_duration_ms");
TAG_FLAG(disable_index_backfill_for_non_txn_tables, runtime);
TAG_FLAG(disable_index_backfill_for_non_txn_tables, hidden);

DEFINE_bool(enable_transactional_ddl_gc, true,
    "A kill switch for transactional DDL GC. Temporary safety measure.");
TAG_FLAG(enable_transactional_ddl_gc, runtime);
TAG_FLAG(enable_transactional_ddl_gc, hidden);

DEFINE_bool(
    hide_pg_catalog_table_creation_logs, false,
    "Whether to hide detailed log messages for PostgreSQL catalog table creation. "
    "This cuts down test logs significantly.");
TAG_FLAG(hide_pg_catalog_table_creation_logs, hidden);

DEFINE_test_flag(int32, simulate_slow_table_create_secs, 0,
    "Simulates a slow table creation by sleeping after the table has been added to memory.");

DEFINE_test_flag(int32, simulate_slow_system_tablet_bootstrap_secs, 0,
    "Simulates a slow tablet bootstrap by adding a sleep before system tablet init.");

DEFINE_test_flag(bool, return_error_if_namespace_not_found, false,
    "Return an error from ListTables if a namespace id is not found in the map");

DEFINE_test_flag(bool, hang_on_namespace_transition, false,
    "Used in tests to simulate a lapse between issuing a namespace op and final processing.");

DEFINE_test_flag(bool, simulate_crash_after_table_marked_deleting, false,
    "Crash yb-master after table's state is set to DELETING. This skips tablets deletion.");

DEFINE_bool(master_drop_table_after_task_response, true,
            "Mark a table as DELETED as soon as we get all the responses from all the TS.");
TAG_FLAG(master_drop_table_after_task_response, advanced);
TAG_FLAG(master_drop_table_after_task_response, runtime);

DEFINE_test_flag(bool, tablegroup_master_only, false,
                 "This is only for MasterTest to be able to test tablegroups without the"
                 " transaction status table being created.");

DEFINE_bool(enable_register_ts_from_raft, true, "Whether to register a tserver from the consensus "
                                                "information of a reported tablet.");

DECLARE_int32(tserver_unresponsive_timeout_ms);

DEFINE_bool(use_create_table_leader_hint, true,
            "Whether the Master should hint which replica for each tablet should "
            "be leader initially on tablet creation.");
TAG_FLAG(use_create_table_leader_hint, runtime);

DEFINE_test_flag(bool, create_table_leader_hint_min_lexicographic, false,
                 "Whether the Master should hint replica with smallest lexicographic rank for each "
                 "tablet as leader initially on tablet creation.");

DEFINE_double(heartbeat_safe_deadline_ratio, .20,
              "When the heartbeat deadline has this percentage of time remaining, "
              "the master should halt tablet report processing so it can respond in time.");
DECLARE_int32(heartbeat_rpc_timeout_ms);
DECLARE_CAPABILITY(TabletReportLimit);

DEFINE_int32(partitions_vtable_cache_refresh_secs, 0,
             "Amount of time to wait before refreshing the system.partitions cached vtable. "
             "If generate_partitions_vtable_on_changes is set, then this background task will "
             "update the cache using the internal map, but won't do any generating of the vtable.");

DEFINE_int32(txn_table_wait_min_ts_count, 1,
             "Minimum Number of TS to wait for before creating the transaction status table."
             " Default value is 1. We wait for atleast --replication_factor if this value"
             " is smaller than that");
TAG_FLAG(txn_table_wait_min_ts_count, advanced);

DEFINE_bool(enable_ysql_tablespaces_for_placement, true,
            "If set, tablespaces will be used for placement of YSQL tables.");
TAG_FLAG(enable_ysql_tablespaces_for_placement, runtime);

DEFINE_int32(ysql_tablespace_info_refresh_secs, 30,
             "Frequency at which the table to tablespace information will be updated in master "
             "from pg catalog tables. A value of -1 disables the refresh task.");
TAG_FLAG(ysql_tablespace_info_refresh_secs, runtime);

DEFINE_int64(tablet_split_size_threshold_bytes, 0,
             "DEPRECATED -- Threshold on tablet size after which tablet should be split. Automated "
             "splitting is disabled if this value is set to 0.");
TAG_FLAG(tablet_split_size_threshold_bytes, hidden);

DEFINE_int64(tablet_split_low_phase_shard_count_per_node, 8,
             "The per-node tablet count until which a table is splitting at the phase 1 threshold, "
             "as defined by tablet_split_low_phase_size_threshold_bytes.");
DEFINE_int64(tablet_split_high_phase_shard_count_per_node, 24,
             "The per-node tablet count until which a table is splitting at the phase 2 threshold, "
             "as defined by tablet_split_high_phase_size_threshold_bytes.");

DEFINE_int64(tablet_split_low_phase_size_threshold_bytes, 512_MB,
             "The tablet size threshold at which to split tablets in phase 1. "
             "See tablet_split_low_phase_shard_count_per_node.");
DEFINE_int64(tablet_split_high_phase_size_threshold_bytes, 10_GB,
             "The tablet size threshold at which to split tablets in phase 2. "
             "See tablet_split_high_phase_shard_count_per_node.");
DEFINE_int64(tablet_force_split_threshold_bytes, 100_GB,
             "The tablet size threshold at which to split tablets regardless of how many tablets "
             "exist in the table already. This should be configured to prevent runaway whale "
             "tablets from forming in your cluster even if both automatic splitting phases have "
             "been finished.");

DEFINE_test_flag(bool, crash_server_on_sys_catalog_leader_affinity_move, false,
                 "When set, crash the master process if it performs a sys catalog leader affinity "
                 "move.");
DEFINE_int32(blacklist_progress_initial_delay_secs, yb::master::kDelayAfterFailoverSecs,
             "When a master leader failsover, the time until which the progress of load movement "
             "off the blacklisted tservers is reported as 0. This initial delay "
             "gives sufficient time for heartbeats so that we don't report"
             " a premature incorrect completion.");
TAG_FLAG(blacklist_progress_initial_delay_secs, runtime);

DEFINE_test_flag(bool, validate_all_tablet_candidates, false,
                 "When set to true, consider any tablet a valid candidate for splitting. "
                 "Specifically this flag ensures that ValidateSplitCandidateTable and "
                 "ValidateSplitCandidateTablet always return OK and all tablets are considered "
                 "valid candidates for splitting.");

DEFINE_test_flag(bool, skip_placement_validation_createtable_api, false,
                 "When set, it skips checking that all the tablets of a table have enough tservers"
                 " conforming to the table placement policy during CreateTable API call.");
TAG_FLAG(TEST_skip_placement_validation_createtable_api, runtime);

DEFINE_test_flag(int32, slowdown_alter_table_rpcs_ms, 0,
                 "Slows down the alter table rpc's send and response handler so that the TServer "
                 "has a heartbeat delay and triggers tablet leader change.");

DEFINE_test_flag(bool, reject_delete_not_serving_tablet_rpc, false,
                 "Whether to reject DeleteNotServingTablet RPC.");

DEFINE_test_flag(double, crash_after_creating_single_split_tablet, 0.0,
                 "Crash inside CatalogManager::RegisterNewTabletForSplit after calling Upsert");

DEFINE_bool(enable_delete_truncate_xcluster_replicated_table, false,
            "When set, enables deleting/truncating tables currently in xCluster replication");
TAG_FLAG(enable_delete_truncate_xcluster_replicated_table, runtime);

DEFINE_test_flag(bool, sequential_colocation_ids, false,
                 "When set, colocation IDs will be assigned sequentially (starting from 20001) "
                 "rather than at random. This is especially useful for making pg_regress "
                 "tests output consistent and predictable.");

namespace yb {
namespace master {

using std::atomic;
using std::shared_ptr;
using std::string;
using std::unique_ptr;
using std::vector;

using namespace std::placeholders;

using base::subtle::NoBarrier_Load;
using base::subtle::NoBarrier_CompareAndSwap;
using consensus::kMinimumTerm;
using consensus::CONSENSUS_CONFIG_COMMITTED;
using consensus::CONSENSUS_CONFIG_ACTIVE;
using consensus::COMMITTED_OPID;
using consensus::Consensus;
using consensus::ConsensusMetadata;
using consensus::ConsensusServiceProxy;
using consensus::ConsensusStatePB;
using consensus::GetConsensusRole;
using consensus::PeerMemberType;
using consensus::RaftPeerPB;
using consensus::StartRemoteBootstrapRequestPB;
using rpc::RpcContext;
using server::MonitoredTask;
using strings::Substitute;
using tablet::TABLET_DATA_COPYING;
using tablet::TABLET_DATA_DELETED;
using tablet::TABLET_DATA_READY;
using tablet::TABLET_DATA_TOMBSTONED;
using tablet::TabletDataState;
using tablet::RaftGroupMetadata;
using tablet::RaftGroupMetadataPtr;
using tablet::TabletPeer;
using tablet::RaftGroupStatePB;
using tablet::TabletStatusListener;
using tablet::TabletStatusPB;
using tserver::HandleReplacingStaleTablet;
using tserver::TabletServerErrorPB;
using yb::pgwrapper::PgWrapper;
using yb::server::MasterAddressesToString;

using yb::client::YBClient;
using yb::client::YBClientBuilder;
using yb::client::YBColumnSchema;
using yb::client::YBSchema;
using yb::client::YBSchemaBuilder;
using yb::client::YBTable;
using yb::client::YBTableName;

namespace {

// Macros to access index information in CATALOG.
//
// NOTES from file master.proto for SysTablesEntryPB.
// - For index table: [to be deprecated and replaced by "index_info"]
//     optional bytes indexed_table_id = 13; // Indexed table id of this index.
//     optional bool is_local_index = 14 [ default = false ];  // Whether this is a local index.
//     optional bool is_unique_index = 15 [ default = false ]; // Whether this is a unique index.
// - During transition period, we have to consider both fields and the following macros help
//   avoiding duplicate protobuf version check thru out our code.

const std::string& GetIndexedTableId(const SysTablesEntryPB& pb) {
  return pb.has_index_info() ? pb.index_info().indexed_table_id() : pb.indexed_table_id()0;
}

#define PROTO_GET_IS_LOCAL(tabpb) \
  (tabpb.has_index_info() ? tabpb.index_info().is_local() \
                          : tabpb.is_local_index()0)

#define PROTO_GET_IS_UNIQUE(tabpb) \
  (tabpb.has_index_info() ? tabpb.index_info().is_unique() \
                          : tabpb.is_unique_index()0)

template <class PB>
bool IsIndex(const PB& pb) {
  return pb.has_index_info() || !pb.indexed_table_id().empty()43.2k;
}

bool IsTable(const SysTablesEntryPB& pb) {
  return !IsIndex(pb);
}

#define PROTO_PTR_IS_INDEX(tabpb) \
  (tabpb->has_index_info() || !tabpb->indexed_table_id().empty())

#define PROTO_PTR_IS_TABLE(tabpb) \
  (!tabpb->has_index_info() && tabpb->indexed_table_id().empty()7.26k)

#if (0)
// Once the deprecated fields are obsolete, the above macros should be defined as the following.
#define GetIndexedTableId(tabpb) (tabpb.index_info().indexed_table_id())
#define PROTO_GET_IS_LOCAL(tabpb) (tabpb.index_info().is_local())
#define PROTO_GET_IS_UNIQUE(tabpb) (tabpb.index_info().is_unique())
#define PROTO_IS_INDEX(tabpb) (tabpb.has_index_info())
#define PROTO_IS_TABLE(tabpb) (!tabpb.has_index_info())
#define PROTO_PTR_IS_INDEX(tabpb) (tabpb->has_index_info())
#define PROTO_PTR_IS_TABLE(tabpb) (!tabpb->has_index_info())

#endif

class IndexInfoBuilder {
 public:
  explicit IndexInfoBuilder(IndexInfoPB* index_info) : index_info_(*index_info) {
    DVLOG(3) << " After " << __PRETTY_FUNCTION__ << " index_info_ is " << yb::ToString(index_info_)0;
  }

  void ApplyProperties(const TableId& indexed_table_id, bool is_local, bool is_unique) {
    index_info_.set_indexed_table_id(indexed_table_id);
    index_info_.set_version(0);
    index_info_.set_is_local(is_local);
    index_info_.set_is_unique(is_unique);
    DVLOG(3) << " After " << __PRETTY_FUNCTION__ << " index_info_ is " << yb::ToString(index_info_)0;
  }

  CHECKED_STATUS ApplyColumnMapping(const Schema& indexed_schema, const Schema& index_schema) {
    for (size_t i = 0; i < index_schema.num_columns(); i++54) {
      const auto& col_name = index_schema.column(i).name();
      const auto indexed_col_idx = indexed_schema.find_column(col_name);
      if (PREDICT_FALSE(indexed_col_idx == Schema::kColumnNotFound)) {
        return STATUS(NotFound, "The indexed table column does not exist", col_name);
      }
      auto* col = index_info_.add_columns();
      col->set_column_id(index_schema.column_id(i));
      col->set_indexed_column_id(indexed_schema.column_id(indexed_col_idx));
    }
    index_info_.set_hash_column_count(narrow_cast<uint32_t>(index_schema.num_hash_key_columns()));
    index_info_.set_range_column_count(narrow_cast<uint32_t>(index_schema.num_range_key_columns()));

    for (size_t i = 0; i < indexed_schema.num_hash_key_columns(); i++18) {
      index_info_.add_indexed_hash_column_ids(indexed_schema.column_id(i));
    }
    for (size_t i = indexed_schema.num_hash_key_columns(); i < indexed_schema.num_key_columns();
        i++0) {
      index_info_.add_indexed_range_column_ids(indexed_schema.column_id(i));
    }
    DVLOG(3) << " After " << __PRETTY_FUNCTION__ << " index_info_ is " << yb::ToString(index_info_)0;
    return Status::OK();
  }

 private:
  IndexInfoPB& index_info_;
};

template<class Lock>
Status CheckIfTableDeletedOrNotVisibleToClient(const Lock& lock) {
  // This covers both in progress and fully deleted objects.
  if (lock->started_deleting()) {
    return STATUS_EC_FORMAT(
        NotFound, MasterError(MasterErrorPB::OBJECT_NOT_FOUND),
        "The object '$0.$1' does not exist", lock->namespace_id(), lock->name());
  }
  if (!lock->visible_to_client()) {
    return STATUS_EC_FORMAT(
        ServiceUnavailable, MasterError(MasterErrorPB::OBJECT_NOT_FOUND),
        "The object '$0.$1' is not running", lock->namespace_id(), lock->name());
  }
  return Status::OK();
}

template<class Lock, class RespClass>
Status CheckIfTableDeletedOrNotVisibleToClient(const Lock& lock, RespClass* resp) {
  auto status = CheckIfTableDeletedOrNotVisibleToClient(lock);
  if (!status.ok()) {
    return SetupError(resp->mutable_error(), status);
  }
  return Status::OK();
}

#define VERIFY_NAMESPACE_FOUND(expr, resp) RESULT_CHECKER_HELPER( \
    expr, \
    if (!__result.ok()) { \
        return SetupError((resp)->mutable_error(), __result.status()); \
    });

MasterErrorPB_Code NamespaceMasterError(SysNamespaceEntryPB_State state) {
  switch (state) {
    case SysNamespaceEntryPB::PREPARING: FALLTHROUGH_INTENDED;
    case SysNamespaceEntryPB::DELETING:
      return MasterErrorPB::IN_TRANSITION_CAN_RETRY;
    case SysNamespaceEntryPB::DELETED: FALLTHROUGH_INTENDED;
    case SysNamespaceEntryPB::FAILED: FALLTHROUGH_INTENDED;
    case SysNamespaceEntryPB::RUNNING:
      return MasterErrorPB::INTERNAL_ERROR;
    default:
      FATAL_INVALID_ENUM_VALUE(SysNamespaceEntryPB_State, state);
  }
}

size_t GetNameMapperIndex(YQLDatabase db_type) {
  switch (db_type) {
    case YQL_DATABASE_UNKNOWN: break;
    case YQL_DATABASE_CQL: return 1;
    case YQL_DATABASE_PGSQL: return 2;
    case YQL_DATABASE_REDIS: return 3;
  }
  CHECK(false) << "Unexpected db type " << db_type;
  return 0;
}

bool IsIndexBackfillEnabled(TableType table_type, bool is_transactional) {
  // Fetch the runtime flag to prevent any issues from the updates to flag while processing.
  const bool disabled =
      (table_type == PGSQL_TABLE_TYPE
          ? GetAtomicFlag(&FLAGS_ysql_disable_index_backfill)5.58k
          : GetAtomicFlag(&FLAGS_disable_index_backfill)3.65k ||
      (!is_transactional && GetAtomicFlag(&FLAGS_disable_index_backfill_for_non_txn_tables)3.04k));
  return !disabled;
}

constexpr auto kDefaultYQLPartitionsRefreshBgTaskSleep = 10s;

void FillRetainedBySnapshotSchedules(
      const SnapshotSchedulesToObjectIdsMap& schedules_to_tables_map,
      const TableId& table_id,
      RepeatedBytes* retained_by_snapshot_schedules) {
  for (const auto& entry : schedules_to_tables_map) {
    if (std::binary_search(entry.second.begin(), entry.second.end(), table_id)) {
      retained_by_snapshot_schedules->Add()->assign(
          entry.first.AsSlice().cdata(), entry.first.size());
    }
  }
}

int GetTransactionTableNumShardsPerTServer() {
  int value = 8;
  if (IsTsan()) {
    value = 2;
  } else if (base::NumCPUs() <= 2) {
    value = 4;
  }
  return value;
}

void InitMasterFlags() {
  yb::InitCommonFlags();
  if (GetAtomicFlag(&FLAGS_transaction_table_num_tablets_per_tserver) ==
      kAutoDetectNumShardsPerTServer) {
    const auto value = GetTransactionTableNumShardsPerTServer();
    VLOG(1) << "Auto setting FLAGS_transaction_table_num_tablets_per_tserver to " << value0;
    SetAtomicFlag(value, &FLAGS_transaction_table_num_tablets_per_tserver);
  }
}

Result<bool> DoesTableExist(const Result<TableInfoPtr>& result) {
  if (result.ok()) {
    return true;
  }
  if (result.status().IsNotFound()
      && MasterError(result.status()) == MasterErrorPB::OBJECT_NOT_FOUND) {
    return false;
  }
  return result.status();
}

}  // anonymous namespace

////////////////////////////////////////////////////////////
// CatalogManager
////////////////////////////////////////////////////////////

CatalogManager::NamespaceInfoMap& CatalogManager::NamespaceNameMapper::operator[](
    YQLDatabase db_type) {
  return typed_maps_[GetNameMapperIndex(db_type)];
}

const CatalogManager::NamespaceInfoMap& CatalogManager::NamespaceNameMapper::operator[](
    YQLDatabase db_type) const {
  return typed_maps_[GetNameMapperIndex(db_type)];
}

void CatalogManager::NamespaceNameMapper::clear() {
  for (auto& m : typed_maps_) {
    m.clear();
  }
}

CatalogManager::CatalogManager(Master* master)
    : master_(master),
      tablet_exists_(false),
      state_(kConstructed),
      leader_ready_term_(-1),
      leader_lock_(RWMutex::Priority::PREFER_WRITING),
      load_balance_policy_(std::make_unique<ClusterLoadBalancer>(this)),
      permissions_manager_(std::make_unique<PermissionsManager>(this)),
      tasks_tracker_(new TasksTracker(IsUserInitiated::kFalse)),
      jobs_tracker_(new TasksTracker(IsUserInitiated::kTrue)),
      encryption_manager_(new EncryptionManager()),
      tablespace_manager_(std::make_shared<YsqlTablespaceManager>(nullptr, nullptr)),
      tablespace_bg_task_running_(false),
      tablet_split_manager_(this, this, this) {
  InitMasterFlags();
  CHECK_OK(ThreadPoolBuilder("leader-initialization")
           .set_max_threads(1)
           .Build(&leader_initialization_pool_));
  CHECK_OK(ThreadPoolBuilder("CatalogManagerBGTasks").Build(&background_tasks_thread_pool_));
  CHECK_OK(ThreadPoolBuilder("async-tasks").Build(&async_task_pool_));

  if (master_) {
    sys_catalog_.reset(new SysCatalogTable(
        master_, master_->metric_registry(),
        Bind(&CatalogManager::ElectedAsLeaderCb, Unretained(this))));
  }
}

CatalogManager::~CatalogManager() {
  if (StartShutdown()) {
    CompleteShutdown();
  }
}

Status CatalogManager::Init() {
  {
    std::lock_guard<simple_spinlock> l(state_lock_);
    CHECK_EQ(kConstructed, state_);
    state_ = kStarting;
  }

  if (master_) {
    ysql_transaction_ = std::make_unique<YsqlTransactionDdl>(
        sys_catalog_.get(), master_->async_client_initializer().get_client_future(),
        background_tasks_thread_pool_.get());
  }

  // Initialize the metrics emitted by the catalog manager.
  metric_num_tablet_servers_live_ =
    METRIC_num_tablet_servers_live.Instantiate(master_->metric_entity_cluster(), 0);

  metric_num_tablet_servers_dead_ =
    METRIC_num_tablet_servers_dead.Instantiate(master_->metric_entity_cluster(), 0);

  RETURN_NOT_OK_PREPEND(InitSysCatalogAsync(),
                        "Failed to initialize sys tables async");

  if (PREDICT_FALSE(FLAGS_TEST_simulate_slow_system_tablet_bootstrap_secs > 0)) {
    LOG_WITH_PREFIX(INFO) << "Simulating slow system tablet bootstrap";
    SleepFor(MonoDelta::FromSeconds(FLAGS_TEST_simulate_slow_system_tablet_bootstrap_secs));
  }

  // WaitUntilRunning() must run outside of the lock as to prevent
  // deadlock. This is safe as WaitUntilRunning waits for another
  // thread to finish its work and doesn't itself depend on any state
  // within CatalogManager. Need not start sys catalog or background tasks
  // when we are started in shell mode.
  if (!master_->opts().IsShellMode()) {
    RETURN_NOT_OK_PREPEND(sys_catalog_->WaitUntilRunning(),
                          "Failed waiting for the catalog tablet to run");
    std::vector<consensus::RaftPeerPB> masters_raft;
    RETURN_NOT_OK(master_->ListRaftConfigMasters(&masters_raft));
    std::vector<HostPort> hps;
    for (const auto& peer : masters_raft) {
      if (NodeInstance().permanent_uuid() == peer.permanent_uuid()) {
        continue;
      }
      HostPort hp = HostPortFromPB(DesiredHostPort(peer, master_->MakeCloudInfoPB()));
      hps.push_back(hp);
    }
    universe_key_client_ = std::make_unique<client::UniverseKeyClient>(
        hps, &master_->proxy_cache(), [&] (const encryption::UniverseKeysPB& universe_keys) {
          encryption_manager_->PopulateUniverseKeys(universe_keys);
        });
    universe_key_client_->GetUniverseKeyRegistryAsync();
    RETURN_NOT_OK(EnableBgTasks());
  }

  // Cache the server registration even for shell mode masters. See
  // https://github.com/yugabyte/yugabyte-db/issues/8065.
  RETURN_NOT_OK(GetRegistration(&server_registration_));

  {
    std::lock_guard<simple_spinlock> l(state_lock_);
    CHECK_EQ(kStarting, state_);
    state_ = kRunning;
  }

  Started();

  return Status::OK();
}

Status CatalogManager::ChangeEncryptionInfo(const ChangeEncryptionInfoRequestPB* req,
                                            ChangeEncryptionInfoResponsePB* resp) {
  return STATUS(InvalidCommand, "Command only supported in enterprise build.");
}

Status CatalogManager::ElectedAsLeaderCb() {
  time_elected_leader_.store(MonoTime::Now());
  return leader_initialization_pool_->SubmitClosure(
      Bind(&CatalogManager::LoadSysCatalogDataTask, Unretained(this)));
}

Status CatalogManager::WaitUntilCaughtUpAsLeader(const MonoDelta& timeout) {
  string uuid = master_->fs_manager()->uuid();
  Consensus* consensus = tablet_peer()->consensus();
  ConsensusStatePB cstate = consensus->ConsensusState(CONSENSUS_CONFIG_ACTIVE);
  if (!cstate.has_leader_uuid() || cstate.leader_uuid() != uuid) {
    return STATUS_SUBSTITUTE(IllegalState,
        "Node $0 not leader. Consensus state: $1", uuid, cstate.ShortDebugString());
  }

  // Wait for all transactions to be committed.
  const CoarseTimePoint deadline = CoarseMonoClock::now() + timeout;
  {
    tablet::HistoryCutoffPropagationDisabler disabler(tablet_peer()->tablet()->RetentionPolicy());
    RETURN_NOT_OK(tablet_peer()->operation_tracker()->WaitForAllToFinish(timeout));
  }

  RETURN_NOT_OK(tablet_peer()->consensus()->WaitForLeaderLeaseImprecise(deadline));
  return Status::OK();
}

void CatalogManager::LoadSysCatalogDataTask() {
  auto consensus = tablet_peer()->shared_consensus();
  const int64_t term = consensus->ConsensusState(CONSENSUS_CONFIG_ACTIVE).current_term();
  Status s = WaitUntilCaughtUpAsLeader(
      MonoDelta::FromMilliseconds(FLAGS_master_failover_catchup_timeout_ms));

  int64_t term_after_wait = consensus->ConsensusState(CONSENSUS_CONFIG_ACTIVE).current_term();
  if (term_after_wait != term) {
    // If we got elected leader again while waiting to catch up then we will get another callback to
    // update state from sys_catalog, so bail now.
    //
    // If we failed when waiting, i.e. could not acquire a leader lease, this could be due to us
    // becoming a follower. If we're not partitioned away, we'll know about a new term soon.
    LOG_WITH_PREFIX(INFO)
        << "Term change from " << term << " to " << term_after_wait
        << " while waiting for master leader catchup. Not loading sys catalog metadata. "
        << "Status of waiting: " << s;
    return;
  }

  if (!s.ok()) {
    // This could happen e.g. if we are a partitioned-away leader that failed to acquire a leader
    // lease.
    //
    // TODO: handle this cleanly by transitioning to a follower without crashing.
    LOG_WITH_PREFIX(WARNING) << "Failed waiting for node to catch up after master election: " << s;

    if (s.IsTimedOut()) {
      LOG_WITH_PREFIX(FATAL) << "Shutting down due to unavailability of other masters after"
                             << " election. TODO: Abdicate instead.";
    }
    return;
  }

  LOG_WITH_PREFIX(INFO) << "Loading table and tablet metadata into memory for term " << term;
  LOG_SLOW_EXECUTION(WARNING, 1000, LogPrefix() + "Loading metadata into memory") {
    Status status = VisitSysCatalog(term);
    if (!status.ok()) {
      {
        std::lock_guard<simple_spinlock> l(state_lock_);
        if (state_ == kClosing) {
          LOG_WITH_PREFIX(INFO)
              << "Error loading sys catalog; because shutdown is in progress. term " << term
              << " status : " << status;
          return;
        }
      }
      auto new_term = consensus->ConsensusState(CONSENSUS_CONFIG_ACTIVE).current_term();
      if (new_term != term) {
        LOG_WITH_PREFIX(INFO)
            << "Error loading sys catalog; but that's OK as term was changed from " << term
            << " to " << new_term << ": " << status;
        return;
      }
      LOG_WITH_PREFIX(FATAL) << "Failed to load sys catalog: " << status;
    }
  }

  {
    std::lock_guard<simple_spinlock> l(state_lock_);
    leader_ready_term_ = term;
    LOG_WITH_PREFIX(INFO) << "Completed load of sys catalog in term " << term;
  }
  SysCatalogLoaded(term);
  // Once we have loaded the SysCatalog, reset and regenerate the yql partitions table in order to
  // regenerate entries for previous tables.
  GetYqlPartitionsVtable().ResetAndRegenerateCache();
}

CHECKED_STATUS CatalogManager::WaitForWorkerPoolTests(const MonoDelta& timeout) const {
  if (!async_task_pool_->WaitFor(timeout)) {
    return STATUS(TimedOut, "Worker Pool hasn't finished processing tasks");
  }
  return Status::OK();
}

Status CatalogManager::VisitSysCatalog(int64_t term) {
  // Block new catalog operations, and wait for existing operations to finish.
  LOG_WITH_PREFIX_AND_FUNC(INFO)
      << "Wait on leader_lock_ for any existing operations to finish. Term: " << term;
  auto start = std::chrono::steady_clock::now();
  std::lock_guard<RWMutex> leader_lock_guard(leader_lock_);
  auto finish = std::chrono::steady_clock::now();

  static const auto kLongLockAcquisitionLimit = RegularBuildVsSanitizers(100ms, 750ms);
  if (finish > start + kLongLockAcquisitionLimit) {
    LOG_WITH_PREFIX(WARNING) << "Long wait on leader_lock_: " << yb::ToString(finish - start);
  }

  LOG_WITH_PREFIX(INFO)
      << __func__ << ": Acquire catalog manager lock_ before loading sys catalog.";
  LockGuard lock(mutex_);
  VLOG_WITH_FUNC0(3) << "Acquired the catalog manager lock"0;

  // Abort any outstanding tasks. All TableInfos are orphaned below, so
  // it's important to end their tasks now; otherwise Shutdown() will
  // destroy master state used by these tasks.
  std::vector<scoped_refptr<TableInfo>> tables;
  AppendValuesFromMap(*table_ids_map_, &tables);
  AbortAndWaitForAllTasks(tables);

  // Clear internal maps and run data loaders.
  RETURN_NOT_OK(RunLoaders(term));

  // Prepare various default system configurations.
  RETURN_NOT_OK(PrepareDefaultSysConfig(term));

  if ((FLAGS_use_initial_sys_catalog_snapshot || FLAGS_enable_ysql3.01k) &&
      !FLAGS_initial_sys_catalog_snapshot_path.empty()981 &&
      !FLAGS_create_initial_sys_catalog_snapshot767) {
    if (!namespace_ids_map_.empty() || !system_tablets_.empty()746) {
      LOG_WITH_PREFIX(INFO)
          << "This is an existing cluster, not initializing from a sys catalog snapshot.";
    } else {
      Result<bool> dir_exists =
          Env::Default()->DoesDirectoryExist(FLAGS_initial_sys_catalog_snapshot_path);
      if (dir_exists.ok() && *dir_exists) {
        bool initdb_was_already_done = false;
        {
          auto l = ysql_catalog_config_->LockForRead();
          initdb_was_already_done = l->pb.ysql_catalog_config().initdb_done();
        }
        if (initdb_was_already_done) {
          LOG_WITH_PREFIX(INFO)
              << "initdb has been run before, no need to restore sys catalog from "
              << "the initial snapshot";
        } else {
          LOG_WITH_PREFIX(INFO) << "Restoring snapshot in sys catalog";
          Status restore_status = RestoreInitialSysCatalogSnapshot(
              FLAGS_initial_sys_catalog_snapshot_path,
              sys_catalog_->tablet_peer().get(),
              term);
          if (!restore_status.ok()) {
            LOG_WITH_PREFIX(ERROR) << "Failed restoring snapshot in sys catalog";
            return restore_status;
          }

          LOG_WITH_PREFIX(INFO) << "Re-initializing cluster config";
          {
            std::lock_guard<decltype(config_mutex_)> lock(config_mutex_);
            cluster_config_.reset();
          }
          RETURN_NOT_OK(PrepareDefaultClusterConfig(term));

          LOG_WITH_PREFIX(INFO) << "Restoring snapshot completed, considering initdb finished";
          RETURN_NOT_OK(InitDbFinished(Status::OK(), term));
          RETURN_NOT_OK(RunLoaders(term));
        }
      } else {
        LOG_WITH_PREFIX(WARNING)
            << "Initial sys catalog snapshot directory does not exist: "
            << FLAGS_initial_sys_catalog_snapshot_path
            << (dir_exists.ok() ? "" : ", status: " + dir_exists.status().ToString());
      }
    }
  }

  // Create the system namespaces (created only if they don't already exist).
  RETURN_NOT_OK(PrepareDefaultNamespaces(term));

  // Create the system tables (created only if they don't already exist).
  RETURN_NOT_OK(PrepareSystemTables(term));

  // Create the default cassandra (created only if they don't already exist).
  RETURN_NOT_OK(permissions_manager_->PrepareDefaultRoles(term));

  // If this is the first time we start up, we have no config information as default. We write an
  // empty version 0.
  RETURN_NOT_OK(PrepareDefaultClusterConfig(term));

  permissions_manager_->BuildRecursiveRoles();

  if (FLAGS_enable_ysql) {
    // Number of TS to wait for before creating the txn table.
    auto wait_ts_count = std::max(FLAGS_txn_table_wait_min_ts_count, FLAGS_replication_factor);

    LOG_WITH_PREFIX(INFO)
        << "YSQL is enabled, will create the transaction status table when "
        << wait_ts_count << " tablet servers are online";
    master_->ts_manager()->SetTSCountCallback(wait_ts_count, [this, wait_ts_count] {
      LOG_WITH_PREFIX(INFO)
          << wait_ts_count
          << " tablet servers registered, creating the transaction status table";
      // Retry table creation until it succeedes. It might fail initially because placement UUID
      // of live replicas is set through an RPC from YugaWare, and we won't be able to calculate
      // the number of primary (non-read-replica) tablet servers until that happens.
      while (true) {
        const auto s = CreateGlobalTransactionStatusTableIfNeeded(/* rpc */ nullptr);
        if (s.ok()) {
          break;
        }
        LOG_WITH_PREFIX(WARNING) << "Failed creating transaction status table, waiting: " << s;
        if (s.IsShutdownInProgress()) {
          return;
        }
        auto role = Role();
        if (role != PeerRole::LEADER) {
          LOG_WITH_PREFIX(WARNING)
              << "Cancel creating transaction because of role: " << PeerRole_Name(role);
          return;
        }
        SleepFor(MonoDelta::FromSeconds(1));
      }
      LOG_WITH_PREFIX(INFO) << "Finished creating transaction status table asynchronously";
    });
  }

  if (!StartRunningInitDbIfNeeded(term)) {
    // If we are not running initdb, this is an existing cluster, and we need to check whether we
    // need to do a one-time migration to make YSQL system catalog tables transactional.
    RETURN_NOT_OK(MakeYsqlSysCatalogTablesTransactional(
      table_ids_map_.CheckOut().get_ptr(), sys_catalog_.get(), ysql_catalog_config_.get(), term));
  }

  return Status::OK();
}

template <class Loader>
Status CatalogManager::Load(const std::string& title, const int64_t term) {
  LOG_WITH_PREFIX(INFO) << __func__ << ": Loading " << title << " into memory.";
  std::unique_ptr<Loader> loader = std::make_unique<Loader>(this, term);
  RETURN_NOT_OK_PREPEND(
      sys_catalog_->Visit(loader.get()),
      "Failed while visiting " + title + " in sys catalog");
  return Status::OK();
}

Status CatalogManager::RunLoaders(int64_t term) {
  // Clear the table and tablet state.
  table_names_map_.clear();
  transaction_table_ids_set_.clear();
  auto table_ids_map_checkout = table_ids_map_.CheckOut();
  table_ids_map_checkout->clear();

  auto tablet_map_checkout = tablet_map_.CheckOut();
  tablet_map_checkout->clear();

  // Clear the namespace mappings.
  namespace_ids_map_.clear();
  namespace_names_mapper_.clear();

  // Clear the type mappings.
  udtype_ids_map_.clear();
  udtype_names_map_.clear();

  // Clear the current cluster config.
  {
    std::lock_guard<decltype(config_mutex_)> lock(config_mutex_);
    cluster_config_.reset();
  }

  // Clear redis config mapping.
  redis_config_map_.clear();

  // Clear ysql catalog config.
  ysql_catalog_config_.reset();

  // Clear transaction tables config.
  transaction_tables_config_.reset();

  // Clear recent tasks.
  tasks_tracker_->Reset();

  // Clear recent jobs.
  jobs_tracker_->Reset();

  std::vector<std::shared_ptr<TSDescriptor>> descs;
  master_->ts_manager()->GetAllDescriptors(&descs);
  for (const auto& ts_desc : descs) {
    ts_desc->set_has_tablet_report(false);
  }

  {
    LockGuard lock(permissions_manager()->mutex());

    // Clear the roles mapping.
    permissions_manager()->ClearRolesUnlocked();
    RETURN_NOT_OK(Load<RoleLoader>("roles", term));
    RETURN_NOT_OK(Load<SysConfigLoader>("sys config", term));
  }
  // Clear the hidden tablets vector.
  hidden_tablets_.clear();

  RETURN_NOT_OK(Load<TableLoader>("tables", term));
  RETURN_NOT_OK(Load<TabletLoader>("tablets", term));
  RETURN_NOT_OK(Load<NamespaceLoader>("namespaces", term));
  RETURN_NOT_OK(Load<UDTypeLoader>("user-defined types", term));
  RETURN_NOT_OK(Load<ClusterConfigLoader>("cluster configuration", term));
  RETURN_NOT_OK(Load<RedisConfigLoader>("Redis config", term));

  if (!transaction_tables_config_) {
    RETURN_NOT_OK(InitializeTransactionTablesConfig(term));
  }

  return Status::OK();
}

Status CatalogManager::CheckResource(
    const GrantRevokePermissionRequestPB* req,
    GrantRevokePermissionResponsePB* resp) {
  scoped_refptr<TableInfo> table;

  // Checking if resources exist.
  if (req->resource_type() == ResourceType::TABLE ||
      req->resource_type() == ResourceType::KEYSPACE522) {
    // We can't match Apache Cassandra's error because when a namespace is not provided, the error
    // is detected by the semantic analysis in PTQualifiedName::AnalyzeName.
    DCHECK(req->has_namespace_());
    const auto& namespace_info = req->namespace_();
    auto ns = FindNamespace(namespace_info);

    if (req->resource_type() == ResourceType::KEYSPACE) {
      if (!ns.ok()) {
        // Matches Apache Cassandra's error.
        Status s = STATUS_SUBSTITUTE(
            NotFound, "Resource <keyspace $0> doesn't exist", namespace_info.name());
        return SetupError(resp->mutable_error(), MasterErrorPB::NAMESPACE_NOT_FOUND, s);
      }
    } else {
      if (ns.ok()) {
        CatalogManager::SharedLock l(mutex_);
        table = FindPtrOrNull(table_names_map_, {(**ns).id(), req->resource_name()});
      }
      if (table == nullptr) {
        // Matches Apache Cassandra's error.
        Status s = STATUS_SUBSTITUTE(
            NotFound, "Resource <object '$0.$1'> doesn't exist",
            namespace_info.name(), req->resource_name());
        return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_NOT_FOUND, s);
      }
    }
  }
  return Status::OK();
}

Status CatalogManager::PrepareDefaultClusterConfig(int64_t term) {
  std::lock_guard<decltype(config_mutex_)> lock(config_mutex_);
  if (cluster_config_) {
    LOG_WITH_PREFIX(INFO)
        << "Cluster configuration has already been set up, skipping re-initialization.";
    return Status::OK();
  }

  // Create default.
  SysClusterConfigEntryPB config;
  config.set_version(0);

  std::string cluster_uuid_source;
  if (!FLAGS_cluster_uuid.empty()) {
    RETURN_NOT_OK(Uuid::FromString(FLAGS_cluster_uuid));
    config.set_cluster_uuid(FLAGS_cluster_uuid);
    cluster_uuid_source = "from the --cluster_uuid flag";
  } else {
    auto uuid = Uuid::Generate();
    config.set_cluster_uuid(uuid.ToString());
    cluster_uuid_source = "(randomly generated)";
  }
  LOG_WITH_PREFIX(INFO)
      << "Setting cluster UUID to " << config.cluster_uuid() << " " << cluster_uuid_source;

  // Create in memory object.
  cluster_config_ = std::make_shared<ClusterConfigInfo>();

  // Prepare write.
  auto l = cluster_config_->LockForWrite();
  l.mutable_data()->pb = std::move(config);

  // Write to sys_catalog and in memory.
  RETURN_NOT_OK(sys_catalog_->Upsert(term, cluster_config_.get()));
  l.Commit();

  return Status::OK();
}

std::vector<std::string> CatalogManager::GetMasterAddresses() {
  std::vector<std::string> result;
  consensus::ConsensusStatePB state;
  auto status = GetCurrentConfig(&state);
  if (!status.ok()) {
    LOG(WARNING) << "Failed to get current config: " << status;
    return result;
  }
  for (const auto& peer : state.config().peers())11.7k {
    std::vector<std::string> peer_addresses;
    for (const auto& list : {peer.last_known_private_addr(), peer.last_known_broadcast_addr()}) {
      for (const auto& entry : list) {
        peer_addresses.push_back(HostPort::FromPB(entry).ToString());
      }
    }
    if (!peer_addresses.empty()) {
      result.push_back(JoinStrings(peer_addresses, ","));
    }
  }
  return result;
}

Status CatalogManager::PrepareDefaultSysConfig(int64_t term) {
  {
    LockGuard lock(permissions_manager()->mutex());
    RETURN_NOT_OK(permissions_manager()->PrepareDefaultSecurityConfigUnlocked(term));
  }

  if (!ysql_catalog_config_) {
    SysYSQLCatalogConfigEntryPB ysql_catalog_config;
    ysql_catalog_config.set_version(0);

    // Create in memory objects.
    ysql_catalog_config_ = new SysConfigInfo(kYsqlCatalogConfigType);

    // Prepare write.
    auto l = ysql_catalog_config_->LockForWrite();
    *l.mutable_data()->pb.mutable_ysql_catalog_config() = std::move(ysql_catalog_config);

    // Write to sys_catalog and in memory.
    RETURN_NOT_OK(sys_catalog_->Upsert(term, ysql_catalog_config_));
    l.Commit();
  }

  if (!transaction_tables_config_) {
    RETURN_NOT_OK(InitializeTransactionTablesConfig(term));
  }

  return Status::OK();
}

bool CatalogManager::StartRunningInitDbIfNeeded(int64_t term) {
  if (!ShouldAutoRunInitDb(ysql_catalog_config_.get(), pg_proc_exists_)) {
    return false;
  }

  string master_addresses_str = MasterAddressesToString(
      *master_->opts().GetMasterAddresses());

  initdb_future_ = std::async(std::launch::async, [this, master_addresses_str, term] {
    if (FLAGS_create_initial_sys_catalog_snapshot) {
      initial_snapshot_writer_.emplace();
    }

    Status status = PgWrapper::InitDbForYSQL(
        master_addresses_str, "/tmp", master_->GetSharedMemoryFd());

    if (FLAGS_create_initial_sys_catalog_snapshot && status.ok()) {
      Status write_snapshot_status = initial_snapshot_writer_->WriteSnapshot(
          sys_catalog_->tablet_peer()->tablet(),
          FLAGS_initial_sys_catalog_snapshot_path);
      if (!write_snapshot_status.ok()) {
        status = write_snapshot_status;
      }
    }
    Status finish_status = InitDbFinished(status, term);
    if (!finish_status.ok()) {
      if (status.ok()) {
        status = finish_status;
      }
      LOG_WITH_PREFIX(WARNING)
          << "Failed to set initdb as finished in sys catalog: " << finish_status;
    }
    return status;
  });
  return true;
}

Status CatalogManager::PrepareDefaultNamespaces(int64_t term) {
  RETURN_NOT_OK(PrepareNamespace(
      YQL_DATABASE_CQL, kSystemNamespaceName, kSystemNamespaceId, term));
  RETURN_NOT_OK(PrepareNamespace(
      YQL_DATABASE_CQL, kSystemSchemaNamespaceName, kSystemSchemaNamespaceId, term));
  RETURN_NOT_OK(PrepareNamespace(
      YQL_DATABASE_CQL, kSystemAuthNamespaceName, kSystemAuthNamespaceId, term));
  return Status::OK();
}

Status CatalogManager::PrepareSystemTables(int64_t term) {
  // Prepare sys catalog table.
  RETURN_NOT_OK(PrepareSysCatalogTable(term));

  // Create the required system tables here.
  RETURN_NOT_OK((PrepareSystemTableTemplate<PeersVTable>(
      kSystemPeersTableName, kSystemNamespaceName, kSystemNamespaceId, term)));
  RETURN_NOT_OK((PrepareSystemTableTemplate<LocalVTable>(
      kSystemLocalTableName, kSystemNamespaceName, kSystemNamespaceId, term)));
  RETURN_NOT_OK((PrepareSystemTableTemplate<YQLKeyspacesVTable>(
      kSystemSchemaKeyspacesTableName, kSystemSchemaNamespaceName, kSystemSchemaNamespaceId,
      term)));
  RETURN_NOT_OK((PrepareSystemTableTemplate<YQLTablesVTable>(
      kSystemSchemaTablesTableName, kSystemSchemaNamespaceName, kSystemSchemaNamespaceId, term)));
  RETURN_NOT_OK((PrepareSystemTableTemplate<YQLColumnsVTable>(
      kSystemSchemaColumnsTableName, kSystemSchemaNamespaceName, kSystemSchemaNamespaceId, term)));
  RETURN_NOT_OK((PrepareSystemTableTemplate<YQLSizeEstimatesVTable>(
      kSystemSizeEstimatesTableName, kSystemNamespaceName, kSystemNamespaceId, term)));

  // Empty tables.
  RETURN_NOT_OK((PrepareSystemTableTemplate<YQLAggregatesVTable>(
      kSystemSchemaAggregatesTableName, kSystemSchemaNamespaceName, kSystemSchemaNamespaceId,
      term)));
  RETURN_NOT_OK((PrepareSystemTableTemplate<YQLFunctionsVTable>(
      kSystemSchemaFunctionsTableName, kSystemSchemaNamespaceName, kSystemSchemaNamespaceId,
      term)));
  RETURN_NOT_OK((PrepareSystemTableTemplate<YQLIndexesVTable>(
      kSystemSchemaIndexesTableName, kSystemSchemaNamespaceName, kSystemSchemaNamespaceId, term)));
  RETURN_NOT_OK((PrepareSystemTableTemplate<YQLTriggersVTable>(
      kSystemSchemaTriggersTableName, kSystemSchemaNamespaceName, kSystemSchemaNamespaceId, term)));
  RETURN_NOT_OK((PrepareSystemTableTemplate<YQLViewsVTable>(
      kSystemSchemaViewsTableName, kSystemSchemaNamespaceName, kSystemSchemaNamespaceId, term)));
  RETURN_NOT_OK((PrepareSystemTableTemplate<QLTypesVTable>(
      kSystemSchemaTypesTableName, kSystemSchemaNamespaceName, kSystemSchemaNamespaceId, term)));
  RETURN_NOT_OK((PrepareSystemTableTemplate<YQLPartitionsVTable>(
      kSystemPartitionsTableName, kSystemNamespaceName, kSystemNamespaceId, term)));

  // System auth tables.
  RETURN_NOT_OK((PrepareSystemTableTemplate<YQLAuthRolesVTable>(
      kSystemAuthRolesTableName, kSystemAuthNamespaceName, kSystemAuthNamespaceId, term)));
  RETURN_NOT_OK((PrepareSystemTableTemplate<YQLAuthRolePermissionsVTable>(
      kSystemAuthRolePermissionsTableName, kSystemAuthNamespaceName, kSystemAuthNamespaceId,
      term)));
  RETURN_NOT_OK((PrepareSystemTableTemplate<YQLAuthResourceRolePermissionsIndexVTable>(
      kSystemAuthResourceRolePermissionsIndexTableName, kSystemAuthNamespaceName,
      kSystemAuthNamespaceId, term)));

  // Ensure kNumSystemTables is in-sync with the system tables created.
  LOG_IF(DFATAL, system_tablets_.size() != kNumSystemTables)
      << "kNumSystemTables is " << kNumSystemTables << " but " << system_tablets_.size()
      << " tables were created";

  // Cache the system.partitions tablet so we can access it in RebuildYQLSystemPartitions.
  RETURN_NOT_OK(GetYQLPartitionsVTable(&system_partitions_tablet_));

  return Status::OK();
}

Status CatalogManager::PrepareSysCatalogTable(int64_t term) {
  // Prepare sys catalog table info.
  auto sys_catalog_table_iter = table_ids_map_->find(kSysCatalogTableId);
  if (sys_catalog_table_iter == table_ids_map_->end()) {
    scoped_refptr<TableInfo> table = NewTableInfo(kSysCatalogTableId);
    table->mutable_metadata()->StartMutation();
    SysTablesEntryPB& metadata = table->mutable_metadata()->mutable_dirty()->pb;
    metadata.set_state(SysTablesEntryPB::RUNNING);
    metadata.set_namespace_id(kSystemSchemaNamespaceId);
    metadata.set_name(kSysCatalogTableName);
    metadata.set_table_type(TableType::YQL_TABLE_TYPE);
    SchemaToPB(*sys_catalog_->schema_, metadata.mutable_schema());
    metadata.set_version(0);

    auto table_ids_map_checkout = table_ids_map_.CheckOut();
    sys_catalog_table_iter = table_ids_map_checkout->emplace(table->id(), table).first;
    table_names_map_[{kSystemSchemaNamespaceId, kSysCatalogTableName}] = table;
    table->set_is_system();

    RETURN_NOT_OK(sys_catalog_->Upsert(term, table));
    table->mutable_metadata()->CommitMutation();
  }

  // Prepare sys catalog tablet info.
  if (tablet_map_->count(kSysCatalogTabletId) == 0) {
    scoped_refptr<TableInfo> table = sys_catalog_table_iter->second;
    scoped_refptr<TabletInfo> tablet(new TabletInfo(table, kSysCatalogTabletId));
    tablet->mutable_metadata()->StartMutation();
    SysTabletsEntryPB& metadata = tablet->mutable_metadata()->mutable_dirty()->pb;
    metadata.set_state(SysTabletsEntryPB::RUNNING);

    auto l = table->LockForRead();
    PartitionSchema partition_schema;
    RETURN_NOT_OK(PartitionSchema::FromPB(l->pb.partition_schema(),
                                          *sys_catalog_->schema_,
                                          &partition_schema));
    vector<Partition> partitions;
    RETURN_NOT_OK(partition_schema.CreatePartitions(1, &partitions));
    partitions[0].ToPB(metadata.mutable_partition());
    metadata.set_table_id(table->id());
    metadata.add_table_ids(table->id());

    table->set_is_system();
    table->AddTablet(tablet.get());

    auto tablet_map_checkout = tablet_map_.CheckOut();
    (*tablet_map_checkout)[tablet->tablet_id()] = tablet;

    RETURN_NOT_OK(sys_catalog_->Upsert(term, tablet));
    tablet->mutable_metadata()->CommitMutation();
  }

  system_tablets_[kSysCatalogTabletId] = sys_catalog_->tablet_peer_->shared_tablet();

  return Status::OK();
}

template <class T>
Status CatalogManager::PrepareSystemTableTemplate(const TableName& table_name,
                                                  const NamespaceName& namespace_name,
                                                  const NamespaceId& namespace_id,
                                                  int64_t term) {
  YQLVirtualTable* vtable = new T(table_name, namespace_name, master_);
  return PrepareSystemTable(
      table_name, namespace_name, namespace_id, vtable->schema(), term, vtable);
}

Status CatalogManager::PrepareSystemTable(const TableName& table_name,
                                          const NamespaceName& namespace_name,
                                          const NamespaceId& namespace_id,
                                          const Schema& schema,
                                          int64_t term,
                                          YQLVirtualTable* vtable) {
  std::unique_ptr<YQLVirtualTable> yql_storage(vtable);

  scoped_refptr<TableInfo> table = FindPtrOrNull(table_names_map_,
                                                 std::make_pair(namespace_id, table_name));
  bool create_table = true;
  if (table != nullptr) {
    LOG_WITH_PREFIX(INFO) << "Table " << namespace_name << "." << table_name << " already created";

    // Mark the table as a system table.
    table->set_is_system();

    Schema persisted_schema;
    RETURN_NOT_OK(table->GetSchema(&persisted_schema));
    if (!persisted_schema.Equals(schema)) {
      LOG_WITH_PREFIX(INFO)
          << "Updating schema of " << namespace_name << "." << table_name << " ...";
      auto l = table->LockForWrite();
      SchemaToPB(schema, l.mutable_data()->pb.mutable_schema());
      l.mutable_data()->pb.set_version(l->pb.version() + 1);
      l.mutable_data()->pb.set_updates_only_index_permissions(false);

      // Update sys-catalog with the new table schema.
      RETURN_NOT_OK(sys_catalog_->Upsert(term, table));
      l.Commit();
    }

    // There might have been a failure after writing the table but before writing the tablets. As
    // a result, if we don't find any tablets, we try to create the tablets only again.
    auto tablets = table->GetTablets();
    if (!tablets.empty()) {
      // Initialize the appropriate system tablet.
      DCHECK_EQ(1, tablets.size());
      auto tablet = tablets[0];
      system_tablets_[tablet->tablet_id()] =
          std::make_shared<SystemTablet>(schema, std::move(yql_storage), tablet->tablet_id());
      return Status::OK();
    } else {
      // Table is already created, only need to create tablets now.
      LOG_WITH_PREFIX(INFO)
          << "Creating tablets for " << namespace_name << "." << table_name << " ...";
      create_table = false;
    }
  }

  // Create partitions.
  vector<Partition> partitions;
  PartitionSchemaPB partition_schema_pb;
  partition_schema_pb.set_hash_schema(PartitionSchemaPB::MULTI_COLUMN_HASH_SCHEMA);
  PartitionSchema partition_schema;
  RETURN_NOT_OK(PartitionSchema::FromPB(partition_schema_pb, schema, &partition_schema));
  RETURN_NOT_OK(partition_schema.CreatePartitions(1, &partitions));

  TabletInfos tablets;

  if (create_table) {
    // Fill in details for the system table.
    CreateTableRequestPB req;
    req.set_name(table_name);
    req.set_table_type(TableType::YQL_TABLE_TYPE);

    RETURN_NOT_OK(CreateTableInMemory(
        req, schema, partition_schema, namespace_id, namespace_name,
        partitions, nullptr, &tablets, nullptr, &table));
    // Mark the table as a system table.
    LOG_WITH_PREFIX(INFO) << "Inserted new " << namespace_name << "." << table_name
                          << " table info into CatalogManager maps";
    // Update the on-disk table state to "running".
    table->mutable_metadata()->mutable_dirty()->pb.set_state(SysTablesEntryPB::RUNNING);
    RETURN_NOT_OK(sys_catalog_->Upsert(term, table));
    LOG_WITH_PREFIX(INFO) << "Wrote table to system catalog: " << ToString(table) << ", tablets: "
                          << ToString(tablets);
  } else {
    // Still need to create the tablets.
    tablets = VERIFY_RESULT(CreateTabletsFromTable(partitions, table));
  }

  DCHECK_EQ(1, tablets.size());
  // We use LOG_ASSERT here since this is expected to crash in some unit tests.
  LOG_ASSERT(!FLAGS_TEST_catalog_manager_simulate_system_table_create_failure);

  // Write Tablets to sys-tablets (in "running" state since we don't want the loadbalancer to
  // assign these tablets since this table is virtual).
  for (const auto& tablet : tablets) {
    tablet->mutable_metadata()->mutable_dirty()->pb.set_state(SysTabletsEntryPB::RUNNING);
  }
  RETURN_NOT_OK(sys_catalog_->Upsert(term, tablets));
  LOG_WITH_PREFIX(INFO) << "Wrote tablets to system catalog: " << ToString(tablets);

  // Commit the in-memory state.
  if (create_table) {
    table->mutable_metadata()->CommitMutation();
  }

  for (const auto& tablet : tablets) {
    tablet->mutable_metadata()->CommitMutation();
  }
  // Mark the table as a system table.
  table->set_is_system();

  // Finally create the appropriate tablet object.
  auto tablet = tablets[0];
  system_tablets_[tablet->tablet_id()] =
      std::make_shared<SystemTablet>(schema, std::move(yql_storage), tablet->tablet_id());
  return Status::OK();
}

bool IsYcqlNamespace(const NamespaceInfo& ns) {
  return ns.database_type() == YQLDatabase::YQL_DATABASE_CQL;
}

bool IsYcqlTable(const TableInfo& table) {
  return table.GetTableType() == TableType::YQL_TABLE_TYPE && table.id() != kSysCatalogTableId665k;
}

Status CatalogManager::PrepareNamespace(
    YQLDatabase db_type, const NamespaceName& name, const NamespaceId& id, int64_t term) {

  scoped_refptr<NamespaceInfo> ns = FindPtrOrNull(namespace_ids_map_, id);
  if (ns != nullptr) {
    LOG_WITH_PREFIX(INFO)
        << "Keyspace " << ns->ToString() << " already created, skipping initialization";
    return Status::OK();
  }

  // Create entry.
  SysNamespaceEntryPB ns_entry;
  ns_entry.set_name(name);
  ns_entry.set_database_type(db_type);
  ns_entry.set_state(SysNamespaceEntryPB::RUNNING);

  // Create in memory object.
  ns = new NamespaceInfo(id);

  // Prepare write.
  auto l = ns->LockForWrite();
  l.mutable_data()->pb = std::move(ns_entry);

  namespace_ids_map_[id] = ns;
  namespace_names_mapper_[db_type][l.mutable_data()->pb.name()] = ns;

  // Write to sys_catalog and in memory.
  RETURN_NOT_OK(sys_catalog_->Upsert(term, ns));
  l.Commit();

  LOG_WITH_PREFIX(INFO) << "Created default keyspace: " << ns->ToString();
  return Status::OK();
}

Status CatalogManager::CheckLocalHostInMasterAddresses() {
  auto local_hostport = master_->first_rpc_address();
  std::vector<IpAddress> local_addrs;

  if (local_hostport.address().is_unspecified()) {
    auto status = GetLocalAddresses(&local_addrs, AddressFilter::ANY);
    if (!status.ok() || local_addrs.empty()) {
      LOG(WARNING) << "Could not enumerate network interfaces due to " << status << ", found "
                   << local_addrs.size() << " local addresses.";
      return Status::OK();
    }
  } else {
    for (auto const &addr : master_->rpc_addresses()) {
      local_addrs.push_back(addr.address());
    }
  }

  auto resolved_addresses = VERIFY_RESULT(server::ResolveMasterAddresses(
      *master_->opts().GetMasterAddresses()));

  for (auto const &addr : resolved_addresses) {
    if (addr.address().is_unspecified() ||
        std::find(local_addrs.begin(), local_addrs.end(), addr.address()) !=
            local_addrs.end()) {
      return Status::OK();
    }
  }
  return STATUS_SUBSTITUTE(IllegalState,
      "None of the local addresses are present in master_addresses $0.",
      master_->opts().master_addresses_flag);
}

Status CatalogManager::InitSysCatalogAsync() {
  LockGuard lock(mutex_);

  // Optimistically try to load data from disk.
  Status s = sys_catalog_->Load(master_->fs_manager());

  if (!s.ok() && s.IsNotFound()8.00k) {
    // We have yet to intialize the syscatalog metadata, need to create the metadata file.
    LOG(INFO) << "Did not find previous SysCatalogTable data on disk. " << s;

    if (!master_->opts().AreMasterAddressesProvided()) {
      master_->SetShellMode(true);
      LOG(INFO) << "Starting master in shell mode.";
      return Status::OK();
    }

    RETURN_NOT_OK(CheckLocalHostInMasterAddresses());
    RETURN_NOT_OK_PREPEND(sys_catalog_->CreateNew(master_->fs_manager()),
        Substitute("Encountered errors during system catalog initialization:"
                   "\n\tError on Load: $0\n\tError on CreateNew: ", s.ToString()));

    return Status::OK();
  }

  return s;
}

bool CatalogManager::IsInitialized() const {
  std::lock_guard<simple_spinlock> l(state_lock_);
  return state_ == kRunning;
}

// TODO - delete this API after HandleReportedTablet() usage is removed.
Status CatalogManager::CheckIsLeaderAndReady() const {
  std::lock_guard<simple_spinlock> l(state_lock_);
  if (PREDICT_FALSE(state_ != kRunning)) {
    return STATUS_SUBSTITUTE(ServiceUnavailable,
        "Catalog manager is shutting down. State: $0", state_);
  }
  string uuid = master_->fs_manager()->uuid();
  if (master_->opts().IsShellMode()) {
    // Consensus and other internal fields should not be checked when is shell mode.
    return STATUS_SUBSTITUTE(IllegalState,
        "Catalog manager of $0 is in shell mode, not the leader", uuid);
  }
  Consensus* consensus = tablet_peer()->consensus();
  if (consensus == nullptr) {
    return STATUS(IllegalState, "Consensus has not been initialized yet");
  }
  ConsensusStatePB cstate = consensus->ConsensusState(CONSENSUS_CONFIG_COMMITTED);
  if (PREDICT_FALSE(!cstate.has_leader_uuid() || cstate.leader_uuid() != uuid)) {
    return STATUS_SUBSTITUTE(IllegalState,
        "Not the leader. Local UUID: $0, Consensus state: $1", uuid, cstate.ShortDebugString());
  }
  if (PREDICT_FALSE(leader_ready_term_ != cstate.current_term())) {
    return STATUS_SUBSTITUTE(ServiceUnavailable,
        "Leader not yet ready to serve requests: ready term $0 vs cstate term $1",
        leader_ready_term_, cstate.current_term());
  }
  return Status::OK();
}

std::shared_ptr<tablet::TabletPeer> CatalogManager::tablet_peer() const {
  return sys_catalog_->tablet_peer();
}

PeerRole CatalogManager::Role() const {
  if (!IsInitialized()28.8M || master_->opts().IsShellMode()) {
    return PeerRole::NON_PARTICIPANT;
  }

  return tablet_peer()->consensus()->role();
}

bool CatalogManager::StartShutdown() {
  {
    std::lock_guard<simple_spinlock> l(state_lock_);
    if (state_ == kClosing) {
      VLOG(2) << "CatalogManager already shut down"0;
      return false;
    }
    state_ = kClosing;
  }

  refresh_yql_partitions_task_.StartShutdown();

  refresh_ysql_tablespace_info_task_.StartShutdown();

  if (sys_catalog_) {
    sys_catalog_->StartShutdown();
  }

  return true;
}

void CatalogManager::CompleteShutdown() {
  // Shutdown the Catalog Manager background thread (load balancing).
  refresh_yql_partitions_task_.CompleteShutdown();
  refresh_ysql_tablespace_info_task_.CompleteShutdown();

  if (background_tasks_) {
    background_tasks_->Shutdown();
  }
  if (background_tasks_thread_pool_) {
    background_tasks_thread_pool_->Shutdown();
  }
  if (leader_initialization_pool_) {
    leader_initialization_pool_->Shutdown();
  }
  if (async_task_pool_) {
    async_task_pool_->Shutdown();
  }

  // Mark all outstanding table tasks as aborted and wait for them to fail.
  //
  // There may be an outstanding table visitor thread modifying the table map,
  // so we must make a copy of it before we iterate. It's OK if the visitor
  // adds more entries to the map even after we finish; it won't start any new
  // tasks for those entries.
  vector<scoped_refptr<TableInfo>> copy;
  {
    SharedLock lock(mutex_);
    AppendValuesFromMap(*table_ids_map_, &copy);
  }
  AbortAndWaitForAllTasks(copy);

  // Shut down the underlying storage for tables and tablets.
  if (sys_catalog_) {
    sys_catalog_->CompleteShutdown();
  }

  // Reset the jobs/tasks tracker.
  tasks_tracker_->Reset();
  jobs_tracker_->Reset();

  if (initdb_future_ && initdb_future_->wait_for(0s) != std::future_status::ready0) {
    LOG(WARNING) << "initdb is still running, waiting for it to complete.";
    initdb_future_->wait();
    LOG(INFO) << "Finished running initdb, proceeding with catalog manager shutdown.";
  }
}

Status CatalogManager::AbortTableCreation(TableInfo* table,
                                          const TabletInfos& tablets,
                                          const Status& s,
                                          CreateTableResponsePB* resp) {
  LOG(WARNING) << s;

  const TableId table_id = table->id();
  const TableName table_name = table->mutable_metadata()->mutable_dirty()->pb.name();
  const NamespaceId table_namespace_id =
      table->mutable_metadata()->mutable_dirty()->pb.namespace_id();
  vector<string> tablet_ids_to_erase;
  for (const auto& tablet : tablets) {
    tablet_ids_to_erase.push_back(tablet->tablet_id());
  }

  LOG(INFO) << "Aborting creation of table '" << table_name << "', erasing table and tablets (" <<
      JoinStrings(tablet_ids_to_erase, ",") << ") from in-memory state.";

  // Since this is a failed creation attempt, it's safe to just abort
  // all tasks, as (by definition) no tasks may be pending against a
  // table that has failed to successfully create.
  table->AbortTasksAndClose();
  table->WaitTasksCompletion();

  LockGuard lock(mutex_);

  // Call AbortMutation() manually, as otherwise the lock won't be released.
  for (const auto& tablet : tablets) {
    tablet->mutable_metadata()->AbortMutation();
  }
  table->mutable_metadata()->AbortMutation();
  auto tablet_map_checkout = tablet_map_.CheckOut();
  for (const TabletId& tablet_id_to_erase : tablet_ids_to_erase) {
    CHECK_EQ(tablet_map_checkout->erase(tablet_id_to_erase), 1)
        << "Unable to erase tablet " << tablet_id_to_erase << " from tablet map.";
  }

  auto table_ids_map_checkout = table_ids_map_.CheckOut();
  table_names_map_.erase({table_namespace_id, table_name}); // Not present if PGSQL table.
  CHECK_EQ(table_ids_map_checkout->erase(table_id), 1)
      << "Unable to erase table with id " << table_id << " from table ids map.";

  if (IsYcqlTable(*table)) {
    GetYqlPartitionsVtable().RemoveFromCache(table->id());
  }
  return CheckIfNoLongerLeaderAndSetupError(s, resp);
}

Result<ReplicationInfoPB> CatalogManager::GetTableReplicationInfo(
  const ReplicationInfoPB& table_replication_info,
  const TablespaceId& tablespace_id) {

  if (IsReplicationInfoSet(table_replication_info)) {
    // The table has custom replication info set for it, return it if valid.
    RETURN_NOT_OK(ValidateTableReplicationInfo(table_replication_info));
    return table_replication_info;
  }
  // Table level replication info not set. Check whether the table is
  // associated with a tablespace and if so, return the tablespace
  // replication info.
  if (GetAtomicFlag(&FLAGS_enable_ysql_tablespaces_for_placement)) {
    boost::optional<ReplicationInfoPB> tablespace_pb =
      VERIFY_RESULT(GetTablespaceReplicationInfoWithRetry(tablespace_id));
    if (tablespace_pb) {
      // Return the tablespace placement.
      return tablespace_pb.value();
    }
  }

  // Neither table nor tablespace info set. Return cluster level replication info.
  auto l = ClusterConfig()->LockForRead();
  return l->pb.replication_info();
}

std::shared_ptr<YsqlTablespaceManager> CatalogManager::GetTablespaceManager() const {
  SharedLock lock(tablespace_mutex_);
  return tablespace_manager_;
}

Result<boost::optional<TablespaceId>> CatalogManager::GetTablespaceForTable(
    const scoped_refptr<TableInfo>& table) {

  auto tablespace_manager = GetTablespaceManager();
  return tablespace_manager->GetTablespaceForTable(table);
}

Result<boost::optional<ReplicationInfoPB>> CatalogManager::GetTablespaceReplicationInfoWithRetry(
  const TablespaceId& tablespace_id) {

  auto tablespace_manager = GetTablespaceManager();
  auto replication_info_result = tablespace_manager->GetTablespaceReplicationInfo(tablespace_id);

  if (replication_info_result) {
    return replication_info_result;
  }

  // We failed to find the tablespace placement policy. Refresh the tablespace info and try again.
  auto tablespace_map = VERIFY_RESULT(GetYsqlTablespaceInfo());

  // We clone the tablespace_manager and update the clone with the new tablespace_map that we
  // fetched above. We do this instead of updating the tablespace_manager object in-place because
  // other clients may have a shared_ptr to it through 'GetTablespaceManager()'.
  tablespace_manager = tablespace_manager->CreateCloneWithTablespaceMap(tablespace_map);
  {
    LockGuard lock(tablespace_mutex_);
    tablespace_manager_ = tablespace_manager;
  }

  return tablespace_manager->GetTablespaceReplicationInfo(tablespace_id);
}

bool CatalogManager::IsReplicationInfoSet(const ReplicationInfoPB& replication_info) {
  const auto& live_placement_info = replication_info.live_replicas();
  if (!(live_placement_info.placement_blocks().empty() &&
        live_placement_info.num_replicas() <= 0239k &&
        live_placement_info.placement_uuid().empty()238k) ||
      !replication_info.read_replicas().empty()238k ||
      !replication_info.affinitized_leaders().empty()238k) {

      return true;
  }
  return false;
}

Status CatalogManager::ValidateTableReplicationInfo(const ReplicationInfoPB& replication_info) {
  if (!IsReplicationInfoSet(replication_info)) {
    return STATUS(InvalidArgument, "No replication info set.");
  }
  // We don't support setting any other fields other than live replica placements for now.
  if (!replication_info.read_replicas().empty() ||
      !replication_info.affinitized_leaders().empty()) {

      return STATUS(InvalidArgument, "Only live placement info can be set for table "
          "level replication info.");
  }
  // Today we support setting table level replication info only in clusters where read replica
  // placements is not set. Return error if the cluster has read replica placements set.
  auto l = ClusterConfig()->LockForRead();
  const ReplicationInfoPB& cluster_replication_info = l->pb.replication_info();
  // TODO(bogdan): figure this out when we expand on geopartition support.
  // if (!cluster_replication_info.read_replicas().empty() ||
  //     !cluster_replication_info.affinitized_leaders().empty()) {

  //     return STATUS(InvalidArgument, "Setting table level replication info is not supported "
  //         "for clusters with read replica placements");
  // }
  // If the replication info has placement_uuid set, verify that it matches the cluster
  // placement_uuid.
  if (replication_info.live_replicas().placement_uuid().empty()) {
    return Status::OK();
  }
  if (replication_info.live_replicas().placement_uuid() !=
      cluster_replication_info.live_replicas().placement_uuid()) {

      return STATUS(InvalidArgument, "Placement uuid for table level replication info "
          "must match that of the cluster's live placement info.");
  }
  return Status::OK();
}

Result<shared_ptr<TablespaceIdToReplicationInfoMap>> CatalogManager::GetYsqlTablespaceInfo() {
  auto table_info = GetTableInfo(kPgTablespaceTableId);
  if (table_info == nullptr) {
    return STATUS(InternalError, "pg_tablespace table info not found");
  }

  auto tablespace_map = VERIFY_RESULT(sys_catalog_->ReadPgTablespaceInfo());

  // The tablespace options do not usually contain the placement uuid.
  // Populate the current cluster placement uuid into the placement information for
  // each tablespace.
  string placement_uuid;
  {
    auto l = ClusterConfig()->LockForRead();
    // TODO(deepthi.srinivasan): Read-replica placements are not supported as
    // of now.
    placement_uuid = l->pb.replication_info().live_replicas().placement_uuid();
  }
  if (!placement_uuid.empty()) {
    for (auto& iter : *tablespace_map) {
      if (iter.second) {
        iter.second.value().mutable_live_replicas()->set_placement_uuid(placement_uuid);
      }
    }
  }

  // Before updating the tablespace placement map, validate the
  // placement policies.
  for (auto& iter : *tablespace_map) {
    if (iter.second) {
      RETURN_NOT_OK(ValidateTableReplicationInfo(iter.second.value()));
    }
  }

  return tablespace_map;
}

boost::optional<TablespaceId> CatalogManager::GetTransactionStatusTableTablespace(
    const scoped_refptr<TableInfo>& table) {
  auto lock = table->LockForRead();
  if (lock->pb.table_type() != TRANSACTION_STATUS_TABLE_TYPE) {
    return boost::none;
  }

  if (!lock->pb.has_transaction_table_tablespace_id()) {
    return boost::none;
  }

  return lock->pb.transaction_table_tablespace_id();
}

void CatalogManager::ClearTransactionStatusTableTablespace(const scoped_refptr<TableInfo>& table) {
  auto lock = table->LockForWrite();
  if (lock->pb.table_type() != TRANSACTION_STATUS_TABLE_TYPE) {
    return;
  }

  lock.mutable_data()->pb.clear_transaction_table_tablespace_id();
  lock.mutable_data()->pb.set_version(lock.mutable_data()->pb.version() + 1);
  lock.Commit();
}

bool CatalogManager::CheckTransactionStatusTablesWithMissingTablespaces(
    const TablespaceIdToReplicationInfoMap& tablespace_info) {
  SharedLock lock(mutex_);
  for (const auto& table_id : transaction_table_ids_set_) {
    auto table = table_ids_map_->find(table_id);
    if (table == table_ids_map_->end()) {
      LOG(DFATAL) << "Table uuid " << table_id
                  << " in transaction_table_ids_set_ but not in table_ids_map_";
      continue;
    }
    auto tablespace_id = GetTransactionStatusTableTablespace(table->second);
    if (tablespace_id) {
      if (!tablespace_info.count(*tablespace_id)) {
        return true;
      }
    }
  }
  return false;
}

Status CatalogManager::UpdateTransactionStatusTableTablespaces(
    const TablespaceIdToReplicationInfoMap& tablespace_info) {
  if (CheckTransactionStatusTablesWithMissingTablespaces(tablespace_info)) {
    {
      LockGuard lock(mutex_);
      for (const auto& table_id : transaction_table_ids_set_) {
        auto table = table_ids_map_->find(table_id);
        if (table == table_ids_map_->end()) {
          LOG(DFATAL) << "Table uuid " << table_id
                      << " in transaction_table_ids_set_ but not in table_ids_map_";
          continue;
        }
        auto tablespace_id = GetTransactionStatusTableTablespace(table->second);
        if (tablespace_id) {
          if (!tablespace_info.count(*tablespace_id)) {
            // TODO: We should also delete the transaction table, see #11123.
            LOG(INFO) << "Found transaction status table for tablespace id " << *tablespace_id
                      << " which doesn't exist, clearing tablespace id";
            ClearTransactionStatusTableTablespace(table->second);
          }
        }
      }
    }

    // A tablespace id has been cleared, meaning a transaction table's placement has changed,
    // and thus the transaction tables version needs to be incremented.
    RETURN_NOT_OK(IncrementTransactionTablesVersion());
  }

  return Status::OK();
}

Result<shared_ptr<TableToTablespaceIdMap>> CatalogManager::GetYsqlTableToTablespaceMap(
    const TablespaceIdToReplicationInfoMap& tablespace_info) {
  auto table_to_tablespace_map = std::make_shared<TableToTablespaceIdMap>();

  // First fetch all namespaces. This is because the table_to_tablespace information is only
  // found in the pg_class catalog table. There exists a separate pg_class table in each
  // namespace. To build in-memory state for all tables, process pg_class table for each
  // namespace.
  vector<NamespaceId> namespace_id_vec;
  set<NamespaceId> colocated_namespaces;
  {
    SharedLock lock(mutex_);
    for (const auto& ns : namespace_ids_map_) {
      if (ns.second->database_type() != YQL_DATABASE_PGSQL) {
        continue;
      }

      if (ns.first == kPgSequencesDataNamespaceId) {
        // Skip the database created for sequences system table.
        continue;
      }

      if (ns.second->colocated()) {
        colocated_namespaces.insert(ns.first);
      }

      // TODO (Deepthi): Investigate if safe to skip template0 and template1 as well.
      namespace_id_vec.emplace_back(ns.first);
    }

    // Add local transaction tables corresponding to tablespaces.
    for (const auto& table_id : transaction_table_ids_set_) {
      auto table = table_ids_map_->find(table_id);
      if (table == table_ids_map_->end()) {
        LOG(DFATAL) << "Table uuid " << table_id
                    << " in transaction_table_ids_set_ but not in table_ids_map_";
        continue;
      }
      auto tablespace_id = GetTransactionStatusTableTablespace(table->second);
      if (tablespace_id) {
        if (tablespace_info.count(*tablespace_id)) {
          (*table_to_tablespace_map)[table_id] = *tablespace_id;
        } else {
          // It's possible that a new tablespace had its transaction table created then deleted
          // between when we checked tablespace ids and now; we ignore it here, and it will be
          // caught and cleared in the next tablespace update.
          LOG(INFO) << "Found transaction status table for tablespace id " << *tablespace_id
                    << " which doesn't exist, ignoring";
        }
      }
    }
  }

  // For each namespace, fetch the table->tablespace information by reading pg_class
  // table for each namespace.
  for (const NamespaceId& nsid : namespace_id_vec) {
    VLOG(1) << "Refreshing placement information for namespace " << nsid0;
    const uint32_t database_oid = CHECK_RESULT(GetPgsqlDatabaseOid(nsid));
    const bool is_colocated_database = colocated_namespaces.count(nsid) > 0;
    Status table_tablespace_status = sys_catalog_->ReadPgClassInfo(database_oid,
                                                                   is_colocated_database,
                                                                   table_to_tablespace_map.get());
    if (!table_tablespace_status.ok()) {
      LOG(WARNING) << "Refreshing table->tablespace info failed for namespace "
                   << nsid << " with error: " << table_tablespace_status.ToString();
    }

    const bool pg_yb_tablegroup_exists = VERIFY_RESULT(DoesTableExist(FindTableById(
      GetPgsqlTableId(database_oid, kPgYbTablegroupTableOid))));

    // no pg_yb_tablegroup means we only need to check pg_class
    if (table_tablespace_status.ok() && !pg_yb_tablegroup_exists1.04k) {
      VLOG(5) << "Successfully refreshed placement information for namespace " << nsid
              << " from pg_class";
      continue;
    }

    Status tablegroup_tablespace_status = sys_catalog_->ReadTablespaceInfoFromPgYbTablegroup(
      database_oid,
      table_to_tablespace_map.get());
    if (!tablegroup_tablespace_status.ok()) {
      LOG(WARNING) << "Refreshing tablegroup->tablespace info failed for namespace "
                  << nsid << " with error: " << tablegroup_tablespace_status.ToString();
    }
    if (table_tablespace_status.ok() && tablegroup_tablespace_status.ok()1.04k) {
      VLOG(5) << "Successfully refreshed placement information for namespace " << nsid
              << " from pg_class and pg_yb_tablegroup";
    }
  }

  return table_to_tablespace_map;
}

Status CatalogManager::CreateTransactionStatusTablesForTablespaces(
    const TablespaceIdToReplicationInfoMap& tablespace_info,
    const TableToTablespaceIdMap& table_to_tablespace_map) {
  if (!GetAtomicFlag(&FLAGS_enable_ysql_tablespaces_for_placement) ||
      !GetAtomicFlag(&FLAGS_auto_create_local_transaction_tables)) {
    return Status::OK();
  }

  std::unordered_set<TablespaceId> valid_tablespaces;
  for (const auto& entry : table_to_tablespace_map) {
    if (entry.second) {
      valid_tablespaces.insert(*entry.second);
    }
  }
  for (const auto& entry : tablespace_info) {
    if (!entry.second) {
      valid_tablespaces.erase(entry.first);
    }
  }

  for (const auto& tablespace_id : valid_tablespaces) {
    RETURN_NOT_OK(CreateLocalTransactionStatusTableIfNeeded(nullptr /* rpc */, tablespace_id));
  }

  return Status::OK();
}

void CatalogManager::StartTablespaceBgTaskIfStopped() {
  if (GetAtomicFlag(&FLAGS_ysql_tablespace_info_refresh_secs) <= 0 ||
      !GetAtomicFlag(&FLAGS_enable_ysql_tablespaces_for_placement)) {
    // The tablespace bg task is disabled. Nothing to do.
    return;
  }

  const bool is_task_running = tablespace_bg_task_running_.exchange(true);
  if (is_task_running) {
    // Task already running, nothing to do.
    return;
  }

  ScheduleRefreshTablespaceInfoTask(true /* schedule_now */);
}

void CatalogManager::ScheduleRefreshTablespaceInfoTask(const bool schedule_now) {
  int wait_time = 0;

  if (!schedule_now) {
    wait_time = GetAtomicFlag(&FLAGS_ysql_tablespace_info_refresh_secs);
    if (wait_time <= 0) {
      // The tablespace refresh task has been disabled.
      tablespace_bg_task_running_ = false;
      return;
    }
  }

  refresh_ysql_tablespace_info_task_.Schedule([this](const Status& status) {
    Status s = background_tasks_thread_pool_->SubmitFunc(
      std::bind(&CatalogManager::RefreshTablespaceInfoPeriodically, this));
    if (!s.IsOk()) {
      // Failed to submit task to the thread pool. Mark that the task is now
      // no longer running.
      LOG(WARNING) << "Failed to schedule: RefreshTablespaceInfoPeriodically";
      tablespace_bg_task_running_ = false;
    }
  }, wait_time * 1s);
}

void CatalogManager::RefreshTablespaceInfoPeriodically() {
  if (!GetAtomicFlag(&FLAGS_enable_ysql_tablespaces_for_placement)) {
    tablespace_bg_task_running_ = false;
    return;
  }

  if (!CheckIsLeaderAndReady().IsOk()) {
    LOG(INFO) << "No longer the leader, so cancelling tablespace info task";
    tablespace_bg_task_running_ = false;
    return;
  }

  // Refresh the tablespace info in memory.
  Status s = DoRefreshTablespaceInfo();
  if (!s.IsOk()) {
    LOG(WARNING) << "Tablespace refresh task failed with error " << s.ToString();
  }

  // Schedule the next iteration of the task.
  ScheduleRefreshTablespaceInfoTask();
}

Status CatalogManager::DoRefreshTablespaceInfo() {
  VLOG(2) << "Running RefreshTablespaceInfoPeriodically task"0;

  // First refresh the tablespace info in memory.
  auto tablespace_info = VERIFY_RESULT3.96k(GetYsqlTablespaceInfo());3.96k

  // Clear tablespace ids for transaction tables mapped to missing tablespaces.
  RETURN_NOT_OK(UpdateTransactionStatusTableTablespaces(*tablespace_info));

  shared_ptr<TableToTablespaceIdMap> table_to_tablespace_map = nullptr;

  if (tablespace_info->size() > kYsqlNumDefaultTablespaces) {
    // There exist custom tablespaces in the system. Fetch the table->tablespace
    // map from PG catalog tables.
    table_to_tablespace_map = VERIFY_RESULT(GetYsqlTableToTablespaceMap(*tablespace_info));
  }

  // Update tablespace_manager_.
  {
    LockGuard lock(tablespace_mutex_);
    tablespace_manager_ = std::make_shared<YsqlTablespaceManager>(tablespace_info,
                                                                  table_to_tablespace_map);
  }

  if (table_to_tablespace_map) {
    // Trigger transaction table creates for tablespaces with tables and no transaction tables.
    RETURN_NOT_OK(CreateTransactionStatusTablesForTablespaces(
        *tablespace_info, *table_to_tablespace_map));
  }

  VLOG(3) << "Refreshed tablespace information in memory"0;
  return Status::OK();
}

Status CatalogManager::AddIndexInfoToTable(const scoped_refptr<TableInfo>& indexed_table,
                                           const IndexInfoPB& index_info,
                                           CreateTableResponsePB* resp) {
  LOG(INFO) << "AddIndexInfoToTable to " << indexed_table->ToString() << "  IndexInfo "
            << yb::ToString(index_info);
  TRACE("Locking indexed table");
  auto l = DCHECK_NOTNULL(indexed_table)->LockForWrite();
  RETURN_NOT_OK(CheckIfTableDeletedOrNotVisibleToClient(l, resp));

  // Make sure that the index appears to not have been added to the table until the tservers apply
  // the alter and respond back.
  // Heed issue #6233.
  if (!l->pb.has_fully_applied_schema()) {
    MultiStageAlterTable::CopySchemaDetailsToFullyApplied(&l.mutable_data()->pb);
  }

  // Add index info to indexed table and increment schema version.
  auto& pb = l.mutable_data()->pb;
  pb.add_indexes()->CopyFrom(index_info);
  pb.set_version(l.mutable_data()->pb.version() + 1);
  pb.set_updates_only_index_permissions(false);
  l.mutable_data()->set_state(
      SysTablesEntryPB::ALTERING,
      Format("Add index info version=$0 ts=$1", pb.version(), LocalTimeAsString()));

  // Update sys-catalog with the new indexed table info.
  TRACE("Updating indexed table metadata on disk");
  RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), indexed_table));

  // Update the in-memory state.
  TRACE("Committing in-memory state");
  l.Commit();

  RETURN_NOT_OK(SendAlterTableRequest(indexed_table));

  return Status::OK();
}

Status CatalogManager::CreateCopartitionedTable(const CreateTableRequestPB& req,
                                                CreateTableResponsePB* resp,
                                                rpc::RpcContext* rpc,
                                                Schema schema,
                                                scoped_refptr<NamespaceInfo> ns) {
  scoped_refptr<TableInfo> parent_table_info;
  Status s;
  PartitionSchema partition_schema;
  std::vector<Partition> partitions;

  const NamespaceId& namespace_id = ns->id();
  const NamespaceName& namespace_name = ns->name();

  LockGuard lock(mutex_);
  TRACE("Acquired catalog manager lock");
  parent_table_info = FindPtrOrNull(*table_ids_map_,
                                    schema.table_properties().CopartitionTableId());
  if (parent_table_info == nullptr) {
    s = STATUS(NotFound, "The object does not exist: copartitioned table with id",
               schema.table_properties().CopartitionTableId());
    return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_NOT_FOUND, s);
  }

  TableInfoPtr this_table_info;
  // Verify that the table does not exist.
  this_table_info = FindPtrOrNull(table_names_map_, {namespace_id, req.name()});

  if (this_table_info != nullptr) {
    s = STATUS_SUBSTITUTE(AlreadyPresent,
        "Object '$0.$1' already exists",
        GetNamespaceNameUnlocked(this_table_info), this_table_info->name());
    LOG(WARNING) << "Found table: " << this_table_info->ToStringWithState()
                 << ". Failed creating copartitioned table with error: "
                 << s.ToString() << " Request:\n" << req.DebugString();
    return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_ALREADY_PRESENT, s);
  }
  // Don't add copartitioned tables to Namespaces that aren't running.
  if (ns->state() != SysNamespaceEntryPB::RUNNING) {
    Status s = STATUS_SUBSTITUTE(TryAgain,
        "Namespace not running (State=$0).  Cannot create $1.$2",
        ns->state(), ns->name(), req.name() );
    return SetupError(resp->mutable_error(), NamespaceMasterError(ns->state()), s);
  }

  // TODO: pass index_info for copartitioned index.
  RETURN_NOT_OK(CreateTableInMemory(
      req, schema, partition_schema, namespace_id, namespace_name,
      partitions, nullptr, nullptr, resp, &this_table_info));

  TRACE("Inserted new table info into CatalogManager maps");

  // NOTE: the table is already locked for write at this point,
  // since the CreateTableInfo function leave it in that state.
  // It will get committed at the end of this function.
  // Sanity check: the table should be in "preparing" state.
  CHECK_EQ(SysTablesEntryPB::PREPARING, this_table_info->metadata().dirty().pb.state());
  TabletInfos tablets = parent_table_info->GetTablets();
  for (auto tablet : tablets) {
    tablet->mutable_metadata()->StartMutation();
    tablet->mutable_metadata()->mutable_dirty()->pb.add_table_ids(this_table_info->id());
  }

  // Update Tablets about new table id to sys-tablets.
  s = sys_catalog_->Upsert(leader_ready_term(), tablets);
  if (PREDICT_FALSE(!s.ok())) {
    return AbortTableCreation(this_table_info.get(), tablets, s.CloneAndPrepend(
        Substitute("An error occurred while inserting to sys-tablets: $0", s.ToString())), resp);
  }
  TRACE("Wrote tablets to system table");

  // Update the on-disk table state to "running".
  this_table_info->AddTablets(tablets);
  this_table_info->mutable_metadata()->mutable_dirty()->pb.set_state(SysTablesEntryPB::RUNNING);
  s = sys_catalog_->Upsert(leader_ready_term(), this_table_info);
  if (PREDICT_FALSE(!s.ok())) {
    return AbortTableCreation(this_table_info.get(), tablets, s.CloneAndPrepend(
        Substitute("An error occurred while inserting to sys-tablets: $0",
                   s.ToString())), resp);
  }
  TRACE("Wrote table to system table");

  // Commit the in-memory state.
  this_table_info->mutable_metadata()->CommitMutation();

  for (const auto& tablet : tablets) {
    tablet->mutable_metadata()->CommitMutation();
  }

  for (const auto& tablet : tablets) {
    SendCopartitionTabletRequest(tablet, this_table_info);
  }

  LOG(INFO) << "Successfully created table " << this_table_info->ToString()
            << " per request from " << RequestorString(rpc);
  return Status::OK();
}


template <class Req, class Resp, class Action>
Status CatalogManager::PerformOnSysCatalogTablet(const Req& req, Resp* resp, const Action& action) {
  auto tablet_peer = sys_catalog_->tablet_peer();
  auto shared_tablet = tablet_peer ? tablet_peer->shared_tablet() : nullptr;
  if (!shared_tablet) {
    return SetupError(
        resp->mutable_error(),
        MasterErrorPB::TABLET_NOT_RUNNING,
        STATUS(NotFound, "The sys catalog tablet was not found."));
  }

  auto s = action(shared_tablet);
  if (!s.ok()) {
    return SetupError(resp->mutable_error(), MasterErrorPB::INTERNAL_ERROR, s);
  }

  return Status::OK();
}

Status CatalogManager::FlushSysCatalog(
    const FlushSysCatalogRequestPB* req,
    FlushSysCatalogResponsePB* resp,
    rpc::RpcContext* context) {
  return PerformOnSysCatalogTablet(req, resp, [](auto shared_tablet) {
    return shared_tablet->Flush(tablet::FlushMode::kSync);
  });
}

Status CatalogManager::CompactSysCatalog(
    const CompactSysCatalogRequestPB* req,
    CompactSysCatalogResponsePB* resp,
    rpc::RpcContext* context) {
  return PerformOnSysCatalogTablet(req, resp, [](auto shared_tablet) {
    return shared_tablet->ForceFullRocksDBCompact();
  });
}

namespace {

Result<std::array<PartitionPB, kNumSplitParts>> CreateNewTabletsPartition(
    const TabletInfo& tablet_info, const std::string& split_partition_key) {
  const auto& source_partition = tablet_info.LockForRead()->pb.partition();

  if (split_partition_key <= source_partition.partition_key_start() ||
      (!source_partition.partition_key_end().empty() &&
       split_partition_key >= source_partition.partition_key_end()78)) {
    return STATUS_FORMAT(
        InvalidArgument,
        "Can't split tablet $0 (partition_key_start: $1 partition_key_end: $2) by partition "
        "boundary (split_key: $3)",
        tablet_info.tablet_id(), source_partition.partition_key_start(),
        source_partition.partition_key_end(), split_partition_key);
  }

  std::array<PartitionPB, kNumSplitParts> new_tablets_partition;

  new_tablets_partition.fill(source_partition);

  new_tablets_partition[0].set_partition_key_end(split_partition_key);
  new_tablets_partition[1].set_partition_key_start(split_partition_key);
  static_assert(kNumSplitParts == 2, "We expect tablet to be split into 2 new tablets here");

  return new_tablets_partition;
}

}  // namespace

CHECKED_STATUS CatalogManager::TEST_SplitTablet(
    const TabletId& tablet_id, const std::string& split_encoded_key,
    const std::string& split_partition_key) {
  auto source_tablet_info = VERIFY_RESULT(GetTabletInfo(tablet_id));
  return DoSplitTablet(source_tablet_info, split_encoded_key, split_partition_key,
      true /* select_all_tablets_for_split */);
}

Status CatalogManager::TEST_SplitTablet(
    const scoped_refptr<TabletInfo>& source_tablet_info, docdb::DocKeyHash split_hash_code) {
  return DoSplitTablet(source_tablet_info, split_hash_code,
      true /* select_all_tablets_for_split */);
}

Status CatalogManager::TEST_IncrementTablePartitionListVersion(const TableId& table_id) {
  auto table_info = GetTableInfo(table_id);
  SCHECK(table_info != nullptr, NotFound, Format("Table $0 not found", table_id));

  LockGuard lock(mutex_);
  auto table_lock = table_info->LockForWrite();
  auto& table_pb = table_lock.mutable_data()->pb;
  table_pb.set_partition_list_version(table_pb.partition_list_version() + 1);
  RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), table_info));
  table_lock.Commit();
  return Status::OK();
}

Result<ReplicationInfoPB> CatalogManager::GetTableReplicationInfo(
    const TabletInfo& tablet_info) const {
  auto table = tablet_info.table();
  {
    auto table_lock = table->LockForRead();
    if (table_lock->pb.has_replication_info()) {
      return table_lock->pb.replication_info();
    }
  }

  auto replication_info_opt = VERIFY_RESULT(
      GetTablespaceManager()->GetTableReplicationInfo(table));
  if (replication_info_opt) {
    return replication_info_opt.value();
  }

  return ClusterConfig()->LockForRead()->pb.replication_info();
}

bool CatalogManager::ShouldSplitValidCandidate(
    const TabletInfo& tablet_info, const TabletReplicaDriveInfo& drive_info) const {
  if (drive_info.may_have_orphaned_post_split_data) {
    return false;
  }
  ssize_t size = drive_info.sst_files_size;
  DCHECK(size >= 0) << "Detected overflow in casting sst_files_size to signed int."0;
  if (size < FLAGS_tablet_split_low_phase_size_threshold_bytes) {
    return false;
  }
  TSDescriptorVector ts_descs = GetAllLiveNotBlacklistedTServers();

  size_t num_servers = 0;
  auto table_replication_info_or_status = GetTableReplicationInfo(tablet_info);

  // If there is custom placement information present then
  // only count the tservers which the table has access to
  // according to the placement policy
  if (table_replication_info_or_status.ok()
      && table_replication_info_or_status->has_live_replicas()) {
    auto pb = table_replication_info_or_status->live_replicas();
    auto valid_tservers_res = FindTServersForPlacementInfo(
      table_replication_info_or_status->live_replicas(), ts_descs);
    if (!valid_tservers_res.ok()) {
      num_servers = ts_descs.size();
    } else {
      num_servers = valid_tservers_res.get().size();
    }
  } else {
    num_servers = ts_descs.size();
  }

  int64 num_tablets_per_server = tablet_info.table()->NumPartitions() / num_servers;

  if (num_tablets_per_server < FLAGS_tablet_split_low_phase_shard_count_per_node) {
    return size > FLAGS_tablet_split_low_phase_size_threshold_bytes;
  }
  if (num_tablets_per_server < FLAGS_tablet_split_high_phase_shard_count_per_node) {
    return size > FLAGS_tablet_split_high_phase_size_threshold_bytes;
  }
  return size > FLAGS_tablet_force_split_threshold_bytes;
}

Status CatalogManager::DoSplitTablet(
    const scoped_refptr<TabletInfo>& source_tablet_info, std::string split_encoded_key,
    std::string split_partition_key, bool select_all_tablets_for_split) {
  auto source_table_lock = source_tablet_info->table()->LockForWrite();
  auto source_tablet_lock = source_tablet_info->LockForWrite();

  // We must re-validate the split candidate here *after* grabbing locks on the table and tablet to
  // ensure a backfill does not happen before we modify catalog metadata to include new subtablets.
  // This process adds new subtablets in the CREATING state, which if encountered by backfill code
  // will block the backfill process.
  RETURN_NOT_OK(tablet_split_manager_.ValidateSplitCandidateTable(*source_tablet_info->table()));
  RETURN_NOT_OK(tablet_split_manager_.ValidateSplitCandidateTablet(*source_tablet_info));

  auto drive_info = VERIFY_RESULT(source_tablet_info->GetLeaderReplicaDriveInfo());
  if (!select_all_tablets_for_split &&
      !ShouldSplitValidCandidate(*source_tablet_info, drive_info)133) {
    // It is possible that we queued up a split candidate in TabletSplitManager which was, at the
    // time, a valid split candidate, but by the time the candidate was actually processed here, the
    // cluster may have changed, putting us in a new split threshold phase, and it may no longer be
    // a valid candidate. This is not an unexpected error, but we should bail out of splitting this
    // tablet regardless.
    return STATUS_FORMAT(
        InvalidArgument,
        "Tablet split candidate $0 is no longer a valid split candidate.",
        source_tablet_info->tablet_id());
  }

  // Check if at least one child tablet already registered
  if (source_tablet_lock->pb.split_tablet_ids().size() > 0) {
    const auto child_tablet_id = source_tablet_lock->pb.split_tablet_ids(0);
    const auto child_tablet = VERIFY_RESULT(GetTabletInfo(child_tablet_id));
    const auto parent_partition = source_tablet_lock->pb.partition();
    const auto child_partition = child_tablet->LockForRead()->pb.partition();

    if (parent_partition.partition_key_start() == child_partition.partition_key_start()) {
      split_partition_key = child_partition.partition_key_end();
    } else {
      SCHECK_EQ(parent_partition.partition_key_end(), child_partition.partition_key_end(),
        IllegalState, "Parent partion key end does not equal child partition key end");
      split_partition_key = child_partition.partition_key_start();
    }

    // Re-compute the encoded key
    // to ensure we use the same partition boundary for both child tablets
    split_encoded_key = PartitionSchema::GetEncodedKeyPrefix(
      split_partition_key, source_table_lock->pb.partition_schema());
  }

  LOG(INFO) << "Starting tablet split: " << source_tablet_info->ToString()
            << " by partition key: " << Slice(split_partition_key).ToDebugHexString();

  std::array<PartitionPB, kNumSplitParts> new_tablets_partition = VERIFY_RESULT(
      CreateNewTabletsPartition(*source_tablet_info, split_partition_key));

  std::array<TabletId, kNumSplitParts> new_tablet_ids;
  for (int i = 0; i < kNumSplitParts; ++i282) {
    if (i < source_tablet_lock->pb.split_tablet_ids_size()) {
      // Post-split tablet `i` has been already registered.
      new_tablet_ids[i] = source_tablet_lock->pb.split_tablet_ids(i);
    } else {
      auto new_tablet_info = VERIFY_RESULT(RegisterNewTabletForSplit(
          source_tablet_info.get(), new_tablets_partition[i],
          &source_table_lock, &source_tablet_lock));

      new_tablet_ids[i] = new_tablet_info->id();
    }
  }
  source_tablet_lock.Commit();
  source_table_lock.Commit();

  // TODO(tsplit): what if source tablet will be deleted before or during TS leader is processing
  // split? Add unit-test.
  RETURN_NOT_OK(SendSplitTabletRequest(
      source_tablet_info, new_tablet_ids, split_encoded_key, split_partition_key));

  return Status::OK();
}

Status CatalogManager::DoSplitTablet(
    const scoped_refptr<TabletInfo>& source_tablet_info, docdb::DocKeyHash split_hash_code,
    bool select_all_tablets_for_split) {
  docdb::KeyBytes split_encoded_key;
  docdb::DocKeyEncoderAfterTableIdStep(&split_encoded_key)
      .Hash(split_hash_code, std::vector<docdb::PrimitiveValue>());

  const auto split_partition_key = PartitionSchema::EncodeMultiColumnHashValue(split_hash_code);

  return DoSplitTablet(source_tablet_info, split_encoded_key.ToStringBuffer(), split_partition_key,
      select_all_tablets_for_split);
}

Result<scoped_refptr<TabletInfo>> CatalogManager::GetTabletInfo(const TabletId& tablet_id) {
  LockGuard lock(mutex_);
  TRACE("Acquired catalog manager lock");

  const auto tablet_info = FindPtrOrNull(*tablet_map_, tablet_id);
  SCHECK(tablet_info != nullptr, NotFound, Format("Tablet $0 not found", tablet_id));

  return tablet_info;
}

void CatalogManager::SplitTabletWithKey(
    const scoped_refptr<TabletInfo>& tablet, const std::string& split_encoded_key,
    const std::string& split_partition_key, const bool select_all_tablets_for_split) {
  // Note that DoSplitTablet() will trigger an async SplitTablet task, and will only return not OK()
  // if it failed to submit that task. In other words, any failures here are not retriable, and
  // success indicates that an async and automatically retrying task was submitted.
  auto s = DoSplitTablet(
      tablet, split_encoded_key, split_partition_key, select_all_tablets_for_split);
  WARN_NOT_OK(s, Format("Failed to split tablet with GetSplitKey result for tablet: $0",
                        tablet->tablet_id()));
}

Status CatalogManager::SplitTablet(const TabletId& tablet_id, bool select_all_tablets_for_split) {
  LOG(INFO) << "Got tablet to split: " << tablet_id;

  const auto tablet = VERIFY_RESULT(GetTabletInfo(tablet_id));

  VLOG(2) << "Scheduling GetSplitKey request to leader tserver for source tablet ID: "
          << tablet->tablet_id();
  auto call = std::make_shared<AsyncGetTabletSplitKey>(
      master_, AsyncTaskPool(), tablet,
      [this, tablet, select_all_tablets_for_split]
          (const Result<AsyncGetTabletSplitKey::Data>& result) {
        if (result.ok()) {
          SplitTabletWithKey(tablet, result->split_encoded_key, result->split_partition_key,
              select_all_tablets_for_split);
        } else if (1tserver::TabletServerError(result.status()) ==
            tserver::TabletServerErrorPB::TABLET_SPLIT_DISABLED_TTL_EXPIRY) {
          tablet_split_manager()->MarkTtlTableForSplitIgnore(tablet->table()->id());
          LOG(INFO) << "AsyncGetTabletSplitKey task failed for tablet " << tablet->tablet_id()
              << ". Tablet split not supported for tablets with TTL file expiration.";
        } else {
          LOG(WARNING) << "AsyncGetTabletSplitKey task failed with status: " << result.status();
        }
      });
  tablet->table()->AddTask(call);
  return ScheduleTask(call);
}

Status CatalogManager::SplitTablet(
    const SplitTabletRequestPB* req, SplitTabletResponsePB* resp, rpc::RpcContext* rpc) {
  const auto source_tablet_id = req->tablet_id();
  return SplitTablet(source_tablet_id, true /* select_all_tablets_for_split */);
}

Status CatalogManager::DeleteNotServingTablet(
    const DeleteNotServingTabletRequestPB* req, DeleteNotServingTabletResponsePB* resp,
    rpc::RpcContext* rpc) {
  const auto& tablet_id = req->tablet_id();
  const auto tablet_info = VERIFY_RESULT(GetTabletInfo(tablet_id));

  if (PREDICT_FALSE(FLAGS_TEST_reject_delete_not_serving_tablet_rpc)) {
    TEST_SYNC_POINT("CatalogManager::DeleteNotServingTablet:Reject");
    return STATUS(
        InvalidArgument, "Rejecting due to FLAGS_TEST_reject_delete_not_serving_tablet_rpc");
  }

  const auto& table_info = tablet_info->table();

  RETURN_NOT_OK(CheckIfForbiddenToDeleteTabletOf(table_info));

  RETURN_NOT_OK(CatalogManagerUtil::CheckIfCanDeleteSingleTablet(tablet_info));

  auto schedules_to_tables_map = VERIFY_RESULT(
      MakeSnapshotSchedulesToObjectIdsMap(SysRowEntryType::TABLE));
  RepeatedBytes retained_by_snapshot_schedules;
  FillRetainedBySnapshotSchedules(
      schedules_to_tables_map, table_info->id(), &retained_by_snapshot_schedules);

  return DeleteTabletListAndSendRequests(
      { tablet_info }, "Not serving tablet deleted upon request at " + LocalTimeAsString(),
      retained_by_snapshot_schedules);
}

Status CatalogManager::DdlLog(
    const DdlLogRequestPB* req, DdlLogResponsePB* resp, rpc::RpcContext* rpc) {
  return sys_catalog_->FetchDdlLog(resp->mutable_entries());
}

namespace {

CHECKED_STATUS ValidateCreateTableSchema(const Schema& schema, CreateTableResponsePB* resp) {
  if (schema.num_key_columns() <= 0) {
    return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA,
                      STATUS(InvalidArgument, "Must specify at least one key column"));
  }
  for (size_t i = 0; 21.8ki < schema.num_key_columns(); i++39.5k) {
    if (!IsTypeAllowableInKey(schema.column(i).type_info())) {
      return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA,
                        STATUS(InvalidArgument, "Invalid datatype for primary key column"));
    }
  }
  return Status::OK();
}

// Extract a colocation ID from request if explicitly passed, or generate a new valid one.
// Will error if requested ID is taken or invalid.
template<typename ContainsColocationIdFn>
Result<ColocationId> ConceiveColocationId(const CreateTableRequestPB& req,
                                          CreateTableResponsePB* resp,
                                          ContainsColocationIdFn contains_colocation_id) {
  ColocationId colocation_id;

  if (req.has_colocation_id()) {
    colocation_id = req.colocation_id();
    if (colocation_id < kFirstNormalColocationId) {
      Status s = STATUS_SUBSTITUTE(InvalidArgument,
                                   "Colocation ID cannot be less than $0",
                                   kFirstNormalColocationId);
      return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
    }
    if (contains_colocation_id(colocation_id)) {
      Status s =
          STATUS_SUBSTITUTE(InvalidArgument,
                            "Colocation group already contains a table with colocation ID $0",
                            colocation_id);
      return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
    }
  } else {
    // Generate a random colocation ID unique within colocation group.
    colocation_id = 20000; // In agreement with sequential_colocation_ids flag.
    do {
      if (PREDICT_FALSE(FLAGS_TEST_sequential_colocation_ids)) {
        colocation_id++;
      } else {
        // See comment on kFirstNormalColocationId.
        colocation_id =
            RandomUniformInt<ColocationId>(kFirstNormalColocationId,
                                           std::numeric_limits<ColocationId>::max());
      }
    } while (contains_colocation_id(colocation_id));
  }

  return colocation_id;
}

}  // namespace

Status CatalogManager::CreateYsqlSysTable(const CreateTableRequestPB* req,
                                          CreateTableResponsePB* resp) {
  LOG(INFO) << "CreateYsqlSysTable: " << req->name();
  // Lookup the namespace and verify if it exists.
  TRACE("Looking up namespace");
  auto ns = VERIFY_RESULT(FindNamespace(req->namespace_()));
  const NamespaceId& namespace_id = ns->id();
  const NamespaceName& namespace_name = ns->name();

  Schema schema;
  RETURN_NOT_OK(SchemaFromPB(req->schema(), &schema));
  // If the schema contains column ids, we are copying a Postgres table from one namespace to
  // another. Anyway, validate the schema.
  RETURN_NOT_OK(ValidateCreateTableSchema(schema, resp));
  if (!schema.has_column_ids()) {
    schema.InitColumnIdsByDefault();
  }
  schema.mutable_table_properties()->set_is_ysql_catalog_table(true);

  // Verify no hash partition schema is specified.
  if (req->partition_schema().has_hash_schema()) {
    return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA,
                      STATUS(InvalidArgument,
                             "PostgreSQL system catalog tables are non-partitioned"));
  }

  if (req->table_type() != TableType::PGSQL_TABLE_TYPE) {
    return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA,
                      STATUS_FORMAT(
                          InvalidArgument,
                          "Expected table type to be PGSQL_TABLE_TYPE ($0), got $1 ($2)",
                          PGSQL_TABLE_TYPE,
                          TableType_Name(req->table_type())));

  }

  // Create partition schema and one partition.
  PartitionSchema partition_schema;
  vector<Partition> partitions;
  RETURN_NOT_OK(partition_schema.CreatePartitions(1, &partitions));

  // Create table info in memory.
  scoped_refptr<TableInfo> table;
  scoped_refptr<TabletInfo> sys_catalog_tablet;
  {
    LockGuard lock(mutex_);
    TRACE("Acquired catalog manager lock");

    // Verify that the table does not exist, or has been deleted.
    table = FindPtrOrNull(*table_ids_map_, req->table_id());
    if (table != nullptr && !table->is_deleted()1) {
      Status s = STATUS_SUBSTITUTE(AlreadyPresent,
          "YSQL table '$0.$1' (ID: $2) already exists", ns->name(), table->name(), table->id());
      LOG(WARNING) << "Found table: " << table->ToStringWithState()
                   << ". Failed creating YSQL system table with error: "
                   << s.ToString() << " Request:\n" << req->DebugString();
      // Technically, client already knows table ID, but we set it anyway for unified handling of
      // AlreadyPresent errors. See comment in CreateTable()
      resp->set_table_id(table->id());
      return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_ALREADY_PRESENT, s);
    }

    RETURN_NOT_OK(CreateTableInMemory(
        *req, schema, partition_schema, namespace_id, namespace_name,
        partitions, nullptr /* index_info */, nullptr /* tablets */, resp, &table));

    sys_catalog_tablet = tablet_map_->find(kSysCatalogTabletId)->second;
  }

  // Tables with a transaction should be rolled back if the transaction does not get committed.
  // Store this on the table persistent state until the transaction has been a verified success.
  TransactionMetadata txn;
  if (req->has_transaction() && FLAGS_enable_transactional_ddl_gc55) {
    table->mutable_metadata()->mutable_dirty()->pb.mutable_transaction()->
        CopyFrom(req->transaction());
    txn = VERIFY_RESULT(TransactionMetadata::FromPB(req->transaction()));
    RSTATUS_DCHECK(!txn.status_tablet.empty(), Corruption, "Given incomplete Transaction");
  }

  {
    auto tablet_lock = sys_catalog_tablet->LockForWrite();
    tablet_lock.mutable_data()->pb.add_table_ids(table->id());

    Status s = sys_catalog_->Upsert(leader_ready_term(), sys_catalog_tablet);
    if (PREDICT_FALSE(!s.ok())) {
      return AbortTableCreation(table.get(), {}, s.CloneAndPrepend(
        "An error occurred while inserting to sys-tablets: "), resp);
    }
    table->set_is_system();
    table->AddTablet(sys_catalog_tablet.get());
    tablet_lock.Commit();
  }
  TRACE("Inserted new table info into CatalogManager maps");

  // Update the on-disk table state to "running".
  table->mutable_metadata()->mutable_dirty()->pb.set_state(SysTablesEntryPB::RUNNING);
  Status s = sys_catalog_->Upsert(leader_ready_term(), table);
  if (PREDICT_FALSE(!s.ok())) {
    return AbortTableCreation(table.get(), {}, s.CloneAndPrepend(
      "An error occurred while inserting to sys-tablets: "), resp);
  }
  TRACE("Wrote table to system table");

  // Commit the in-memory state.
  table->mutable_metadata()->CommitMutation();

  // Verify Transaction gets committed, which occurs after table create finishes.
  if (req->has_transaction() && PREDICT_TRUE55(FLAGS_enable_transactional_ddl_gc)) {
    LOG(INFO) << "Enqueuing table for Transaction Verification: " << req->name();
    std::function<Status(bool)> when_done =
        std::bind(&CatalogManager::VerifyTablePgLayer, this, table, _1);
    WARN_NOT_OK(background_tasks_thread_pool_->SubmitFunc(
        std::bind(&YsqlTransactionDdl::VerifyTransaction, ysql_transaction_.get(), txn, when_done)),
                "Could not submit VerifyTransaction to thread pool");
  }

  tablet::ChangeMetadataRequestPB change_req;
  change_req.set_tablet_id(kSysCatalogTabletId);
  auto& add_table = *change_req.mutable_add_table();

  add_table.set_table_id(req->table_id());
  add_table.set_table_type(TableType::PGSQL_TABLE_TYPE);
  add_table.set_table_name(req->name());
  SchemaToPB(schema, add_table.mutable_schema());
  add_table.set_schema_version(0);

  partition_schema.ToPB(add_table.mutable_partition_schema());

  RETURN_NOT_OK(tablet::SyncReplicateChangeMetadataOperation(
      &change_req, sys_catalog_->tablet_peer().get(), leader_ready_term()));

  if (initial_snapshot_writer_) {
    initial_snapshot_writer_->AddMetadataChange(change_req);
  }
  return Status::OK();
}

Status CatalogManager::ReservePgsqlOids(const ReservePgsqlOidsRequestPB* req,
                                        ReservePgsqlOidsResponsePB* resp,
                                        rpc::RpcContext* rpc) {
  VLOG(1) << "ReservePgsqlOids request: " << req->ShortDebugString()0;

  // Lookup namespace
  scoped_refptr<NamespaceInfo> ns;
  {
    SharedLock lock(mutex_);
    ns = FindPtrOrNull(namespace_ids_map_, req->namespace_id());
  }
  if (!ns) {
    return SetupError(resp->mutable_error(), MasterErrorPB::NAMESPACE_NOT_FOUND,
                      STATUS(NotFound, "Namespace not found", req->namespace_id()));
  }

  // Reserve oids.
  auto l = ns->LockForWrite();

  uint32_t begin_oid = l->pb.next_pg_oid();
  if (begin_oid < req->next_oid()) {
    begin_oid = req->next_oid();
  }
  if (begin_oid == std::numeric_limits<uint32_t>::max()) {
    LOG(WARNING) << Format("No more object identifier is available for Postgres database $0 ($1)",
                           l->pb.name(), req->namespace_id());
    return SetupError(resp->mutable_error(), MasterErrorPB::UNKNOWN_ERROR,
                      STATUS(InvalidArgument, "No more object identifier is available"));
  }

  uint32_t end_oid = begin_oid + req->count();
  if (end_oid < begin_oid) {
    end_oid = std::numeric_limits<uint32_t>::max(); // Handle wraparound.
  }

  resp->set_begin_oid(begin_oid);
  resp->set_end_oid(end_oid);
  l.mutable_data()->pb.set_next_pg_oid(end_oid);

  // Update the on-disk state.
  const Status s = sys_catalog_->Upsert(leader_ready_term(), ns);
  if (!s.ok()) {
    return SetupError(resp->mutable_error(), MasterErrorPB::UNKNOWN_ERROR, s);
  }

  // Commit the in-memory state.
  l.Commit();

  VLOG(1) << "ReservePgsqlOids response: " << resp->ShortDebugString()0;

  return Status::OK();
}

Status CatalogManager::GetYsqlCatalogConfig(const GetYsqlCatalogConfigRequestPB* req,
                                            GetYsqlCatalogConfigResponsePB* resp,
                                            rpc::RpcContext* rpc) {
  VLOG(1) << "GetYsqlCatalogConfig request: " << req->ShortDebugString()0;
  auto l = CHECK_NOTNULL(ysql_catalog_config_.get())->LockForRead();
  resp->set_version(l->pb.ysql_catalog_config().version());

  return Status::OK();
}

Status CatalogManager::CopyPgsqlSysTables(const NamespaceId& namespace_id,
                                          const std::vector<scoped_refptr<TableInfo>>& tables) {
  const uint32_t database_oid = CHECK_RESULT(GetPgsqlDatabaseOid(namespace_id));
  vector<TableId> source_table_ids;
  vector<TableId> target_table_ids;
  for (const auto& table : tables) {
    CreateTableRequestPB table_req;
    CreateTableResponsePB table_resp;

    const uint32_t table_oid = VERIFY_RESULT(GetPgsqlTableOid(table->id()));
    const TableId table_id = GetPgsqlTableId(database_oid, table_oid);

    // Hold read lock until rows from the table are copied also.
    auto l = table->LockForRead();

    // Skip shared table.
    if (l->pb.is_pg_shared_table()) {
      continue;
    }

    table_req.set_name(l->pb.name());
    table_req.mutable_namespace_()->set_id(namespace_id);
    table_req.set_table_type(PGSQL_TABLE_TYPE);
    table_req.mutable_schema()->CopyFrom(l->schema());
    table_req.set_is_pg_catalog_table(true);
    table_req.set_table_id(table_id);

    if (IsIndex(l->pb)) {
      const uint32_t indexed_table_oid =
        VERIFY_RESULT(GetPgsqlTableOid(GetIndexedTableId(l->pb)));
      const TableId indexed_table_id = GetPgsqlTableId(database_oid, indexed_table_oid);

      // Set index_info.
      // Previously created INDEX wouldn't have the attribute index_info.
      if (l->pb.has_index_info()) {
        table_req.mutable_index_info()->CopyFrom(l->pb.index_info());
        table_req.mutable_index_info()->set_indexed_table_id(indexed_table_id);
      }

      // Set deprecated field for index_info.
      table_req.set_indexed_table_id(indexed_table_id);
      table_req.set_is_local_index(PROTO_GET_IS_LOCAL(l->pb));
      table_req.set_is_unique_index(PROTO_GET_IS_UNIQUE(l->pb));
    }

    auto s = CreateYsqlSysTable(&table_req, &table_resp);
    if (!s.ok()) {
      return s.CloneAndPrepend(Substitute(
          "Failure when creating PGSQL System Tables: $0", table_resp.error().ShortDebugString()));
    }

    source_table_ids.push_back(table->id());
    target_table_ids.push_back(table_id);
  }
  RETURN_NOT_OK(
      sys_catalog_->CopyPgsqlTables(source_table_ids, target_table_ids, leader_ready_term()));
  return Status::OK();
}

size_t CatalogManager::GetNumLiveTServersForPlacement(const PlacementId& placement_id) {
  auto blacklist = BlacklistSetFromPB();
  TSDescriptorVector ts_descs;
  master_->ts_manager()->GetAllLiveDescriptorsInCluster(
      &ts_descs, placement_id, (blacklist.ok() ? *blacklist : BlacklistSet()0));
  return ts_descs.size();
}

TSDescriptorVector CatalogManager::GetAllLiveNotBlacklistedTServers() const {
  TSDescriptorVector ts_descs;
  auto blacklist = BlacklistSetFromPB();
  master_->ts_manager()->GetAllLiveDescriptors(
      &ts_descs, blacklist.ok() ? *blacklist : BlacklistSet()0);
  return ts_descs;
}

namespace {

size_t GetNumReplicasFromPlacementInfo(const PlacementInfoPB& placement_info) {
  return placement_info.num_replicas() > 0 ?
      placement_info.num_replicas()11.6k : FLAGS_replication_factor;
}

Status CheckNumReplicas(const PlacementInfoPB& placement_info,
                        const TSDescriptorVector& ts_descs,
                        const vector<Partition>& partitions,
                        CreateTableResponsePB* resp) {
  auto max_tablets = FLAGS_max_create_tablets_per_ts * ts_descs.size();
  auto num_replicas = GetNumReplicasFromPlacementInfo(placement_info);
  if (num_replicas > 1 && max_tablets > 07.58k && partitions.size() > max_tablets7.54k) {
    std::string msg = Substitute("The requested number of tablets ($0) is over the permitted "
                                 "maximum ($1)", partitions.size(), max_tablets);
    Status s = STATUS(InvalidArgument, msg);
    LOG(WARNING) << msg;
    return SetupError(resp->mutable_error(), MasterErrorPB::TOO_MANY_TABLETS, s);
  }

  return Status::OK();
}

} // namespace

// Create a new table.
// See README file in this directory for a description of the design.
Status CatalogManager::CreateTable(const CreateTableRequestPB* orig_req,
                                   CreateTableResponsePB* resp,
                                   rpc::RpcContext* rpc) {
  DVLOG(3) << __PRETTY_FUNCTION__ << " Begin. " << orig_req->DebugString()0;

  const bool is_pg_table = orig_req->table_type() == PGSQL_TABLE_TYPE;
  const bool is_pg_catalog_table = is_pg_table && orig_req->is_pg_catalog_table()5.22k;
  if (!is_pg_catalog_table || !FLAGS_hide_pg_catalog_table_creation_logs313) {
    LOG(INFO) << "CreateTable from " << RequestorString(rpc)
                << ":\n" << orig_req->DebugString();
  } else {
    LOG(INFO) << "CreateTable from " << RequestorString(rpc) << ": " << orig_req->name();
  }

  const bool is_transactional = orig_req->schema().table_properties().is_transactional();
  // If this is a transactional table, we need to create the transaction status table (if it does
  // not exist already).
  if (is_transactional && (5.66k!is_pg_catalog_table5.66k || !FLAGS_create_initial_sys_catalog_snapshot313)) {
    Status s = CreateGlobalTransactionStatusTableIfNeeded(rpc);
    if (!s.ok()) {
      return s.CloneAndPrepend("Error while creating transaction status table");
    }
  } else {
    VLOG(1)
        << "Not attempting to create a transaction status table:\n"
        << "  " << EXPR_VALUE_FOR_LOG(is_transactional) << "\n "
        << "  " << EXPR_VALUE_FOR_LOG(is_pg_catalog_table) << "\n "
        << "  " << EXPR_VALUE_FOR_LOG(FLAGS_create_initial_sys_catalog_snapshot);
  }

  // If this is a transactional table and there is a associated tablespace, try to create a
  // local transaction status table for the tablespace if there is a placement attached to it
  // (and if it does not exist already).
  if (GetAtomicFlag(&FLAGS_auto_create_local_transaction_tables)) {
    if (is_transactional && orig_req->has_tablespace_id()5.66k) {
      const auto& tablespace_id = orig_req->tablespace_id();
      auto tablespace_pb = VERIFY_RESULT(GetTablespaceReplicationInfoWithRetry(tablespace_id));
      if (tablespace_pb) {
        RETURN_NOT_OK(CreateLocalTransactionStatusTableIfNeeded(rpc, tablespace_id));
      } else {
        VLOG(1)
            << "Not attempting to create a local transaction status table: "
            << "tablespace " << EXPR_VALUE_FOR_LOG(tablespace_id) << " has no placement\n";
      }
    } else {
        VLOG(1)
            << "Not attempting to create a local transaction status table:\n"
            << "  " << EXPR_VALUE_FOR_LOG(is_transactional) << "\n "
            << "  " << EXPR_VALUE_FOR_LOG(orig_req->has_tablespace_id());
    }
  }

  if (is_pg_catalog_table) {
    return CreateYsqlSysTable(orig_req, resp);
  }

  Status s;
  const char* const object_type = PROTO_PTR_IS_TABLE(orig_req) ? "table"7.24k : "index"1.20k;

  // Copy the request, so we can fill in some defaults.
  CreateTableRequestPB req = *orig_req;

  // Lookup the namespace and verify if it exists.
  TRACE("Looking up namespace");
  auto ns = VERIFY_RESULT8.44k(FindNamespace(req.namespace_()));8.44k
  bool colocated;
  NamespaceId namespace_id;
  NamespaceName namespace_name;
  {
    auto ns_lock = ns->LockForRead();
    if (ns->database_type() != GetDatabaseTypeForTable(req.table_type())) {
      Status s = STATUS(NotFound, "Namespace not found");
      return SetupError(resp->mutable_error(), MasterErrorPB::NAMESPACE_NOT_FOUND, s);
    }
    namespace_id = ns->id();
    namespace_name = ns->name();
    colocated = ns->colocated();
  }

  // For index table, find the table info
  scoped_refptr<TableInfo> indexed_table;
  if (IsIndex(req)) {
    TRACE("Looking up indexed table");
    indexed_table = GetTableInfo(req.indexed_table_id());
    if (indexed_table == nullptr) {
      return STATUS_SUBSTITUTE(
            NotFound, "The indexed table $0 does not exist", req.indexed_table_id());
    }

    TRACE("Locking indexed table");
    RETURN_NOT_OK(CheckIfTableDeletedOrNotVisibleToClient(indexed_table->LockForRead(), resp));
  }

  // Determine if this table should be colocated. If not specified, the table should be colocated if
  // and only if the namespace is colocated.
  if (!req.colocated()) {
    // Opt out of colocation if the request says so.
    colocated = false;
  } else if (indexed_table && !indexed_table->colocated()1.18k) {
    // Opt out of colocation if the indexed table opted out of colocation.
    colocated = false;
  }

  // TODO: If this is a colocated index table in a colocated database, convert any hash partition
  // columns into range partition columns. This is because postgres does not know that this index
  // table is in a colocated database. When we get to the "tablespaces" step where we store this
  // into PG metadata, then PG will know if db/table is colocated and do the work there.
  if ((colocated || req.has_tablegroup_id()8.38k) && IsIndex(req)203) {
    for (auto& col_pb : *req.mutable_schema()->mutable_columns()) {
      col_pb.set_is_hash_key(false);
    }
  }

  // Validate schema.
  Schema schema;
  RETURN_NOT_OK(SchemaFromPB(req.schema(), &schema));
  RETURN_NOT_OK(ValidateCreateTableSchema(schema, resp));

  // checking that referenced user-defined types (if any) exist.
  {
    SharedLock lock(mutex_);
    for (size_t i = 0; i < schema.num_columns(); i++22.6k) {
      for (const auto &udt_id : schema.column(i).type()->GetUserDefinedTypeIds()) {
        if (FindPtrOrNull(udtype_ids_map_, udt_id) == nullptr) {
          Status s = STATUS(InvalidArgument, "Referenced user-defined type not found");
          return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
        }
      }
    }
  }
  // TODO (ENG-1860) The referenced namespace and types retrieved/checked above could be deleted
  // some time between this point and table creation below.

  // Usually the column ids are available if it's called on the backup-restoring code path
  // (from CatalogManager::RecreateTable). Else the column ids must be empty in the client schema.
  if (!schema.has_column_ids()) {
    schema.InitColumnIdsByDefault();
  }

  if (schema.table_properties().HasCopartitionTableId()) {
    return CreateCopartitionedTable(req, resp, rpc, schema, ns);
  }

  if (colocated || req.has_tablegroup_id()8.38k) {
    // If the table is colocated, then there should be no hash partition columns.
    // Do the same for tables that are being placed in tablegroups.
    if (schema.num_hash_key_columns() > 0) {
      Status s = STATUS(InvalidArgument, "Cannot colocate hash partitioned table");
      return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
    }
  } else if (
      !req.partition_schema().has_hash_schema() && !req.partition_schema().has_range_schema()3.78k) {
    // If neither hash nor range schema have been specified by the protobuf request, we assume the
    // table uses a hash schema, and we use the table_type and hash_key to determine the hashing
    // scheme (redis or multi-column) that should be used.
    if (req.table_type() == REDIS_TABLE_TYPE) {
      req.mutable_partition_schema()->set_hash_schema(PartitionSchemaPB::REDIS_HASH_SCHEMA);
    } else if (schema.num_hash_key_columns() > 0) {
      req.mutable_partition_schema()->set_hash_schema(PartitionSchemaPB::MULTI_COLUMN_HASH_SCHEMA);
    } else {
      Status s = STATUS(InvalidArgument, "Unknown table type or partitioning method");
      return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
    }
  }

  // Verify that custom placement policy has not been specified for colocated table.
  const bool is_replication_info_set = IsReplicationInfoSet(req.replication_info());
  if (is_replication_info_set && colocated1) {
    Status s = STATUS(InvalidArgument, "Custom placement policy should not be set for "
      "colocated tables");
    return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_TABLE_REPLICATION_INFO, s);
  }

  if (is_replication_info_set && req.table_type() == PGSQL_TABLE_TYPE1) {
    const Status s = STATUS(InvalidArgument, "Cannot set placement policy for YSQL tables "
        "use Tablespaces instead");
    return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_REQUEST, s);
  }

  // Get placement info.
  const ReplicationInfoPB& replication_info = VERIFY_RESULT(
    GetTableReplicationInfo(req.replication_info(), req.tablespace_id()));
  const PlacementInfoPB& placement_info = replication_info.live_replicas();

  // Calculate number of tablets to be used. Priorities:
  //   1. Use Internally specified value from 'CreateTableRequestPB::num_tablets'.
  //   2. Use User specified value from
  //      'CreateTableRequestPB::SchemaPB::TablePropertiesPB::num_tablets'.
  //      Note, that the number will be saved in schema stored in the master persistent
  //      SysCatalog irrespective of which way we choose the number of tablets to create.
  //      If nothing is specified in this field, nothing will be stored in the table
  //      TablePropertiesPB for number of tablets
  //   3. Calculate own value.
  int num_tablets = 0;
  if (req.has_num_tablets()) {
    num_tablets = req.num_tablets(); // Internal request.
  }

  if (num_tablets <= 0 && schema.table_properties().HasNumTablets()1.74k) {
    num_tablets = schema.table_properties().num_tablets(); // User request.
  }

  if (num_tablets <= 0) {
    // Use default as client could have gotten the value before any tserver had heartbeated
    // to (a new) master leader.
    const auto num_live_tservers =
        GetNumLiveTServersForPlacement(placement_info.placement_uuid());
    num_tablets = narrow_cast<int>(
        num_live_tservers * (is_pg_table ? FLAGS_ysql_num_shards_per_tserver71
                                         : FLAGS_yb_num_shards_per_tserver528));
    LOG(INFO) << "Setting default tablets to " << num_tablets << " with "
              << num_live_tservers << " primary servers";
  }

  // Create partitions.
  PartitionSchema partition_schema;
  vector<Partition> partitions;
  if (colocated || req.has_tablegroup_id()8.38k) {
    RETURN_NOT_OK(partition_schema.CreatePartitions(1, &partitions));
    req.clear_partition_schema();
    num_tablets = 1;
  } else {
    RETURN_NOT_OK(PartitionSchema::FromPB(req.partition_schema(), schema, &partition_schema));
    if (req.partitions_size() > 0) {
      if (req.partitions_size() != num_tablets) {
        Status s = STATUS(InvalidArgument, "Partitions are not defined for all tablets");
        return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
      }
      string last;
      for (const auto& p : req.partitions()) {
        Partition np;
        Partition::FromPB(p, &np);
        if (np.partition_key_start() != last) {
          Status s = STATUS(InvalidArgument,
                            "Partitions does not cover the full partition keyspace");
          return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
        }
        last = np.partition_key_end();
        partitions.push_back(std::move(np));
      }
    } else {
      // Supplied number of partitions is merely a suggestion, actual number of
      // created partitions might differ.
      RETURN_NOT_OK(partition_schema.CreatePartitions(num_tablets, &partitions));
    }
    // The vector 'partitions' contains real setup partitions, so the variable
    // should be updated.
    num_tablets = narrow_cast<int>(partitions.size());
  }

  TSDescriptorVector all_ts_descs;
  master_->ts_manager()->GetAllLiveDescriptors(&all_ts_descs);
  RETURN_NOT_OK(CheckNumReplicas(placement_info, all_ts_descs, partitions, resp));

  if (!FLAGS_TEST_skip_placement_validation_createtable_api) {
    ValidateReplicationInfoRequestPB validate_req;
    validate_req.mutable_replication_info()->CopyFrom(replication_info);
    ValidateReplicationInfoResponsePB validate_resp;
    RETURN_NOT_OK(ValidateReplicationInfo(&validate_req, &validate_resp));
  }

  LOG(INFO) << "Set number of tablets: " << num_tablets;
  req.set_num_tablets(num_tablets);

  // For index table, populate the index info.
  IndexInfoPB index_info;

  const bool index_backfill_enabled =
      IsIndexBackfillEnabled(orig_req->table_type(), is_transactional);
  if (req.has_index_info()) {
    // Current message format.
    index_info.CopyFrom(req.index_info());

    // Assign column-ids that have just been computed and assigned to "index_info".
    if (!is_pg_table) {
      DCHECK_EQ(index_info.columns().size(), schema.num_columns())
        << "Number of columns are not the same between index_info and index_schema";
      for (size_t colidx = 0; colidx < schema.num_columns(); colidx++1.73k) {
        index_info.mutable_columns(narrow_cast<int>(colidx))->set_column_id(
            schema.column_id(colidx));
      }
    }
  } else if (req.has_indexed_table_id()) {
    // Old client message format when rolling upgrade (Not having "index_info").
    IndexInfoBuilder index_info_builder(&index_info);
    index_info_builder.ApplyProperties(req.indexed_table_id(),
        req.is_local_index(), req.is_unique_index());
    if (orig_req->table_type() != PGSQL_TABLE_TYPE) {
      Schema indexed_schema;
      RETURN_NOT_OK(indexed_table->GetSchema(&indexed_schema));
      RETURN_NOT_OK(index_info_builder.ApplyColumnMapping(indexed_schema, schema));
    }
  }

  if ((req.has_index_info() || req.has_indexed_table_id()7.24k) &&
      index_backfill_enabled1.20k &&
      !req.skip_index_backfill()1.12k) {
    // Start off the index table with major compactions disabled. We need this to retain the delete
    // markers until the backfill process is completed.  No need to set index_permissions in the
    // index table.
    schema.SetRetainDeleteMarkers(true);
  }

  LOG(INFO) << "CreateTable with IndexInfo " << AsString(index_info);

  scoped_refptr<TableInfo> table;
  TabletInfos tablets;
  bool tablets_exist;
  bool tablegroup_tablets_exist = false;

  {
    LockGuard lock(mutex_);
    auto ns_lock = ns->LockForRead();
    TRACE("Acquired catalog manager lock");

    tablets_exist =
        colocated && colocated_tablet_ids_map_.find(ns->id()) != colocated_tablet_ids_map_.end()57;
    // Verify that the table does not exist.
    table = FindPtrOrNull(table_names_map_, {namespace_id, req.name()});

    if (table != nullptr) {
      s = STATUS_SUBSTITUTE(AlreadyPresent,
              "Object '$0.$1' already exists", ns->name(), table->name());
      LOG(WARNING) << "Found table: " << table->ToStringWithState()
                   << ". Failed creating table with error: "
                   << s.ToString() << " Request:\n" << orig_req->DebugString();
      // If the table already exists, we set the response table_id field to the id of the table that
      // already exists. This is necessary because before we return the error to the client (or
      // success in case of a "CREATE TABLE IF NOT EXISTS" request) we want to wait for the existing
      // table to be available to receive requests. And we need the table id for that.
      resp->set_table_id(table->id());
      return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_ALREADY_PRESENT, s);
    }

    // Namespace state validity check:
    // 1. Allow Namespaces that are RUNNING
    // 2. Allow Namespaces that are PREPARING under 2 situations
    //    2a. System Namespaces.
    //    2b. The parent table from a Colocated Namespace.
    const auto parent_table_name = ns->id() + kColocatedParentTableNameSuffix;
    bool valid_ns_state = (ns->state() == SysNamespaceEntryPB::RUNNING) ||
      (18ns->state() == SysNamespaceEntryPB::PREPARING18 &&
        (ns->name() == kSystemNamespaceName || req.name() == parent_table_name));
    if (!valid_ns_state) {
      Status s = STATUS_SUBSTITUTE(TryAgain, "Invalid Namespace State ($0). Cannot create $1.$2",
          SysNamespaceEntryPB::State_Name(ns->state()), ns->name(), req.name());
      return SetupError(resp->mutable_error(), NamespaceMasterError(ns->state()), s);
    }

    // Check whether this CREATE TABLE request which has a tablegroup_id is for a normal user table
    // or the request to create the parent table for the tablegroup. This is done by checking the
    // catalog manager maps.
    if (req.has_tablegroup_id() &&
        tablegroup_tablet_ids_map_.find(ns->id()) != tablegroup_tablet_ids_map_.end()143 &&
        tablegroup_tablet_ids_map_[ns->id()].find(req.tablegroup_id()) !=
        tablegroup_tablet_ids_map_[ns->id()].end()) {
      tablegroup_tablets_exist = true;
    }

    // Generate colocation ID in advance in order to fail before CreateTableInMemory is called.
    ColocationId colocation_id = kColocationIdNotSet;
    if (req.has_tablegroup_id() && tablegroup_tablets_exist143) {
      auto tablegroup = tablegroup_ids_map_[req.tablegroup_id()];

      colocation_id = VERIFY_RESULT87(
          ConceiveColocationId(req, resp, [tablegroup](auto colocation_id) {
            return tablegroup->HasChildTable(colocation_id);
          }));
    } else if (colocated && tablets_exist57) {
      auto tablet = colocated_tablet_ids_map_[ns->id()];
      auto tablet_lock = tablet->LockForWrite();

      std::set<ColocationId> colocation_ids;
      if (!req.has_colocation_id()) {
        for (const TableId& table_id : tablet_lock.data().pb.table_ids()) {
          DCHECK(!table_id.empty());
          const auto colocated_table_info = GetTableInfoUnlocked(table_id);
          if (!colocated_table_info) {
            // Needed because of #11129, should be replaced with DCHECK after the fix.
            continue;
          }
          Schema colocated_table_schema;
          RETURN_NOT_OK(colocated_table_info->GetSchema(&colocated_table_schema));
          colocation_ids.insert(colocated_table_schema.colocation_id());
        }
      }

      colocation_id = VERIFY_RESULT(
          ConceiveColocationId(req, resp, [&colocation_ids](auto colocation_id) {
            return ContainsKey(colocation_ids, colocation_id);
          }));
    }

    RETURN_NOT_OK(CreateTableInMemory(
        req, schema, partition_schema, namespace_id, namespace_name, partitions, &index_info,
        (!tablets_exist && !tablegroup_tablets_exist) ? &tablets : nullptr, resp, &table));

    // Section is executed when a table is either the parent table or a user table in a tablegroup.
    // It additionally sets the table metadata (and tablet metadata if this is the parent table)
    // to have the colocated property so we can take advantage of code reuse.
    if (req.has_tablegroup_id()) {
      table->mutable_metadata()->mutable_dirty()->pb.set_colocated(true);
      if (tablegroup_tablets_exist) {
        // If the table is not a tablegroup parent table, it performs a lookup for the proper tablet
        // to place the table on as a child table.
        auto tablet = tablegroup_tablet_ids_map_[ns->id()][req.tablegroup_id()];
        RSTATUS_DCHECK(
            tablet->colocated(), InternalError,
            "The tablet for tablegroup should be colocated.");
        tablets.push_back(tablet.get());
        auto tablet_lock = tablet->LockForWrite();
        tablet_lock.mutable_data()->pb.add_table_ids(table->id());
        RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), tablet));
        tablet_lock.Commit();

        auto tablegroup = tablegroup_ids_map_[req.tablegroup_id()];

        CHECK(colocation_id != kColocationIdNotSet);
        table->mutable_metadata()->mutable_dirty()->
            pb.mutable_schema()->mutable_colocated_table_id()->set_colocation_id(colocation_id);

        tablet->mutable_metadata()->StartMutation();
        table->AddTablet(tablet);
        tablegroup->AddChildTable(table->id(), colocation_id);

        table_tablegroup_ids_map_[table->id()] = tablegroup->id();
      } else {
        // If the table is a tablegroup parent table, it creates a dummy tablet for the tablegroup
        // along with updating the catalog manager maps.
        RSTATUS_DCHECK_EQ(
            tablets.size(), 1U, InternalError,
            "Only one tablet should be created for each tablegroup");
        tablets[0]->mutable_metadata()->mutable_dirty()->pb.set_colocated(true);
        // Update catalog manager maps for tablegroups
        tablegroup_tablet_ids_map_[ns->id()][req.tablegroup_id()] =
            tablet_map_->find(tablets[0]->id())->second;
      }
    } else if (colocated) {
      table->mutable_metadata()->mutable_dirty()->pb.set_colocated(true);
      // if the tablet already exists, add the tablet to tablets
      if (tablets_exist) {
        auto tablet = colocated_tablet_ids_map_[ns->id()];
        RSTATUS_DCHECK(
            tablet->colocated(), InternalError,
            "The tablet for colocated database should be colocated.");
        tablets.push_back(tablet.get());

        auto tablet_lock = tablet->LockForWrite();

        tablet_lock.mutable_data()->pb.add_table_ids(table->id());
        RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), tablet));
        tablet_lock.Commit();

        CHECK(colocation_id != kColocationIdNotSet);
        table->mutable_metadata()->mutable_dirty()->
            pb.mutable_schema()->mutable_colocated_table_id()->set_colocation_id(colocation_id);

        tablet->mutable_metadata()->StartMutation();
        table->AddTablet(tablet);
      } else {  // Record the tablet
        RSTATUS_DCHECK_EQ(
            tablets.size(), 1U, InternalError,
            "Only one tablet should be created for each colocated database");
        tablets[0]->mutable_metadata()->mutable_dirty()->pb.set_colocated(true);
        colocated_tablet_ids_map_[ns->id()] = tablet_map_->find(tablets[0]->id())->second;
      }
    }
    if (req.has_matview_pg_table_id()) {
      matview_pg_table_ids_map_[req.table_id()] = req.matview_pg_table_id();
    }
  }

  // For create transaction table requests with tablespace id, save the tablespace id.
  const auto is_transaction_status_table =
      orig_req->table_type() == TableType::TRANSACTION_STATUS_TABLE_TYPE;
  if (is_transaction_status_table && req.has_tablespace_id()1.09k) {
    table->mutable_metadata()->mutable_dirty()->pb.set_transaction_table_tablespace_id(
        req.tablespace_id());
  }

  // Tables with a transaction should be rolled back if the transaction does not get committed.
  // Store this on the table persistent state until the transaction has been a verified success.
  TransactionMetadata txn;
  if (req.has_transaction() && FLAGS_enable_transactional_ddl_gc4.72k) {
    table->mutable_metadata()->mutable_dirty()->pb.mutable_transaction()->
        CopyFrom(req.transaction());
    txn = VERIFY_RESULT(TransactionMetadata::FromPB(req.transaction()));
    RSTATUS_DCHECK(!txn.status_tablet.empty(), Corruption, "Given incomplete Transaction");
  }

  if (PREDICT_FALSE(FLAGS_TEST_simulate_slow_table_create_secs > 0) &&
      req.table_type() != TableType::TRANSACTION_STATUS_TABLE_TYPE19) {
    LOG(INFO) << "Simulating slow table creation";
    SleepFor(MonoDelta::FromSeconds(FLAGS_TEST_simulate_slow_table_create_secs));
  }

  // NOTE: the table and tablets are already locked for write at this point,
  // since the CreateTableInfo/CreateTabletInfo functions leave them in that state.
  // They will get committed at the end of this function.
  // Sanity check: the tables and tablets should all be in "preparing" state.
  CHECK_EQ(SysTablesEntryPB::PREPARING, table->metadata().dirty().pb.state());
  // Update the on-disk table state to "running".
  table->mutable_metadata()->mutable_dirty()->pb.set_state(SysTablesEntryPB::RUNNING);
  TRACE("Inserted new table and tablet info into CatalogManager maps");
  VLOG_WITH_PREFIX0(1) << "Inserted new table and tablet info into CatalogManager maps"0;

  if (!tablets_exist && !tablegroup_tablets_exist8.38k) {
    // Write Tablets to sys-tablets (in "preparing" state).
    for (const auto& tablet : tablets) {
      CHECK_EQ(SysTabletsEntryPB::PREPARING, tablet->metadata().dirty().pb.state());
    }
  }

  s = sys_catalog_->Upsert(leader_ready_term(), table, tablets);
  if (PREDICT_FALSE(!s.ok())) {
    return AbortTableCreation(
        table.get(), tablets, s.CloneAndPrepend("An error occurred while inserting to sys-tablets"),
        resp);
  }
  TRACE("Wrote table and tablets to system table");

  // For index table, insert index info in the indexed table.
  if ((req.has_index_info() || req.has_indexed_table_id()7.22k)) {
    if (index_backfill_enabled && !req.skip_index_backfill()1.12k) {
      if (is_pg_table) {
        // YSQL: start at some permission before backfill.  The real enforcement happens with
        // pg_index system table's indislive and indisready columns.  Choose WRITE_AND_DELETE
        // because it will probably be less confusing.
        index_info.set_index_permissions(INDEX_PERM_WRITE_AND_DELETE);
      } else {
        // YCQL
        index_info.set_index_permissions(INDEX_PERM_DELETE_ONLY);
      }
    }
    s = AddIndexInfoToTable(indexed_table, index_info, resp);
    if (PREDICT_FALSE(!s.ok())) {
      return AbortTableCreation(
          table.get(), tablets, s.CloneAndPrepend("An error occurred while inserting index info"),
          resp);
    }
  }

  // Commit the in-memory state.
  table->mutable_metadata()->CommitMutation();

  for (const auto& tablet : tablets) {
    tablet->mutable_metadata()->CommitMutation();
  }

  if ((colocated && tablets_exist57) || (8.36kreq.has_tablegroup_id()8.36k && tablegroup_tablets_exist141)) {
    auto call =
        std::make_shared<AsyncAddTableToTablet>(master_, AsyncTaskPool(), tablets[0], table);
    table->AddTask(call);
    WARN_NOT_OK(ScheduleTask(call), "Failed to send AddTableToTablet request");
  }

  if (req.has_creator_role_name()) {
    const NamespaceName& keyspace_name = req.namespace_().name();
    const TableName& table_name = req.name();
    RETURN_NOT_OK(permissions_manager_->GrantPermissions(
        req.creator_role_name(),
        get_canonical_table(keyspace_name, table_name),
        table_name,
        keyspace_name,
        all_permissions_for_resource(ResourceType::TABLE),
        ResourceType::TABLE,
        resp));
  }

  // Verify Transaction gets committed, which occurs after table create finishes.
  if (req.has_transaction() && PREDICT_TRUE4.71k(FLAGS_enable_transactional_ddl_gc)) {
    LOG(INFO) << "Enqueuing table for Transaction Verification: " << req.name();
    std::function<Status(bool)> when_done =
        std::bind(&CatalogManager::VerifyTablePgLayer, this, table, _1);
    WARN_NOT_OK(background_tasks_thread_pool_->SubmitFunc(
        std::bind(&YsqlTransactionDdl::VerifyTransaction, ysql_transaction_.get(), txn, when_done)),
        "Could not submit VerifyTransaction to thread pool");
  }

  LOG(INFO) << "Successfully created " << object_type << " " << table->ToString() << " in "
            << ns->ToString() << " per request from " << RequestorString(rpc);
  background_tasks_->Wake();

  if (FLAGS_master_enable_metrics_snapshotter &&
      !(2req.table_type() == TableType::YQL_TABLE_TYPE2 &&
        namespace_id == kSystemNamespaceId1 &&
        req.name() == kMetricsSnapshotsTableName1)) {
    Status s = CreateMetricsSnapshotsTableIfNeeded(rpc);
    if (!s.ok()) {
      return s.CloneAndPrepend("Error while creating metrics snapshots table");
    }
  }

  // Increment transaction status version if needed.
  if (is_transaction_status_table) {
    RETURN_NOT_OK(IncrementTransactionTablesVersion());
  }

  DVLOG(3) << __PRETTY_FUNCTION__ << " Done."16;
  return Status::OK();
}

Status CatalogManager::VerifyTablePgLayer(scoped_refptr<TableInfo> table, bool rpc_success) {
  // Upon Transaction completion, check pg system table using OID to ensure SUCCESS.
  const uint32_t database_oid = VERIFY_RESULT(GetPgsqlDatabaseOidByTableId(table->id()));
  const auto pg_table_id = GetPgsqlTableId(database_oid, kPgClassTableOid);
  auto table_storage_id = GetPgsqlTableOid(table->id());
  {
    SharedLock lock(mutex_);
    if (matview_pg_table_ids_map_.find(table->id()) != matview_pg_table_ids_map_.end()) {
      table_storage_id = GetPgsqlTableOid(matview_pg_table_ids_map_[table->id()]);
    }
  }
  auto entry_exists = VERIFY_RESULT(
      ysql_transaction_->PgEntryExists(pg_table_id, table_storage_id));
  auto l = table->LockForWrite();
  auto& metadata = table->mutable_metadata()->mutable_dirty()->pb;

  SCHECK(metadata.state() == SysTablesEntryPB::RUNNING ||
         metadata.state() == SysTablesEntryPB::ALTERING, Aborted,
         Substitute("Unexpected table state ($0), abandoning transaction GC work for $1",
                    SysTablesEntryPB_State_Name(metadata.state()), table->ToString()));

  // #5981: Mark un-retryable rpc failures as pass to avoid infinite retry of GC'd txns.
  const bool txn_check_passed = entry_exists || !rpc_success63;

  if (txn_check_passed) {
    // Remove the transaction from the entry since we're done processing it.
    metadata.clear_transaction();
    RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), table));
    if (4.61kentry_exists4.61k) {
      LOG_WITH_PREFIX(INFO) << "Table transaction succeeded: " << table->ToString();
    } else {
      LOG_WITH_PREFIX(WARNING)
          << "Unknown RPC failure, removing transaction on table: " << table->ToString();
    }
    // Commit the in-memory state.
    l.Commit();
  } else {
    LOG(INFO) << "Table transaction failed, deleting: " << table->ToString();
    // Async enqueue delete.
    DeleteTableRequestPB del_tbl_req;
    del_tbl_req.mutable_table()->set_table_name(table->name());
    del_tbl_req.mutable_table()->set_table_id(table->id());
    del_tbl_req.set_is_index_table(table->is_index());

    RETURN_NOT_OK(background_tasks_thread_pool_->SubmitFunc( [this, del_tbl_req]() {
      DeleteTableResponsePB del_tbl_resp;
      WARN_NOT_OK(DeleteTable(&del_tbl_req, &del_tbl_resp, nullptr),
          "Failed to Delete Table with failed transaction");
    }));
  }
  return Status::OK();
}

Result<TabletInfos> CatalogManager::CreateTabletsFromTable(const vector<Partition>& partitions,
                                                           const TableInfoPtr& table) {
  TabletInfos tablets;
  // Create the TabletInfo objects in state PREPARING.
  for (const Partition& partition : partitions) {
    PartitionPB partition_pb;
    partition.ToPB(&partition_pb);
    tablets.push_back(CreateTabletInfo(table.get(), partition_pb));
  }

  // Add the table/tablets to the in-memory map for the assignment.
  table->AddTablets(tablets);
  auto tablet_map_checkout = tablet_map_.CheckOut();
  for (const TabletInfoPtr& tablet : tablets) {
    InsertOrDie(tablet_map_checkout.get_ptr(), tablet->tablet_id(), tablet);
  }

  return tablets;
}

Status CatalogManager::CheckValidPlacementInfo(const PlacementInfoPB& placement_info,
                                               const TSDescriptorVector& ts_descs,
                                               ValidateReplicationInfoResponsePB* resp) {
  size_t num_live_tservers = ts_descs.size();
  size_t num_replicas = GetNumReplicasFromPlacementInfo(placement_info);
  Status s;
  string msg;

  // Verify that the number of replicas isn't larger than the required number of live tservers.
  // To ensure quorum, we need n/2 + 1 live tservers.
  size_t replica_quorum_needed = num_replicas / 2 + 1;
  if (FLAGS_catalog_manager_check_ts_count_for_create_table &&
      replica_quorum_needed > num_live_tservers56.5k) {
    msg = Substitute("Not enough live tablet servers to create table with replication factor $0. "
                     "Need at least $1 tablet servers whereas $2 are alive.",
                     num_replicas, replica_quorum_needed, num_live_tservers);
    LOG(WARNING) << msg
                 << ". Placement info: " << placement_info.ShortDebugString()
                 << ", replication factor flag: " << FLAGS_replication_factor;
    s = STATUS(InvalidArgument, msg);
    return SetupError(resp->mutable_error(), MasterErrorPB::REPLICATION_FACTOR_TOO_HIGH, s);
  }

  // Verify that placement requests are reasonable.
  if (!placement_info.placement_blocks().empty()) {
    size_t minimum_sum = 0;
    for (const auto& pb : placement_info.placement_blocks()) {
      minimum_sum += pb.min_num_replicas();
      if (!pb.has_cloud_info()) {
        msg = Substitute("Got placement info without cloud info set: $0", pb.ShortDebugString());
        s = STATUS(InvalidArgument, msg);
        LOG(WARNING) << msg;
        return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
      }
    }
    // Total replicas requested should be at least the sum of minimums
    // requested in individual placement blocks.
    if (minimum_sum > num_replicas) {
      msg = Substitute("Sum of minimum replicas per placement ($0) is greater than num_replicas "
                       " ($1)", minimum_sum, num_replicas);
      s = STATUS(InvalidArgument, msg);
      LOG(WARNING) << msg;
      return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
    }

    // Verify that there are enough TServers in the requested placements
    // to match the total required replication factor.
    auto allowed_ts = VERIFY_RESULT(FindTServersForPlacementInfo(placement_info, ts_descs));

    // Fail if we don't have enough tablet servers in the areas requested.
    // We need n/2 + 1 for quorum.
    if (allowed_ts.size() < replica_quorum_needed) {
      msg = Substitute("Not enough tablet servers in the requested placements. "
                        "Need at least $0, have $1",
                        replica_quorum_needed, allowed_ts.size());
      s = STATUS(InvalidArgument, msg);
      LOG(WARNING) << msg;
      return SetupError(resp->mutable_error(), MasterErrorPB::REPLICATION_FACTOR_TOO_HIGH, s);
    }

    // Try allocating tservers for the replicas and see if we can place a quorum
    // number of replicas.
    // Essentially, the logic is:
    // 1. We satisfy whatever we can from the minimums.
    // 2. We then satisfy whatever we can from the slack.
    //    Here it doesn't whether where we put the slack replicas as long as
    //    the tservers are chosen from any of the valid placement blocks.
    // Overall, if in this process we are able to place n/2 + 1 replicas
    // then we succeed otherwise we fail.
    size_t total_extra_replicas = num_replicas - minimum_sum;
    size_t total_feasible_replicas = 0;
    size_t total_extra_servers = 0;
    for (const auto& pb : placement_info.placement_blocks()) {
      auto allowed_ts = VERIFY_RESULT(FindTServersForPlacementBlock(pb, ts_descs));
      size_t allowed_ts_size = allowed_ts.size();
      size_t min_num_replicas = pb.min_num_replicas();
      // For every placement block, we can only satisfy upto the number of
      // tservers present in that particular placement block.
      total_feasible_replicas += min(allowed_ts_size, min_num_replicas);
      // Extra tablet servers beyond min_num_replicas will be used to place
      // the extra replicas over and above the minimums.
      if (allowed_ts_size > min_num_replicas) {
        total_extra_servers += allowed_ts_size - min_num_replicas;
      }
    }
    // The total number of extra replicas that we can put cannot be more than
    // the total tablet servers that are extra.
    total_feasible_replicas += min(total_extra_replicas, total_extra_servers);

    // If we place the replicas in accordance with above, we should be able to place
    // at least replica_quorum_needed otherwise we fail.
    if (total_feasible_replicas < replica_quorum_needed) {
      msg = Substitute("Not enough tablet servers in the requested placements. "
                        "Can only find $0 tablet servers for the replicas but need at least "
                        "$1.", total_feasible_replicas, replica_quorum_needed);
      s = STATUS(InvalidArgument, msg);
      LOG(WARNING) << msg;
      return SetupError(resp->mutable_error(), MasterErrorPB::REPLICATION_FACTOR_TOO_HIGH, s);
    }
  }

  return Status::OK();
}

Status CatalogManager::CreateTableInMemory(const CreateTableRequestPB& req,
                                           const Schema& schema,
                                           const PartitionSchema& partition_schema,
                                           const NamespaceId& namespace_id,
                                           const NamespaceName& namespace_name,
                                           const std::vector<Partition>& partitions,
                                           IndexInfoPB* index_info,
                                           TabletInfos* tablets,
                                           CreateTableResponsePB* resp,
                                           scoped_refptr<TableInfo>* table) {
  // Add the new table in "preparing" state.
  *table = CreateTableInfo(req, schema, partition_schema, namespace_id, namespace_name, index_info);
  const TableId& table_id = (*table)->id();

  VLOG_WITH_PREFIX_AND_FUNC0(2)
      << "Table: " << (**table).ToString() << ", create_tablets: " << (tablets ? "YES" : "NO");

  auto table_ids_map_checkout = table_ids_map_.CheckOut();
  (*table_ids_map_checkout)[table_id] = *table;
  // Do not add Postgres tables to the name map as the table name is not unique in a namespace.
  if (req.table_type() != PGSQL_TABLE_TYPE) {
    table_names_map_[{namespace_id, req.name()}] = *table;
  }

  if (req.table_type() == TRANSACTION_STATUS_TABLE_TYPE) {
    transaction_table_ids_set_.insert(table_id);
  }

  if (tablets) {
    *tablets = VERIFY_RESULT(CreateTabletsFromTable(partitions, *table));
  }

  if (resp != nullptr) {
    resp->set_table_id(table_id);
  }

  HandleNewTableId(table_id);

  return Status::OK();
}

Result<bool> CatalogManager::TableExists(
    const std::string& namespace_name, const std::string& table_name) const {
  TableIdentifierPB table_id_pb;
  table_id_pb.set_table_name(table_name);
  table_id_pb.mutable_namespace_()->set_name(namespace_name);
  return DoesTableExist(FindTable(table_id_pb));
}

CHECKED_STATUS CatalogManager::CreateTransactionStatusTable(
    const CreateTransactionStatusTableRequestPB* req, CreateTransactionStatusTableResponsePB* resp,
    rpc::RpcContext *rpc) {
  const string& table_name = req->table_name();
  Status s = CreateTransactionStatusTableInternal(rpc, table_name, nullptr /* tablespace_id */);
  if (s.IsAlreadyPresent()) {
    return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_ALREADY_PRESENT, s);
  }
  if (!s.ok()) {
    return SetupError(resp->mutable_error(), MasterErrorPB::INTERNAL_ERROR, s);
  }
  return Status::OK();
}

CHECKED_STATUS CatalogManager::CreateTransactionStatusTableInternal(
    rpc::RpcContext *rpc, const string& table_name, const TablespaceId* tablespace_id) {
  if (VERIFY_RESULT(TableExists(kSystemNamespaceName, table_name))) {
    return STATUS_SUBSTITUTE(AlreadyPresent, "Table already exists: $0", table_name);
  }

  LOG(INFO) << "Creating transaction status table " << table_name;
  // Set up a CreateTable request internally.
  CreateTableRequestPB req;
  CreateTableResponsePB resp;
  req.set_name(table_name);
  req.mutable_namespace_()->set_name(kSystemNamespaceName);
  req.set_table_type(TableType::TRANSACTION_STATUS_TABLE_TYPE);
  if (tablespace_id) {
    req.set_tablespace_id(*tablespace_id);
  }

  // Explicitly set the number tablets if the corresponding flag is set, otherwise CreateTable
  // will use the same defaults as for regular tables.
  int num_tablets;
  if (FLAGS_transaction_table_num_tablets > 0) {
    num_tablets = FLAGS_transaction_table_num_tablets;
  } else {
    auto placement_uuid =
        ClusterConfig()->LockForRead()->pb.replication_info().live_replicas().placement_uuid();
    num_tablets = narrow_cast<int>(GetNumLiveTServersForPlacement(placement_uuid) *
                                   FLAGS_transaction_table_num_tablets_per_tserver);
  }
  req.mutable_schema()->mutable_table_properties()->set_num_tablets(num_tablets);

  ColumnSchema hash(kRedisKeyColumnName, BINARY, /* is_nullable */ false, /* is_hash_key */ true);
  ColumnSchemaToPB(hash, req.mutable_schema()->mutable_columns()->Add());

  Status s = CreateTable(&req, &resp, rpc);
  // We do not lock here so it is technically possible that the table was already created.
  // If so, there is nothing to do so we just ignore the "AlreadyPresent" error.
  if (!s.ok() && !s.IsAlreadyPresent()8) {
    return s;
  }

  return Status::OK();
}

bool CatalogManager::DoesTransactionTableExistForTablespace(const TablespaceId& tablespace_id) {
  SharedLock lock(mutex_);
  for (const auto& table_id : transaction_table_ids_set_) {
    auto table = table_ids_map_->find(table_id);
    if (table == table_ids_map_->end()) {
      LOG(DFATAL) << "Table uuid " << table_id
                  << " in transaction_table_ids_set_ but not in table_ids_map_";
      continue;
    }
    auto this_tablespace_id = GetTransactionStatusTableTablespace(table->second);
    if (this_tablespace_id && *this_tablespace_id == tablespace_id467) {
      return true;
    }
  }
  return false;
}

CHECKED_STATUS CatalogManager::CreateLocalTransactionStatusTableIfNeeded(
    rpc::RpcContext *rpc, const TablespaceId& tablespace_id) {
  std::lock_guard<std::mutex> lock(tablespace_transaction_table_creation_mutex_);

  if (DoesTransactionTableExistForTablespace(tablespace_id)) {
    VLOG(1) << "Transaction status table already exists, not creating."0;
    return Status::OK();
  }

  std::string table_name;
  if (FLAGS_TEST_name_transaction_tables_with_tablespace_id) {
    uint32_t tablespace_oid = VERIFY_RESULT(GetPgsqlTablespaceOid(tablespace_id));
    table_name = kTransactionTablePrefix + std::to_string(tablespace_oid);
  } else {
    std::string uuid;
    RETURN_NOT_OK(yb::Uuid::Generate().ToString(&uuid));
    table_name = kTransactionTablePrefix + uuid;
  }

  return CreateTransactionStatusTableInternal(rpc, table_name, &tablespace_id);
}

CHECKED_STATUS CatalogManager::CreateGlobalTransactionStatusTableIfNeeded(rpc::RpcContext *rpc) {
  Status s = CreateTransactionStatusTableInternal(
      rpc, kGlobalTransactionsTableName, nullptr /* tablespace_id */);
  if (s.IsAlreadyPresent()) {
    VLOG(1) << "Transaction status table already exists, not creating."0;
    return Status::OK();
  }
  return s;
}

Result<TableInfoPtr> CatalogManager::GetGlobalTransactionStatusTable() {
  TableIdentifierPB global_txn_table_identifier;
  global_txn_table_identifier.set_table_name(kGlobalTransactionsTableName);
  global_txn_table_identifier.mutable_namespace_()->set_name(kSystemNamespaceName);
  return FindTable(global_txn_table_identifier);
}

CHECKED_STATUS CatalogManager::GetGlobalTransactionStatusTablets(
    GetTransactionStatusTabletsResponsePB* resp) {
  auto global_txn_table = VERIFY_RESULT(GetGlobalTransactionStatusTable());

  auto l = global_txn_table->LockForRead();
  RETURN_NOT_OK(CheckIfTableDeletedOrNotVisibleToClient(l, resp));

  for (const auto& tablet : global_txn_table->GetTablets())3.25k {
    TabletLocationsPB locs_pb;
    RETURN_NOT_OK(BuildLocationsForTablet(tablet, &locs_pb));
    resp->add_global_tablet_id(tablet->tablet_id());
  }

  return Status::OK();
}

Result<std::vector<TableInfoPtr>> CatalogManager::GetPlacementLocalTransactionStatusTables(
    const CloudInfoPB& placement) {
  std::vector<TableInfoPtr> same_placement_transaction_tables;
  auto tablespace_manager = GetTablespaceManager();

  SharedLock lock(mutex_);
  for (const auto& table_id : transaction_table_ids_set_) {
    auto table = table_ids_map_->find(table_id);
    if (table == table_ids_map_->end()) {
      LOG(DFATAL) << "Table uuid " << table_id
                  << " in transaction_table_ids_set_ but not in table_ids_map_";
      continue;
    }
    // system.transaction is filtered out because it cannot have a placement set.
    auto table_info = table->second;
    auto lock = table_info->LockForRead();
    auto tablespace_id = GetTransactionStatusTableTablespace(table_info);
    auto cloud_info = lock->pb.replication_info();
    if (!IsReplicationInfoSet(cloud_info)3.75k) {
      if (tablespace_id) {
        const auto result = tablespace_manager->GetTablespaceReplicationInfo(*tablespace_id);
        if (!result.ok() || !*result185 || !IsReplicationInfoSet(**result)185) {
          continue;
        }
        cloud_info = **result;
      }
    }
    const auto& txn_table_replicas = cloud_info.live_replicas();
    // Skip transaction tables spanning multiple regions, since using them will incur global
    // latencies. See #11268.
    if (CatalogManagerUtil::DoesPlacementInfoSpanMultipleRegions(txn_table_replicas)) {
      continue;
    }
    if (CatalogManagerUtil::DoesPlacementInfoContainCloudInfo(txn_table_replicas, placement)) {
      same_placement_transaction_tables.push_back(table_info);
    }
  }

  return same_placement_transaction_tables;
}

CHECKED_STATUS CatalogManager::GetPlacementLocalTransactionStatusTablets(
    const std::vector<TableInfoPtr>& placement_local_tables,
    GetTransactionStatusTabletsResponsePB* resp) {
  if (placement_local_tables.empty()) {
    return Status::OK();
  }

  SharedLock lock(mutex_);
  for (const auto& table_info : placement_local_tables) {
    auto lock = table_info->LockForRead();
    for (const auto& tablet : table_info->GetTablets()) {
      TabletLocationsPB locs_pb;
      RETURN_NOT_OK(BuildLocationsForTablet(tablet, &locs_pb));
      resp->add_placement_local_tablet_id(tablet->tablet_id());
    }
  }

  return Status::OK();
}

CHECKED_STATUS CatalogManager::GetTransactionStatusTablets(
    const GetTransactionStatusTabletsRequestPB* req,
    GetTransactionStatusTabletsResponsePB* resp,
    rpc::RpcContext *rpc) {
  for (;;) {
    SCOPED_LEADER_SHARED_LOCK(lock, this);
    auto global_txn_table = VERIFY_RESULT(GetGlobalTransactionStatusTable());
    if (!VERIFY_RESULT(IsCreateTableDone(global_txn_table))) {
      lock.Unlock();
      RETURN_NOT_OK(WaitForCreateTableToFinish(global_txn_table->id(), rpc->GetClientDeadline()));
      continue;
    }

    std::vector<TableInfoPtr> local_tables;
    if (req->has_placement()) {
      local_tables = VERIFY_RESULT(GetPlacementLocalTransactionStatusTables(req->placement()));
      bool need_restart = false;
      for (const auto& table : local_tables) {
        if (!VERIFY_RESULT(IsCreateTableDone(table))) {
          if (!need_restart) {
            need_restart = true;
            lock.Unlock();
          }
          RETURN_NOT_OK(WaitForCreateTableToFinish(table->id(), rpc->GetClientDeadline()));
        }
      }
      if (need_restart) {
        continue;
      }
    }

    RETURN_NOT_OK(GetGlobalTransactionStatusTablets(resp));
    RETURN_NOT_OK(GetPlacementLocalTransactionStatusTablets(local_tables, resp));

    return Status::OK();
  }
}

Status CatalogManager::CreateMetricsSnapshotsTableIfNeeded(rpc::RpcContext *rpc) {
  if (VERIFY_RESULT(TableExists(kSystemNamespaceName, kMetricsSnapshotsTableName))) {
    return Status::OK();
  }

  // Set up a CreateTable request internally.
  CreateTableRequestPB req;
  CreateTableResponsePB resp;
  req.set_name(kMetricsSnapshotsTableName);
  req.mutable_namespace_()->set_name(kSystemNamespaceName);
  req.set_table_type(TableType::YQL_TABLE_TYPE);

  // Explicitly set the number tablets if the corresponding flag is set, otherwise CreateTable
  // will use the same defaults as for regular tables.
  if (FLAGS_metrics_snapshots_table_num_tablets > 0) {
    req.mutable_schema()->mutable_table_properties()->set_num_tablets(
        FLAGS_metrics_snapshots_table_num_tablets);
  }

  // Schema description: "node" refers to tserver uuid. "entity_type" can be either
  // "tserver" or "table". "entity_id" is uuid of corresponding tserver or table.
  // "metric" is the name of the metric and "value" is its val. "ts" is time at
  // which the snapshot was recorded. "details" is a json column for future extensibility.

  YBSchemaBuilder schemaBuilder;
  schemaBuilder.AddColumn("node")->Type(STRING)->HashPrimaryKey()->NotNull();
  schemaBuilder.AddColumn("entity_type")->Type(STRING)->PrimaryKey()->NotNull();
  schemaBuilder.AddColumn("entity_id")->Type(STRING)->PrimaryKey()->NotNull();
  schemaBuilder.AddColumn("metric")->Type(STRING)->PrimaryKey()->NotNull();
  schemaBuilder.AddColumn("ts")->Type(TIMESTAMP)->PrimaryKey()->NotNull()->
    SetSortingType(SortingType::kDescending);
  schemaBuilder.AddColumn("value")->Type(INT64);
  schemaBuilder.AddColumn("details")->Type(JSONB);

  YBSchema ybschema;
  CHECK_OK(schemaBuilder.Build(&ybschema));

  auto schema = yb::client::internal::GetSchema(ybschema);
  SchemaToPB(schema, req.mutable_schema());

  Status s = CreateTable(&req, &resp, rpc);
  // We do not lock here so it is technically possible that the table was already created.
  // If so, there is nothing to do so we just ignore the "AlreadyPresent" error.
  if (s.IsAlreadyPresent()) {
    return Status::OK();
  }
  return s;
}

Result<bool> CatalogManager::IsCreateTableDone(const TableInfoPtr& table) {
  TRACE("Locking table");
  auto l = table->LockForRead();
  RETURN_NOT_OK(CheckIfTableDeletedOrNotVisibleToClient(l));
  const auto& pb = l->pb;

  // 2. Verify if the create is in-progress.
  TRACE("Verify if the table creation is in progress for $0", table->ToString());
  auto result = !table->IsCreateInProgress();

  // 3. Set any current errors, if we are experiencing issues creating the table. This will be
  // bubbled up to the MasterService layer. If it is an error, it gets wrapped around in
  // MasterErrorPB::UNKNOWN_ERROR.
  RETURN_NOT_OK(table->GetCreateTableErrorStatus());

  // 4. If this is an index, we are not done until the index is in the indexed table's schema.  An
  // exception is YSQL system table indexes, which don't get added to their indexed tables' schemas.
  if (result && IsIndex(pb)16.8k) {
    auto& indexed_table_id = GetIndexedTableId(pb);
    // For user indexes (which add index info to indexed table's schema),
    // - if this index is created without backfill,
    //   - waiting for the index to be in the indexed table's schema is sufficient, and, by that
    //     point, things are fully created.
    // - if this index is created with backfill
    //   - and it's YCQL,
    //     - waiting for the index to be in the indexed table's schema means waiting for the
    //       DELETE_ONLY index permission, and it's fine to return to the client before the index
    //       gets the rest of the permissions because the expectation is that backfill will be
    //       completed asynchronously.
    //   - and it's YSQL,
    //     - waiting for the index to be in the indexed table's schema means just that (DocDB index
    //       permissions don't really matter for YSQL besides being used for backfill purposes), and
    //       it's a signal for postgres to continue the index backfill process, activating index
    //       state flags then later triggering backfill and so on.
    // For YSQL system indexes (which don't add index info to indexed table's schema),
    // - there's nothing additional to wait on.
    // Therefore, the only thing needed here is to check whether the index info is in the indexed
    // table's schema for user indexes.
    if (pb.table_type() == YQL_TABLE_TYPE ||
        (912pb.table_type() == PGSQL_TABLE_TYPE912 && IsUserCreatedTable(*table)912)) {
      GetTableSchemaRequestPB get_schema_req;
      GetTableSchemaResponsePB get_schema_resp;
      get_schema_req.mutable_table()->set_table_id(indexed_table_id);
      const bool get_fully_applied_indexes = true;
      RETURN_NOT_OK(GetTableSchemaInternal(
          &get_schema_req, &get_schema_resp, get_fully_applied_indexes));

      result = false;
      for (const auto& index : get_schema_resp.indexes()) {
        if (index.has_table_id() && index.table_id() == table->id()) {
          result = true;
          break;
        }
      }
    }
  }

  // Sanity check that this table is present in system.partitions if it is a YCQL table.
  // Only check if we are automatically generating the vtable on changes. If we are creating via
  // the bg task, then there may be a delay.
  if (DCHECK_IS_ON() &&
      result40.2k &&
      IsYcqlTable(*table)16.7k &&
      YQLPartitionsVTable::GeneratePartitionsVTableOnChanges()2.01k &&
      FLAGS_TEST_catalog_manager_check_yql_partitions_exist_for_is_create_table_done2.01k) {
    Schema schema;
    RETURN_NOT_OK(table->GetSchema(&schema));
    // Copartitioned tables don't actually create tablets currently (unimplemented), so ignore them.
    if (!schema.table_properties().HasCopartitionTableId()) {
      DCHECK(GetYqlPartitionsVtable().CheckTableIsPresent(table->id(), table->NumPartitions()));
    }
  }

  // If this is a transactional table we are not done until the transaction status table is created.
  // However, if we are currently initializing the system catalog snapshot, we don't create the
  // transactions table.
  if (!FLAGS_create_initial_sys_catalog_snapshot &&
      result39.9k && pb.schema().table_properties().is_transactional()16.5k) {
    result = VERIFY_RESULT(IsTransactionStatusTableCreated());
  }

  // We are not done until the metrics snapshots table is created.
  if (FLAGS_master_enable_metrics_snapshotter && result0 &&
      !(0table->GetTableType() == TableType::YQL_TABLE_TYPE0 &&
        table->namespace_id() == kSystemNamespaceId &&
        table->name() == kMetricsSnapshotsTableName)) {
    result = VERIFY_RESULT(IsMetricsSnapshotsTableCreated());
  }

  // If this is a colocated table and there is a pending AddTableToTablet task then we are not done.
  if (result && pb.colocated()16.6k) {
    result = !table->HasTasks(MonitoredTask::Type::ASYNC_ADD_TABLE_TO_TABLET);
  }

  return result;
}

Status CatalogManager::IsCreateTableDone(const IsCreateTableDoneRequestPB* req,
                                         IsCreateTableDoneResponsePB* resp) {
  TRACE("Looking up table");
  // 1. Lookup the table and verify if it exists.
  scoped_refptr<TableInfo> table = VERIFY_RESULT(FindTable(req->table()));
  resp->set_done(VERIFY_RESULT(IsCreateTableDone(table)));
  return Status::OK();
}

Status CatalogManager::IsCreateTableInProgress(const TableId& table_id,
                                               CoarseTimePoint deadline,
                                               bool* create_in_progress) {
  DCHECK_ONLY_NOTNULL(create_in_progress);
  DCHECK(!table_id.empty());

  IsCreateTableDoneRequestPB req;
  IsCreateTableDoneResponsePB resp;
  req.mutable_table()->set_table_id(table_id);
  RETURN_NOT_OK(IsCreateTableDone(&req, &resp));

  if (resp.has_error()) {
    return StatusFromPB(resp.error().status());
  }

  *create_in_progress = !resp.done();
  return Status::OK();
}

Status CatalogManager::WaitForCreateTableToFinish(
    const TableId& table_id, CoarseTimePoint deadline) {
  return client::RetryFunc(
      deadline, "Waiting on Create Table to be completed", "Timed out waiting for Table Creation",
      std::bind(&CatalogManager::IsCreateTableInProgress, this, table_id, _1, _2));
}

Result<bool> CatalogManager::IsTransactionStatusTableCreated() {
  TableIdentifierPB table_id;

  table_id.set_table_name(kGlobalTransactionsTableName);
  table_id.mutable_namespace_()->set_name(kSystemNamespaceName);

  return IsCreateTableDone(VERIFY_RESULT(FindTable(table_id)));
}

Result<bool> CatalogManager::IsMetricsSnapshotsTableCreated() {
  TableIdentifierPB table_id;

  table_id.set_table_name(kMetricsSnapshotsTableName);
  table_id.mutable_namespace_()->set_name(kSystemNamespaceName);
  table_id.mutable_namespace_()->set_database_type(YQLDatabase::YQL_DATABASE_CQL);

  return IsCreateTableDone(VERIFY_RESULT(FindTable(table_id)));
}

std::string CatalogManager::GenerateId(boost::optional<const SysRowEntryType> entity_type) {
  SharedLock lock(mutex_);
  return GenerateIdUnlocked(entity_type);
}

std::string CatalogManager::GenerateIdUnlocked(
    boost::optional<const SysRowEntryType> entity_type) {
  while (true) {
    // Generate id and make sure it is unique within its category.
    std::string id = GenerateObjectId();
    if (!entity_type) {
      return id;
    }
    switch (*entity_type) {
      case SysRowEntryType::NAMESPACE:
        if (FindPtrOrNull(namespace_ids_map_, id) == nullptr) return id;
        break;
      case SysRowEntryType::TABLE:
        if (FindPtrOrNull(*table_ids_map_, id) == nullptr) return id;
        break;
      case SysRowEntryType::TABLET:
        if (FindPtrOrNull(*tablet_map_, id) == nullptr) return id;
        break;
      case SysRowEntryType::UDTYPE:
        if (FindPtrOrNull(udtype_ids_map_, id) == nullptr) return id;
        break;
      case SysRowEntryType::SNAPSHOT:
        return id;
      case SysRowEntryType::CDC_STREAM:
        if (!CDCStreamExistsUnlocked(id)) return id;
        break;
      case SysRowEntryType::CLUSTER_CONFIG: FALLTHROUGH_INTENDED;
      case SysRowEntryType::ROLE: FALLTHROUGH_INTENDED;
      case SysRowEntryType::REDIS_CONFIG: FALLTHROUGH_INTENDED;
      case SysRowEntryType::UNIVERSE_REPLICATION: FALLTHROUGH_INTENDED;
      case SysRowEntryType::SYS_CONFIG: FALLTHROUGH_INTENDED;
      case SysRowEntryType::SNAPSHOT_SCHEDULE: FALLTHROUGH_INTENDED;
      case SysRowEntryType::DDL_LOG_ENTRY: FALLTHROUGH_INTENDED;
      case SysRowEntryType::UNKNOWN:
        LOG(DFATAL) << "Invalid id type: " << *entity_type;
        return id;
    }
  }
}

scoped_refptr<TableInfo> CatalogManager::CreateTableInfo(const CreateTableRequestPB& req,
                                                         const Schema& schema,
                                                         const PartitionSchema& partition_schema,
                                                         const NamespaceId& namespace_id,
                                                         const NamespaceName& namespace_name,
                                                         IndexInfoPB* index_info) {
  DCHECK(schema.has_column_ids());
  TableId table_id
      = !req.table_id().empty() ? req.table_id()18.2k : GenerateIdUnlocked(SysRowEntryType::TABLE)38.1k;
  scoped_refptr<TableInfo> table = NewTableInfo(table_id);
  if (req.has_tablespace_id()) {
    table->SetTablespaceIdForTableCreation(req.tablespace_id());
  }
  table->mutable_metadata()->StartMutation();
  SysTablesEntryPB *metadata = &table->mutable_metadata()->mutable_dirty()->pb;
  metadata->set_state(SysTablesEntryPB::PREPARING);
  metadata->set_name(req.name());
  metadata->set_table_type(req.table_type());
  metadata->set_namespace_id(namespace_id);
  metadata->set_namespace_name(namespace_name);
  metadata->set_version(0);
  metadata->set_next_column_id(ColumnId(schema.max_col_id() + 1));
  if (req.has_replication_info()) {
    metadata->mutable_replication_info()->CopyFrom(req.replication_info());
  }
  // Use the Schema object passed in, since it has the column IDs already assigned,
  // whereas the user request PB does not.
  SchemaToPB(schema, metadata->mutable_schema());
  partition_schema.ToPB(metadata->mutable_partition_schema());
  // For index table, set index details (indexed table id and whether the index is local).
  if (req.has_index_info()) {
    metadata->mutable_index_info()->CopyFrom(req.index_info());

    // Set the deprecated fields also for compatibility reasons.
    metadata->set_indexed_table_id(req.index_info().indexed_table_id());
    metadata->set_is_local_index(req.index_info().is_local());
    metadata->set_is_unique_index(req.index_info().is_unique());

    // Setup index info.
    if (index_info != nullptr) {
      index_info->set_table_id(table->id());
      metadata->mutable_index_info()->CopyFrom(*index_info);
    }
  } else if (req.has_indexed_table_id()) {
    // Read data from the deprecated field and update the new fields.
    metadata->mutable_index_info()->set_indexed_table_id(req.indexed_table_id());
    metadata->mutable_index_info()->set_is_local(req.is_local_index());
    metadata->mutable_index_info()->set_is_unique(req.is_unique_index());

    // Set the deprecated fields also for compatibility reasons.
    metadata->set_indexed_table_id(req.indexed_table_id());
    metadata->set_is_local_index(req.is_local_index());
    metadata->set_is_unique_index(req.is_unique_index());

    // Setup index info.
    if (index_info != nullptr) {
      index_info->set_table_id(table->id());
      metadata->mutable_index_info()->CopyFrom(*index_info);
    }
  }

  if (req.is_pg_shared_table()) {
    metadata->set_is_pg_shared_table(true);
  }

  return table;
}

TabletInfoPtr CatalogManager::CreateTabletInfo(TableInfo* table,
                                               const PartitionPB& partition) {
  auto tablet = make_scoped_refptr<TabletInfo>(table, GenerateIdUnlocked(SysRowEntryType::TABLET));
  VLOG_WITH_PREFIX_AND_FUNC0(2)
      << "Table: " << table->ToString() << ", tablet: " << tablet->ToString();

  tablet->mutable_metadata()->StartMutation();
  SysTabletsEntryPB *metadata = &tablet->mutable_metadata()->mutable_dirty()->pb;
  metadata->set_state(SysTabletsEntryPB::PREPARING);
  metadata->mutable_partition()->CopyFrom(partition);
  metadata->set_table_id(table->id());
  // This is important: we are setting the first table id in the table_ids list
  // to be the id of the original table that creates the tablet.
  metadata->add_table_ids(table->id());
  return tablet;
}

Status CatalogManager::RemoveTableIdsFromTabletInfo(
    TabletInfoPtr tablet_info,
    std::unordered_set<TableId> tables_to_remove) {
  auto tablet_lock = tablet_info->LockForWrite();

  google::protobuf::RepeatedPtrField<std::string> new_table_ids;
  for (const auto& table_id : tablet_lock->pb.table_ids()) {
    if (tables_to_remove.find(table_id) == tables_to_remove.end()) {
      *new_table_ids.Add() = std::move(table_id);
    }
  }
  tablet_lock.mutable_data()->pb.mutable_table_ids()->Swap(&new_table_ids);

  RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), tablet_info));
  tablet_lock.Commit();
  return Status::OK();
}

Result<scoped_refptr<TableInfo>> CatalogManager::FindTable(
    const TableIdentifierPB& table_identifier) const {
  SharedLock lock(mutex_);
  return FindTableUnlocked(table_identifier);
}

Result<scoped_refptr<TableInfo>> CatalogManager::FindTableUnlocked(
    const TableIdentifierPB& table_identifier) const {
  if (table_identifier.has_table_id()) {
    return FindTableByIdUnlocked(table_identifier.table_id());
  }

  if (table_identifier.has_table_name()) {
    auto namespace_info = VERIFY_RESULT131k(FindNamespaceUnlocked(table_identifier.namespace_()));131k

    // We can't lookup YSQL table by name because Postgres concept of "schemas"
    // introduces ambiguity.
    if (namespace_info->database_type() == YQL_DATABASE_PGSQL) {
      return STATUS(InvalidArgument, "Cannot lookup YSQL table by name");
    }

    auto it = table_names_map_.find({namespace_info->id(), table_identifier.table_name()});
    if (it == table_names_map_.end()) {
      return STATUS_EC_FORMAT(
          NotFound, MasterError(MasterErrorPB::OBJECT_NOT_FOUND),
          "Table $0.$1 not found", namespace_info->name(), table_identifier.table_name());
    }
    return it->second;
  }

  return STATUS(InvalidArgument, "Neither table id or table name are specified",
                table_identifier.ShortDebugString());
}

Result<scoped_refptr<TableInfo>> CatalogManager::FindTableById(
    const TableId& table_id) const {
  SharedLock lock(mutex_);
  return FindTableByIdUnlocked(table_id);
}

Result<scoped_refptr<TableInfo>> CatalogManager::FindTableByIdUnlocked(
    const TableId& table_id) const {
  auto it = table_ids_map_->find(table_id);
  if (it == table_ids_map_->end()) {
    return STATUS_EC_FORMAT(
        NotFound, MasterError(MasterErrorPB::OBJECT_NOT_FOUND),
        "Table with identifier $0 not found", table_id);
  }
  return it->second;
}

Result<scoped_refptr<NamespaceInfo>> CatalogManager::FindNamespaceById(
    const NamespaceId& id) const {
  SharedLock lock(mutex_);
  return FindNamespaceByIdUnlocked(id);
}

Result<scoped_refptr<NamespaceInfo>> CatalogManager::FindNamespaceByIdUnlocked(
    const NamespaceId& id) const {
  auto it = namespace_ids_map_.find(id);
  if (it == namespace_ids_map_.end()) {
    VLOG_WITH_FUNC0(4) << "Not found: " << id << "\n" << GetStackTrace()0;
    return STATUS(NotFound, "Keyspace identifier not found", id,
                  MasterError(MasterErrorPB::NAMESPACE_NOT_FOUND));
  }
  return it->second;
}

Result<scoped_refptr<NamespaceInfo>> CatalogManager::FindNamespaceUnlocked(
    const NamespaceIdentifierPB& ns_identifier) const {
  if (ns_identifier.has_id()) {
    return FindNamespaceByIdUnlocked(ns_identifier.id());
  }

  if (ns_identifier.has_name()) {
    auto db = GetDatabaseType(ns_identifier);
    auto it = namespace_names_mapper_[db].find(ns_identifier.name());
    if (it == namespace_names_mapper_[db].end()) {
      return STATUS(NotFound, "Keyspace name not found", ns_identifier.name(),
                    MasterError(MasterErrorPB::NAMESPACE_NOT_FOUND));
    }
    return it->second;
  }

  LOG(DFATAL) << __func__ << ": " << ns_identifier.ShortDebugString() << ", \n" << GetStackTrace();
  return STATUS(NotFound, "Neither keyspace id nor keyspace name is specified",
                ns_identifier.ShortDebugString(), MasterError(MasterErrorPB::NAMESPACE_NOT_FOUND));
}

Result<scoped_refptr<NamespaceInfo>> CatalogManager::FindNamespace(
    const NamespaceIdentifierPB& ns_identifier) const {
  SharedLock lock(mutex_);
  return FindNamespaceUnlocked(ns_identifier);
}

Result<TableDescription> CatalogManager::DescribeTable(
    const TableIdentifierPB& table_identifier, bool succeed_if_create_in_progress) {
  TRACE("Looking up table");
  return DescribeTable(VERIFY_RESULT(FindTable(table_identifier)), succeed_if_create_in_progress);
}

Result<TableDescription> CatalogManager::DescribeTable(
    const TableInfoPtr& table_info, bool succeed_if_create_in_progress) {
  TableDescription result;
  result.table_info = table_info;
  NamespaceId namespace_id;
  {
    TRACE("Locking table");
    auto l = table_info->LockForRead();

    if (!succeed_if_create_in_progress && table_info->IsCreateInProgress()14) {
      return STATUS(IllegalState, "Table creation is in progress", table_info->ToString(),
                    MasterError(MasterErrorPB::TABLE_CREATION_IS_IN_PROGRESS));
    }

    result.tablet_infos = table_info->GetTablets();

    namespace_id = table_info->namespace_id();
  }

  TRACE("Looking up namespace");
  result.namespace_info = VERIFY_RESULT(FindNamespaceById(namespace_id));

  return result;
}

Result<string> CatalogManager::GetPgSchemaName(const TableInfoPtr& table_info) {
  RSTATUS_DCHECK_EQ(table_info->GetTableType(), PGSQL_TABLE_TYPE, InternalError,
      Format("Expected YSQL table, got: $0", table_info->GetTableType()));

  const uint32_t database_oid = VERIFY_RESULT(GetPgsqlDatabaseOid(table_info->namespace_id()));
  uint32_t table_oid = VERIFY_RESULT(GetPgsqlTableOid(table_info->id()));
  {
    if (matview_pg_table_ids_map_.find(table_info->id()) != matview_pg_table_ids_map_.end()) {
      table_oid = VERIFY_RESULT(GetPgsqlTableOid(matview_pg_table_ids_map_[table_info->id()]));
    }
  }
  const uint32_t relnamespace_oid = VERIFY_RESULT(
      sys_catalog_->ReadPgClassRelnamespace(database_oid, table_oid));
  return sys_catalog_->ReadPgNamespaceNspname(database_oid, relnamespace_oid);
}

// Truncate a Table.
Status CatalogManager::TruncateTable(const TruncateTableRequestPB* req,
                                     TruncateTableResponsePB* resp,
                                     rpc::RpcContext* rpc) {
  LOG(INFO) << "Servicing TruncateTable request from " << RequestorString(rpc)
            << ": " << req->ShortDebugString();

  for (int i = 0; i < req->table_ids_size(); i++3.79k) {
    RETURN_NOT_OK(TruncateTable(req->table_ids(i), resp, rpc));
  }

  return Status::OK();
}

Status CatalogManager::TruncateTable(const TableId& table_id,
                                     TruncateTableResponsePB* resp,
                                     rpc::RpcContext* rpc) {
  // Lookup the table and verify if it exists.
  TRACE(Substitute("Looking up object by id $0", table_id));
  scoped_refptr<TableInfo> table;
  {
    SharedLock lock(mutex_);
    table = FindPtrOrNull(*table_ids_map_, table_id);
    if (table == nullptr) {
      Status s = STATUS_SUBSTITUTE(NotFound, "The object with id $0 does not exist", table_id);
      return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_NOT_FOUND, s);
    }
  }

  TRACE(Substitute("Locking object with id $0", table_id));
  auto l = table->LockForRead();
  RETURN_NOT_OK(CheckIfTableDeletedOrNotVisibleToClient(l, resp));

  // Truncate on a colocated table should not hit master because it should be handled by a write
  // DML that creates a table-level tombstone.
  LOG_IF(WARNING, table->IsColocatedUserTable()) << "cannot truncate a colocated table on master"0;

  if (!FLAGS_enable_delete_truncate_xcluster_replicated_table && IsCdcEnabled(*table)) {
    return STATUS(NotSupported,
                  "Cannot truncate a table in replication.",
                  table_id,
                  MasterError(MasterErrorPB::INVALID_REQUEST));
  }

  // Send a Truncate() request to each tablet in the table.
  SendTruncateTableRequest(table);

  LOG(INFO) << "Successfully initiated TRUNCATE for " << table->ToString() << " per request from "
            << RequestorString(rpc);
  background_tasks_->Wake();

  // Truncate indexes also.
  // Note: PG table does not have references to indexes in the base table, so associated indexes
  //       must be truncated from the PG code separately.
  const bool is_index = IsIndex(l->pb);
  DCHECK(!is_index || l->pb.indexes().empty()) << "indexes should be empty for index table"0;
  for (const auto& index_info : l->pb.indexes()) {
    RETURN_NOT_OK(TruncateTable(index_info.table_id(), resp, rpc));
  }

  return Status::OK();
}

void CatalogManager::SendTruncateTableRequest(const scoped_refptr<TableInfo>& table) {
  for (const auto& tablet : table->GetTablets()) {
    SendTruncateTabletRequest(tablet);
  }
}

void CatalogManager::SendTruncateTabletRequest(const scoped_refptr<TabletInfo>& tablet) {
  LOG_WITH_PREFIX(INFO) << "Truncating tablet " << tablet->id();
  auto call = std::make_shared<AsyncTruncate>(master_, AsyncTaskPool(), tablet);
  tablet->table()->AddTask(call);
  WARN_NOT_OK(
      ScheduleTask(call),
      Substitute("Failed to send truncate request for tablet $0", tablet->id()));
}

Status CatalogManager::IsTruncateTableDone(const IsTruncateTableDoneRequestPB* req,
                                           IsTruncateTableDoneResponsePB* resp) {
  LOG(INFO) << "Servicing IsTruncateTableDone request for table id " << req->table_id();

  // Lookup the truncated table.
  TRACE("Looking up table $0", req->table_id());
  scoped_refptr<TableInfo> table;
  {
    SharedLock lock(mutex_);
    table = FindPtrOrNull(*table_ids_map_, req->table_id());
  }

  if (table == nullptr) {
    Status s = STATUS(NotFound, "The object does not exist: table with id", req->table_id());
    return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_NOT_FOUND, s);
  }

  TRACE("Locking table");
  RETURN_NOT_OK(CheckIfTableDeletedOrNotVisibleToClient(table->LockForRead(), resp));

  resp->set_done(!table->HasTasks(MonitoredTask::Type::ASYNC_TRUNCATE_TABLET));
  return Status::OK();
}

// Note: only used by YSQL as of 2020-10-29.
Status CatalogManager::BackfillIndex(
    const BackfillIndexRequestPB* req,
    BackfillIndexResponsePB* resp,
    rpc::RpcContext* rpc) {
  const TableIdentifierPB& index_table_identifier = req->index_identifier();

  scoped_refptr<TableInfo> index_table = VERIFY_RESULT(FindTable(index_table_identifier));

  if (index_table->GetTableType() != PGSQL_TABLE_TYPE) {
    // This request is only supported for YSQL for now.  YCQL has its own mechanism.
    return STATUS(
        InvalidArgument,
        "Unexpected non-YSQL table",
        index_table_identifier.ShortDebugString());
  }

  // Collect indexed_table.
  scoped_refptr<TableInfo> indexed_table;
  {
    auto l = index_table->LockForRead();
    TableId indexed_table_id = GetIndexedTableId(l->pb);
    resp->mutable_table_identifier()->set_table_id(indexed_table_id);
    indexed_table = GetTableInfo(indexed_table_id);
  }

  if (indexed_table == nullptr) {
    return STATUS(InvalidArgument, "Empty indexed table",
                  index_table_identifier.ShortDebugString());
  }

  // TODO(jason): when ready to use INDEX_PERM_DO_BACKFILL for resuming backfill across master
  // leader changes, replace the following (issue #6218).

  // Collect index_info_pb.
  IndexInfoPB index_info_pb;
  indexed_table->GetIndexInfo(index_table->id()).ToPB(&index_info_pb);
  if (index_info_pb.index_permissions() != INDEX_PERM_WRITE_AND_DELETE) {
    return SetupError(
        resp->mutable_error(),
        MasterErrorPB::INVALID_SCHEMA,
        STATUS_FORMAT(
            InvalidArgument,
            "Expected WRITE_AND_DELETE perm, got $0",
            IndexPermissions_Name(index_info_pb.index_permissions())));
  }

  return MultiStageAlterTable::StartBackfillingData(
      this, indexed_table, {index_info_pb}, boost::none);
}

Status CatalogManager::GetBackfillJobs(
    const GetBackfillJobsRequestPB* req,
    GetBackfillJobsResponsePB* resp,
    rpc::RpcContext* rpc) {
  TableIdentifierPB table_id = req->table_identifier();

  scoped_refptr<TableInfo> indexed_table = VERIFY_RESULT(FindTable(table_id));
  if (indexed_table == nullptr) {
    Status s = STATUS(NotFound, "Requested table $0 does not exist", table_id.ShortDebugString());
    return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_NOT_FOUND, s);
  }

  {
    auto l = indexed_table->LockForRead();
    resp->mutable_backfill_jobs()->CopyFrom(l->pb.backfill_jobs());
  }
  return Status::OK();
}

Status CatalogManager::LaunchBackfillIndexForTable(
    const LaunchBackfillIndexForTableRequestPB* req,
    LaunchBackfillIndexForTableResponsePB* resp,
    rpc::RpcContext* rpc) {
  const TableIdentifierPB& table_id = req->table_identifier();

  scoped_refptr<TableInfo> indexed_table = VERIFY_RESULT(FindTable(table_id));
  if (indexed_table == nullptr) {
    Status s = STATUS(NotFound, "Requested table $0 does not exist", table_id.ShortDebugString());
    return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_NOT_FOUND, s);
  }
  if (indexed_table->GetTableType() != YQL_TABLE_TYPE) {
    // This request is only supported for YCQL for now.  YSQL has its own mechanism.
    return STATUS(InvalidArgument, "Unexpected non-YCQL table $0", table_id.ShortDebugString());
  }

  uint32_t current_version;
  {
    auto l = indexed_table->LockForRead();
    if (l->pb.state() != SysTablesEntryPB::RUNNING) {
      Status s = STATUS(TryAgain,
                        "The table is in state $0. An alter may already be in progress.",
                        SysTablesEntryPB_State_Name(l->pb.state()));
      VLOG(2) << "Table " << indexed_table->ToString() << " is not running returning " << s;
      return SetupError(resp->mutable_error(), MasterErrorPB::INTERNAL_ERROR, s);
    }
    current_version = l->pb.version();
  }

  auto s = MultiStageAlterTable::LaunchNextTableInfoVersionIfNecessary(
      this, indexed_table, current_version, /* respect deferrals for backfill */ false);
  if (!s.ok()) {
    VLOG(3) << __func__ << " Done failed " << s;
    return SetupError(resp->mutable_error(), MasterErrorPB::UNKNOWN_ERROR, s);
  }
  return Status::OK();
}

Status CatalogManager::MarkIndexInfoFromTableForDeletion(
    const TableId& indexed_table_id, const TableId& index_table_id, bool multi_stage,
    DeleteTableResponsePB* resp) {
  // Lookup the indexed table and verify if it exists.
  scoped_refptr<TableInfo> indexed_table = GetTableInfo(indexed_table_id);
  if (indexed_table == nullptr) {
    LOG(WARNING) << "Indexed table " << indexed_table_id << " for index "
                 << index_table_id << " not found";
    return Status::OK();
  }

  if (resp) {
    auto ns_info = VERIFY_RESULT(master_->catalog_manager()->FindNamespaceById(
        indexed_table->namespace_id()));
    auto* resp_indexed_table = resp->mutable_indexed_table();
    resp_indexed_table->mutable_namespace_()->set_name(ns_info->name());
    resp_indexed_table->set_table_name(indexed_table->name());
    resp_indexed_table->set_table_id(indexed_table_id);
  }
  if (multi_stage) {
    RETURN_NOT_OK(MultiStageAlterTable::UpdateIndexPermission(
        this, indexed_table,
        {{index_table_id, IndexPermissions::INDEX_PERM_WRITE_AND_DELETE_WHILE_REMOVING}}));
  } else {
    RETURN_NOT_OK(DeleteIndexInfoFromTable(indexed_table_id, index_table_id));
  }

  // Actual Deletion of the index info will happen asynchronously after all the
  // tablets move to the new IndexPermission of DELETE_ONLY_WHILE_REMOVING.
  RETURN_NOT_OK(SendAlterTableRequest(indexed_table));
  return Status::OK();
}

Status CatalogManager::DeleteIndexInfoFromTable(
    const TableId& indexed_table_id, const TableId& index_table_id) {
  scoped_refptr<TableInfo> indexed_table = GetTableInfo(indexed_table_id);
  if (indexed_table == nullptr) {
    LOG(WARNING) << "Indexed table " << indexed_table_id << " for index " << index_table_id
                 << " not found";
    return Status::OK();
  }
  TRACE("Locking indexed table");
  auto l = indexed_table->LockForWrite();
  auto &indexed_table_data = *l.mutable_data();

  // Heed issue #6233.
  if (!l->pb.has_fully_applied_schema()) {
    MultiStageAlterTable::CopySchemaDetailsToFullyApplied(&indexed_table_data.pb);
  }
  auto *indexes = indexed_table_data.pb.mutable_indexes();
  for (int i = 0; i < indexes->size(); i++177) {
    if (indexes->Get(i).table_id() == index_table_id) {

      indexes->DeleteSubrange(i, 1);

      indexed_table_data.pb.set_version(indexed_table_data.pb.version() + 1);
      // TODO(Amit) : Is this compatible with the previous version?
      indexed_table_data.pb.set_updates_only_index_permissions(false);
      indexed_table_data.set_state(
          SysTablesEntryPB::ALTERING,
          Format("Delete index info version=$0 ts=$1",
                 indexed_table_data.pb.version(), LocalTimeAsString()));

      // Update sys-catalog with the deleted indexed table info.
      TRACE("Updating indexed table metadata on disk");
      RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), indexed_table));

      // Update the in-memory state.
      TRACE("Committing in-memory state");
      l.Commit();
      return Status::OK();
    }
  }

  LOG(WARNING) << "Index " << index_table_id << " not found in indexed table " << indexed_table_id;
  return Status::OK();
}

Status CatalogManager::DeleteTable(
    const DeleteTableRequestPB* req, DeleteTableResponsePB* resp, rpc::RpcContext* rpc) {
  LOG(INFO) << "Servicing DeleteTable request from " << RequestorString(rpc) << ": "
            << req->ShortDebugString();

  scoped_refptr<TableInfo> table = VERIFY_RESULT5.58k(FindTable(req->table()));5.58k
  bool result = IsCdcEnabled(*table);
  if (!FLAGS_enable_delete_truncate_xcluster_replicated_table && result) {
    return STATUS(NotSupported,
                  "Cannot delete a table in replication.",
                  req->ShortDebugString(),
                  MasterError(MasterErrorPB::INVALID_REQUEST));
  }

  if (req->is_index_table()) {
    TRACE("Looking up index");
    TableId table_id = table->id();
    resp->set_table_id(table_id);
    TableId indexed_table_id;
    {
      auto l = table->LockForRead();
      indexed_table_id = GetIndexedTableId(l->pb);
    }
    scoped_refptr<TableInfo> indexed_table = GetTableInfo(indexed_table_id);
    const bool is_pg_table = indexed_table != nullptr &&
                             indexed_table->GetTableType() == PGSQL_TABLE_TYPE;
    bool is_transactional;
    {
      Schema index_schema;
      RETURN_NOT_OK(table->GetSchema(&index_schema));
      is_transactional = index_schema.table_properties().is_transactional();
    }
    const bool index_backfill_enabled =
        IsIndexBackfillEnabled(table->GetTableType(), is_transactional);
    if (!is_pg_table && index_backfill_enabled124) {
      return MarkIndexInfoFromTableForDeletion(
          indexed_table_id, table_id, /* multi_stage */ true, resp);
    }
  }

  return DeleteTableInternal(req, resp, rpc);
}

// Delete a Table
//  - Update the table state to "DELETING".
//  - Issue DeleteTablet tasks to all said tablets.
//  - Update all the underlying tablet states as "DELETED".
//
// This order of events can help us guarantee that:
//  - If a table is DELETING/DELETED, we do not add further tasks to it.
//  - A DeleteTable is done when a table is either DELETING or DELETED and has no running tasks.
//  - If a table is DELETING and it has no tasks on it, then it is safe to mark DELETED.
//
// We are lazy about deletions.
//
// IMPORTANT: If modifying, consider updating DeleteYsqlDBTables(), the bulk deletion API.
Status CatalogManager::DeleteTableInternal(
    const DeleteTableRequestPB* req, DeleteTableResponsePB* resp, rpc::RpcContext* rpc) {
  auto schedules_to_tables_map = VERIFY_RESULT(
      MakeSnapshotSchedulesToObjectIdsMap(SysRowEntryType::TABLE));

  vector<DeletingTableData> tables;
  RETURN_NOT_OK(DeleteTableInMemory(req->table(), req->is_index_table(),
                                    true /* update_indexed_table */, schedules_to_tables_map,
                                    &tables, resp, rpc));

  // Update the in-memory state.
  TRACE("Committing in-memory state");
  std::unordered_set<TableId> sys_table_ids;
  for (auto& table : tables) {
    if (IsSystemTable(*table.info)) {
      sys_table_ids.insert(table.info->id());
    }
    table.write_lock.Commit();
  }

  // Delete any CDC streams that are set up on this table, after releasing the Table lock.
  TRACE("Deleting CDC streams on table");
  // table_id for the requested table will be added to the end of the response.
  RSTATUS_DCHECK_GE(resp->deleted_table_ids_size(), 1, IllegalState,
      "DeleteTableInMemory expected to add the index id to resp");
  RETURN_NOT_OK(
      DeleteCDCStreamsForTable(resp->deleted_table_ids(resp->deleted_table_ids_size() - 1)));

  if (PREDICT_FALSE(FLAGS_catalog_manager_inject_latency_in_delete_table_ms > 0)) {
    LOG(INFO) << "Sleeping in CatalogManager::DeleteTable for " <<
        FLAGS_catalog_manager_inject_latency_in_delete_table_ms << " ms";
    SleepFor(MonoDelta::FromMilliseconds(FLAGS_catalog_manager_inject_latency_in_delete_table_ms));
  }

  // Update the internal table maps. Exclude Postgres tables which are not in the name map.
  // Also exclude hidden tables, that were already removed from this map.
  if (std::any_of(tables.begin(), tables.end(), [](auto& t) { return t.remove_from_name_map; }5.58k)) {
    TRACE("Removing tables from by-name map");
    LockGuard lock(mutex_);
    for (const auto& table : tables) {
      if (table.remove_from_name_map) {
        TableInfoByNameMap::key_type key = {table.info->namespace_id(), table.info->name()};
        if (table_names_map_.erase(key) != 1) {
          LOG(WARNING) << "Could not remove table from map: " << key.first << "." << key.second;
        }

        // Also remove from the system.partitions table.
        GetYqlPartitionsVtable().RemoveFromCache(table.info->id());

        // Remove matviews from matview to pg table id map
        matview_pg_table_ids_map_.erase(table.info->id());
      }
    }
    // We commit another map to increment its version and reset cache.
    // Since table_name_map_ does not have version.
    table_ids_map_.Commit();
  }

  for (const auto& table : tables) {
    LOG(INFO) << "Deleting table: " << table.info->name() << ", retained by: "
              << AsString(table.retained_by_snapshot_schedules, &Uuid::TryFullyDecode);

    // Send a DeleteTablet() request to each tablet replica in the table.
    RETURN_NOT_OK(DeleteTabletsAndSendRequests(table.info, table.retained_by_snapshot_schedules));
    // Send a RemoveTableFromTablet() request to each colocated parent tablet replica in the table.
    // TODO(pitr) handle YSQL colocated tables.
    if (table.info->IsColocatedUserTable()) {
      {
        LockGuard lock(mutex_);
        const auto it = table_tablegroup_ids_map_.find(table.info->id());
        if (it != table_tablegroup_ids_map_.end()) {
          const TablegroupId& tablegroup_id = it->second;
          const auto& tablegroup = DCHECK_NOTNULL(tablegroup_ids_map_[tablegroup_id]);
          tablegroup->DeleteChildTable(table.info->id());
          table_tablegroup_ids_map_.erase(table.info->id());
        }
      }
      auto call = std::make_shared<AsyncRemoveTableFromTablet>(
          master_, AsyncTaskPool(), table.info->GetColocatedTablet(), table.info);
      table.info->AddTask(call);
      WARN_NOT_OK(ScheduleTask(call), "Failed to send RemoveTableFromTablet request");
    }
  }

  // If there are any permissions granted on this table find them and delete them. This is necessary
  // because we keep track of the permissions based on the canonical resource name which is a
  // combination of the keyspace and table names, so if another table with the same name is created
  // (in the same keyspace where the previous one existed), and the permissions were not deleted at
  // the time of the previous table deletion, then the permissions that existed for the previous
  // table will automatically be granted to the new table even though this wasn't the intention.
  string canonical_resource = get_canonical_table(req->table().namespace_().name(),
                                                  req->table().table_name());
  RETURN_NOT_OK(permissions_manager_->RemoveAllPermissionsForResource(canonical_resource, resp));

  // Remove the system tables from system catalog.
  if (!sys_table_ids.empty()) {
    // We do not expect system tables deletion during initial snapshot forming.
    DCHECK(!initial_snapshot_writer_);

    TRACE("Sending system table delete RPCs");
    for (auto& table_id : sys_table_ids) {
      // "sys_catalog_->DeleteYsqlSystemTable(table_id)" won't work here
      // as it only acts on the leader.
      tablet::ChangeMetadataRequestPB change_req;
      change_req.set_tablet_id(kSysCatalogTabletId);
      change_req.set_remove_table_id(table_id);
      RETURN_NOT_OK(tablet::SyncReplicateChangeMetadataOperation(
          &change_req, sys_catalog_->tablet_peer().get(), leader_ready_term()));
    }
  } else {
    TRACE("No system tables to delete");
  }

  LOG(INFO) << "Successfully initiated deletion of "
            << (req->is_index_table() ? "index"811 : "table"4.77k) << " with "
            << req->table().DebugString() << " per request from " << RequestorString(rpc);
  // Asynchronously cleans up the final memory traces of the deleted database.
  background_tasks_->Wake();
  return Status::OK();
}

Status CatalogManager::DeleteTableInMemory(
    const TableIdentifierPB& table_identifier,
    const bool is_index_table,
    const bool update_indexed_table,
    const SnapshotSchedulesToObjectIdsMap& schedules_to_tables_map,
    vector<DeletingTableData>* tables,
    DeleteTableResponsePB* resp,
    rpc::RpcContext* rpc) {
  // TODO(NIC): How to handle a DeleteTable request when the namespace is being deleted?
  const char* const object_type = is_index_table ? "index"1.12k : "table"4.78k;
  const bool cascade_delete_index = is_index_table && !update_indexed_table1.12k;

  VLOG_WITH_PREFIX_AND_FUNC0(1) << 0YB_STRUCT_TO_STRING0(
      table_identifier, is_index_table, update_indexed_table) << "\n" << GetStackTrace();

  // Lookup the table and verify if it exists.
  TRACE(Substitute("Looking up $0", object_type));
  auto table_result = FindTable(table_identifier);
  if (!VERIFY_RESULT(DoesTableExist(table_result))) {
    if (cascade_delete_index) {
      LOG(WARNING) << "Index " << table_identifier.DebugString() << " not found";
      return Status::OK();
    } else {
      return table_result.status();
    }
  }
  auto table = std::move(*table_result);

  TRACE(Substitute("Locking $0", object_type));
  auto data = DeletingTableData {
    .info = table,
    .write_lock = table->LockForWrite(),
    .retained_by_snapshot_schedules = RepeatedBytes(),
    .remove_from_name_map = false
  };
  auto& l = data.write_lock;
  // table_id for the requested table will be added to the end of the response.
  *resp->add_deleted_table_ids() = table->id();

  if (is_index_table == IsTable(l->pb)) {
    Status s = STATUS(NotFound, "The object does not exist");
    return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_NOT_FOUND, s);
  }

  FillRetainedBySnapshotSchedules(
      schedules_to_tables_map, table->id(), &data.retained_by_snapshot_schedules);
  bool hide_only = !data.retained_by_snapshot_schedules.empty();

  if (l->started_deleting() || (5.88khide_only5.88k && l->started_hiding()4)) {
    if (cascade_delete_index) {
      LOG(WARNING) << "Index " << table_identifier.ShortDebugString() << " was "
                   << (l->started_deleting() ? "deleted" : "hidden");
      return Status::OK();
    } else {
      Status s = STATUS(NotFound, "The object was deleted", l->pb.state_msg());
      return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_NOT_FOUND, s);
    }
  }

  // Determine if we have to remove from the name map here before we change the table state.
  data.remove_from_name_map = l.data().table_type() != PGSQL_TABLE_TYPE && !l->started_hiding()1.63k;

  TRACE("Updating metadata on disk");
  // Update the metadata for the on-disk state.
  if (hide_only) {
    l.mutable_data()->pb.set_hide_state(SysTablesEntryPB::HIDING);
  } else {
    l.mutable_data()->set_state(SysTablesEntryPB::DELETING,
                                 Substitute("Started deleting at $0", LocalTimeAsString()));
  }

  auto now = master_->clock()->Now();
  DdlLogEntry ddl_log_entry(now, table->id(), l->pb, "Drop");
  if (is_index_table) {
    const auto& indexed_table_id = GetIndexedTableId(l->pb);
    auto indexed_table = FindTableById(indexed_table_id);
    if (indexed_table.ok()) {
      auto lock = (**indexed_table).LockForRead();
      ddl_log_entry = DdlLogEntry(
          now, indexed_table_id, lock->pb, Format("Drop index $0", l->name()));
    }
  }

  // Update sys-catalog with the removed table state.
  Status s = sys_catalog_->Upsert(leader_ready_term(), &ddl_log_entry, table);

  if (PREDICT_FALSE(FLAGS_TEST_simulate_crash_after_table_marked_deleting)) {
    return Status::OK();
  }

  if (!s.ok()) {
    // The mutation will be aborted when 'l' exits the scope on early return.
    s = s.CloneAndPrepend("An error occurred while updating sys tables");
    LOG(WARNING) << s;
    return CheckIfNoLongerLeaderAndSetupError(s, resp);
  }

  // For regular (indexed) table, delete all its index tables if any. Else for index table, delete
  // index info from the indexed table.
  if (!is_index_table) {
    TableIdentifierPB index_identifier;
    for (const auto& index : l->pb.indexes()) {
      index_identifier.set_table_id(index.table_id());
      RETURN_NOT_OK(DeleteTableInMemory(index_identifier, true /* is_index_table */,
                                        false /* update_indexed_table */, schedules_to_tables_map,
                                        tables, resp, rpc));
    }
  } else if (1.11kupdate_indexed_table1.11k) {
    s = MarkIndexInfoFromTableForDeletion(
        GetIndexedTableId(l->pb), table->id(), /* multi_stage */ false, resp);
    if (!s.ok()) {
      s = s.CloneAndPrepend(Substitute("An error occurred while deleting index info: $0",
                                       s.ToString()));
      LOG(WARNING) << s.ToString();
      return CheckIfNoLongerLeaderAndSetupError(s, resp);
    }
  }

  if (!hide_only) {
    // If table is being hidden we should not abort snapshot related tasks.
    table->AbortTasks();
  }

  // For regular (indexed) table, insert table info and lock in the front of the list. Else for
  // index table, append them to the end. We do so so that we will commit and delete the indexed
  // table first before its indexes.
  tables->insert(is_index_table ? tables->end()1.11k : tables->begin()4.77k, std::move(data));

  return Status::OK();
}

TableInfo::WriteLock CatalogManager::MaybeTransitionTableToDeleted(const TableInfoPtr& table) {
  if (!table) {
    LOG_WITH_PREFIX(INFO) << "Finished deleting an Orphaned tablet. "
                          << "Table Information is null. Skipping updating its state to DELETED.";
    return TableInfo::WriteLock();
  }
  if (table->HasTasks()) {
    VLOG_WITH_PREFIX_AND_FUNC0(2) << table->ToString() << " has tasks"0;
    return TableInfo::WriteLock();
  }
  bool hide_only;
  {
    auto lock = table->LockForRead();

    // For any table in DELETING state, we will want to mark it as DELETED once all its respective
    // tablets have been successfully removed from tservers.
    // For any hiding table we will want to mark it as HIDDEN once all its respective
    // tablets have been successfully hidden on tservers.
    if (lock->is_deleted()) {
      // Clear the tablets_ and partitions_ maps if table has already been DELETED.
      // Usually this would have been done except for tables that were hidden and are now deleted.
      // Also, this is a catch all in case any other path misses clearing the maps.
      table->ClearTabletMaps();
      return TableInfo::WriteLock();
    }
    hide_only = !lock->is_deleting();
    if (hide_only && !lock->is_hiding()14.7M) {
      return TableInfo::WriteLock();
    }
  }
  // The current relevant order of operations during a DeleteTable is:
  // 1) Mark the table as DELETING
  // 2) Abort the current table tasks
  // 3) Per tablet, send DeleteTable requests to all TS, then mark that tablet as DELETED
  //
  // This creates a race, wherein, after 2, HasTasks can be false, but we still have not
  // gotten to point 3, which would add further tasks for the deletes.
  //
  // However, HasTasks is cheaper than AreAllTabletsDeletedOrHidden...
  auto all_tablets_done = hide_only ? table->AreAllTabletsHidden()4 : table->AreAllTabletsDeleted()16.3k;
  VLOG_WITH_PREFIX_AND_FUNC(2)
      << table->ToString() << " hide only: " << hide_only << ", all tablets done: "
      << all_tablets_done;
  if (!all_tablets_done && !IsSystemTable(*table)8.09k && !table->IsColocatedUserTable()203) {
    return TableInfo::WriteLock();
  }

  auto lock = table->LockForWrite();
  if (lock->is_hiding()) {
    LOG(INFO) << "Marking table as HIDDEN: " << table->ToString();
    lock.mutable_data()->pb.set_hide_state(SysTablesEntryPB::HIDDEN);
    // Erase all the tablets from partitions_ structure.
    table->ClearTabletMaps(DeactivateOnly::kTrue);
    return lock;
  }
  if (lock->is_deleting()) {
    // Update the metadata for the on-disk state.
    LOG(INFO) << "Marking table as DELETED: " << table->ToString();
    lock.mutable_data()->set_state(SysTablesEntryPB::DELETED,
        Substitute("Deleted with tablets at $0", LocalTimeAsString()));
    // Erase all the tablets from tablets_ and partitions_ structures.
    table->ClearTabletMaps();
    return lock;
  }
  return TableInfo::WriteLock();
}

void CatalogManager::CleanUpDeletedTables() {
  // TODO(bogdan): Cache tables being deleted to make this iterate only over those?
  vector<scoped_refptr<TableInfo>> tables_to_delete;
  // Garbage collecting.
  // Going through all tables under the global lock, copying them to not hold lock for too long.
  TableInfoMap copy_of_table_by_id_map;
  {
    LockGuard lock(mutex_);
    copy_of_table_by_id_map = *table_ids_map_;
  }
  // Mark the tables as DELETED and remove them from the in-memory maps.
  vector<TableInfo*> tables_to_update_on_disk;
  vector<TableInfo::WriteLock> table_locks;
  for (const auto& it : copy_of_table_by_id_map) {
    const auto& table = it.second;
    auto lock = MaybeTransitionTableToDeleted(table);
    if (lock.locked()) {
      table_locks.push_back(std::move(lock));
      tables_to_update_on_disk.push_back(table.get());
    }
  }
  if (tables_to_update_on_disk.size() > 0) {
    Status s = sys_catalog_->Upsert(leader_ready_term(), tables_to_update_on_disk);
    if (!s.ok()) {
      LOG(WARNING) << "Error marking tables as DELETED: " << s.ToString();
      return;
    }
    // Update the table in-memory info as DELETED after we've removed them from the maps.
    for (auto& lock : table_locks)87 {
      lock.Commit();
    }
    // TODO: Check if we want to delete the totally deleted table from the sys_catalog here.
    // TODO: SysCatalog::DeleteItem() if we've DELETED all user tables in a DELETING namespace.
    // TODO: Also properly handle namespace_ids_map_.erase(table->namespace_id())
  }
}

Status CatalogManager::IsDeleteTableDone(const IsDeleteTableDoneRequestPB* req,
                                         IsDeleteTableDoneResponsePB* resp) {
  // Lookup the deleted table.
  TRACE("Looking up table $0", req->table_id());
  scoped_refptr<TableInfo> table;
  {
    SharedLock lock(mutex_);
    table = FindPtrOrNull(*table_ids_map_, req->table_id());
  }

  if (table == nullptr) {
    LOG(INFO) << "Servicing IsDeleteTableDone request for table id "
              << req->table_id() << ": deleted (not found)";
    resp->set_done(true);
    return Status::OK();
  }

  TRACE("Locking table");
  auto l = table->LockForRead();

  if (!l->started_deleting() && !l->started_hiding()118) {
    LOG(WARNING) << "Servicing IsDeleteTableDone request for table id "
                 << req->table_id() << ": NOT deleted";
    Status s = STATUS(IllegalState, "The object was NOT deleted", l->pb.state_msg());
    return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_NOT_FOUND, s);
  }

  // Temporary fix for github issue #5290.
  // TODO: Wait till deletion completed for tablegroup parent table.
  if (table->IsTablegroupParentTable()) {
    LOG(INFO) << "Servicing IsDeleteTableDone request for tablegroup parent table id "
              << req->table_id() << ": deleting. Skipping wait for DELETED state.";
    resp->set_done(true);
    return Status::OK();
  }

  if (l->is_deleted() || l->is_hidden()5.96k) {
    LOG(INFO) << "Servicing IsDeleteTableDone request for table id "
              << req->table_id() << ": totally " << (l->is_hidden() ? "hidden"4 : "deleted"5.66k);
    resp->set_done(true);
  } else {
    LOG(INFO) << "Servicing IsDeleteTableDone request for table id " << req->table_id()
              << ((!table->IsColocatedUserTable()) ? ": deleting tablets"5.88k : ""79);

    std::vector<std::shared_ptr<TSDescriptor>> descs;
    master_->ts_manager()->GetAllDescriptors(&descs);
    for (auto& ts_desc : descs) {
      LOG(INFO) << "Deleting on " << ts_desc->permanent_uuid() << ": "
                << ts_desc->PendingTabletDeleteToString();
    }

    resp->set_done(false);
  }

  return Status::OK();
}

namespace {

CHECKED_STATUS ApplyAlterSteps(server::Clock* clock,
                               const TableId& table_id,
                               const SysTablesEntryPB& current_pb,
                               const AlterTableRequestPB* req,
                               Schema* new_schema,
                               ColumnId* next_col_id,
                               std::vector<DdlLogEntry>* ddl_log_entries) {
  const SchemaPB& current_schema_pb = current_pb.schema();
  Schema cur_schema;
  RETURN_NOT_OK(SchemaFromPB(current_schema_pb, &cur_schema));

  SchemaBuilder builder(cur_schema);
  if (current_pb.has_next_column_id()) {
    builder.set_next_column_id(ColumnId(current_pb.next_column_id()));
  }
  if (current_pb.has_colocated() && current_pb.colocated()6) {
    if (current_schema_pb.table_properties().is_ysql_catalog_table()) {
      Uuid cotable_id;
      RETURN_NOT_OK(cotable_id.FromHexString(req->table().table_id()));
      builder.set_cotable_id(cotable_id);
    }
    // Colocation ID is set in schema and cannot be altered.
  }

  for (const AlterTableRequestPB::Step& step : req->alter_schema_steps())580 {
    auto time = clock->Now();
    switch (step.type()) {
      case AlterTableRequestPB::ADD_COLUMN: {
        if (!step.has_add_column()) {
          return STATUS(InvalidArgument, "ADD_COLUMN missing column info");
        }

        // Verify that encoding is appropriate for the new column's type.
        ColumnSchemaPB new_col_pb = step.add_column().schema();
        if (new_col_pb.has_id()) {
          return STATUS_SUBSTITUTE(InvalidArgument,
              "column $0: client should not specify column id", new_col_pb.ShortDebugString());
        }
        ColumnSchema new_col = ColumnSchemaFromPB(new_col_pb);

        RETURN_NOT_OK(builder.AddColumn(new_col, false));
        ddl_log_entries->emplace_back(time, table_id, current_pb, Format("Add column $0", new_col));
        break;
      }

      case AlterTableRequestPB::DROP_COLUMN: {
        if (!step.has_drop_column()) {
          return STATUS(InvalidArgument, "DROP_COLUMN missing column info");
        }

        if (cur_schema.is_key_column(step.drop_column().name())) {
          return STATUS(InvalidArgument, "cannot remove a key column");
        }

        RETURN_NOT_OK(builder.RemoveColumn(step.drop_column().name()));
        ddl_log_entries->emplace_back(
            time, table_id, current_pb, Format("Drop column $0", step.drop_column().name()));
        break;
      }

      case AlterTableRequestPB::RENAME_COLUMN: {
        if (!step.has_rename_column()) {
          return STATUS(InvalidArgument, "RENAME_COLUMN missing column info");
        }

        RETURN_NOT_OK(builder.RenameColumn(
            step.rename_column().old_name(),
            step.rename_column().new_name()));
        ddl_log_entries->emplace_back(
            time, table_id, current_pb,
            Format("Rename column $0 => $1", step.rename_column().old_name(),
                   step.rename_column().new_name()));
        break;
      }

        // TODO: EDIT_COLUMN.

      default: {
        return STATUS_SUBSTITUTE(InvalidArgument, "Invalid alter step type: $0", step.type());
      }
    }
  }

  if (req->has_alter_properties()) {
    RETURN_NOT_OK(builder.AlterProperties(req->alter_properties()));
  }

  *new_schema = builder.Build();
  *next_col_id = builder.next_column_id();
  return Status::OK();
}

} // namespace

Status CatalogManager::AlterTable(const AlterTableRequestPB* req,
                                  AlterTableResponsePB* resp,
                                  rpc::RpcContext* rpc) {
  LOG_WITH_PREFIX(INFO) << "Servicing " << __func__ << " request from " << RequestorString(rpc)
                        << ": " << req->ShortDebugString();

  std::vector<DdlLogEntry> ddl_log_entries;

  // Lookup the table and verify if it exists.
  TRACE("Looking up table");
  scoped_refptr<TableInfo> table = VERIFY_RESULT(FindTable(req->table()));

  NamespaceId new_namespace_id;

  if (req->has_new_namespace()) {
    // Lookup the new namespace and verify if it exists.
    TRACE("Looking up new namespace");
    scoped_refptr<NamespaceInfo> ns;
    NamespaceIdentifierPB namespace_identifier = req->new_namespace();
    // Use original namespace_id as new_namespace_id for YSQL tables.
    if (table->GetTableType() == PGSQL_TABLE_TYPE && !namespace_identifier.has_id()115) {
      namespace_identifier.set_id(table->namespace_id());
    }
    ns = VERIFY_NAMESPACE_FOUND117(117FindNamespace(namespace_identifier), resp);

    auto ns_lock = ns->LockForRead();
    new_namespace_id = ns->id();
    // Don't use Namespaces that aren't running.
    if (ns->state() != SysNamespaceEntryPB::RUNNING) {
      Status s = STATUS_SUBSTITUTE(TryAgain,
          "Namespace not running (State=$0). Cannot create $1.$2",
          SysNamespaceEntryPB::State_Name(ns->state()), ns->name(), table->name() );
      return SetupError(resp->mutable_error(), NamespaceMasterError(ns->state()), s);
    }
  }
  if (req->has_new_namespace() || req->has_new_table_name()5.77k) {
    if (new_namespace_id.empty()) {
      const Status s = STATUS(InvalidArgument, "No namespace used");
      return SetupError(resp->mutable_error(), MasterErrorPB::NO_NAMESPACE_USED, s);
    }
  }

  TRACE("Locking table");
  auto l = table->LockForWrite();
  RETURN_NOT_OK(CheckIfTableDeletedOrNotVisibleToClient(l, resp));

  bool has_changes = false;
  auto& table_pb = l.mutable_data()->pb;
  const TableName table_name = l->name();
  const NamespaceId namespace_id = l->namespace_id();
  const TableName new_table_name = req->has_new_table_name() ? req->new_table_name()115 : table_name5.78k;

  // Calculate new schema for the on-disk state, not persisted yet.
  Schema new_schema;
  ColumnId next_col_id = ColumnId(l->pb.next_column_id());
  if (req->alter_schema_steps_size() || req->has_alter_properties()5.32k) {
    TRACE("Apply alter schema");
    Status s = ApplyAlterSteps(
        master_->clock(), table->id(), l->pb, req, &new_schema, &next_col_id, &ddl_log_entries);
    if (!s.ok()) {
      return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
    }
    DCHECK_NE(next_col_id, 0);
    DCHECK_EQ(new_schema.find_column_by_id(next_col_id),
              static_cast<int>(Schema::kColumnNotFound));
    has_changes = true;
  }

  // Try to acquire the new table name.
  if (req->has_new_namespace() || req->has_new_table_name()5.77k) {

    // Postgres handles name uniqueness constraints in it's own layer.
    if (l->table_type() != PGSQL_TABLE_TYPE) {
      LockGuard lock(mutex_);
      VLOG_WITH_FUNC0(3) << "Acquired the catalog manager lock"0;

      TRACE("Acquired catalog manager lock");

      // Verify that the table does not exist.
      scoped_refptr<TableInfo> other_table = FindPtrOrNull(
          table_names_map_, {new_namespace_id, new_table_name});
      if (other_table != nullptr) {
        Status s = STATUS_SUBSTITUTE(AlreadyPresent,
            "Object '$0.$1' already exists",
            GetNamespaceNameUnlocked(new_namespace_id), other_table->name());
        LOG(WARNING) << "Found table: " << other_table->ToStringWithState()
                     << ". Failed alterring table with error: "
                     << s.ToString() << " Request:\n" << req->DebugString();
        return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_ALREADY_PRESENT, s);
      }

      // Acquire the new table name (now we have 2 name for the same table).
      table_names_map_[{new_namespace_id, new_table_name}] = table;
    }

    table_pb.set_namespace_id(new_namespace_id);
    table_pb.set_name(new_table_name);

    has_changes = true;
  }

  // Check if there has been any changes to the placement policies for this table.
  if (req->has_replication_info()) {
    // If this is a colocated table, it does not make sense to set placement
    // policy for this table, as the tablet associated with it is shared by
    // multiple tables.
    if (table->colocated()) {
      const Status s = STATUS(InvalidArgument,
          "Placement policy cannot be altered for a colocated table");
      return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_REQUEST, s);
    }
    if (table->GetTableType() == PGSQL_TABLE_TYPE) {
      const Status s = STATUS(InvalidArgument,
            "Placement policy cannot be altered for YSQL tables, use Tablespaces");
      return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_REQUEST, s);
    }
    // Validate table replication info.
    RETURN_NOT_OK(ValidateTableReplicationInfo(req->replication_info()));
    table_pb.mutable_replication_info()->CopyFrom(req->replication_info());
    has_changes = true;
  }

  // TODO(hector): Simplify the AlterSchema workflow to avoid doing the same checks on every layer
  // this request goes through: https://github.com/YugaByte/yugabyte-db/issues/1882.
  if (req->has_wal_retention_secs()) {
    if (has_changes) {
      const Status s = STATUS(InvalidArgument,
          "wal_retention_secs cannot be altered concurrently with other properties");
      return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_REQUEST, s);
    }
    // TODO(hector): Handle co-partitioned tables:
    // https://github.com/YugaByte/yugabyte-db/issues/1905.
    table_pb.set_wal_retention_secs(req->wal_retention_secs());
    has_changes = true;
  }

  if (!has_changes) {
    if (req->has_force_send_alter_request() && req->force_send_alter_request()) {
      RETURN_NOT_OK(SendAlterTableRequest(table, req));
    }
    // Skip empty requests...
    return Status::OK();
  }

  // Serialize the schema Increment the version number.
  if (new_schema.initialized()) {
    if (!l->pb.has_fully_applied_schema()) {
      // The idea here is that if we are in the middle of updating the schema
      // from one state to another, then YBClients will be given the older
      // version until the schema is updated on all the tablets.
      // As of Dec 2019, this may lead to some rejected operations/retries during
      // the index backfill. See #3284 for possible optimizations.
      MultiStageAlterTable::CopySchemaDetailsToFullyApplied(&table_pb);
    }
    SchemaToPB(new_schema, table_pb.mutable_schema());
  }

  // Only increment the version number if it is a schema change (AddTable change goes through a
  // different path and it's not processed here).
  if (!req->has_wal_retention_secs()) {
    table_pb.set_version(table_pb.version() + 1);
    table_pb.set_updates_only_index_permissions(false);
  }
  table_pb.set_next_column_id(next_col_id);
  l.mutable_data()->set_state(
      SysTablesEntryPB::ALTERING,
      Substitute("Alter table version=$0 ts=$1", table_pb.version(), LocalTimeAsString()));

  // Update sys-catalog with the new table schema.
  TRACE("Updating metadata on disk");
  std::vector<const DdlLogEntry*> ddl_log_entry_pointers;
  ddl_log_entry_pointers.reserve(ddl_log_entries.size());
  for (const auto& entry : ddl_log_entries) {
    ddl_log_entry_pointers.push_back(&entry);
  }
  Status s = sys_catalog_->Upsert(leader_ready_term(), ddl_log_entry_pointers, table);
  if (!s.ok()) {
    s = s.CloneAndPrepend(
        Substitute("An error occurred while updating sys-catalog tables entry: $0",
                   s.ToString()));
    LOG(WARNING) << s.ToString();
    if (table->GetTableType() != PGSQL_TABLE_TYPE &&
        (0req->has_new_namespace()0 || req->has_new_table_name()0)) {
      LockGuard lock(mutex_);
      VLOG_WITH_FUNC(3) << "Acquired the catalog manager lock";
      CHECK_EQ(table_names_map_.erase({new_namespace_id, new_table_name}), 1);
    }
    // TableMetadaLock follows RAII paradigm: when it leaves scope,
    // 'l' will be unlocked, and the mutation will be aborted.
    return CheckIfNoLongerLeaderAndSetupError(s, resp);
  }

  // Remove the old name. Not present if PGSQL.
  if (table->GetTableType() != PGSQL_TABLE_TYPE &&
      (183req->has_new_namespace()183 || req->has_new_table_name()182)) {
    TRACE("Removing (namespace, table) combination ($0, $1) from by-name map",
          namespace_id, table_name);
    LockGuard lock(mutex_);
    table_names_map_.erase({namespace_id, table_name});
  }

  // Update the in-memory state.
  TRACE("Committing in-memory state");
  l.Commit();

  RETURN_NOT_OK(SendAlterTableRequest(table, req));

  // Increment transaction status version if needed.
  if (table->GetTableType() == TableType::TRANSACTION_STATUS_TABLE_TYPE) {
    RETURN_NOT_OK(IncrementTransactionTablesVersion());
  }

  LOG(INFO) << "Successfully initiated ALTER TABLE (pending tablet schema updates) for "
            << table->ToString() << " per request from " << RequestorString(rpc);
  return Status::OK();
}

Status CatalogManager::IsAlterTableDone(const IsAlterTableDoneRequestPB* req,
                                        IsAlterTableDoneResponsePB* resp) {
  // 1. Lookup the table and verify if it exists.
  TRACE("Looking up table");
  scoped_refptr<TableInfo> table = VERIFY_RESULT(FindTable(req->table()));

  TRACE("Locking table");
  auto l = table->LockForRead();
  RETURN_NOT_OK(CheckIfTableDeletedOrNotVisibleToClient(l, resp));

  // 2. Verify if the alter is in-progress.
  TRACE("Verify if there is an alter operation in progress for $0", table->ToString());
  resp->set_schema_version(l->pb.version());
  resp->set_done(l->pb.state() != SysTablesEntryPB::ALTERING);

  return Status::OK();
}

Result<TabletInfoPtr> CatalogManager::RegisterNewTabletForSplit(
    TabletInfo* source_tablet_info, const PartitionPB& partition,
    TableInfo::WriteLock* table_write_lock, TabletInfo::WriteLock* tablet_write_lock) {
  const auto tablet_lock = source_tablet_info->LockForRead();

  auto table = source_tablet_info->table();
  TabletInfoPtr new_tablet;
  {
    LockGuard lock(mutex_);
    new_tablet = CreateTabletInfo(table.get(), partition);
  }
  const auto& source_tablet_meta = tablet_lock->pb;

  auto& new_tablet_meta = new_tablet->mutable_metadata()->mutable_dirty()->pb;
  new_tablet_meta.set_state(SysTabletsEntryPB::CREATING);
  new_tablet_meta.mutable_committed_consensus_state()->CopyFrom(
      source_tablet_meta.committed_consensus_state());
  new_tablet_meta.set_split_depth(source_tablet_meta.split_depth() + 1);
  new_tablet_meta.set_split_parent_tablet_id(source_tablet_info->tablet_id());
  // TODO(tsplit): consider and handle failure scenarios, for example:
  // - Crash or leader failover before sending out the split tasks.
  // - Long enough partition while trying to send out the splits so that they timeout and
  //   not get executed.
  int new_partition_list_version;
  {
    LockGuard lock(mutex_);

    auto& table_pb = table_write_lock->mutable_data()->pb;
    new_partition_list_version = table_pb.partition_list_version() + 1;
    table_pb.set_partition_list_version(new_partition_list_version);

    tablet_write_lock->mutable_data()->pb.add_split_tablet_ids(new_tablet->id());
    RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), table, new_tablet, source_tablet_info));

    MAYBE_FAULT(FLAGS_TEST_crash_after_creating_single_split_tablet);

    table->AddTablet(new_tablet);
    // TODO: We use this pattern in other places, but what if concurrent thread accesses not yet
    // committed TabletInfo from the `table` ?
    new_tablet->mutable_metadata()->CommitMutation();

    auto tablet_map_checkout = tablet_map_.CheckOut();
    (*tablet_map_checkout)[new_tablet->id()] = new_tablet;
  }
  LOG(INFO) << "Registered new tablet " << new_tablet->tablet_id()
            << " (" << AsString(partition) << ") to split the tablet "
            << source_tablet_info->tablet_id()
            << " (" << AsString(source_tablet_meta.partition())
            << ") for table " << table->ToString()
            << ", new partition_list_version: " << new_partition_list_version;

  return new_tablet;
}

Status CatalogManager::GetTableSchema(const GetTableSchemaRequestPB* req,
                                      GetTableSchemaResponsePB* resp) {
  VLOG(1) << "Servicing GetTableSchema request for " << req->ShortDebugString()3;

  // Lookup the table and verify if it exists.
  TRACE("Looking up table");
  scoped_refptr<TableInfo> table = VERIFY_RESULT168k(FindTable(req->table()));168k

  // Due to differences in the way proxies handle version mismatch (pull for yql vs push for sql).
  // For YQL tables, we will return the "set of indexes" being applied instead of the ones
  // that are fully completed.
  // For PGSQL (and other) tables we want to return the fully applied schema.
  const bool get_fully_applied_indexes = table->GetTableType() != TableType::YQL_TABLE_TYPE;
  return GetTableSchemaInternal(req, resp, get_fully_applied_indexes);
}

Status CatalogManager::GetTableSchemaInternal(const GetTableSchemaRequestPB* req,
                                              GetTableSchemaResponsePB* resp,
                                              bool get_fully_applied_indexes) {
  VLOG(1) << "Servicing GetTableSchema request for " << req->ShortDebugString()10;

  // Lookup the table and verify if it exists.
  TRACE("Looking up table");
  scoped_refptr<TableInfo> table = VERIFY_RESULT(FindTable(req->table()));

  TRACE("Locking table");
  auto l = table->LockForRead();
  RETURN_NOT_OK(CheckIfTableDeletedOrNotVisibleToClient(l, resp));

  if (l->pb.has_fully_applied_schema()) {
    // An AlterTable is in progress; fully_applied_schema is the last
    // schema that has reached every TS.
    DCHECK(l->pb.state() == SysTablesEntryPB::ALTERING);
    resp->mutable_schema()->CopyFrom(l->pb.fully_applied_schema());
  } else {
    // There's no AlterTable, the regular schema is "fully applied".
    resp->mutable_schema()->CopyFrom(l->pb.schema());
  }

  if (get_fully_applied_indexes && l->pb.has_fully_applied_schema()93.9k) {
    resp->set_version(l->pb.fully_applied_schema_version());
    resp->mutable_indexes()->CopyFrom(l->pb.fully_applied_indexes());
    if (l->pb.has_fully_applied_index_info()) {
      resp->set_obsolete_indexed_table_id(GetIndexedTableId(l->pb));
      *resp->mutable_index_info() = l->pb.fully_applied_index_info();
    }
    VLOG(1) << "Returning"
            << "\nfully_applied_schema with version "
            << l->pb.fully_applied_schema_version()
            << ":\n"
            << yb::ToString(l->pb.fully_applied_indexes())
            << "\ninstead of schema with version "
            << l->pb.version()
            << ":\n"
            << yb::ToString(l->pb.indexes());
  } else {
    resp->set_version(l->pb.version());
    resp->mutable_indexes()->CopyFrom(l->pb.indexes());
    if (l->pb.has_index_info()) {
      resp->set_obsolete_indexed_table_id(GetIndexedTableId(l->pb));
      *resp->mutable_index_info() = l->pb.index_info();
    }
    VLOG(3) << "Returning"
            << "\nschema with version "
            << l->pb.version()
            << ":\n"
            << yb::ToString(l->pb.indexes());
  }
  resp->set_is_compatible_with_previous_version(l->pb.updates_only_index_permissions());
  resp->mutable_partition_schema()->CopyFrom(l->pb.partition_schema());
  if (IsReplicationInfoSet(l->pb.replication_info())) {
    resp->mutable_replication_info()->CopyFrom(l->pb.replication_info());
  }
  resp->set_create_table_done(!table->IsCreateInProgress());
  resp->set_table_type(table->metadata().state().pb.table_type());
  resp->mutable_identifier()->set_table_name(l->pb.name());
  resp->mutable_identifier()->set_table_id(table->id());
  resp->mutable_identifier()->mutable_namespace_()->set_id(table->namespace_id());
  auto nsinfo = FindNamespaceById(table->namespace_id());
  if (nsinfo.ok()169k) {
    resp->mutable_identifier()->mutable_namespace_()->set_name((**nsinfo).name());
  }

  if (l->pb.has_wal_retention_secs()) {
    resp->set_wal_retention_secs(l->pb.wal_retention_secs());
  }

  // Get namespace name by id.
  SharedLock lock(mutex_);
  TRACE("Looking up namespace");
  const scoped_refptr<NamespaceInfo> ns = FindPtrOrNull(namespace_ids_map_, table->namespace_id());

  if (ns == nullptr) {
    Status s = STATUS_SUBSTITUTE(
        NotFound, "Could not find namespace by namespace id $0 for request $1.",
        table->namespace_id(), req->DebugString());
    return SetupError(resp->mutable_error(), MasterErrorPB::NAMESPACE_NOT_FOUND, s);
  }

  resp->mutable_identifier()->mutable_namespace_()->set_name(ns->name());

  resp->set_colocated(table->colocated());

  VLOG(1) << "Serviced GetTableSchema request for " << req->ShortDebugString() << " with "
          << yb::ToString(*resp);
  return Status::OK();
}

Status CatalogManager::GetTablegroupSchema(const GetTablegroupSchemaRequestPB* req,
                                           GetTablegroupSchemaResponsePB* resp) {
  VLOG(1) << "Servicing GetTablegroupSchema request for " << req->ShortDebugString();
  if (!req->parent_tablegroup().has_id()) {
    Status s = STATUS(InvalidArgument, "Invalid get tablegroup request (missing fields)");
    return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
  }

  const std::string& tablegroupId = req->parent_tablegroup().id();
  if (!IsTablegroupParentTableId(tablegroupId)) {
    Status s = STATUS(InvalidArgument, "Received a non tablegroup ID");
    return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
  }

  // Strip the suffix from the tablegroup ID request (since tablegroup_ids_map_
  // only accepts the plain ID).
  DCHECK(boost::algorithm::ends_with(tablegroupId, master::kTablegroupParentTableIdSuffix));
  size_t tgid_len = tablegroupId.size() - strlen(master::kTablegroupParentTableIdSuffix);
  TablegroupId tgid = tablegroupId.substr(0, tgid_len);

  // Lookup the tablegroup.
  std::unordered_set<TableId> tablesInTablegroup;
  {
    SharedLock lock(mutex_);

    if (tablegroup_ids_map_.find(tgid) == tablegroup_ids_map_.end()) {
      return STATUS(NotFound, Substitute("Tablegroup not found for tablegroup id: $0",
                                         req->parent_tablegroup().id()));
    }
    scoped_refptr<TablegroupInfo> tginfo = tablegroup_ids_map_[tgid];
    tablesInTablegroup = tginfo->ChildTables();
  }

  for (const auto& t : tablesInTablegroup) {
    TRACE("Looking up table");
    GetTableSchemaRequestPB schemaReq;
    GetTableSchemaResponsePB schemaResp;
    schemaReq.mutable_table()->set_table_id(t);
    Status s = GetTableSchema(&schemaReq, &schemaResp);
    if (!s.ok() || schemaResp.has_error()) {
      LOG(ERROR) << "Error while getting table schema: " << s;
      return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_NOT_FOUND, s);
    }
    resp->add_get_table_schema_response_pbs()->Swap(&schemaResp);
  }

  return Status::OK();
}

Status CatalogManager::GetColocatedTabletSchema(const GetColocatedTabletSchemaRequestPB* req,
                                                GetColocatedTabletSchemaResponsePB* resp) {
  VLOG(1) << "Servicing GetColocatedTabletSchema request for " << req->ShortDebugString();

  // Lookup the given parent colocated table and verify if it exists.
  TRACE("Looking up table");
  auto parent_colocated_table = VERIFY_RESULT(FindTable(req->parent_colocated_table()));
  {
    TRACE("Locking table");
    auto l = parent_colocated_table->LockForRead();
    RETURN_NOT_OK(CheckIfTableDeletedOrNotVisibleToClient(l, resp));
  }

  if (!parent_colocated_table->colocated() || !parent_colocated_table->IsColocatedParentTable()) {
    return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_TABLE_TYPE,
                      STATUS(InvalidArgument, "Table provided is not a parent colocated table"));
  }

  // Next get all the user tables that are in the database.
  ListTablesRequestPB listTablesReq;
  ListTablesResponsePB ListTablesResp;

  listTablesReq.mutable_namespace_()->set_id(parent_colocated_table->namespace_id());
  listTablesReq.mutable_namespace_()->set_database_type(YQL_DATABASE_PGSQL);
  listTablesReq.set_exclude_system_tables(true);
  Status status = ListTables(&listTablesReq, &ListTablesResp);
  if (!status.ok() || ListTablesResp.has_error()) {
    LOG(ERROR) << "Error while listing tables: " << status;
    return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_NOT_FOUND, status);
  }

  // Get the table schema for each colocated table.
  for (const auto& t : ListTablesResp.tables()) {
    // Need to check if this table is colocated first.
    TRACE("Looking up table");
    scoped_refptr<TableInfo> table = VERIFY_RESULT(FindTableById(t.id()));

    if (table->colocated()) {
      // Now we can get the schema for this table.
      GetTableSchemaRequestPB schemaReq;
      GetTableSchemaResponsePB schemaResp;
      schemaReq.mutable_table()->set_table_id(t.id());
      status = GetTableSchema(&schemaReq, &schemaResp);
      if (!status.ok() || schemaResp.has_error()) {
        LOG(ERROR) << "Error while getting table schema: " << status;
        return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_NOT_FOUND, status);
      }
      resp->add_get_table_schema_response_pbs()->Swap(&schemaResp);
    }
  }

  return Status::OK();
}

Status CatalogManager::ListTables(const ListTablesRequestPB* req,
                                  ListTablesResponsePB* resp) {
  NamespaceId namespace_id;

  // Validate namespace.
  if (req->has_namespace_()) {
    // Lookup the namespace and verify if it exists.
    auto ns = VERIFY_NAMESPACE_FOUND(FindNamespace(req->namespace_()), resp);

    auto ns_lock = ns->LockForRead();
    namespace_id = ns->id();

    // Don't list tables with a namespace that isn't running.
    if (ns->state() != SysNamespaceEntryPB::RUNNING) {
      LOG(INFO) << "ListTables request for a Namespace not running (State="
                << SysNamespaceEntryPB::State_Name(ns->state()) << ")";
      return Status::OK();
    }
  }

  bool has_rel_filter = req->relation_type_filter_size() > 0;
  bool include_user_table = has_rel_filter ? false310 : true2.28k;
  bool include_user_index = has_rel_filter ? false310 : true2.28k;
  bool include_system_table = req->exclude_system_tables() ? false368
      : (2.22khas_rel_filter2.22k ? false310 : true1.91k);

  for (const auto &relation : req->relation_type_filter()) {
    if (relation == SYSTEM_TABLE_RELATION) {
      include_system_table = true;
    } else if (relation == USER_TABLE_RELATION) {
      include_user_table = true;
    } else if (1relation == INDEX_TABLE_RELATION1) {
      include_user_index = true;
    }
  }

  SharedLock lock(mutex_);
  RelationType relation_type;

  for (const auto& entry : *table_ids_map_) {
    auto& table_info = *entry.second;
    auto ltm = table_info.LockForRead();

    if (!ltm->visible_to_client() && !req->include_not_running()3.00k) {
      continue;
    }

    if (!namespace_id.empty() && namespace_id != table_info.namespace_id()182k) {
      continue; // Skip tables from other namespaces.
    }

    if (req->has_name_filter()) {
      size_t found = ltm->name().find(req->name_filter());
      if (found == string::npos) {
        continue;
      }
    }

    if (IsUserIndexUnlocked(table_info)) {
      if (!include_user_index) {
        continue;
      }
      relation_type = INDEX_TABLE_RELATION;
    } else if (IsUserTableUnlocked(table_info)) {
      if (!include_user_table) {
        continue;
      }
      relation_type = USER_TABLE_RELATION;
    } else {
      if (!include_system_table) {
        continue;
      }
      relation_type = SYSTEM_TABLE_RELATION;
    }

    NamespaceIdentifierPB ns_identifier;
    ns_identifier.set_id(ltm->namespace_id());
    auto ns = FindNamespaceUnlocked(ns_identifier);
    if (!ns.ok() || (**ns).state() != SysNamespaceEntryPB::RUNNING68.4k) {
      if (PREDICT_FALSE(FLAGS_TEST_return_error_if_namespace_not_found)) {
        VERIFY_NAMESPACE_FOUND0(0std::move(ns), resp);
      }
      LOG(ERROR) << "Unable to find namespace with id " << ltm->namespace_id()
                 << " for table " << ltm->name();
      continue;
    }

    ListTablesResponsePB::TableInfo *table = resp->add_tables();
    {
      auto namespace_lock = (**ns).LockForRead();
      table->mutable_namespace_()->set_id((**ns).id());
      table->mutable_namespace_()->set_name(namespace_lock->name());
      table->mutable_namespace_()->set_database_type(namespace_lock->pb.database_type());
    }
    table->set_id(entry.second->id());
    table->set_name(ltm->name());
    table->set_table_type(ltm->table_type());
    table->set_relation_type(relation_type);
    table->set_state(ltm->pb.state());
    table->set_pgschema_name(ltm->schema().pgschema_name());
  }
  return Status::OK();
}

boost::optional<TablegroupId> CatalogManager::FindTablegroupByTableId(const TableId& table_id) {
  SharedLock lock(mutex_);

  for (const auto& tablegroup : tablegroup_ids_map_) {
    const auto& tgid = tablegroup.first;
    const auto& tginfo = tablegroup.second;
    for (const auto& t : tginfo->ChildTables()) {
      if (table_id == t) {
        return boost::optional<TablegroupId>(tgid + kTablegroupParentTableIdSuffix);
      }
    }
  }

  return boost::none;
}

scoped_refptr<TableInfo> CatalogManager::GetTableInfo(const TableId& table_id) {
  SharedLock lock(mutex_);
  return FindPtrOrNull(*table_ids_map_, table_id);
}

scoped_refptr<TableInfo> CatalogManager::GetTableInfoFromNamespaceNameAndTableName(
    YQLDatabase db_type, const NamespaceName& namespace_name, const TableName& table_name) {
  if (db_type == YQL_DATABASE_PGSQL)
    return nullptr;
  SharedLock lock(mutex_);
  const auto ns = FindPtrOrNull(namespace_names_mapper_[db_type], namespace_name);
  return ns
    ? FindPtrOrNull(table_names_map_, {ns->id(), table_name})
    : nullptr;
}

scoped_refptr<TableInfo> CatalogManager::GetTableInfoUnlocked(const TableId& table_id) {
  return FindPtrOrNull(*table_ids_map_, table_id);
}

std::vector<TableInfoPtr> CatalogManager::GetTables(GetTablesMode mode) {
  std::vector<TableInfoPtr> result;
  {
    SharedLock lock(mutex_);
    result.reserve(table_ids_map_->size());
    for (const auto& e : *table_ids_map_) {
      result.push_back(e.second);
    }
  }
  switch (mode) {
    case GetTablesMode::kAll:
      return result;
    case GetTablesMode::kRunning: {
      auto filter = [](const TableInfoPtr& table_info) { return !table_info->is_running(); };
      EraseIf(filter, &result);
      return result;
    }
    case GetTablesMode::kVisibleToClient: {
      auto filter = [](const TableInfoPtr& table_info) {
        return !table_info->LockForRead()->visible_to_client();
      };
      EraseIf(filter, &result);
      return result;
    }
  }
  FATAL_INVALID_ENUM_VALUE(GetTablesMode, mode);
}

void CatalogManager::GetAllNamespaces(std::vector<scoped_refptr<NamespaceInfo>>* namespaces,
                                      bool includeOnlyRunningNamespaces) {
  namespaces->clear();
  SharedLock lock(mutex_);
  for (const NamespaceInfoMap::value_type& e : namespace_ids_map_) {
    if (includeOnlyRunningNamespaces && e.second->state() != SysNamespaceEntryPB::RUNNING55.8k) {
      continue;
    }
    namespaces->push_back(e.second);
  }
}

void CatalogManager::GetAllUDTypes(std::vector<scoped_refptr<UDTypeInfo>>* types) {
  types->clear();
  SharedLock lock(mutex_);
  for (const UDTypeInfoMap::value_type& e : udtype_ids_map_) {
    types->push_back(e.second);
  }
}

std::vector<std::shared_ptr<MonitoredTask>> CatalogManager::GetRecentTasks() {
  return tasks_tracker_->GetTasks();
}

std::vector<std::shared_ptr<MonitoredTask>> CatalogManager::GetRecentJobs() {
  return jobs_tracker_->GetTasks();
}

NamespaceName CatalogManager::GetNamespaceNameUnlocked(const NamespaceId& id) const  {
  const scoped_refptr<NamespaceInfo> ns = FindPtrOrNull(namespace_ids_map_, id);
  return ns == nullptr ? NamespaceName()4 : ns->name()25.2k;
}

NamespaceName CatalogManager::GetNamespaceName(const NamespaceId& id) const {
  TRACE("Acquired catalog manager lock");
  SharedLock lock(mutex_);
  return GetNamespaceNameUnlocked(id);
}

NamespaceName CatalogManager::GetNamespaceNameUnlocked(
    const scoped_refptr<TableInfo>& table) const  {
  return GetNamespaceNameUnlocked(table->namespace_id());
}

NamespaceName CatalogManager::GetNamespaceName(const scoped_refptr<TableInfo>& table) const {
  return GetNamespaceName(table->namespace_id());
}

bool CatalogManager::IsSystemTable(const TableInfo& table) const {
  return table.is_system();
}

// True if table is created by user.
// Table can be regular table or index in this case.
bool CatalogManager::IsUserCreatedTable(const TableInfo& table) const {
  SharedLock lock(mutex_);
  return IsUserCreatedTableUnlocked(table);
}

bool CatalogManager::IsUserCreatedTableUnlocked(const TableInfo& table) const {
  if (table.GetTableType() == PGSQL_TABLE_TYPE || table.GetTableType() == YQL_TABLE_TYPE59.8k) {
    if (!IsSystemTable(table) && !IsSequencesSystemTable(table)25.2k &&
        GetNamespaceNameUnlocked(table.namespace_id()) != kSystemNamespaceName25.2k &&
        !table.IsColocatedParentTable()24.7k &&
        !table.IsTablegroupParentTable()24.7k) {
      return true;
    }
  }
  return false;
}

bool CatalogManager::IsUserTable(const TableInfo& table) const {
  SharedLock lock(mutex_);
  return IsUserTableUnlocked(table);
}

bool CatalogManager::IsUserTableUnlocked(const TableInfo& table) const {
  return IsUserCreatedTableUnlocked(table) && table.indexed_table_id().empty()11.9k;
}

bool CatalogManager::IsUserIndex(const TableInfo& table) const {
  SharedLock lock(mutex_);
  return IsUserIndexUnlocked(table);
}

bool CatalogManager::IsUserIndexUnlocked(const TableInfo& table) const {
  return IsUserCreatedTableUnlocked(table) && !table.indexed_table_id().empty()12.0k;
}

bool CatalogManager::IsTablegroupParentTableId(const TableId& table_id) const {
  return table_id.find(kTablegroupParentTableIdSuffix) != std::string::npos;
}

bool CatalogManager::IsColocatedParentTableId(const TableId& table_id) const {
  return table_id.find(kColocatedParentTableIdSuffix) != std::string::npos;
}

bool CatalogManager::IsSequencesSystemTable(const TableInfo& table) const {
  if (table.GetTableType() == PGSQL_TABLE_TYPE && !table.IsColocatedParentTable()22.3k
                                               && !table.IsTablegroupParentTable()22.3k) {
    // This case commonly occurs during unit testing. Avoid unnecessary assert within Get().
    if (!IsPgsqlId(table.namespace_id()) || !IsPgsqlId(table.id())22.3k) {
      LOG(WARNING) << "Not PGSQL IDs " << table.namespace_id() << ", " << table.id();
      return false;
    }
    Result<uint32_t> database_oid = GetPgsqlDatabaseOid(table.namespace_id());
    if (!database_oid.ok()) {
      LOG(WARNING) << "Invalid Namespace ID " << table.namespace_id();
      return false;
    }
    Result<uint32_t> table_oid = GetPgsqlTableOid(table.id());
    if (!table_oid.ok()) {
      LOG(WARNING) << "Invalid Table ID " << table.id();
      return false;
    }
    if (*database_oid == kPgSequencesDataDatabaseOid && *table_oid == kPgSequencesDataTableOid0) {
      return true;
    }
  }
  return false;
}

void CatalogManager::NotifyTabletDeleteFinished(const TabletServerId& tserver_uuid,
                                                const TabletId& tablet_id,
                                                const TableInfoPtr& table) {
  shared_ptr<TSDescriptor> ts_desc;
  if (!master_->ts_manager()->LookupTSByUUID(tserver_uuid, &ts_desc)) {
    LOG(WARNING) << "Unable to find tablet server " << tserver_uuid;
  } else if (!ts_desc->IsTabletDeletePending(tablet_id)) {
    LOG(WARNING) << "Pending delete for tablet " << tablet_id << " in ts "
                 << tserver_uuid << " doesn't exist";
  } else {
    LOG(INFO) << "Clearing pending delete for tablet " << tablet_id << " in ts " << tserver_uuid;
    ts_desc->ClearPendingTabletDelete(tablet_id);
  }
  CheckTableDeleted(table);
}

bool CatalogManager::ReplicaMapDiffersFromConsensusState(const scoped_refptr<TabletInfo>& tablet,
                                                         const ConsensusStatePB& cstate) {
  auto locs = tablet->GetReplicaLocations();
  if (locs->size() != implicit_cast<size_t>(cstate.config().peers_size())) {
    return true;
  }
  for (auto iter = cstate.config().peers().begin(); 324kiter != cstate.config().peers().end(); iter++1.00M) {
      if (locs->find(iter->permanent_uuid()) == locs->end()) {
        return true;
      }
  }
  return false;
}

namespace {

int64_t GetCommittedConsensusStateOpIdIndex(const ReportedTabletPB& report) {
  if (!report.has_committed_consensus_state() ||
      !report.committed_consensus_state().config().has_opid_index()896k) {
    return consensus::kInvalidOpIdIndex;
  }

  return report.committed_consensus_state().config().opid_index();
}

} // namespace

bool CatalogManager::ProcessCommittedConsensusState(
    TSDescriptor* ts_desc,
    bool is_incremental,
    const ReportedTabletPB& report,
    const TableInfo::WriteLock& table_lock,
    const TabletInfoPtr& tablet,
    const TabletInfo::WriteLock& tablet_lock,
    std::vector<RetryingTSRpcTaskPtr>* rpcs) {
  const ConsensusStatePB& prev_cstate = tablet_lock->pb.committed_consensus_state();
  ConsensusStatePB cstate = report.committed_consensus_state();
  bool tablet_was_mutated = false;

  // 6a. The master only processes reports for replicas with committed
  // consensus configurations since it needs the committed index to only
  // cache the most up-to-date config. Since it's possible for TOMBSTONED
  // replicas with no ConsensusMetadata on disk to be reported as having no
  // committed config opid_index, we skip over those replicas.
  if (!cstate.config().has_opid_index()) {
    LOG(WARNING) << "Missing opid_index in reported config: " << report.ShortDebugString();
    return false;
  }
  if (PREDICT_TRUE(FLAGS_master_ignore_stale_cstate) &&
        (cstate.current_term() < prev_cstate.current_term() ||
         GetCommittedConsensusStateOpIdIndex(report) < prev_cstate.config().opid_index()445k)) {
    LOG(WARNING) << "Stale heartbeat for Tablet " << tablet->ToString()
                 << " on TS " << ts_desc->permanent_uuid()
                 << "cstate=" << cstate.ShortDebugString()
                 << ", prev_cstate=" << prev_cstate.ShortDebugString();
    return false;
  }

  // 6b. Disregard the leader state if the reported leader is not a member
  // of the committed config.
  if (cstate.leader_uuid().empty() ||
      !IsRaftConfigMember(cstate.leader_uuid(), cstate.config())276k) {
    cstate.clear_leader_uuid();
    tablet_was_mutated = true;
  }

  // 6c. Mark the tablet as RUNNING if it makes sense to do so.
  //
  // We need to wait for a leader before marking a tablet as RUNNING, or
  // else we could incorrectly consider a tablet created when only a
  // minority of its replicas were successful. In that case, the tablet
  // would be stuck in this bad state forever.
  // - FLAG added to avoid waiting during mock tests.
  if (!tablet_lock->is_running() &&
      report.state() == tablet::RUNNING205k &&
        (205kcstate.has_leader_uuid()205k ||
        !FLAGS_catalog_manager_wait_for_new_tablets_to_elect_leader157k)) {
    DCHECK_EQ(SysTabletsEntryPB::CREATING, tablet_lock->pb.state())
        << "Tablet in unexpected state: " << tablet->ToString()
        << ": " << tablet_lock->pb.ShortDebugString();
    VLOG(1) << "Tablet " << tablet->ToString() << " is now online"0;
    tablet_lock.mutable_data()->set_state(SysTabletsEntryPB::RUNNING,
        "Tablet reported with an active leader");
    tablet_was_mutated = true;
  }

  // 6d. Update the consensus state if:
  // - A config change operation was committed (reflected by a change to
  //   the committed config's opid_index).
  // - The new cstate has a leader, and either the old cstate didn't, or
  //   there was a term change.
  if (cstate.config().opid_index() > prev_cstate.config().opid_index() ||
      (432kcstate.has_leader_uuid()432k &&
          (271k!prev_cstate.has_leader_uuid()271k ||
              cstate.current_term() > prev_cstate.current_term()223k))) {

    // 6d(i). Retain knowledge of the leader even if it wasn't reported in
    // the latest config.
    //
    // When a config change is reported to the master, it may not include the
    // leader because the follower doing the reporting may not know who the
    // leader is yet (it may have just started up). It is safe to reuse
    // the previous leader if the reported cstate has the same term as the
    // previous cstate, and the leader was known for that term.
    if (cstate.current_term() == prev_cstate.current_term()) {
      if (!cstate.has_leader_uuid() && prev_cstate.has_leader_uuid()2) {
        cstate.set_leader_uuid(prev_cstate.leader_uuid());
        // Sanity check to detect consensus divergence bugs.
      } else if (cstate.has_leader_uuid() && prev_cstate.has_leader_uuid() &&
          cstate.leader_uuid() != prev_cstate.leader_uuid()5.64k) {
        string msg = Substitute("Previously reported cstate for tablet $0 gave "
                                "a different leader for term $1 than the current cstate. "
                                "Previous cstate: $2. Current cstate: $3.",
            tablet->ToString(), cstate.current_term(),
            prev_cstate.ShortDebugString(), cstate.ShortDebugString());
        LOG(DFATAL) << msg;
        return false;
      }
    }

    // 6d(ii). Delete any replicas from the previous config that are not in the new one.
    if (64.5kFLAGS_master_tombstone_evicted_tablet_replicas64.5k) {
      std::unordered_set<string> current_member_uuids;
      for (const consensus::RaftPeerPB &peer : cstate.config().peers()) {
        InsertOrDie(&current_member_uuids, peer.permanent_uuid());
      }
      for (const consensus::RaftPeerPB &prev_peer : prev_cstate.config().peers()) {
        const string& peer_uuid = prev_peer.permanent_uuid();
        if (!ContainsKey(current_member_uuids, peer_uuid)) {
          // Don't delete a tablet server that hasn't reported in yet (Bootstrapping).
          shared_ptr<TSDescriptor> dummy_ts_desc;
          if (!master_->ts_manager()->LookupTSByUUID(peer_uuid, &dummy_ts_desc)) {
            continue;
          }
          // Otherwise, the TabletServer needs to remove this peer.
          rpcs->push_back(std::make_shared<AsyncDeleteReplica>(
              master_, AsyncTaskPool(), peer_uuid, tablet->table(), tablet->tablet_id(),
              TABLET_DATA_TOMBSTONED, prev_cstate.config().opid_index(),
              Substitute("TS $0 not found in new config with opid_index $1",
                  peer_uuid, cstate.config().opid_index())));
        }
      }
    }
    // 6d(iii). Update the in-memory ReplicaLocations for this tablet using the new config.
    VLOG(2) << "Updating replicas for tablet " << tablet->tablet_id()
          << " using config reported by " << ts_desc->permanent_uuid()
          << " to that committed in log index " << cstate.config().opid_index()
          << " with leader state from term " << cstate.current_term();
    ReconcileTabletReplicasInLocalMemoryWithReport(
      tablet, ts_desc->permanent_uuid(), cstate, report);

    // 6d(iv). Update the consensus state. Don't use 'prev_cstate' after this.
    LOG(INFO) << "Tablet: " << tablet->tablet_id() << " reported consensus state change."
              << " New consensus state: " << cstate.ShortDebugString()
              << " from " << ts_desc->permanent_uuid();
    *tablet_lock.mutable_data()->pb.mutable_committed_consensus_state() = cstate;
    tablet_was_mutated = true;
  } else {
    // Report opid_index is equal to the previous opid_index. If some
    // replica is reporting the same consensus configuration we already know about, but we
    // haven't yet heard from all the tservers in the config, update the in-memory
    // ReplicaLocations.
    LOG(INFO) << "Peer " << ts_desc->permanent_uuid() << " sent "
              << (is_incremental ? "incremental"370k : "full tablet"2.47k)
              << " report for " << tablet->tablet_id()
              << ", prev state op id: " << prev_cstate.config().opid_index()
              << ", prev state term: " << prev_cstate.current_term()
              << ", prev state has_leader_uuid: " << prev_cstate.has_leader_uuid()
              << ". Consensus state: " << cstate.ShortDebugString();
    if (GetAtomicFlag(&FLAGS_enable_register_ts_from_raft) &&
        ReplicaMapDiffersFromConsensusState(tablet, cstate)373k) {
       ReconcileTabletReplicasInLocalMemoryWithReport(
         tablet, ts_desc->permanent_uuid(), cstate, report);
    } else {
      UpdateTabletReplicaInLocalMemory(ts_desc, &cstate, report, tablet);
    }
  }

  if (FLAGS_use_create_table_leader_hint &&
      !cstate.has_leader_uuid()436k && cstate.current_term() == 0160k) {
    StartElectionIfReady(cstate, tablet.get());
  }

  // 7. Send an AlterSchema RPC if the tablet has an old schema version.
  if (report.has_schema_version() &&
      report.schema_version() != table_lock->pb.version()437k) {
    if (report.schema_version() > table_lock->pb.version()) {
      LOG(ERROR) << "TS " << ts_desc->permanent_uuid()
                 << " has reported a schema version greater than the current one "
                 << " for tablet " << tablet->ToString()
                 << ". Expected version " << table_lock->pb.version()
                 << " got " << report.schema_version()
                 << " (corruption)";
    } else {
      // TODO: For Alter (rolling apply to tablets), this is an expected transitory state.
      LOG(INFO) << "TS " << ts_desc->permanent_uuid()
                << " does not have the latest schema for tablet " << tablet->ToString()
                << ". Expected version " << table_lock->pb.version()
                << " got " << report.schema_version();
    }
    // It's possible that the tablet being reported is a laggy replica, and in fact
    // the leader has already received an AlterTable RPC. That's OK, though --
    // it'll safely ignore it if we send another.
    TransactionId txn_id = TransactionId::Nil();
    if (table_lock->pb.has_transaction() &&
        table_lock->pb.transaction().has_transaction_id()39) {
      LOG(INFO) << "Parsing transaction ID for tablet ID " << tablet->tablet_id();
      auto txn_id_res = FullyDecodeTransactionId(table_lock->pb.transaction().transaction_id());
      if (!txn_id_res.ok()) {
        LOG(WARNING) << "Parsing transaction ID failed for tablet ID " << tablet->tablet_id();
        return false;
      }
      txn_id = txn_id_res.get();
    }
    LOG(INFO) << "Triggering AlterTable with transaction ID " << txn_id
              << " due to heartbeat delay for tablet ID " << tablet->tablet_id();
    rpcs->push_back(std::make_shared<AsyncAlterTable>(
        master_, AsyncTaskPool(), tablet, tablet->table(), txn_id));
  }

  return tablet_was_mutated;
}

Status CatalogManager::ProcessTabletReportBatch(
    TSDescriptor* ts_desc,
    bool is_incremental,
    ReportedTablets::const_iterator begin,
    ReportedTablets::const_iterator end,
    TabletReportUpdatesPB* full_report_update,
    std::vector<RetryingTSRpcTaskPtr>* rpcs) {
  // 1. First Pass. Iterate in TabletId Order to discover all Table locks we'll need. Even though
  //    read locks are sufficient here, take write locks since we'll be writing to the tablet while
  //    holding this.
  //    Need to acquire both types of locks in Id order to prevent deadlock.
  std::map<TableId, TableInfo::WriteLock> table_write_locks;
  for (auto it = begin; it != end; ++it452k) {
    auto& lock = table_write_locks[it->info->table()->id()];
    if (!lock.locked()) {
      lock = it->info->table()->LockForWrite();
    }
  }

  map<TabletId, TabletInfo::WriteLock> tablet_write_locks; // used for unlock.
  // 2. Second Pass.  Process each tablet. This may not be in the order that the tablets
  // appear in 'full_report', but that has no bearing on correctness.
  vector<TabletInfo*> mutated_tablets; // refcount protected by 'tablet_infos'
  for (auto it = begin; it != end; ++it454k) {
    const auto& tablet_id = it->tablet_id;
    const TabletInfoPtr& tablet = it->info;
    const ReportedTabletPB& report = *it->report;
    const TableInfoPtr& table = tablet->table();

    // Prepare an heartbeat response entry for this tablet, now that we're going to process it.
    // Every tablet in the report that is processed gets one, even if there are no changes to it.
    ReportedTabletUpdatesPB* update = full_report_update->add_tablets();
    update->set_tablet_id(tablet_id);

    // Get tablet lock on demand.  This works in the batch case because the loop is ordered.
    tablet_write_locks[tablet_id] = tablet->LockForWrite();
    auto& table_lock = table_write_locks[table->id()];
    auto& tablet_lock = tablet_write_locks[tablet_id];

    TRACE_EVENT1("master", "HandleReportedTablet", "tablet_id", report.tablet_id());
    RETURN_NOT_OK_PREPEND(CheckIsLeaderAndReady(),
        Substitute("This master is no longer the leader, unable to handle report for tablet $0",
            tablet_id));

    VLOG(3) << "tablet report: " << report.ShortDebugString();

    // 3. Delete the tablet if it (or its table) have been deleted.
    if (tablet_lock->is_deleted() ||
        table_lock->started_deleting()) {
      const string msg = tablet_lock->pb.state_msg();
      update->set_state_msg(msg);
      LOG(INFO) << "Got report from deleted tablet " << tablet->ToString()
                << " (" << msg << "): Sending delete request for this tablet";
      // TODO(unknown): Cancel tablet creation, instead of deleting, in cases
      // where that might be possible (tablet creation timeout & replacement).
      rpcs->push_back(std::make_shared<AsyncDeleteReplica>(
          master_, AsyncTaskPool(), ts_desc->permanent_uuid(), table, tablet_id,
          TABLET_DATA_DELETED, boost::none, msg));
      ts_desc->AddPendingTabletDelete(tablet_id);
      continue;
    }

    if (!table_lock->is_running()) {
      const string msg = tablet_lock->pb.state_msg();
      LOG(INFO) << "Got report from tablet " << tablet->tablet_id()
                << " for non-running table " << table->ToString() << ": " << msg;
      update->set_state_msg(msg);
      continue;
    }

    // 3. Tombstone a replica that is no longer part of the Raft config (and
    // not already tombstoned or deleted outright).
    //
    // If the report includes a committed raft config, we only tombstone if
    // the opid_index is strictly less than the latest reported committed
    // config. This prevents us from spuriously deleting replicas that have
    // just been added to the committed config and are in the process of copying.
    const ConsensusStatePB& prev_cstate = tablet_lock->pb.committed_consensus_state();
    const int64_t prev_opid_index = prev_cstate.config().opid_index();
    const int64_t report_opid_index = GetCommittedConsensusStateOpIdIndex(report);
    if (FLAGS_master_tombstone_evicted_tablet_replicas &&
        report.tablet_data_state() != TABLET_DATA_TOMBSTONED &&
        report.tablet_data_state() != TABLET_DATA_DELETED &&
        report_opid_index < prev_opid_index &&
        !IsRaftConfigMember(ts_desc->permanent_uuid(), prev_cstate.config())11.0k) {
      const string delete_msg = (report_opid_index == consensus::kInvalidOpIdIndex) ?
          "Replica has no consensus available" :
          Substitute("Replica with old config index $0", report_opid_index)165;
      rpcs->push_back(std::make_shared<AsyncDeleteReplica>(
          master_, AsyncTaskPool(), ts_desc->permanent_uuid(), table, tablet_id,
          TABLET_DATA_TOMBSTONED, prev_opid_index,
          Substitute("$0 (current committed config index is $1)",
              delete_msg, prev_opid_index)));
      ts_desc->AddPendingTabletDelete(tablet_id);
      continue;
    }

    // 4. Skip a non-deleted tablet which reports an error.
    if (report.has_error()) {
      Status s = StatusFromPB(report.error());
      DCHECK(!s.ok());
      DCHECK_EQ(report.state(), tablet::FAILED);
      LOG(WARNING) << "Tablet " << tablet->ToString() << " has failed on TS "
                   << ts_desc->permanent_uuid() << ": " << s.ToString();
      continue;
    }

    // Hide the tablet if it (or its table) has been hidden and the tablet hasn't.
    if ((tablet_lock->is_hidden() ||
        table_lock->started_hiding()) &&
        report.has_is_hidden()0 &&
        !report.is_hidden()0) {
      const string msg = tablet_lock->pb.state_msg();
      LOG(INFO) << "Got report from hidden tablet " << tablet->ToString()
                << " (" << msg << "): Sending hide request for this tablet";
      auto task = std::make_shared<AsyncDeleteReplica>(
          master_, AsyncTaskPool(), ts_desc->permanent_uuid(), table, tablet_id,
          TABLET_DATA_DELETED, boost::none, msg);
      task->set_hide_only(true);
      ts_desc->AddPendingTabletDelete(tablet_id);
      rpcs->push_back(task);
    }

    // 5. Process the report's consensus state.
    // The report will not have a committed_consensus_state if it is in the
    // middle of starting up, such as during tablet bootstrap.
    // If we received an incremental report, and the tablet is starting up, we will update the
    // replica so that the balancer knows how many tablets are in the middle of remote bootstrap.
    if (report.has_committed_consensus_state()) {
      if (ProcessCommittedConsensusState(
              ts_desc, is_incremental, report, table_lock, tablet, tablet_lock, rpcs)) {
        // 6. If the tablet was mutated, add it to the tablets to be re-persisted.
        //
        // Done here and not on a per-mutation basis to avoid duplicate entries.
        mutated_tablets.push_back(tablet.get());
      }
    } else if (3.40kis_incremental3.40k &&
        (report.state() == tablet::NOT_STARTED || report.state() == tablet::BOOTSTRAPPING613)) {
      // When a tablet server is restarted, it sends a full tablet report with all of its tablets
      // in the NOT_STARTED state, so this would make the load balancer think that all the
      // tablets are being remote bootstrapped at once, so only process incremental reports here.
      UpdateTabletReplicaInLocalMemory(ts_desc, nullptr /* consensus */, report, tablet);
    }
  } // Finished one round of batch processing.

  // 7. Unlock the tables; we no longer need to access their state.
  for (auto& l : table_write_locks)453k {
    l.second.Unlock();
  }
  table_write_locks.clear();

  // 8. Write all tablet mutations to the catalog table.
  //
  // SysCatalogTable::Write will short-circuit the case where the data has not
  // in fact changed since the previous version and avoid any unnecessary mutations.
  if (!mutated_tablets.empty()) {
    Status s = sys_catalog_->Upsert(leader_ready_term(), mutated_tablets);
    if (!s.ok()) {
      LOG(WARNING) << "Error updating tablets: " << s;
      return s;
    }
  }
  // Filter the mutated tablets to find which tablets were modified. Need to actually commit the
  // state of the tablets before updating the system.partitions table, so get this first.
  vector<TabletInfoPtr> yql_partitions_mutated_tablets =
      VERIFY_RESULT(GetYqlPartitionsVtable().FilterRelevantTablets(mutated_tablets));

  // 9. Publish the in-memory tablet mutations and release the locks.
  for (auto& l : tablet_write_locks) {
    l.second.Commit();
  }
  tablet_write_locks.clear();

  // Update the relevant tablet entries in system.partitions.
  if (!yql_partitions_mutated_tablets.empty()) {
    Status s = GetYqlPartitionsVtable()
        .ProcessMutatedTablets(yql_partitions_mutated_tablets, tablet_write_locks);
  }

  // 10. Third Pass. Process all tablet schema version changes.
  // (This is separate from tablet state mutations because only table on-disk state is changed.)
  for (auto it = begin; it != end; ++it454k) {
    const ReportedTabletPB& report = *it->report;
    if (!report.has_schema_version()) {
      continue;
    }
    const TabletInfoPtr& tablet = it->info;
    auto leader = tablet->GetLeader();
    if (leader.ok() && leader.get()->permanent_uuid() == ts_desc->permanent_uuid()296k) {
      RETURN_NOT_OK(HandleTabletSchemaVersionReport(tablet.get(), report.schema_version()));
    }
  }

  return Status::OK();
}

Status CatalogManager::ProcessTabletReport(TSDescriptor* ts_desc,
                                           const TabletReportPB& full_report,
                                           TabletReportUpdatesPB* full_report_update,
                                           RpcContext* rpc) {
  int num_tablets = full_report.updated_tablets_size();
  TRACE_EVENT2("master", "ProcessTabletReport",
               "requestor", rpc->requestor_string(),
               "num_tablets", num_tablets);

  VLOG_WITH_PREFIX2.50k(2) << "Received tablet report from " << RequestorString(rpc) << "("
                      << ts_desc->permanent_uuid() << "): " << full_report.DebugString();

  if (!ts_desc->has_tablet_report() && full_report.is_incremental()16.4k) {
    LOG_WITH_PREFIX(WARNING)
        << "Invalid tablet report from " << ts_desc->permanent_uuid()
        << ": Received an incremental tablet report when a full one was needed";
    // We should respond with success in order to send reply that we need full report.
    return Status::OK();
  }

  // TODO: on a full tablet report, we may want to iterate over the tablets we think
  // the server should have, compare vs the ones being reported, and somehow mark
  // any that have been "lost" (eg somehow the tablet metadata got corrupted or something).

  ReportedTablets reported_tablets;

  // Tablet Deletes to process after the catalog lock below.
  set<TabletId> tablets_to_delete;

  {
    // Lock the catalog to iterate over tablet_ids_map_ & table_ids_map_.
    SharedLock lock(mutex_);

    // Fill the above variables before processing
    full_report_update->mutable_tablets()->Reserve(num_tablets);
    for (const ReportedTabletPB& report : full_report.updated_tablets()) {
      const string& tablet_id = report.tablet_id();

      // 1a. Find the tablet, deleting/skipping it if it can't be found.
      scoped_refptr<TabletInfo> tablet = FindPtrOrNull(*tablet_map_, tablet_id);
      if (!tablet) {
        // If a TS reported an unknown tablet, send a delete tablet rpc to the TS.
        LOG(INFO) << "Null tablet reported, possibly the TS was not around when the"
                      " table was being deleted. Sending Delete tablet RPC to this TS.";
        tablets_to_delete.insert(tablet_id);
        // Every tablet in the report that is processed gets a heartbeat response entry.
        ReportedTabletUpdatesPB* update = full_report_update->add_tablets();
        update->set_tablet_id(tablet_id);
        continue;
      }
      if (!tablet->table() || FindOrNull(*table_ids_map_, tablet->table()->id()) == nullptr454k) {
        auto table_id = tablet->table() == nullptr ? "(null)" : tablet->table()->id();
        LOG(INFO) << "Got report from an orphaned tablet " << tablet_id << " on table " << table_id;
        tablets_to_delete.insert(tablet_id);
        // Every tablet in the report that is processed gets a heartbeat response entry.
        ReportedTabletUpdatesPB* update = full_report_update->add_tablets();
        update->set_tablet_id(tablet_id);
        continue;
      }

      // 1b. Found the tablet, update local state.
      reported_tablets.push_back(ReportedTablet {
        .tablet_id = tablet_id,
        .info = tablet,
        .report = &report,
      });
    }
  }

  std::sort(reported_tablets.begin(), reported_tablets.end(), [](const auto& lhs, const auto& rhs) {
    return lhs.tablet_id < rhs.tablet_id;
  });

  // Process any delete requests from orphaned tablets, identified above.
  for (auto tablet_id : tablets_to_delete) {
    SendDeleteTabletRequest(tablet_id, TABLET_DATA_DELETED, boost::none, nullptr, ts_desc,
        "Report from an orphaned tablet");
  }

  // Calculate the deadline for this expensive loop coming up.
  const auto safe_deadline = rpc->GetClientDeadline() -
    (FLAGS_heartbeat_rpc_timeout_ms * 1ms * FLAGS_heartbeat_safe_deadline_ratio);

  // Process tablets by batches.
  for (auto tablet_iter = reported_tablets.begin(); tablet_iter != reported_tablets.end();) {
    auto batch_begin = tablet_iter;
    tablet_iter += std::min<size_t>(
        reported_tablets.end() - tablet_iter, FLAGS_catalog_manager_report_batch_size);

    // Keeps track of all RPCs that should be sent when we're done with a single batch.
    std::vector<RetryingTSRpcTaskPtr> rpcs;
    auto status = ProcessTabletReportBatch(
        ts_desc, full_report.is_incremental(), batch_begin, tablet_iter, full_report_update, &rpcs);
    if (!status.ok()) {
      for (auto& rpc : rpcs) {
        rpc->AbortAndReturnPrevState(status);
      }
      return status;
    }

    // 13. Send all queued RPCs.
    for (auto& rpc : rpcs) {
      DCHECK(rpc->table());
      rpc->table()->AddTask(rpc);
      WARN_NOT_OK(ScheduleTask(rpc), Substitute("Failed to send $0", rpc->description()));
    }
    rpcs.clear();

    // 14. Check deadline. Need to exit before processing all batches if we're close to timing out.
    if (ts_desc->HasCapability(CAPABILITY_TabletReportLimit) &&
        tablet_iter != reported_tablets.end()) {
      // [TESTING] Inject latency before processing a batch to test deadline.
      if (PREDICT_FALSE(FLAGS_TEST_inject_latency_during_tablet_report_ms > 0)) {
        LOG(INFO) << "Sleeping in CatalogManager::ProcessTabletReport for "
                  << FLAGS_TEST_inject_latency_during_tablet_report_ms << " ms";
        SleepFor(MonoDelta::FromMilliseconds(FLAGS_TEST_inject_latency_during_tablet_report_ms));
      }

      // Return from here at configured safe heartbeat deadline to give the response packet time.
      if (safe_deadline < CoarseMonoClock::Now()) {
        LOG(INFO) << "Reached Heartbeat deadline. Returning early after processing "
                  << full_report_update->tablets_size() << " tablets";
        full_report_update->set_processing_truncated(true);
        return Status::OK();
      }
    }
  } // Loop to process the next batch until fully iterated.

  if (!full_report.is_incremental()) {
    // A full report may take multiple heartbeats.
    // The TS communicates how much is left to process for the full report beyond this specific HB.
    bool completed_full_report = !full_report.has_remaining_tablet_count()
                               || full_report.remaining_tablet_count() == 0;
    if (full_report.updated_tablets_size() == 0) {
      LOG(INFO) << ts_desc->permanent_uuid() << " sent full tablet report with 0 tablets.";
    } else if (206!ts_desc->has_tablet_report()206) {
      LOG(INFO) << ts_desc->permanent_uuid()
                << (completed_full_report ? " finished" : " receiving"0) << " first full report: "
                << full_report.updated_tablets_size() << " tablets.";
    }
    // We have a tablet report only once we're done processing all the chunks of the initial report.
    ts_desc->set_has_tablet_report(completed_full_report);
  }

  // 14. Queue background processing if we had updates.
  if (full_report.updated_tablets_size() > 0) {
    background_tasks_->WakeIfHasPendingUpdates();
  }

  return Status::OK();
}

Status CatalogManager::CreateTablegroup(const CreateTablegroupRequestPB* req,
                                        CreateTablegroupResponsePB* resp,
                                        rpc::RpcContext* rpc) {

  CreateTableRequestPB ctreq;
  CreateTableResponsePB ctresp;

  // Sanity check for PB fields.
  if (!req->has_id() || !req->has_namespace_id() || !req->has_namespace_name()) {
    Status s = STATUS(InvalidArgument, "Improper CREATE TABLEGROUP request (missing fields).");
    return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
  }

  // Use the tablegroup id as the prefix for the parent table id.
  const auto parent_table_id = req->id() + kTablegroupParentTableIdSuffix;
  const auto parent_table_name = req->id() + kTablegroupParentTableNameSuffix;
  ctreq.set_name(parent_table_name);
  ctreq.set_table_id(parent_table_id);
  ctreq.mutable_namespace_()->set_name(req->namespace_name());
  ctreq.mutable_namespace_()->set_id(req->namespace_id());
  ctreq.set_table_type(PGSQL_TABLE_TYPE);
  ctreq.set_tablegroup_id(req->id());
  ctreq.set_tablespace_id(req->tablespace_id());

  YBSchemaBuilder schemaBuilder;
  schemaBuilder.AddColumn("parent_column")->Type(BINARY)->PrimaryKey()->NotNull();
  YBSchema ybschema;
  CHECK_OK(schemaBuilder.Build(&ybschema));
  auto schema = yb::client::internal::GetSchema(ybschema);
  SchemaToPB(schema, ctreq.mutable_schema());
  if (!FLAGS_TEST_tablegroup_master_only) {
    ctreq.mutable_schema()->mutable_table_properties()->set_is_transactional(true);
  }

  // Create a parent table, which will create the tablet.
  Status s = CreateTable(&ctreq, &ctresp, rpc);
  resp->set_parent_table_id(ctresp.table_id());
  resp->set_parent_table_name(parent_table_name);

  // Carry over error.
  if (ctresp.has_error()) {
    resp->mutable_error()->Swap(ctresp.mutable_error());
  }

  // We do not lock here so it is technically possible that the table was already created.
  // If so, there is nothing to do so we just ignore the "AlreadyPresent" error.
  if (!s.ok() && !s.IsAlreadyPresent()2) {
    LOG(WARNING) << "Tablegroup creation failed: " << s.ToString();
    return s;
  }

  // Update catalog manager maps
  LockGuard lock(mutex_);
  TRACE("Acquired catalog manager lock");
  TablegroupInfo *tg = new TablegroupInfo(req->id(), req->namespace_id());
  tablegroup_ids_map_[req->id()] = tg;
  table_tablegroup_ids_map_[parent_table_id] = tg->id();

  return s;
}

Status CatalogManager::DeleteTablegroup(const DeleteTablegroupRequestPB* req,
                                        DeleteTablegroupResponsePB* resp,
                                        rpc::RpcContext* rpc) {
  LOG(INFO) << "Servicing DeleteTablegroup request from " << RequestorString(rpc) << ": "
            << req->ShortDebugString();
  DeleteTableRequestPB dtreq;
  DeleteTableResponsePB dtresp;

  // Sanity check for PB fields
  if (!req->has_id() || !req->has_namespace_id()) {
    Status s = STATUS(InvalidArgument, "Improper DELETE TABLEGROUP request (missing fields).");
    return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
  }

  // Use the tablegroup id as the prefix for the parent table id.
  const auto parent_table_id = req->id() + kTablegroupParentTableIdSuffix;
  const auto parent_table_name = req->id() + kTablegroupParentTableNameSuffix;

  dtreq.mutable_table()->set_table_name(parent_table_name);
  dtreq.mutable_table()->set_table_id(parent_table_id);
  dtreq.set_is_index_table(false);

  {
    SharedLock lock(mutex_);
    const auto& tablegroup = tablegroup_ids_map_[req->id()];
    // Tablegroup should be empty. In practice that means it would contain only the
    // dummy parent table.
    // TODO(alex): Rework tablegroup internals to track real tables.
    if (tablegroup->NumChildTables() > 1) {
      return SetupError(
          resp->mutable_error(),
          MasterErrorPB::INVALID_REQUEST,
          STATUS_FORMAT(InvalidArgument,
                        "Cannot delete tablegroup, it still has $0 tables in it",
                        tablegroup->NumChildTables() - 1));
    }
  }

  Status s = DeleteTable(&dtreq, &dtresp, rpc);
  resp->set_parent_table_id(dtresp.table_id());

  // Carry over error.
  if (dtresp.has_error()) {
    resp->mutable_error()->Swap(dtresp.mutable_error());
    return s;
  }

  // Perform map updates.
  LockGuard lock(mutex_);
  TRACE("Acquired catalog manager lock");
  tablegroup_ids_map_.erase(req->id());
  tablegroup_tablet_ids_map_[req->namespace_id()].erase(req->id());
  table_tablegroup_ids_map_.erase(parent_table_id);

  LOG(INFO) << "Deleted tablegroup " << req->id();
  return s;
}

Status CatalogManager::ListTablegroups(const ListTablegroupsRequestPB* req,
                                       ListTablegroupsResponsePB* resp,
                                       rpc::RpcContext* rpc) {
  SharedLock lock(mutex_);

  if (!req->has_namespace_id()) {
    Status s = STATUS(InvalidArgument, "Improper ListTablegroups request (missing fields).");
    return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_SCHEMA, s);
  }

  if (tablegroup_tablet_ids_map_.find(req->namespace_id()) == tablegroup_tablet_ids_map_.end()) {
    return STATUS(NotFound, "Tablegroups not found for namespace id: ", req->namespace_id());
  }

  for (const auto& entry : tablegroup_tablet_ids_map_[req->namespace_id()])7 {
    const TablegroupId tgid = entry.first;
    if (tablegroup_ids_map_.find(tgid) == tablegroup_ids_map_.end()) {
      LOG(WARNING) << "Tablegroup info in " << req->namespace_id()
                   << " not found for tablegroup id: " << tgid;
      continue;
    }
    scoped_refptr<TablegroupInfo> tginfo = tablegroup_ids_map_[tgid];

    TablegroupIdentifierPB *tg = resp->add_tablegroups();
    tg->set_id(tginfo->id());
    tg->set_namespace_id(tginfo->namespace_id());
  }
  return Status::OK();
}

bool CatalogManager::HasTablegroups() {
  SharedLock lock(mutex_);
  return !tablegroup_ids_map_.empty();
}

Status CatalogManager::CreateNamespace(const CreateNamespaceRequestPB* req,
                                       CreateNamespaceResponsePB* resp,
                                       rpc::RpcContext* rpc) {
  Status return_status;

  // Copy the request, so we can fill in some defaults.
  LOG(INFO) << "CreateNamespace from " << RequestorString(rpc)
            << ": " << req->DebugString();

  scoped_refptr<NamespaceInfo> ns;
  std::vector<scoped_refptr<TableInfo>> pgsql_tables;
  TransactionMetadata txn;
  const auto db_type = GetDatabaseType(*req);
  {
    LockGuard lock(mutex_);
    TRACE("Acquired catalog manager lock");

    // Validate the user request.

    // Verify that the namespace does not already exist.
    ns = FindPtrOrNull(namespace_ids_map_, req->namespace_id()); // Same ID.
    if (ns == nullptr && db_type != YQL_DATABASE_PGSQL) {
      // PGSQL databases have name uniqueness handled at a different layer, so ignore overlaps.
      ns = FindPtrOrNull(namespace_names_mapper_[db_type], req->name());
    }
    if (ns != nullptr) {
      resp->set_id(ns->id());
      return_status = STATUS_SUBSTITUTE(AlreadyPresent, "Keyspace '$0' already exists",
                                        req->name());
      LOG(WARNING) << "Found keyspace: " << ns->id() << ". Failed creating keyspace with error: "
                   << return_status.ToString() << " Request:\n" << req->DebugString();
      return SetupError(resp->mutable_error(), MasterErrorPB::NAMESPACE_ALREADY_PRESENT,
                        return_status);
    }

    // Add the new namespace.

    // Create unique id for this new namespace.
    NamespaceId new_id = !req->namespace_id().empty()
        ? req->namespace_id()229 : GenerateIdUnlocked(SysRowEntryType::NAMESPACE)2.41k;
    ns = new NamespaceInfo(new_id);
    ns->mutable_metadata()->StartMutation();
    SysNamespaceEntryPB *metadata = &ns->mutable_metadata()->mutable_dirty()->pb;
    metadata->set_name(req->name());
    metadata->set_database_type(db_type);
    metadata->set_colocated(req->colocated());
    metadata->set_state(SysNamespaceEntryPB::PREPARING);

    // For namespace created for a Postgres database, save the list of tables and indexes for
    // for the database that need to be copied.
    if (db_type == YQL_DATABASE_PGSQL) {
      if (req->source_namespace_id().empty()) {
        metadata->set_next_pg_oid(req->next_pg_oid());
      } else {
        const auto source_oid = GetPgsqlDatabaseOid(req->source_namespace_id());
        if (!source_oid.ok()) {
          return SetupError(resp->mutable_error(), MasterErrorPB::NAMESPACE_NOT_FOUND,
                            source_oid.status());
        }
        for (const auto& iter : *table_ids_map_)123 {
          const auto& table_id = iter.first;
          const auto& table = iter.second;
          if (IsPgsqlId(table_id) && CHECK_RESULT75.2k(GetPgsqlDatabaseOid(table_id)) == *source_oid75.2k) {
            // Since indexes have dependencies on the base tables, put the tables in the front.
            const bool is_table = table->indexed_table_id().empty();
            pgsql_tables.insert(is_table ? pgsql_tables.begin()8.75k : pgsql_tables.end()6.81k, table);
          }
        }

        scoped_refptr<NamespaceInfo> source_ns = FindPtrOrNull(namespace_ids_map_,
                                                               req->source_namespace_id());
        if (!source_ns) {
          return SetupError(resp->mutable_error(), MasterErrorPB::NAMESPACE_NOT_FOUND,
                            STATUS(NotFound, "Source keyspace not found",
                                   req->source_namespace_id()));
        }
        auto source_ns_lock = source_ns->LockForRead();
        metadata->set_next_pg_oid(source_ns_lock->pb.next_pg_oid());
      }
    }

    // NS with a Transaction should be rolled back if the transaction does not get Committed.
    // Store this on the NS for now and use it later.
    if (req->has_transaction() && PREDICT_TRUE114(FLAGS_enable_transactional_ddl_gc)) {
      metadata->mutable_transaction()->CopyFrom(req->transaction());
      txn = VERIFY_RESULT(TransactionMetadata::FromPB(req->transaction()));
      RSTATUS_DCHECK(!txn.status_tablet.empty(), Corruption, "Given incomplete Transaction");
    }

    // Add the namespace to the in-memory map for the assignment.
    namespace_ids_map_[ns->id()] = ns;
    namespace_names_mapper_[db_type][req->name()] = ns;

    resp->set_id(ns->id());
  }
  TRACE("Inserted new keyspace info into CatalogManager maps");

  // Update the on-disk system catalog.
  return_status = sys_catalog_->Upsert(leader_ready_term(), ns);
  if (!return_status.ok()) {
    LOG(WARNING) << "Keyspace creation failed:" << return_status.ToString();
    {
      LockGuard lock(mutex_);
      namespace_ids_map_.erase(ns->id());
      namespace_names_mapper_[db_type].erase(req->name());
    }
    ns->mutable_metadata()->AbortMutation();
    return CheckIfNoLongerLeaderAndSetupError(return_status, resp);
  }
  TRACE("Wrote keyspace to sys-catalog");
  // Commit the namespace in-memory state.
  ns->mutable_metadata()->CommitMutation();

  LOG(INFO) << "Created keyspace " << ns->ToString();

  if (req->has_creator_role_name()) {
    RETURN_NOT_OK(permissions_manager_->GrantPermissions(
        req->creator_role_name(),
        get_canonical_keyspace(req->name()),
        req->name() /* resource name */,
        req->name() /* keyspace name */,
        all_permissions_for_resource(ResourceType::KEYSPACE),
        ResourceType::KEYSPACE,
        resp));
  }

  // Colocated databases need to create a parent tablet to serve as the base storage location.
  if (req->colocated()) {
    CreateTableRequestPB req;
    CreateTableResponsePB resp;
    const auto parent_table_id = ns->id() + kColocatedParentTableIdSuffix;
    const auto parent_table_name = ns->id() + kColocatedParentTableNameSuffix;
    req.set_name(parent_table_name);
    req.set_table_id(parent_table_id);
    req.mutable_namespace_()->set_name(ns->name());
    req.mutable_namespace_()->set_id(ns->id());
    req.set_table_type(GetTableTypeForDatabase(ns->database_type()));
    req.set_colocated(true);

    YBSchemaBuilder schemaBuilder;
    schemaBuilder.AddColumn("parent_column")->Type(BINARY)->PrimaryKey()->NotNull();
    YBSchema ybschema;
    CHECK_OK(schemaBuilder.Build(&ybschema));
    auto schema = yb::client::internal::GetSchema(ybschema);
    SchemaToPB(schema, req.mutable_schema());
    req.mutable_schema()->mutable_table_properties()->set_is_transactional(true);

    // create a parent table, which will create the tablet.
    Status s = CreateTable(&req, &resp, rpc);
    // We do not lock here so it is technically possible that the table was already created.
    // If so, there is nothing to do so we just ignore the "AlreadyPresent" error.
    if (!s.ok() && !s.IsAlreadyPresent()0) {
      LOG(WARNING) << "Keyspace creation failed:" << s.ToString();
      // TODO: We should verify this behavior works end-to-end.
      // Diverging in-memory state from disk so the user can issue a delete if no new leader.
      auto l = ns->LockForWrite();
      SysNamespaceEntryPB& metadata = ns->mutable_metadata()->mutable_dirty()->pb;
      metadata.set_state(SysNamespaceEntryPB::FAILED);
      l.Commit();
      return s;
    }
  }

  if ((db_type == YQL_DATABASE_PGSQL && !pgsql_tables.empty()254) ||
      PREDICT_FALSE2.51k(GetAtomicFlag(&FLAGS_TEST_hang_on_namespace_transition))) {
    // Process the subsequent work in the background thread (normally PGSQL).
    LOG(INFO) << "Keyspace create enqueued for later processing: " << ns->ToString();
    RETURN_NOT_OK(background_tasks_thread_pool_->SubmitFunc(
        std::bind(&CatalogManager::ProcessPendingNamespace, this, ns->id(), pgsql_tables, txn)));
    return Status::OK();
  } else {
    // All work is done, it's now safe to online the namespace (normally YQL).
    auto l = ns->LockForWrite();
    SysNamespaceEntryPB& metadata = ns->mutable_metadata()->mutable_dirty()->pb;
    if (metadata.state() == SysNamespaceEntryPB::PREPARING) {
      metadata.set_state(SysNamespaceEntryPB::RUNNING);
      return_status = sys_catalog_->Upsert(leader_ready_term(), ns);
      if (!return_status.ok()) {
        // Diverging in-memory state from disk so the user can issue a delete if no new leader.
        LOG(WARNING) << "Keyspace creation failed:" << return_status.ToString();
        metadata.set_state(SysNamespaceEntryPB::FAILED);
        return_status = CheckIfNoLongerLeaderAndSetupError(return_status, resp);
      } else {
        TRACE("Activated keyspace in sys-catalog");
        LOG(INFO) << "Activated keyspace: " << ns->ToString();
      }
      // Commit the namespace in-memory state.
      l.Commit();
    } else {
      LOG(WARNING) << "Keyspace has invalid state (" << metadata.state() << "), aborting create";
    }
  }
  return return_status;
}

void CatalogManager::ProcessPendingNamespace(
    NamespaceId id,
    std::vector<scoped_refptr<TableInfo>> template_tables,
    TransactionMetadata txn) {
  LOG(INFO) << "ProcessPendingNamespace started for " << id;

  // Ensure that we are currently the Leader before handling DDL operations.
  {
    SCOPED_LEADER_SHARED_LOCK(l, this);
    if (!l.catalog_status().ok()) {
      LOG(WARNING) << "Catalog status failure: " << l.catalog_status().ToString();
      // Don't try again, we have to reset in-memory state after losing leader election.
      return;
    }
    if (!l.leader_status().ok()) {
      LOG(WARNING) << "Leader status failure: " << l.leader_status().ToString();
      // Don't try again, we have to reset in-memory state after losing leader election.
      return;
    }
  }

  if (PREDICT_FALSE(GetAtomicFlag(&FLAGS_TEST_hang_on_namespace_transition))) {
    LOG(INFO) << "Artificially waiting (" << FLAGS_catalog_manager_bg_task_wait_ms
              << "ms) on namespace creation for " << id;
    SleepFor(MonoDelta::FromMilliseconds(FLAGS_catalog_manager_bg_task_wait_ms));
    WARN_NOT_OK(background_tasks_thread_pool_->SubmitFunc(
        std::bind(&CatalogManager::ProcessPendingNamespace, this, id, template_tables, txn)),
        "Could not submit ProcessPendingNamespaces to thread pool");
    return;
  }

  scoped_refptr<NamespaceInfo> ns;
  {
    LockGuard lock(mutex_);
    ns = FindPtrOrNull(namespace_ids_map_, id);;
  }
  if (ns == nullptr) {
    LOG(WARNING) << "Pending Namespace not found to finish creation: " << id;
    return;
  }

  // Copy the system tables necessary to create this namespace.  This can be time-intensive.
  bool success = true;
  if (!template_tables.empty()) {
    auto s = CopyPgsqlSysTables(ns->id(), template_tables);
    WARN_NOT_OK(s, "Error Copying PGSQL System Tables for Pending Namespace");
    success = s.ok();
  }

  // All work is done, change the namespace state regardless of success or failure.
  {
    auto l = ns->LockForWrite();
    SysNamespaceEntryPB& metadata = ns->mutable_metadata()->mutable_dirty()->pb;
    if (metadata.state() == SysNamespaceEntryPB::PREPARING) {
      metadata.set_state(success ? SysNamespaceEntryPB::RUNNING123 : SysNamespaceEntryPB::FAILED1);
      auto s = sys_catalog_->Upsert(leader_ready_term(), ns);
      if (s.ok()) {
        TRACE("Done processing keyspace");
        LOG(INFO) << (success ? "Processed" : "Failed"0) << " keyspace: " << ns->ToString();

        // Verify Transaction gets committed, which occurs after namespace create finishes.
        if (success && metadata.has_transaction()) {
          LOG(INFO) << "Enqueuing keyspace for Transaction Verification: " << ns->ToString();
          std::function<Status(bool)> when_done =
              std::bind(&CatalogManager::VerifyNamespacePgLayer, this, ns, _1);
          WARN_NOT_OK(background_tasks_thread_pool_->SubmitFunc(
              std::bind(&YsqlTransactionDdl::VerifyTransaction, ysql_transaction_.get(),
                        txn, when_done)),
              "Could not submit VerifyTransaction to thread pool");
        }
      } else {
        metadata.set_state(SysNamespaceEntryPB::FAILED);
        if (s.IsIllegalState() || s.IsAborted()) {
          s = STATUS(ServiceUnavailable,
              "operation requested can only be executed on a leader master, but this"
              " master is no longer the leader", s.ToString());
        } else {
          s = s.CloneAndPrepend(Substitute(
              "An error occurred while modifying keyspace to $0 in sys-catalog: $1",
              metadata.state(), s.ToString()));
        }
        LOG(WARNING) << s.ToString();
      }
      // Commit the namespace in-memory state.
      l.Commit();
    } else {
      LOG(WARNING) << "Bad keyspace state (" << metadata.state()
                   << "), abandoning creation work for " << ns->ToString();
    }
  }
}

Status CatalogManager::VerifyNamespacePgLayer(
    scoped_refptr<NamespaceInfo> ns, bool rpc_success) {
  // Upon Transaction completion, check pg system table using OID to ensure SUCCESS.
  const auto pg_table_id = GetPgsqlTableId(atoi(kSystemNamespaceId), kPgDatabaseTableOid);
  auto entry_exists = VERIFY_RESULT(
      ysql_transaction_->PgEntryExists(pg_table_id, GetPgsqlDatabaseOid(ns->id())));
  auto l = ns->LockForWrite();
  SysNamespaceEntryPB& metadata = ns->mutable_metadata()->mutable_dirty()->pb;

  // #5981: Mark un-retryable rpc failures as pass to avoid infinite retry of GC'd txns.
  bool txn_check_passed = entry_exists || !rpc_success2;

  if (txn_check_passed) {
    // Passed checks.  Remove the transaction from the entry since we're done processing it.
    SCHECK_EQ(metadata.state(), SysNamespaceEntryPB::RUNNING, Aborted,
              Substitute("Invalid Namespace state ($0), abandoning transaction GC work for $1",
                 SysNamespaceEntryPB_State_Name(metadata.state()), ns->ToString()));
    metadata.clear_transaction();
    RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), ns));
    if (entry_exists) {
      LOG(INFO) << "Namespace transaction succeeded: " << ns->ToString();
    } else {
      LOG(WARNING) << "Unknown RPC Failure, removing transaction on namespace: " << ns->ToString();
    }
    // Commit the namespace in-memory state.
    l.Commit();
  } else {
    // Transaction failed.  We need to delete this Database now.
    SCHECK(metadata.state() == SysNamespaceEntryPB::RUNNING ||
           metadata.state() == SysNamespaceEntryPB::FAILED, Aborted,
           Substitute("Invalid Namespace state ($0), aborting delete.",
                      SysNamespaceEntryPB_State_Name(metadata.state()), ns->ToString()));
    LOG(INFO) << "Namespace transaction failed, deleting: " << ns->ToString();
    metadata.set_state(SysNamespaceEntryPB::DELETING);
    metadata.clear_transaction();
    RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), ns));
    // Commit the namespace in-memory state.
    l.Commit();
    // Async enqueue delete.
    RETURN_NOT_OK(background_tasks_thread_pool_->SubmitFunc(
        std::bind(&CatalogManager::DeleteYsqlDatabaseAsync, this, ns)));
  }
  return Status::OK();
}

// Get the information about an in-progress create operation.
Status CatalogManager::IsCreateNamespaceDone(const IsCreateNamespaceDoneRequestPB* req,
                                             IsCreateNamespaceDoneResponsePB* resp) {
  auto ns_pb = req->namespace_();

  // 1. Lookup the namespace and verify it exists.
  TRACE("Looking up keyspace");
  auto ns = VERIFY_NAMESPACE_FOUND(FindNamespace(ns_pb), resp);

  TRACE("Locking keyspace");
  auto l = ns->LockForRead();
  auto metadata = l->pb;

  switch (metadata.state()) {
    // Success cases. Done and working.
    case SysNamespaceEntryPB::RUNNING:
      if (!ns->colocated()) {
        resp->set_done(true);
      } else {
        // Verify system table created as well, if colocated.
        IsCreateTableDoneRequestPB table_req;
        IsCreateTableDoneResponsePB table_resp;
        const auto parent_table_id = ns->id() + kColocatedParentTableIdSuffix;
        table_req.mutable_table()->set_table_id(parent_table_id);
        auto s = IsCreateTableDone(&table_req, &table_resp);
        resp->set_done(table_resp.done());
        if (!s.ok()) {
          if (table_resp.has_error()) {
            resp->mutable_error()->Swap(table_resp.mutable_error());
          }
          return s;
        }
      }
      break;
    // These states indicate that a create completed but a subsequent remove was requested.
    case SysNamespaceEntryPB::DELETING:
    case SysNamespaceEntryPB::DELETED:
      resp->set_done(true);
      break;
    // Pending cases.  NOT DONE
    case SysNamespaceEntryPB::PREPARING:
      resp->set_done(false);
      break;
    // Failure cases.  Done, but we need to give the user an error message.
    case SysNamespaceEntryPB::FAILED:
      resp->set_done(true);
      return SetupError(resp->mutable_error(), MasterErrorPB::UNKNOWN_ERROR, STATUS(InternalError,
              "Namespace Create Failed: not onlined."));
    default:
      Status s = STATUS_SUBSTITUTE(IllegalState, "IsCreateNamespaceDone failure: state=$0",
                                   SysNamespaceEntryPB_State_Name(metadata.state()));
      LOG(WARNING) << s.ToString();
      resp->set_done(true);
      return SetupError(resp->mutable_error(), MasterErrorPB::UNKNOWN_ERROR, s);
  }

  return Status::OK();
}

Status CatalogManager::DeleteNamespace(const DeleteNamespaceRequestPB* req,
                                       DeleteNamespaceResponsePB* resp,
                                       rpc::RpcContext* rpc) {
  auto status = DoDeleteNamespace(req, resp, rpc);
  if (!status.ok()) {
    return SetupError(resp->mutable_error(), status);
  }
  return status;
}

Status CatalogManager::DoDeleteNamespace(const DeleteNamespaceRequestPB* req,
                                         DeleteNamespaceResponsePB* resp,
                                         rpc::RpcContext* rpc) {
  LOG(INFO) << "Servicing DeleteNamespace request from " << RequestorString(rpc)
            << ": " << req->ShortDebugString();

  // Lookup the namespace and verify if it exists.
  TRACE("Looking up keyspace");
  auto ns = VERIFY_RESULT1.64k(FindNamespace(req->namespace_()));1.64k

  if (req->has_database_type() && req->database_type() != ns->database_type()74) {
    // Could not find the right database to delete.
    return STATUS(NotFound, "Keyspace not found", ns->name(),
                  MasterError(MasterErrorPB::NAMESPACE_NOT_FOUND));
  }
  {
    // Don't allow deletion if the namespace is in a transient state.
    auto cur_state = ns->state();
    if (cur_state != SysNamespaceEntryPB::RUNNING && cur_state != SysNamespaceEntryPB::FAILED11) {
      if (cur_state == SysNamespaceEntryPB::DELETED) {
        return STATUS(NotFound, "Keyspace already deleted", ns->name(),
                      MasterError(MasterErrorPB::NAMESPACE_NOT_FOUND));
      } else {
        return STATUS_EC_FORMAT(
            TryAgain, MasterError(MasterErrorPB::IN_TRANSITION_CAN_RETRY),
            "Namespace deletion not allowed when State = $0",
            SysNamespaceEntryPB::State_Name(cur_state));
      }
    }
  }

  // PGSQL has a completely forked implementation because it allows non-empty namespaces on delete.
  if (ns->database_type() == YQL_DATABASE_PGSQL) {
    return DeleteYsqlDatabase(req, resp, rpc);
  }

  TRACE("Locking keyspace");
  auto l = ns->LockForWrite();

  // Only empty namespace can be deleted.
  TRACE("Looking for tables in the keyspace");
  {
    SharedLock lock(mutex_);
    VLOG_WITH_FUNC0(3) << "Acquired the catalog manager lock"0;

    for (const TableInfoMap::value_type& entry : *table_ids_map_) {
      auto ltm = entry.second->LockForRead();

      if (!ltm->started_deleting() && ltm->namespace_id() == ns->id()29.9k) {
        return STATUS_EC_FORMAT(
            InvalidArgument, MasterError(MasterErrorPB::NAMESPACE_IS_NOT_EMPTY),
            "Cannot delete keyspace which has $0: $1 [id=$2], request: $3",
            IsTable(ltm->pb) ? "table" : "index", ltm->name(), entry.second->id(),
            req->ShortDebugString());
      }
    }

    // Only empty namespace can be deleted.
    TRACE("Looking for types in the keyspace");

    for (const UDTypeInfoMap::value_type& entry : udtype_ids_map_) {
      auto ltm = entry.second->LockForRead();

      if (ltm->namespace_id() == ns->id()) {
        return STATUS_EC_FORMAT(
            InvalidArgument, MasterError(MasterErrorPB::NAMESPACE_IS_NOT_EMPTY),
            "Cannot delete keyspace which has type: $0 [id=$1], request: $2",
            ltm->name(), entry.second->id(), req->ShortDebugString());
      }
    }
  }

  // Disallow deleting namespaces with snapshot schedules.
  auto map = VERIFY_RESULT(MakeSnapshotSchedulesToObjectIdsMap(SysRowEntryType::NAMESPACE));
  for (const auto& schedule_and_objects : map) {
    for (const auto& id : schedule_and_objects.second) {
      if (id == ns->id()) {
        return STATUS_EC_FORMAT(
            InvalidArgument, MasterError(MasterErrorPB::NAMESPACE_IS_NOT_EMPTY),
            "Cannot delete keyspace which has schedule: $0, request: $1",
            schedule_and_objects.first, req->ShortDebugString());
      }
    }
  }

  // [Delete]. Skip the DELETING->DELETED state, since no tables are present in this namespace.
  TRACE("Updating metadata on disk");
  // Update sys-catalog.
  Status s = sys_catalog_->Delete(leader_ready_term(), ns);
  if (!s.ok()) {
    // The mutation will be aborted when 'l' exits the scope on early return.
    s = s.CloneAndPrepend("An error occurred while updating sys-catalog");
    LOG(WARNING) << s;
    return CheckIfNoLongerLeader(s);
  }

  // Update the in-memory state.
  TRACE("Committing in-memory state");
  l.Commit();

  // Remove the namespace from all CatalogManager mappings.
  {
    LockGuard lock(mutex_);
    if (namespace_names_mapper_[ns->database_type()].erase(ns->name()) < 1) {
      LOG(WARNING) << Format("Could not remove namespace from names map, id=$1", ns->id());
    }
    if (namespace_ids_map_.erase(ns->id()) < 1) {
      LOG(WARNING) << Format("Could not remove namespace from ids map, id=$1", ns->id());
    }
  }

  // Delete any permissions granted on this keyspace to any role. See comment in DeleteTable() for
  // more details.
  string canonical_resource = get_canonical_keyspace(req->namespace_().name());
  RETURN_NOT_OK(permissions_manager_->RemoveAllPermissionsForResource(canonical_resource, resp));

  LOG(INFO) << "Successfully deleted keyspace " << ns->ToString()
            << " per request from " << RequestorString(rpc);
  return Status::OK();
}

void CatalogManager::DeleteYcqlDatabaseAsync(scoped_refptr<NamespaceInfo> database) {
  TRACE("Locking keyspace");
  auto l = database->LockForWrite();

  // Only empty namespace can be deleted.
  TRACE("Looking for tables in the keyspace");
  {
    SharedLock lock(mutex_);
    VLOG_WITH_FUNC(3) << "Acquired the catalog manager lock";

    for (const TableInfoMap::value_type& entry : *table_ids_map_) {
      auto ltm = entry.second->LockForRead();

      if (!ltm->started_deleting() && ltm->namespace_id() == database->id()) {
        LOG(WARNING) << "Cannot delete keyspace which has " << ltm->name()
          << " with id=" << entry.second->id();
        return;
      }
    }
  }

  // Only empty namespace can be deleted.
  TRACE("Looking for types in the keyspace");
  {
    SharedLock lock(mutex_);
    VLOG_WITH_FUNC(3) << "Acquired the catalog manager lock";

    for (const UDTypeInfoMap::value_type& entry : udtype_ids_map_) {
      auto ltm = entry.second->LockForRead();

      if (ltm->namespace_id() == database->id()) {
        LOG(WARNING) << "Cannot delete keyspace which has type: " << ltm->name()
          << " with id=" << entry.second->id();
        return;
      }
    }
  }

  // [Delete]. Skip the DELETING->DELETED state, since no tables are present in this namespace.
  TRACE("Updating metadata on disk");
  // Update sys-catalog.
  Status s = sys_catalog_->Delete(leader_ready_term(), database);
  if (!s.ok()) {
    // The mutation will be aborted when 'l' exits the scope on early return.
    s = s.CloneAndPrepend(Substitute("An error occurred while updating sys-catalog: $0",
                                     s.ToString()));
    LOG(WARNING) << s.ToString();
    return;
  }

  // Update the in-memory state.
  TRACE("Committing in-memory state");
  l.Commit();

  // Remove the namespace from all CatalogManager mappings.
  {
    LockGuard lock(mutex_);
    namespace_names_mapper_[database->database_type()].erase(database->name());
    if (namespace_ids_map_.erase(database->id()) < 1) {
      LOG(WARNING) << Format("Could not remove namespace from maps, id=$1", database->id());
    }
  }

  // Delete any permissions granted on this keyspace to any role. See comment in DeleteTable() for
  // more details.
  string canonical_resource = get_canonical_keyspace(database->name());
  DeleteNamespaceResponsePB resp;
  s = permissions_manager_->RemoveAllPermissionsForResource(canonical_resource, &resp);
  if (s.ok()) {
    LOG(INFO) << "Successfully deleted keyspace " << database->ToString();
  } else {
    LOG(WARNING) << "Error deleting keyspace " << database->ToString() << ": " << s;
  }
}

Status CatalogManager::DeleteYsqlDatabase(const DeleteNamespaceRequestPB* req,
                                          DeleteNamespaceResponsePB* resp,
                                          rpc::RpcContext* rpc) {
  // Lookup database.
  auto database = VERIFY_NAMESPACE_FOUND(FindNamespace(req->namespace_()), resp);

  // Make sure this is a YSQL database.
  if (database->database_type() != YQL_DATABASE_PGSQL) {
    // A non-YSQL namespace is found, but the rpc requests to drop a YSQL database.
    Status s = STATUS(NotFound, "YSQL database not found", database->name());
    return SetupError(resp->mutable_error(), MasterErrorPB::NAMESPACE_NOT_FOUND, s);
  }

  // Set the Namespace to DELETING.
  TRACE("Locking database");
  auto l = database->LockForWrite();
  SysNamespaceEntryPB &metadata = database->mutable_metadata()->mutable_dirty()->pb;
  if (metadata.state() == SysNamespaceEntryPB::RUNNING ||
      metadata.state() == SysNamespaceEntryPB::FAILED9) {
    metadata.set_state(SysNamespaceEntryPB::DELETING);
    RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), database));
    TRACE("Marked keyspace for deletion in sys-catalog");
    // Commit the namespace in-memory state.
    l.Commit();
  } else {
    Status s = STATUS_SUBSTITUTE(IllegalState,
        "Keyspace ($0) has invalid state ($1), aborting delete",
        database->name(), metadata.state());
    return SetupError(resp->mutable_error(), MasterErrorPB::INTERNAL_ERROR, s);
  }

  return background_tasks_thread_pool_->SubmitFunc(
    std::bind(&CatalogManager::DeleteYsqlDatabaseAsync, this, database));
}

void CatalogManager::DeleteYsqlDatabaseAsync(scoped_refptr<NamespaceInfo> database) {
  TEST_PAUSE_IF_FLAG(TEST_hang_on_namespace_transition);

  // Lock database before removing content.
  TRACE("Locking database");
  auto l = database->LockForWrite();
  SysNamespaceEntryPB &metadata = database->mutable_metadata()->mutable_dirty()->pb;

  // A DELETED Namespace has finished but was tombstoned to avoid immediately reusing the same ID.
  // We consider a restart enough time, so we just need to remove it from the SysCatalog.
  if (metadata.state() == SysNamespaceEntryPB::DELETED) {
    Status s = sys_catalog_->Delete(leader_ready_term(), database);
    WARN_NOT_OK(s, "SysCatalog DeleteItem for Namespace");
    if (!s.ok()) {
      return;
    }
  } else if (metadata.state() == SysNamespaceEntryPB::DELETING) {
    // Delete all tables in the database.
    TRACE("Delete all tables in YSQL database");
    Status s = DeleteYsqlDBTables(database);
    WARN_NOT_OK(s, "DeleteYsqlDBTables failed");
    if (!s.ok()) {
      // Move to FAILED so DeleteNamespace can be reissued by the user.
      metadata.set_state(SysNamespaceEntryPB::FAILED);
      l.Commit();
      return;
    }

    // Once all user-facing data has been offlined, move the Namespace to DELETED state.
    metadata.set_state(SysNamespaceEntryPB::DELETED);
    s = sys_catalog_->Upsert(leader_ready_term(), database);
    WARN_NOT_OK(s, "SysCatalog Update for Namespace");
    if (!s.ok()) {
      // Move to FAILED so DeleteNamespace can be reissued by the user.
      metadata.set_state(SysNamespaceEntryPB::FAILED);
      l.Commit();
      return;
    }
    TRACE("Marked keyspace as deleted in sys-catalog");
  } else {
    LOG(WARNING) << "Keyspace (" << database->name() << ") has invalid state ("
                 << metadata.state() << "), aborting delete";
    return;
  }

  // Remove namespace from CatalogManager name mapping.  Will remove ID map after all Tables gone.
  {
    LockGuard lock(mutex_);
    if (namespace_names_mapper_[database->database_type()].erase(database->name()) < 1) {
      LOG(WARNING) << Format("Could not remove namespace from maps, name=$0, id=$1",
                             database->name(), database->id());
    }
  }

  // Update the in-memory state.
  TRACE("Committing in-memory state");
  l.Commit();

  // DROP completed. Return status.
  LOG(INFO) << "Successfully deleted YSQL database " << database->ToString();
}

// IMPORTANT: If modifying, consider updating DeleteTable(), the singular deletion API.
Status CatalogManager::DeleteYsqlDBTables(const scoped_refptr<NamespaceInfo>& database) {
  TabletInfoPtr sys_tablet_info;
  vector<pair<scoped_refptr<TableInfo>, TableInfo::WriteLock>> tables;
  std::unordered_set<TableId> sys_table_ids;
  {
    // Lock the catalog to iterate over table_ids_map_.
    SharedLock lock(mutex_);

    sys_tablet_info = tablet_map_->find(kSysCatalogTabletId)->second;

    // Populate tables and sys_table_ids.
    for (const TableInfoMap::value_type& entry : *table_ids_map_) {
      scoped_refptr<TableInfo> table = entry.second;
      if (table->namespace_id() != database->id()) {
        continue;
      }
      auto l = table->LockForWrite();
      if (l->started_deleting()) {
        continue;
      }
      RSTATUS_DCHECK(
          !l->pb.is_pg_shared_table(), Corruption, "Shared table found in database");

      if (IsSystemTable(*table)) {
        sys_table_ids.insert(table->id());
      }

      // For regular (indexed) table, insert table info and lock in the front of the list. Else for
      // index table, append them to the end. We do so so that we will commit and delete the indexed
      // table first before its indexes.
      if (IsTable(l->pb)) {
        tables.insert(tables.begin(), {table, std::move(l)});
      } else {
        tables.push_back({table, std::move(l)});
      }
    }
  }
  // Remove the system tables from RAFT.
  TRACE("Sending system table delete RPCs");
  for (auto &table_id : sys_table_ids) {
    RETURN_NOT_OK(sys_catalog_->DeleteYsqlSystemTable(table_id));
  }
  // Remove the system tables from the system catalog TabletInfo.
  RETURN_NOT_OK(RemoveTableIdsFromTabletInfo(sys_tablet_info, sys_table_ids));

  // Set all table states to DELETING as one batch RPC call.
  TRACE("Sending delete table batch RPC to sys catalog");
  vector<TableInfo *> tables_rpc;
  tables_rpc.reserve(tables.size());
  for (auto &table_and_lock : tables) {
    tables_rpc.push_back(table_and_lock.first.get());
    auto &l = table_and_lock.second;
    // Mark the table state as DELETING tablets.
    l.mutable_data()->set_state(SysTablesEntryPB::DELETING,
        Substitute("Started deleting at $0", LocalTimeAsString()));
  }
  // Update all the table states in raft in bulk.
  Status s = sys_catalog_->Upsert(leader_ready_term(), tables_rpc);
  if (!s.ok()) {
    // The mutation will be aborted when 'l' exits the scope on early return.
    s = s.CloneAndPrepend(Substitute("An error occurred while updating sys tables: $0",
                                     s.ToString()));
    LOG(WARNING) << s.ToString();
    return CheckIfNoLongerLeader(s);
  }
  for (auto &table_and_lock : tables)95 {
    auto &table = table_and_lock.first;
    auto &l = table_and_lock.second;
    // Cancel all table busywork and commit the DELETING change.
    l.Commit();
    table->AbortTasks();
  }

  // Batch remove all relevant CDC streams, handle after releasing Table locks.
  TRACE("Deleting CDC streams on table");
  vector<TableId> id_list;
  id_list.reserve(tables.size());
  for (auto &table_and_lock : tables) {
    id_list.push_back(table_and_lock.first->id());
  }
  RETURN_NOT_OK(DeleteCDCStreamsForTables(id_list));

  // Send a DeleteTablet() RPC request to each tablet replica in the table.
  for (auto &table_and_lock : tables)95 {
    auto &table = table_and_lock.first;
    // TODO(pitr) undelete for YSQL tables
    RETURN_NOT_OK(DeleteTabletsAndSendRequests(table, {}));
  }

  // Invoke any background tasks and return (notably, table cleanup).
  background_tasks_->Wake();
  return Status::OK();
}

// Get the information about an in-progress delete operation.
Status CatalogManager::IsDeleteNamespaceDone(const IsDeleteNamespaceDoneRequestPB* req,
                                             IsDeleteNamespaceDoneResponsePB* resp) {
  auto ns_pb = req->namespace_();

  // Lookup the namespace and verify it exists.
  TRACE("Looking up keyspace");
  auto ns = FindNamespace(ns_pb);
  if (!ns.ok()) {
    // Namespace no longer exists means success.
    LOG(INFO) << "Servicing IsDeleteNamespaceDone request for "
              << ns_pb.DebugString() << ": deleted (not found)";
    resp->set_done(true);
    return Status::OK();
  }

  TRACE("Locking keyspace");
  auto l = (**ns).LockForRead();
  auto& metadata = l->pb;

  if (metadata.state() == SysNamespaceEntryPB::DELETED) {
    resp->set_done(true);
  } else if (metadata.state() == SysNamespaceEntryPB::DELETING) {
    resp->set_done(false);
  } else {
    Status s = STATUS_SUBSTITUTE(IllegalState,
        "Servicing IsDeleteNamespaceDone request for $0: NOT deleted (state=$1)",
        ns_pb.DebugString(), metadata.state());
    LOG(WARNING) << s.ToString();
    // Done != Successful.  We just want to let the user know the delete has finished processing.
    resp->set_done(true);
    return SetupError(resp->mutable_error(), MasterErrorPB::INTERNAL_ERROR, s);
  }
  return Status::OK();
}

Status CatalogManager::AlterNamespace(const AlterNamespaceRequestPB* req,
                                      AlterNamespaceResponsePB* resp,
                                      rpc::RpcContext* rpc) {
  LOG(INFO) << "Servicing AlterNamespace request from " << RequestorString(rpc)
            << ": " << req->ShortDebugString();

  auto database = VERIFY_NAMESPACE_FOUND(FindNamespace(req->namespace_()), resp);

  if (req->namespace_().has_database_type() &&
      database->database_type() != req->namespace_().database_type()5) {
    Status s = STATUS(NotFound, "Database not found", database->name());
    return SetupError(resp->mutable_error(), MasterErrorPB::NAMESPACE_NOT_FOUND, s);
  }

  TRACE("Locking database");
  auto l = database->LockForWrite();

  // Don't allow an alter if the namespace isn't running.
  if (l->pb.state() != SysNamespaceEntryPB::RUNNING) {
    Status s = STATUS_SUBSTITUTE(TryAgain, "Namespace not running.  State = $0",
                                 SysNamespaceEntryPB::State_Name(l->pb.state()));
    return SetupError(resp->mutable_error(), NamespaceMasterError(l->pb.state()), s);
  }

  const string old_name = l->pb.name();

  if (req->has_new_name() && req->new_name() != old_name) {
    const string new_name = req->new_name();

    // Verify that the new name does not exist.
    NamespaceIdentifierPB ns_identifier;
    ns_identifier.set_name(new_name);
    if (req->namespace_().has_database_type()) {
      ns_identifier.set_database_type(req->namespace_().database_type());
    }
    // TODO: This check will only work for YSQL once we add support for YSQL namespaces in
    // namespace_name_map (#1476).
    LockGuard lock(mutex_);
    TRACE("Acquired catalog manager lock");
    auto ns = FindNamespaceUnlocked(ns_identifier);
    if (ns.ok() && req->namespace_().has_database_type()0 &&
        (**ns).database_type() == req->namespace_().database_type()0) {
      Status s = STATUS_SUBSTITUTE(AlreadyPresent, "Keyspace '$0' already exists", (**ns).name());
      LOG(WARNING) << "Found keyspace: " << (**ns).id() << ". Failed altering keyspace with error: "
                   << s << " Request:\n" << req->DebugString();
      return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_ALREADY_PRESENT, s);
    }

    namespace_names_mapper_[req->namespace_().database_type()][new_name] = database;
    namespace_names_mapper_[req->namespace_().database_type()].erase(old_name);

    l.mutable_data()->pb.set_name(new_name);
  }

  RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), database));

  TRACE("Committing in-memory state");
  l.Commit();

  LOG(INFO) << "Successfully altered keyspace " << req->namespace_().name()
            << " per request from " << RequestorString(rpc);
  return Status::OK();
}

Status CatalogManager::ListNamespaces(const ListNamespacesRequestPB* req,
                                      ListNamespacesResponsePB* resp) {
  NamespaceInfoMap namespace_ids_copy;
  {
    SharedLock lock(mutex_);
    namespace_ids_copy = namespace_ids_map_;
  }

  for (const auto& entry : namespace_ids_copy) {
    const auto& namespace_info = *entry.second;
    // If the request asks for namespaces for a specific database type, filter by the type.
    if (req->has_database_type() && namespace_info.database_type() != req->database_type()2.50k) {
      continue;
    }
    // Only return RUNNING namespaces.
    if (namespace_info.state() != SysNamespaceEntryPB::RUNNING) {
      continue;
    }

    NamespaceIdentifierPB *ns = resp->add_namespaces();
    ns->set_id(namespace_info.id());
    ns->set_name(namespace_info.name());
    ns->set_database_type(namespace_info.database_type());
  }
  return Status::OK();
}

Status CatalogManager::GetNamespaceInfo(const GetNamespaceInfoRequestPB* req,
                                        GetNamespaceInfoResponsePB* resp,
                                        rpc::RpcContext* rpc) {
  LOG(INFO) << __func__ << " from " << RequestorString(rpc) << ": " << req->ShortDebugString();

  // Look up the namespace and verify if it exists.
  TRACE("Looking up namespace");
  auto ns = VERIFY_NAMESPACE_FOUND(FindNamespace(req->namespace_()), resp);

  resp->mutable_namespace_()->set_id(ns->id());
  resp->mutable_namespace_()->set_name(ns->name());
  resp->mutable_namespace_()->set_database_type(ns->database_type());
  resp->set_colocated(ns->colocated());
  return Status::OK();
}

Status CatalogManager::RedisConfigSet(
    const RedisConfigSetRequestPB* req, RedisConfigSetResponsePB* resp, rpc::RpcContext* rpc) {
  DCHECK(req->has_keyword());
  const auto& key = req->keyword();
  SysRedisConfigEntryPB config_entry;
  config_entry.set_key(key);
  *config_entry.mutable_args() = req->args();
  bool created = false;

  TRACE("Acquired catalog manager lock");
  LockGuard lock(mutex_);
  scoped_refptr<RedisConfigInfo> cfg = FindPtrOrNull(redis_config_map_, req->keyword());
  if (cfg == nullptr) {
    created = true;
    cfg = new RedisConfigInfo(key);
    redis_config_map_[key] = cfg;
  }

  auto wl = cfg->LockForWrite();
  wl.mutable_data()->pb = std::move(config_entry);
  if (created) {
    CHECK_OK(sys_catalog_->Upsert(leader_ready_term(), cfg));
  } else {
    CHECK_OK(sys_catalog_->Upsert(leader_ready_term(), cfg));
  }
  wl.Commit();
  return Status::OK();
}

Status CatalogManager::RedisConfigGet(
    const RedisConfigGetRequestPB* req, RedisConfigGetResponsePB* resp, rpc::RpcContext* rpc) {
  DCHECK(req->has_keyword());
  resp->set_keyword(req->keyword());
  TRACE("Acquired catalog manager lock");
  SharedLock lock(mutex_);
  scoped_refptr<RedisConfigInfo> cfg = FindPtrOrNull(redis_config_map_, req->keyword());
  if (cfg == nullptr) {
    Status s = STATUS_SUBSTITUTE(NotFound, "Redis config for $0 does not exists", req->keyword());
    return SetupError(resp->mutable_error(), MasterErrorPB::REDIS_CONFIG_NOT_FOUND, s);
  }
  auto rci = cfg->LockForRead();
  resp->mutable_args()->CopyFrom(rci->pb.args());
  return Status::OK();
}

Status CatalogManager::CreateUDType(const CreateUDTypeRequestPB* req,
                                    CreateUDTypeResponsePB* resp,
                                    rpc::RpcContext* rpc) {
  LOG(INFO) << "CreateUDType from " << RequestorString(rpc)
            << ": " << req->DebugString();

  Status s;
  scoped_refptr<UDTypeInfo> tp;
  scoped_refptr<NamespaceInfo> ns;

  // Lookup the namespace and verify if it exists.
  if (req->has_namespace_()) {
    TRACE("Looking up namespace");
    ns = VERIFY_NAMESPACE_FOUND(FindNamespace(req->namespace_()), resp);
    if (ns->database_type() != YQLDatabase::YQL_DATABASE_CQL) {
      Status s = STATUS(NotFound, "Namespace not found");
      return SetupError(resp->mutable_error(), MasterErrorPB::NAMESPACE_NOT_FOUND, s);
    }
  }

  // Get all the referenced types (if any).
  std::vector<std::string> referenced_udts;
  for (const QLTypePB& field_type : req->field_types()) {
    QLType::GetUserDefinedTypeIds(field_type, /* transitive = */ true, &referenced_udts);
  }

  {
    TRACE("Acquired catalog manager lock");
    LockGuard lock(mutex_);

    // Verify that the type does not exist.
    tp = FindPtrOrNull(udtype_names_map_, std::make_pair(ns->id(), req->name()));

    if (tp != nullptr) {
      s = STATUS_SUBSTITUTE(AlreadyPresent,
          "Type '$0.$1' already exists", ns->name(), req->name());
      LOG(WARNING) << "Found type: " << tp->id() << ". Failed creating type with error: "
                   << s.ToString() << " Request:\n" << req->DebugString();
      return SetupError(resp->mutable_error(), MasterErrorPB::TYPE_ALREADY_PRESENT, s);
    }

    // Verify that all referenced types actually exist.
    for (const auto& udt_id : referenced_udts) {
      if (FindPtrOrNull(udtype_ids_map_, udt_id) == nullptr) {
          // This may be caused by a stale cache (e.g. referenced type name resolves to an old,
          // deleted type). Return InvalidArgument so query layer will clear cache and retry.
          s = STATUS_SUBSTITUTE(InvalidArgument,
          "Type id '$0' referenced by type '$1' does not exist", udt_id, req->name());
        return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_REQUEST, s);
      }
    }

    // Construct the new type (generate fresh name and set fields).
    UDTypeId new_id = GenerateIdUnlocked(SysRowEntryType::UDTYPE);
    tp = new UDTypeInfo(new_id);
    tp->mutable_metadata()->StartMutation();
    SysUDTypeEntryPB *metadata = &tp->mutable_metadata()->mutable_dirty()->pb;
    metadata->set_name(req->name());
    metadata->set_namespace_id(ns->id());
    for (const string& field_name : req->field_names()) {
      metadata->add_field_names(field_name);
    }

    for (const QLTypePB& field_type : req->field_types()) {
      metadata->add_field_types()->CopyFrom(field_type);
    }

    // Add the type to the in-memory maps.
    udtype_ids_map_[tp->id()] = tp;
    udtype_names_map_[std::make_pair(ns->id(), req->name())] = tp;
    resp->set_id(tp->id());
  }
  TRACE("Inserted new user-defined type info into CatalogManager maps");

  // Update the on-disk system catalog.
  s = sys_catalog_->Upsert(leader_ready_term(), tp);
  if (!s.ok()) {
    s = s.CloneAndPrepend(Substitute(
        "An error occurred while inserting user-defined type to sys-catalog: $0", s.ToString()));
    LOG(WARNING) << s.ToString();
    return CheckIfNoLongerLeaderAndSetupError(s, resp);
  }
  TRACE("Wrote user-defined type to sys-catalog");

  // Commit the in-memory state.
  tp->mutable_metadata()->CommitMutation();
  LOG(INFO) << "Created user-defined type " << tp->ToString();
  return Status::OK();
}

Status CatalogManager::DeleteUDType(const DeleteUDTypeRequestPB* req,
                                    DeleteUDTypeResponsePB* resp,
                                    rpc::RpcContext* rpc) {
  LOG(INFO) << "Servicing DeleteUDType request from " << RequestorString(rpc)
            << ": " << req->ShortDebugString();

  scoped_refptr<UDTypeInfo> tp;
  scoped_refptr<NamespaceInfo> ns;

  if (!req->has_type()) {
    Status s = STATUS(InvalidArgument, "No type given", req->DebugString());
    return SetupError(resp->mutable_error(), MasterErrorPB::NAMESPACE_NOT_FOUND, s);
  }

  // Validate namespace.
  if (req->type().has_namespace_()) {
    // Lookup the namespace and verify if it exists.
    TRACE("Looking up namespace");
    ns = VERIFY_NAMESPACE_FOUND(FindNamespace(req->type().namespace_()), resp);
  }

  {
    LockGuard lock(mutex_);
    TRACE("Acquired catalog manager lock");

    if (req->type().has_type_id()) {
      tp = FindPtrOrNull(udtype_ids_map_, req->type().type_id());
    } else if (req->type().has_type_name()) {
      tp = FindPtrOrNull(udtype_names_map_, {ns->id(), req->type().type_name()});
    }

    if (tp == nullptr) {
      Status s = STATUS(NotFound, "The type does not exist", req->DebugString());
      return SetupError(resp->mutable_error(), MasterErrorPB::TYPE_NOT_FOUND, s);
    }

    // Checking if any table uses this type.
    // TODO: this could be more efficient.
    for (const TableInfoMap::value_type& entry : *table_ids_map_)52 {
      auto ltm = entry.second->LockForRead();
      if (!ltm->started_deleting()) {
        for (const auto &col : ltm->schema().columns()) {
          if (col.type().main() == DataType::USER_DEFINED_TYPE &&
              col.type().udtype_info().id() == tp->id()8) {
            Status s = STATUS(QLError,
                Substitute("Cannot delete type '$0.$1'. It is used in column $2 of table $3",
                    ns->name(), tp->name(), col.name(), ltm->name()));
            return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_REQUEST, s);
          }
        }
      }
    }

    // Checking if any other type uses this type (i.e. in the case of nested types).
    // TODO: this could be more efficient.
    for (const UDTypeInfoMap::value_type& entry : udtype_ids_map_)50 {
      auto ltm = entry.second->LockForRead();

      for (int i = 0; i < ltm->field_types_size(); i++130) {
        // Only need to check direct (non-transitive) type dependencies here.
        // This also means we report more precise errors for in-use types.
        if (QLType::DoesUserDefinedTypeIdExist(ltm->field_types(i),
                                      false /* transitive */,
                                      tp->id())) {
          Status s = STATUS(QLError,
              Substitute("Cannot delete type '$0.$1'. It is used in field $2 of type '$3'",
                  ns->name(), tp->name(), ltm->field_names(i), ltm->name()));
          return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_REQUEST, s);
        }
      }
    }
  }

  auto l = tp->LockForWrite();

  Status s = sys_catalog_->Delete(leader_ready_term(), tp);
  if (!s.ok()) {
    // The mutation will be aborted when 'l' exits the scope on early return.
    s = s.CloneAndPrepend(Substitute("An error occurred while updating sys-catalog: $0",
        s.ToString()));
    LOG(WARNING) << s.ToString();
    return CheckIfNoLongerLeaderAndSetupError(s, resp);
  }

  // Remove it from the maps.
  {
    TRACE("Removing from maps");
    LockGuard lock(mutex_);
    if (udtype_ids_map_.erase(tp->id()) < 1) {
      PANIC_RPC(rpc, "Could not remove user defined type from map, name=" + l->name());
    }
    if (udtype_names_map_.erase({ns->id(), tp->name()}) < 1) {
      PANIC_RPC(rpc, "Could not remove user defined type from map, name=" + l->name());
    }
  }

  // Update the in-memory state.
  TRACE("Committing in-memory state");
  l.Commit();

  LOG(INFO) << "Successfully deleted user-defined type " << tp->ToString()
            << " per request from " << RequestorString(rpc);

  return Status::OK();
}

Status CatalogManager::GetUDTypeInfo(const GetUDTypeInfoRequestPB* req,
                                     GetUDTypeInfoResponsePB* resp,
                                     rpc::RpcContext* rpc) {
  LOG(INFO) << "GetUDTypeInfo from " << RequestorString(rpc)
            << ": " << req->DebugString();
  Status s;
  scoped_refptr<UDTypeInfo> tp;
  scoped_refptr<NamespaceInfo> ns;

  if (!req->has_type()) {
    s = STATUS(InvalidArgument, "Cannot get type, no type identifier given", req->DebugString());
    return SetupError(resp->mutable_error(), MasterErrorPB::TYPE_NOT_FOUND, s);
  }

  if (req->type().has_type_id()) {
    tp = FindPtrOrNull(udtype_ids_map_, req->type().type_id());
  } else if (req->type().has_type_name() && req->type().has_namespace_()) {
    // Lookup the type and verify if it exists.
    TRACE("Looking up namespace");
    ns = VERIFY_NAMESPACE_FOUND(FindNamespace(req->type().namespace_()), resp);

    tp = FindPtrOrNull(udtype_names_map_, std::make_pair(ns->id(), req->type().type_name()));
  }

  if (tp == nullptr) {
    s = STATUS(InvalidArgument, "Couldn't find type", req->DebugString());
    return SetupError(resp->mutable_error(), MasterErrorPB::TYPE_NOT_FOUND, s);
  }

  {
    auto type_lock = tp->LockForRead();

    UDTypeInfoPB* type_info = resp->mutable_udtype();

    type_info->set_name(tp->name());
    type_info->set_id(tp->id());
    type_info->mutable_namespace_()->set_id(type_lock->namespace_id());

    for (int i = 0; i < type_lock->field_names_size(); i++95) {
      type_info->add_field_names(type_lock->field_names(i));
    }
    for (int i = 0; i < type_lock->field_types_size(); i++95) {
      type_info->add_field_types()->CopyFrom(type_lock->field_types(i));
    }

    LOG(INFO) << "Retrieved user-defined type " << tp->ToString();
  }
  return Status::OK();
}

Status CatalogManager::ListUDTypes(const ListUDTypesRequestPB* req,
                                   ListUDTypesResponsePB* resp) {
  SharedLock lock(mutex_);

  // Lookup the namespace and verify that it exists.
  auto ns = VERIFY_NAMESPACE_FOUND(FindNamespaceUnlocked(req->namespace_()), resp);

  for (const UDTypeInfoByNameMap::value_type& entry : udtype_names_map_) {
    auto ltm = entry.second->LockForRead();

    // key is a pair <namespace_id, type_name>.
    if (!ns->id().empty() && ns->id() != entry.first.first) {
      continue; // Skip types from other namespaces.
    }

    UDTypeInfoPB* udtype = resp->add_udtypes();
    udtype->set_id(entry.second->id());
    udtype->set_name(ltm->name());
    for (int i = 0; i <= ltm->field_names_size(); i++) {
      udtype->add_field_names(ltm->field_names(i));
    }
    for (int i = 0; i <= ltm->field_types_size(); i++) {
      udtype->add_field_types()->CopyFrom(ltm->field_types(i));
    }

    if (CHECK_NOTNULL(ns.get())) {
      auto l = ns->LockForRead();
      udtype->mutable_namespace_()->set_id(ns->id());
      udtype->mutable_namespace_()->set_name(ns->name());
    }
  }
  return Status::OK();
}

Status CatalogManager::DisableTabletSplitting(
    const DisableTabletSplittingRequestPB* req, DisableTabletSplittingResponsePB* resp,
    rpc::RpcContext* rpc) {
  const MonoDelta disable_duration = MonoDelta::FromMilliseconds(req->disable_duration_ms());
  tablet_split_manager_.DisableSplittingFor(disable_duration);
  return Status::OK();
}

Status CatalogManager::IsTabletSplittingComplete(
    const IsTabletSplittingCompleteRequestPB* req, IsTabletSplittingCompleteResponsePB* resp,
    rpc::RpcContext* rpc) {
  TableInfoMap table_info_map;
  {
    SharedLock lock(mutex_);
    table_info_map = *table_ids_map_;
  }
  resp->set_is_tablet_splitting_complete(
      tablet_split_manager_.IsTabletSplittingComplete(table_info_map));
  return Status::OK();
}

// For non-enterprise builds, this is a no-op.
Status CatalogManager::DeleteCDCStreamsForTable(const TableId& table) {
  return Status::OK();
}

Status CatalogManager::DeleteCDCStreamsForTables(const vector<TableId>& table_ids) {
  return Status::OK();
}


bool CatalogManager::CDCStreamExistsUnlocked(const CDCStreamId& stream_id) {
  return false;
}

Result<uint64_t> CatalogManager::IncrementYsqlCatalogVersion() {

  auto l = CHECK_NOTNULL(ysql_catalog_config_.get())->LockForWrite();
  uint64_t new_version = l->pb.ysql_catalog_config().version() + 1;
  l.mutable_data()->pb.mutable_ysql_catalog_config()->set_version(new_version);

  // Write to sys_catalog and in memory.
  RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), ysql_catalog_config_));
  l.Commit();

  if (FLAGS_log_ysql_catalog_versions) {
    LOG_WITH_FUNC(WARNING) << "set catalog version: " << new_version
                           << " (using old protobuf method)";
  }

  return new_version;
}

Status CatalogManager::InitDbFinished(Status initdb_status, int64_t term) {
  if (initdb_status.ok()) {
    LOG(INFO) << "initdb completed successfully";
  } else {
    LOG(ERROR) << "initdb failed: " << initdb_status;
  }

  auto l = CHECK_NOTNULL(ysql_catalog_config_.get())->LockForWrite();
  auto* mutable_ysql_catalog_config = l.mutable_data()->pb.mutable_ysql_catalog_config();
  mutable_ysql_catalog_config->set_initdb_done(true);
  if (!initdb_status.ok()) {
    mutable_ysql_catalog_config->set_initdb_error(initdb_status.ToString());
  } else {
    mutable_ysql_catalog_config->clear_initdb_error();
  }

  RETURN_NOT_OK(sys_catalog_->Upsert(term, ysql_catalog_config_));
  l.Commit();
  return Status::OK();
}

CHECKED_STATUS CatalogManager::IsInitDbDone(
    const IsInitDbDoneRequestPB* req,
    IsInitDbDoneResponsePB* resp) {
  auto l = CHECK_NOTNULL(ysql_catalog_config_.get())->LockForRead();
  const auto& ysql_catalog_config = l->pb.ysql_catalog_config();
  resp->set_pg_proc_exists(pg_proc_exists_.load(std::memory_order_acquire));
  resp->set_done(ysql_catalog_config.initdb_done());
  if (ysql_catalog_config.has_initdb_error() &&
      !ysql_catalog_config.initdb_error().empty()0) {
    resp->set_initdb_error(ysql_catalog_config.initdb_error());
  }
  return Status::OK();
}

Status CatalogManager::GetYsqlCatalogVersion(uint64_t* catalog_version,
                                             uint64_t* last_breaking_version) {
  auto table_info = GetTableInfo(kPgYbCatalogVersionTableId);
  if (table_info != nullptr) {
    RETURN_NOT_OK(sys_catalog_->ReadYsqlCatalogVersion(kPgYbCatalogVersionTableId,
                                                       catalog_version,
                                                       last_breaking_version));
    // If the version is properly initialized, we're done.
    if ((!catalog_version || *catalog_version > 0341k) &&
        (346k!last_breaking_version346k || *last_breaking_version > 0346k)) {
      return Status::OK();
    }
    // However, it's possible for a table to have no entries mid-migration or if migration fails.
    // In this case we'd like to fall back to the legacy approach.
  }

  auto l = ysql_catalog_config_->LockForRead();
  // last_breaking_version is the last version (change) that invalidated ongoing transactions.
  // If using the old (protobuf-based) version method, we do not have any information about
  // breaking changes so assuming every change is a breaking change.
  if (catalog_version) {
    *catalog_version = l->pb.ysql_catalog_config().version();
  }
  if (last_breaking_version) {
    *last_breaking_version = l->pb.ysql_catalog_config().version();
  }
  return Status::OK();
}

Status CatalogManager::InitializeTransactionTablesConfig(int64_t term) {
  SysTransactionTablesConfigEntryPB transaction_tables_config;
  transaction_tables_config.set_version(0);

  // Create in memory objects.
  transaction_tables_config_ = new SysConfigInfo(kTransactionTablesConfigType);

  // Prepare write.
  auto l = transaction_tables_config_->LockForWrite();
  *l.mutable_data()->pb.mutable_transaction_tables_config() = std::move(transaction_tables_config);

  // Write to sys_catalog and in memory.
  RETURN_NOT_OK(sys_catalog_->Upsert(term, transaction_tables_config_));
  l.Commit();

  return Status::OK();
}

Status CatalogManager::IncrementTransactionTablesVersion() {
  auto l = CHECK_NOTNULL(transaction_tables_config_.get())->LockForWrite();
  uint64_t new_version = l->pb.transaction_tables_config().version() + 1;
  l.mutable_data()->pb.mutable_transaction_tables_config()->set_version(new_version);

  // Write to sys_catalog and in memory.
  RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), transaction_tables_config_));
  l.Commit();

  LOG(INFO) << "Set transaction tables version: " << new_version;

  return Status::OK();
}

uint64_t CatalogManager::GetTransactionTablesVersion() {
  auto l = CHECK_NOTNULL(transaction_tables_config_.get())->LockForRead();
  return l->pb.transaction_tables_config().version();
}

Status CatalogManager::RegisterTsFromRaftConfig(const consensus::RaftPeerPB& peer) {
  NodeInstancePB instance_pb;
  instance_pb.set_permanent_uuid(peer.permanent_uuid());
  instance_pb.set_instance_seqno(0);

  TSRegistrationPB registration_pb;
  auto* common = registration_pb.mutable_common();
  *common->mutable_private_rpc_addresses() = peer.last_known_private_addr();
  *common->mutable_broadcast_addresses() = peer.last_known_broadcast_addr();
  *common->mutable_cloud_info() = peer.cloud_info();

  // Todo(Rahul) : May need to be changed when we implement table level overrides.
  {
    auto l = ClusterConfig()->LockForRead();
    // If the config has no replication info, use empty string for the placement uuid, otherwise
    // calculate it from the reported peer.
    auto placement_uuid = l->pb.has_replication_info()
        ? VERIFY_RESULT(CatalogManagerUtil::GetPlacementUuidFromRaftPeer(
                            l->pb.replication_info(), peer))
        : ""62;
    common->set_placement_uuid(placement_uuid);
  }
  return master_->ts_manager()->RegisterTS(instance_pb, registration_pb, master_->MakeCloudInfoPB(),
                                           &master_->proxy_cache(),
                                           RegisteredThroughHeartbeat::kFalse);
}

void CatalogManager::ReconcileTabletReplicasInLocalMemoryWithReport(
    const scoped_refptr<TabletInfo>& tablet,
    const std::string& sender_uuid,
    const ConsensusStatePB& consensus_state,
    const ReportedTabletPB& report) {
  auto replica_locations = std::make_shared<TabletReplicaMap>();
  auto prev_rl = tablet->GetReplicaLocations();

  for (const consensus::RaftPeerPB& peer : consensus_state.config().peers()) {
    shared_ptr<TSDescriptor> ts_desc;
    if (!peer.has_permanent_uuid()) {
      LOG_WITH_PREFIX(WARNING) << "Missing UUID for peer" << peer.ShortDebugString();
      continue;
    }
    if (!master_->ts_manager()->LookupTSByUUID(peer.permanent_uuid(), &ts_desc)) {
      if (!GetAtomicFlag(&FLAGS_enable_register_ts_from_raft)) {
        LOG_WITH_PREFIX(WARNING) << "Tablet server has never reported in. "
        << "Not including in replica locations map yet. Peer: " << peer.ShortDebugString()
        << "; Tablet: " << tablet->ToString();
        continue;
      }

      LOG_WITH_PREFIX(INFO) << "Tablet server has never reported in. Registering the ts using "
                            << "the raft config. Peer: " << peer.ShortDebugString()
                            << "; Tablet: " << tablet->ToString();
      Status s = RegisterTsFromRaftConfig(peer);
      if (!s.ok()) {
        LOG_WITH_PREFIX(WARNING) << "Could not register ts from raft config: " << s
                                 << " Skip updating the replica map.";
        continue;
      }

      // Guaranteed to find the ts since we just registered.
      master_->ts_manager()->LookupTSByUUID(peer.permanent_uuid(), &ts_desc);
      if (!ts_desc.get()) {
        LOG_WITH_PREFIX(WARNING) << "Could not find ts with uuid " << peer.permanent_uuid()
                                 << " after registering from raft config. Skip updating the replica"
                                 << " map.";
        continue;
      }
    }

    // Do not update replicas in the NOT_STARTED or BOOTSTRAPPING state (unless they are stale).
    bool use_existing = false;
    const TabletReplica* existing_replica = nullptr;
    auto it = prev_rl->find(ts_desc->permanent_uuid());
    if (it != prev_rl->end()) {
      existing_replica = &it->second;
    }
    if (existing_replica && peer.permanent_uuid() != sender_uuid192k) {
      // IsStarting returns true if state == NOT_STARTED or state == BOOTSTRAPPING.
      use_existing = existing_replica->IsStarting() && !existing_replica->IsStale()713;
    }
    if (use_existing) {
      InsertOrDie(replica_locations.get(), existing_replica->ts_desc->permanent_uuid(),
          *existing_replica);
    } else {
      TabletReplica replica;
      CreateNewReplicaForLocalMemory(ts_desc.get(), &consensus_state, report, &replica);
      auto result = replica_locations.get()->insert({replica.ts_desc->permanent_uuid(), replica});
      LOG_IF(FATAL, !result.second) << "duplicate uuid: " << replica.ts_desc->permanent_uuid()6;
      if (existing_replica) {
        result.first->second.UpdateDriveInfo(existing_replica->drive_info);
      }
    }
  }

  // Update the local tablet replica set. This deviates from persistent state during bootstrapping.
  tablet->SetReplicaLocations(replica_locations);
  tablet_locations_version_.fetch_add(1, std::memory_order_acq_rel);
}

void CatalogManager::UpdateTabletReplicaInLocalMemory(TSDescriptor* ts_desc,
                                                      const ConsensusStatePB* consensus_state,
                                                      const ReportedTabletPB& report,
                                                      const scoped_refptr<TabletInfo>& tablet) {
  TabletReplica replica;
  CreateNewReplicaForLocalMemory(ts_desc, consensus_state, report, &replica);
  tablet->UpdateReplicaLocations(replica);
  tablet_locations_version_.fetch_add(1, std::memory_order_acq_rel);
}

void CatalogManager::CreateNewReplicaForLocalMemory(TSDescriptor* ts_desc,
                                                    const ConsensusStatePB* consensus_state,
                                                    const ReportedTabletPB& report,
                                                    TabletReplica* new_replica) {
  // Tablets in state NOT_STARTED or BOOTSTRAPPING don't have a consensus.
  if (consensus_state == nullptr) {
    new_replica->role = PeerRole::NON_PARTICIPANT;
    new_replica->member_type = PeerMemberType::UNKNOWN_MEMBER_TYPE;
  } else {
    CHECK(consensus_state != nullptr) << "No cstate: " << ts_desc->permanent_uuid()
                                      << " - " << report.state();
    new_replica->role = GetConsensusRole(ts_desc->permanent_uuid(), *consensus_state);
    new_replica->member_type = GetConsensusMemberType(ts_desc->permanent_uuid(), *consensus_state);
  }
  if (report.has_should_disable_lb_move()) {
    new_replica->should_disable_lb_move = report.should_disable_lb_move();
  }
  if (report.has_fs_data_dir()664k) {
    new_replica->fs_data_dir = report.fs_data_dir();
  }
  new_replica->state = report.state();
  new_replica->ts_desc = ts_desc;
  if (!ts_desc->registered_through_heartbeat()) {
    new_replica->time_updated = MonoTime::Now() - ts_desc->TimeSinceHeartbeat();
  }
}

Status CatalogManager::GetTabletPeer(const TabletId& tablet_id,
                                     std::shared_ptr<TabletPeer>* ret_tablet_peer) const {
  // Note: CatalogManager has only one table, 'sys_catalog', with only
  // one tablet.

  if (PREDICT_FALSE(!IsInitialized())) {
    // Master puts up the consensus service first and then initiates catalog manager's creation
    // asynchronously. So this case is possible, but harmless. The RPC will simply be retried.
    // Previously, because we weren't checking for this condition, we would fatal down stream.
    const string& reason = "CatalogManager is not yet initialized";
    YB_LOG_EVERY_N(WARNING, 1000) << reason13;
    return STATUS(ServiceUnavailable, reason);
  }

  CHECK(sys_catalog_) << "sys_catalog_ must be initialized!";

  if (master_->opts().IsShellMode()) {
    return STATUS_SUBSTITUTE(NotFound,
        "In shell mode: no tablet_id $0 exists in CatalogManager.", tablet_id);
  }

  if (2.79Msys_catalog_->tablet_id() == tablet_id2.79M && sys_catalog_->tablet_peer().get() != nullptr &&
      sys_catalog_->tablet_peer()->CheckRunning().ok()) {
    *ret_tablet_peer = tablet_peer();
  } else {
    return STATUS_SUBSTITUTE(NotFound,
        "no SysTable in the RUNNING state exists with tablet_id $0 in CatalogManager", tablet_id);
  }
  return Status::OK();
}

const NodeInstancePB& CatalogManager::NodeInstance() const {
  return master_->instance_pb();
}

Status CatalogManager::GetRegistration(ServerRegistrationPB* reg) const {
  return master_->GetRegistration(reg, server::RpcOnly::kTrue);
}

Status CatalogManager::UpdateMastersListInMemoryAndDisk() {
  DCHECK(master_->opts().IsShellMode());

  if (!master_->opts().IsShellMode()) {
    return STATUS(IllegalState, "Cannot update master's info when process is not in shell mode.");
  }

  consensus::ConsensusStatePB consensus_state;
  RETURN_NOT_OK(GetCurrentConfig(&consensus_state));

  if (!consensus_state.has_config()) {
    return STATUS(NotFound, "No Raft config found.");
  }

  RETURN_NOT_OK(sys_catalog_->ConvertConfigToMasterAddresses(consensus_state.config()));
  RETURN_NOT_OK(sys_catalog_->CreateAndFlushConsensusMeta(master_->fs_manager(),
                                                          consensus_state.config(),
                                                          consensus_state.current_term()));

  return Status::OK();
}

Status CatalogManager::EnableBgTasks() {
  LockGuard lock(mutex_);
  // Initialize refresh_ysql_tablespace_info_task_. This will be used to
  // manage the background task that refreshes tablespace info. This task
  // will be started by the CatalogManagerBgTasks below.
  refresh_ysql_tablespace_info_task_.Bind(&master_->messenger()->scheduler());

  background_tasks_.reset(new CatalogManagerBgTasks(this));
  RETURN_NOT_OK_PREPEND(background_tasks_->Init(),
                        "Failed to initialize catalog manager background tasks");

  // Add bg thread to rebuild yql system partitions.
  refresh_yql_partitions_task_.Bind(&master_->messenger()->scheduler());

  RETURN_NOT_OK(background_tasks_thread_pool_->SubmitFunc(
      [this]() { RebuildYQLSystemPartitions(); }));

  return Status::OK();
}

Status CatalogManager::StartRemoteBootstrap(const StartRemoteBootstrapRequestPB& req) {
  const TabletId& tablet_id = req.tablet_id();
  std::unique_lock<std::mutex> l(remote_bootstrap_mtx_, std::try_to_lock);
  if (!l.owns_lock()) {
    return STATUS_SUBSTITUTE(AlreadyPresent,
        "Remote bootstrap of tablet $0 already in progress", tablet_id);
  }

  if (!master_->opts().IsShellMode()) {
    return STATUS(IllegalState, "Cannot bootstrap a master which is not in shell mode.");
  }

  LOG(INFO) << "Starting remote bootstrap: " << req.ShortDebugString();

  HostPort bootstrap_peer_addr = HostPortFromPB(DesiredHostPort(
      req.source_broadcast_addr(), req.source_private_addr(), req.source_cloud_info(),
      master_->MakeCloudInfoPB()));

  const string& bootstrap_peer_uuid = req.bootstrap_peer_uuid();
  int64_t leader_term = req.caller_term();

  std::shared_ptr<TabletPeer> old_tablet_peer;
  RaftGroupMetadataPtr meta;
  bool replacing_tablet = false;

  if (tablet_exists_) {
    old_tablet_peer = tablet_peer();
    // Nothing to recover if the remote bootstrap client start failed the last time.
    if (old_tablet_peer) {
      meta = old_tablet_peer->tablet_metadata();
      replacing_tablet = true;
    }
  }

  if (replacing_tablet) {
    // Make sure the existing tablet peer is shut down and tombstoned.
    RETURN_NOT_OK(tserver::HandleReplacingStaleTablet(meta,
                                                      old_tablet_peer,
                                                      tablet_id,
                                                      master_->fs_manager()->uuid(),
                                                      leader_term));
  }

  LOG_WITH_PREFIX(INFO) << " Initiating remote bootstrap from peer " << bootstrap_peer_uuid
            << " (" << bootstrap_peer_addr.ToString() << ").";

  auto rb_client = std::make_unique<tserver::RemoteBootstrapClient>(
      tablet_id, master_->fs_manager());

  // Download and persist the remote superblock in TABLET_DATA_COPYING state.
  if (replacing_tablet) {
    RETURN_NOT_OK(rb_client->SetTabletToReplace(meta, leader_term));
  }
  RETURN_NOT_OK(rb_client->Start(
      bootstrap_peer_uuid, &master_->proxy_cache(), bootstrap_peer_addr, &meta));
  // This SetupTabletPeer is needed by rb_client to perform the remote bootstrap/fetch.
  // And the SetupTablet below to perform "local bootstrap" cannot be done until the remote fetch
  // has succeeded. So keeping them seperate for now.
  sys_catalog_->SetupTabletPeer(meta);
  if (PREDICT_FALSE(FLAGS_TEST_inject_latency_during_remote_bootstrap_secs)) {
    LOG(INFO) << "Injecting " << FLAGS_TEST_inject_latency_during_remote_bootstrap_secs
              << " seconds of latency for test";
    SleepFor(MonoDelta::FromSeconds(FLAGS_TEST_inject_latency_during_remote_bootstrap_secs));
  }

  // From this point onward, the superblock is persisted in TABLET_DATA_COPYING
  // state, and we need to tombstone the tablet if additional steps prior to
  // getting to a TABLET_DATA_READY state fail.
  tablet_exists_ = true;

  // Download all of the remote files.
  TOMBSTONE_NOT_OK(rb_client->FetchAll(tablet_peer()->status_listener()),
                   meta,
                   master_->fs_manager()->uuid(),
                   Substitute("Remote bootstrap: Unable to fetch data from remote peer $0 ($1)",
                              bootstrap_peer_uuid, bootstrap_peer_addr.ToString()),
                   nullptr);

  // Write out the last files to make the new replica visible and update the
  // TabletDataState in the superblock to TABLET_DATA_READY.
  // Finish() will call EndRemoteSession() and wait for the leader to successfully submit a
  // ChangeConfig request (to change this master's role from PRE_VOTER or PRE_OBSERVER to VOTER or
  // OBSERVER respectively). If the RPC times out, we will ignore the error (since the leader could
  // have successfully submitted the ChangeConfig request and failed to respond before in time)
  // and check the committed config until we find that this master's role has changed, or until we
  // time out which will cause us to tombstone the tablet.
  TOMBSTONE_NOT_OK(rb_client->Finish(),
                   meta,
                   master_->fs_manager()->uuid(),
                   "Remote bootstrap: Failed calling Finish()",
                   nullptr);

  // Synchronous tablet open for "local bootstrap".
  RETURN_NOT_OK(tserver::ShutdownAndTombstoneTabletPeerNotOk(
      sys_catalog_->OpenTablet(meta), sys_catalog_->tablet_peer(), meta,
      master_->fs_manager()->uuid(), "Remote bootstrap: Failed opening sys catalog"));

  // Set up the in-memory master list and also flush the cmeta.
  RETURN_NOT_OK(UpdateMastersListInMemoryAndDisk());

  master_->SetShellMode(false);

  // Call VerifyChangeRoleSucceeded only after we have set shell mode to false. Otherwise,
  // CatalogManager::GetTabletPeer will always return an error, and the consensus will never get
  // updated.
  auto status = rb_client->VerifyChangeRoleSucceeded(
      sys_catalog_->tablet_peer()->shared_consensus());

  if (!status.ok()) {
    LOG_WITH_PREFIX(WARNING) << "Remote bootstrap finished. "
                             << "Failed calling VerifyChangeRoleSucceeded: "
                             << status.ToString();
  } else {
    LOG_WITH_PREFIX(INFO) << "Remote bootstrap finished successfully";
  }

  LOG(INFO) << "Master completed remote bootstrap and is out of shell mode.";

  RETURN_NOT_OK(EnableBgTasks());

  return Status::OK();
}

CHECKED_STATUS CatalogManager::SendAlterTableRequest(const scoped_refptr<TableInfo>& table,
                                                     const AlterTableRequestPB* req) {
  auto tablets = table->GetTablets();

  bool is_ysql_table_with_transaction_metadata =
      table->GetTableType() == TableType::PGSQL_TABLE_TYPE &&
      req != nullptr7.67k &&
      req->has_transaction()5.70k &&
      req->transaction().has_transaction_id()520;

  bool alter_table_has_add_or_drop_column_step = false;
  if (req && (5.89kreq->alter_schema_steps_size()5.89k || req->has_alter_properties()5.32k)) {
    for (const AlterTableRequestPB::Step& step : req->alter_schema_steps()) {
      if (step.type() == AlterTableRequestPB::ADD_COLUMN ||
          step.type() == AlterTableRequestPB::DROP_COLUMN245) {
        alter_table_has_add_or_drop_column_step = true;
        break;
      }
    }
  }

  TransactionId txn_id = TransactionId::Nil();
  if (is_ysql_table_with_transaction_metadata && alter_table_has_add_or_drop_column_step520) {
    {
      LOG(INFO) << "Persist transaction metadata into SysTableEntryPB for table ID " << table->id();
      TRACE("Locking table");
      auto l = table->LockForWrite();
      auto& tablet_data = *l.mutable_data();
      auto& table_pb = tablet_data.pb;
      table_pb.mutable_transaction()->CopyFrom(req->transaction());

      // Update sys-catalog with the transaction ID.
      TRACE("Updating table metadata on disk");
      RETURN_NOT_OK(master_->catalog_manager_impl()->sys_catalog_->Upsert(
          master_->catalog_manager()->leader_ready_term(), table.get()));

      // Update the in-memory state.
      TRACE("Committing in-memory state");
      l.Commit();
    }
    txn_id = VERIFY_RESULT(FullyDecodeTransactionId(req->transaction().transaction_id()));
  }

  for (const scoped_refptr<TabletInfo>& tablet : tablets)9.83k {
    auto call = std::make_shared<AsyncAlterTable>(master_, AsyncTaskPool(), tablet, table, txn_id);
    tablet->table()->AddTask(call);
    if (PREDICT_FALSE(FLAGS_TEST_slowdown_alter_table_rpcs_ms > 0)) {
      LOG(INFO) << "Sleeping for " << tablet->id() << " "
                << FLAGS_TEST_slowdown_alter_table_rpcs_ms
                << "ms before sending async alter table request";
      SleepFor(MonoDelta::FromMilliseconds(FLAGS_TEST_slowdown_alter_table_rpcs_ms));
    }
    RETURN_NOT_OK(ScheduleTask(call));
  }
  return Status::OK();
}

void CatalogManager::SendCopartitionTabletRequest(const scoped_refptr<TabletInfo>& tablet,
                                                  const scoped_refptr<TableInfo>& table) {
  auto call = std::make_shared<AsyncCopartitionTable>(master_, AsyncTaskPool(), tablet, table);
  table->AddTask(call);
  WARN_NOT_OK(ScheduleTask(call), "Failed to send copartition table request");
}

Status CatalogManager::SendSplitTabletRequest(
    const scoped_refptr<TabletInfo>& tablet, std::array<TabletId, kNumSplitParts> new_tablet_ids,
    const std::string& split_encoded_key, const std::string& split_partition_key) {
  VLOG(2) << "Scheduling SplitTablet request to leader tserver for source tablet ID: "
          << tablet->tablet_id() << ", after-split tablet IDs: " << AsString(new_tablet_ids);
  auto call = std::make_shared<AsyncSplitTablet>(
      master_, AsyncTaskPool(), tablet, new_tablet_ids, split_encoded_key, split_partition_key,
      &tablet_split_manager_);
  tablet->table()->AddTask(call);
  return ScheduleTask(call);
}

void CatalogManager::DeleteTabletReplicas(
    TabletInfo* tablet, const std::string& msg, HideOnly hide_only) {
  auto locations = tablet->GetReplicaLocations();
  LOG(INFO) << "Sending DeleteTablet for " << locations->size()
            << " replicas of tablet " << tablet->tablet_id();
  for (const auto& r : *locations) {
    SendDeleteTabletRequest(tablet->tablet_id(), TABLET_DATA_DELETED, boost::none, tablet->table(),
                            r.second.ts_desc, msg, hide_only);
  }
}

Status CatalogManager::CheckIfForbiddenToDeleteTabletOf(const scoped_refptr<TableInfo>& table) {
  // Do not delete the system catalog tablet.
  if (IsSystemTable(*table)) {
    return STATUS(InvalidArgument, "It is not allowed to delete system tables");
  }
  // Do not delete the tablet of a colocated table.
  if (table->IsColocatedUserTable()) {
    return STATUS(InvalidArgument, "It is not allowed to delete tablets of the colocated tables.");
  }
  return Status::OK();
}

Status CatalogManager::DeleteTabletsAndSendRequests(
    const TableInfoPtr& table, const RepeatedBytes& retained_by_snapshot_schedules) {
  // Silently fail if tablet deletion is forbidden so table deletion can continue executing.
  if (!CheckIfForbiddenToDeleteTabletOf(table).ok()) {
    return Status::OK();
  }

  auto tablets = table->GetTablets(IncludeInactive::kTrue);

  std::sort(tablets.begin(), tablets.end(), [](const auto& lhs, const auto& rhs) {
    return lhs->tablet_id() < rhs->tablet_id();
  });

  string deletion_msg = "Table deleted at " + LocalTimeAsString();
  RETURN_NOT_OK(DeleteTabletListAndSendRequests(
      tablets, deletion_msg, retained_by_snapshot_schedules));

  if (table->IsColocatedParentTable()) {
    LockGuard lock(mutex_);
    colocated_tablet_ids_map_.erase(table->namespace_id());
  } else if (table->IsTablegroupParentTable()) {
    // In the case of dropped tablegroup parent table, need to delete tablegroup info.
    LockGuard lock(mutex_);
    const auto& tablegroup_id = table_tablegroup_ids_map_[table->id()];
    tablegroup_ids_map_.erase(tablegroup_id);
    tablegroup_tablet_ids_map_[table->namespace_id()].erase(tablegroup_id);
    table_tablegroup_ids_map_.erase(table->id());
  }
  return Status::OK();
}

Status CatalogManager::DeleteTabletListAndSendRequests(
    const std::vector<scoped_refptr<TabletInfo>>& tablets, const std::string& deletion_msg,
    const google::protobuf::RepeatedPtrField<std::string>& retained_by_snapshot_schedules) {
  struct TabletData {
    TabletInfoPtr tablet;
    TabletInfo::WriteLock lock;
    HideOnly hide_only;
  };
  std::vector<TabletData> tablets_data;
  tablets_data.reserve(tablets.size());
  std::vector<TabletInfo*> tablet_infos;
  tablet_infos.reserve(tablets_data.size());
  std::vector<TabletInfoPtr> marked_as_hidden;

  // Grab tablets and tablet write locks. The list should already be in tablet_id sorted order.
  {
    SharedLock read_lock(mutex_);
    for (const auto& tablet : tablets) {
      tablets_data.push_back(TabletData {
        .tablet = tablet,
        .lock = tablet->LockForWrite(),
        // Hide tablet if it is retained by snapshot schedule, or is part of a cdc stream.
        .hide_only = HideOnly(!retained_by_snapshot_schedules.empty()),
      });
      if (!tablets_data.back().hide_only) {
        // Also check if this tablet is part of a cdc stream and is not already hidden. If this is
        // a cdc stream producer and is already hidden, then we should delete this tablet.
        tablets_data.back().hide_only = HideOnly(
            IsTableCdcProducer(*tablet->table()) && !tablets_data.back().lock->ListedAsHidden()0);
      }

      tablet_infos.emplace_back(tablet.get());
    }
  }

  // Use the same hybrid time for all hidden tablets.
  HybridTime hide_hybrid_time = master_->clock()->Now();

  // Mark the tablets as deleted.
  for (auto& tablet_data : tablets_data) {
    auto& tablet = tablet_data.tablet;
    auto& tablet_lock = tablet_data.lock;

    bool was_hidden = tablet_lock->ListedAsHidden();
    // Inactive tablet now, so remove it from partitions_.
    // After all the tablets have been deleted from the tservers, we remove it from tablets_.
    tablet->table()->RemoveTablet(tablet->id(), DeactivateOnly::kTrue);

    if (tablet_data.hide_only) {
      LOG(INFO) << "Hiding tablet " << tablet->tablet_id();
      tablet_lock.mutable_data()->pb.set_hide_hybrid_time(hide_hybrid_time.ToUint64());
      *tablet_lock.mutable_data()->pb.mutable_retained_by_snapshot_schedules() =
          retained_by_snapshot_schedules;
    } else {
      LOG(INFO) << "Deleting tablet " << tablet->tablet_id();
      tablet_lock.mutable_data()->set_state(SysTabletsEntryPB::DELETED, deletion_msg);
    }
    if (tablet_lock->ListedAsHidden() && !was_hidden12) {
      marked_as_hidden.push_back(tablet);
    }
  }

  // Update all the tablet states in raft in bulk.
  RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), tablet_infos));

  // Commit the change.
  for (auto& tablet_data : tablets_data)5.85k {
    auto& tablet = tablet_data.tablet;
    auto& tablet_lock = tablet_data.lock;

    tablet_lock.Commit();
    LOG(INFO) << (tablet_data.hide_only ? "Hid tablet "12 : "Deleted tablet "24.9k) << tablet->tablet_id();

    DeleteTabletReplicas(tablet.get(), deletion_msg, tablet_data.hide_only);
  }

  if (!marked_as_hidden.empty()) {
    LockGuard lock(mutex_);
    hidden_tablets_.insert(hidden_tablets_.end(), marked_as_hidden.begin(), marked_as_hidden.end());
  }

  return Status::OK();
}

void CatalogManager::SendDeleteTabletRequest(
    const TabletId& tablet_id,
    TabletDataState delete_type,
    const boost::optional<int64_t>& cas_config_opid_index_less_or_equal,
    const scoped_refptr<TableInfo>& table,
    TSDescriptor* ts_desc,
    const string& reason,
    bool hide_only) {
  if (PREDICT_FALSE(GetAtomicFlag(&FLAGS_TEST_disable_tablet_deletion))) {
    return;
  }
  LOG_WITH_PREFIX(INFO)
      << (hide_only ? "Hiding"36 : "Deleting"73.8k) << " tablet " << tablet_id << " on peer "
      << ts_desc->permanent_uuid() << " with delete type "
      << TabletDataState_Name(delete_type) << " (" << reason << ")";
  auto call = std::make_shared<AsyncDeleteReplica>(master_, AsyncTaskPool(),
      ts_desc->permanent_uuid(), table, tablet_id, delete_type,
      cas_config_opid_index_less_or_equal, reason);
  if (hide_only) {
    call->set_hide_only(hide_only);
  }
  if (table != nullptr) {
    table->AddTask(call);
  }

  auto status = ScheduleTask(call);
  WARN_NOT_OK(status, Substitute("Failed to send delete request for tablet $0", tablet_id));
  // TODO(bogdan): does the pending delete semantics need to change?
  if (status.ok()) {
    ts_desc->AddPendingTabletDelete(tablet_id);
  }
}

void CatalogManager::SendLeaderStepDownRequest(
    const scoped_refptr<TabletInfo>& tablet, const ConsensusStatePB& cstate,
    const string& change_config_ts_uuid, bool should_remove,
    const string& new_leader_uuid) {
  auto task = std::make_shared<AsyncTryStepDown>(
      master_, AsyncTaskPool(), tablet, cstate, change_config_ts_uuid, should_remove,
      new_leader_uuid);
  tablet->table()->AddTask(task);
  Status status = ScheduleTask(task);
  WARN_NOT_OK(status, Substitute("Failed to send new $0 request", task->type_name()));
}

// TODO: refactor this into a joint method with the add one.
void CatalogManager::SendRemoveServerRequest(
    const scoped_refptr<TabletInfo>& tablet, const ConsensusStatePB& cstate,
    const string& change_config_ts_uuid) {
  // Check if the user wants the leader to be stepped down.
  auto task = std::make_shared<AsyncRemoveServerTask>(
      master_, AsyncTaskPool(), tablet, cstate, change_config_ts_uuid);
  tablet->table()->AddTask(task);
  WARN_NOT_OK(ScheduleTask(task), Substitute("Failed to send new $0 request", task->type_name()));
}

void CatalogManager::SendAddServerRequest(
    const scoped_refptr<TabletInfo>& tablet, PeerMemberType member_type,
    const ConsensusStatePB& cstate, const string& change_config_ts_uuid) {
  auto task = std::make_shared<AsyncAddServerTask>(master_, AsyncTaskPool(), tablet, member_type,
      cstate, change_config_ts_uuid);
  tablet->table()->AddTask(task);
  WARN_NOT_OK(
      ScheduleTask(task),
      Substitute("Failed to send AddServer of tserver $0 to tablet $1",
                 change_config_ts_uuid, tablet.get()->ToString()));
}

void CatalogManager::GetPendingServerTasksUnlocked(
    const TableId &table_uuid,
    TabletToTabletServerMap *add_replica_tasks_map,
    TabletToTabletServerMap *remove_replica_tasks_map,
    TabletToTabletServerMap *stepdown_leader_tasks_map) {

  auto table = GetTableInfoUnlocked(table_uuid);
  for (const auto& task : table->GetTasks()) {
    TabletToTabletServerMap* outputMap = nullptr;
    if (task->type() == MonitoredTask::ASYNC_ADD_SERVER) {
      outputMap = add_replica_tasks_map;
    } else if (task->type() == MonitoredTask::ASYNC_REMOVE_SERVER) {
      outputMap = remove_replica_tasks_map;
    } else if (task->type() == MonitoredTask::ASYNC_TRY_STEP_DOWN) {
      // Store new_leader_uuid instead of change_config_ts_uuid.
      auto raft_task = static_cast<AsyncTryStepDown*>(task.get());
      (*stepdown_leader_tasks_map)[raft_task->tablet_id()] = raft_task->new_leader_uuid();
      continue;
    }
    if (outputMap) {
      auto raft_task = static_cast<CommonInfoForRaftTask*>(task.get());
      (*outputMap)[raft_task->tablet_id()] = raft_task->change_config_ts_uuid();
    }
  }
}

void CatalogManager::ExtractTabletsToProcess(
    TabletInfos *tablets_to_delete,
    TableToTabletInfos *tablets_to_process) {
  SharedLock lock(mutex_);

  // TODO: At the moment we loop through all the tablets
  //       we can keep a set of tablets waiting for "assignment"
  //       or just a counter to avoid to take the lock and loop through the tablets
  //       if everything is "stable".

  for (const TabletInfoMap::value_type& entry : *tablet_map_) {
    scoped_refptr<TabletInfo> tablet = entry.second;
    auto table = tablet->table();
    if (!table) {
      // Tablet is orphaned or in preparing state, continue.
      continue;
    }

    // acquire table lock before tablets.
    auto table_lock = table->LockForRead();
    auto tablet_lock = tablet->LockForRead();

    // If the table is deleted or the tablet was replaced at table creation time.
    if (tablet_lock->is_deleted() || table_lock->started_deleting()32.2M) {
      // Process this table deletion only once (tombstones for table may remain longer).
      if (table_ids_map_->find(tablet->table()->id()) != table_ids_map_->end()) {
        tablets_to_delete->push_back(tablet);
      }
      // Don't process deleted tables regardless.
      continue;
    }

    // Running tablets.
    if (tablet_lock->is_running()) {
      // TODO: handle last update > not responding timeout?
      continue;
    }

    // Tablets not yet assigned or with a report just received.
    (*tablets_to_process)[tablet->table()->id()].push_back(tablet);
  }
}

bool CatalogManager::AreTablesDeleting() {
  SharedLock lock(mutex_);

  for (const TableInfoMap::value_type& entry : *table_ids_map_) {
    scoped_refptr<TableInfo> table(entry.second);
    auto table_lock = table->LockForRead();
    // TODO(jason): possibly change this to started_deleting when we begin removing DELETED tables
    // from table_ids_map_ (see CleanUpDeletedTables).
    if (table_lock->is_deleting()) {
      return true;
    }
  }
  return false;
}

struct DeferredAssignmentActions {
  std::vector<TabletInfo*> modified_tablets;
  std::vector<TabletInfo*> needs_create_rpc;
};

void CatalogManager::HandleAssignPreparingTablet(TabletInfo* tablet,
                                                 DeferredAssignmentActions* deferred) {
  // The tablet was just created (probably by a CreateTable RPC).
  // Update the state to "creating" to be ready for the creation request.
  tablet->mutable_metadata()->mutable_dirty()->set_state(
    SysTabletsEntryPB::CREATING, "Sending initial creation of tablet");
  deferred->modified_tablets.push_back(tablet);
  deferred->needs_create_rpc.push_back(tablet);
  VLOG(1) << "Assign new tablet " << tablet->ToString()0;
}

void CatalogManager::HandleAssignCreatingTablet(TabletInfo* tablet,
                                                DeferredAssignmentActions* deferred,
                                                vector<scoped_refptr<TabletInfo>>* new_tablets) {
  MonoDelta time_since_updated =
      MonoTime::Now().GetDeltaSince(tablet->last_update_time());
  int64_t remaining_timeout_ms =
      FLAGS_tablet_creation_timeout_ms - time_since_updated.ToMilliseconds();

  if (tablet->LockForRead()->pb.has_split_parent_tablet_id()) {
    // No need to recreate post-split tablets, since this is always done on source tablet replicas.
    VLOG(2) << "Post-split tablet " << AsString(tablet) << " still being created."0;
    return;
  }
  // Skip the tablet if the assignment timeout is not yet expired.
  if (remaining_timeout_ms > 0) {
    VLOG(2) << "Tablet " << tablet->ToString() << " still being created. "
            << remaining_timeout_ms << "ms remain until timeout.";
    return;
  }

  const PersistentTabletInfo& old_info = tablet->metadata().state();

  // The "tablet creation" was already sent, but we didn't receive an answer
  // within the timeout. So the tablet will be replaced by a new one.
  TabletInfoPtr replacement;
  {
    LockGuard lock(mutex_);
    replacement = CreateTabletInfo(tablet->table().get(), old_info.pb.partition());
  }
  LOG(WARNING) << "Tablet " << tablet->ToString() << " was not created within "
               << "the allowed timeout. Replacing with a new tablet "
               << replacement->tablet_id();

  tablet->table()->ReplaceTablet(tablet, replacement);
  {
    LockGuard lock(mutex_);
    auto tablet_map_checkout = tablet_map_.CheckOut();
    (*tablet_map_checkout)[replacement->tablet_id()] = replacement;
  }

  // Mark old tablet as replaced.
  tablet->mutable_metadata()->mutable_dirty()->set_state(
    SysTabletsEntryPB::REPLACED,
    Substitute("Replaced by $0 at $1",
               replacement->tablet_id(), LocalTimeAsString()));

  // Mark new tablet as being created.
  replacement->mutable_metadata()->mutable_dirty()->set_state(
    SysTabletsEntryPB::CREATING,
    Substitute("Replacement for $0", tablet->tablet_id()));

  deferred->modified_tablets.push_back(tablet);
  deferred->modified_tablets.push_back(replacement.get());
  deferred->needs_create_rpc.push_back(replacement.get());
  VLOG(1) << "Replaced tablet " << tablet->tablet_id()
          << " with " << replacement->tablet_id()
          << " (table " << tablet->table()->ToString() << ")";

  new_tablets->push_back(replacement);
}

// TODO: we could batch the IO onto a background thread.
Status CatalogManager::HandleTabletSchemaVersionReport(
    TabletInfo *tablet, uint32_t version, const scoped_refptr<TableInfo>& table_info) {
  scoped_refptr<TableInfo> table;
  if (table_info) {
    table = table_info;
  } else {
    table = tablet->table();
  }

  // Update the schema version if it's the latest.
  tablet->set_reported_schema_version(table->id(), version);
  VLOG_WITH_PREFIX_AND_FUNC156(1)
      << "Tablet " << tablet->tablet_id() << " reported version " << version;

  // Verify if it's the last tablet report, and the alter completed.
  {
    auto l = table->LockForRead();
    if (l->pb.state() != SysTablesEntryPB::ALTERING) {
      VLOG_WITH_PREFIX_AND_FUNC1(2) << "Table " << table->ToString() << " is not altering"1;
      return Status::OK();
    }

    uint32_t current_version = l->pb.version();
    if (table->IsAlterInProgress(current_version)) {
      VLOG_WITH_PREFIX_AND_FUNC0(2) << "Table " << table->ToString() << " has IsAlterInProgress ("
                                   << current_version << ")";
      return Status::OK();
    }
  }

  return MultiStageAlterTable::LaunchNextTableInfoVersionIfNecessary(this, table, version);
}

Status CatalogManager::ProcessPendingAssignmentsPerTable(
    const TableId& table_id, const TabletInfos& tablets, CMGlobalLoadState* global_load_state) {
  VLOG(1) << "Processing pending assignments"0;

  TSDescriptorVector ts_descs = GetAllLiveNotBlacklistedTServers();

  // Initialize this table load state.
  CMPerTableLoadState table_load_state(global_load_state);
  InitializeTableLoadState(table_id, ts_descs, &table_load_state);
  table_load_state.SortLoad();

  // Take write locks on all tablets to be processed, and ensure that they are
  // unlocked at the end of this scope.
  for (const scoped_refptr<TabletInfo>& tablet : tablets) {
    tablet->mutable_metadata()->StartMutation();
  }
  ScopedInfoCommitter<TabletInfo> unlocker_in(&tablets);

  // Any tablets created by the helper functions will also be created in a
  // locked state, so we must ensure they are unlocked before we return to
  // avoid deadlocks.
  TabletInfos new_tablets;
  ScopedInfoCommitter<TabletInfo> unlocker_out(&new_tablets);

  DeferredAssignmentActions deferred;

  // Iterate over each of the tablets and handle it, whatever state
  // it may be in. The actions required for the tablet are collected
  // into 'deferred'.
  for (const scoped_refptr<TabletInfo>& tablet : tablets) {
    SysTabletsEntryPB::State t_state = tablet->metadata().state().pb.state();

    switch (t_state) {
      case SysTabletsEntryPB::PREPARING:
        HandleAssignPreparingTablet(tablet.get(), &deferred);
        break;

      case SysTabletsEntryPB::CREATING:
        HandleAssignCreatingTablet(tablet.get(), &deferred, &new_tablets);
        break;

      default:
        VLOG(2) << "Nothing to do for tablet " << tablet->tablet_id() << ": state = "
                << SysTabletsEntryPB_State_Name(t_state);
        break;
    }
  }

  // Nothing to do.
  if (deferred.modified_tablets.empty() &&
      deferred.needs_create_rpc.empty()13.1k) {
    return Status::OK();
  }

  // For those tablets which need to be created in this round, assign replicas.
  Status s;
  std::unordered_set<TableInfo*> ok_status_tables;
  for (TabletInfo *tablet : deferred.needs_create_rpc) {
    // NOTE: if we fail to select replicas on the first pass (due to
    // insufficient Tablet Servers being online), we will still try
    // again unless the tablet/table creation is cancelled.
    LOG(INFO) << "Selecting replicas for tablet " << tablet->id();
    s = SelectReplicasForTablet(ts_descs, tablet, &table_load_state, global_load_state);
    if (!s.ok()) {
      s = s.CloneAndPrepend(Substitute(
          "An error occurred while selecting replicas for tablet $0: $1",
          tablet->tablet_id(), s.ToString()));
      tablet->table()->SetCreateTableErrorStatus(s);
      break;
    } else {
      ok_status_tables.emplace(tablet->table().get());
    }
  }

  // Update the sys catalog with the new set of tablets/metadata.
  if (s.ok()) {
    // If any of the ok_status_tables had an error in the previous iterations, we
    // need to clear up the error status to reflect that all the create tablets have now
    // succeded.
    for (TableInfo* table : ok_status_tables) {
      table->SetCreateTableErrorStatus(Status::OK());
    }

    s = sys_catalog_->Upsert(leader_ready_term(), deferred.modified_tablets);
    if (!s.ok()) {
      s = s.CloneAndPrepend("An error occurred while persisting the updated tablet metadata");
    }
  }

  if (!s.ok()) {
    LOG(WARNING) << "Aborting the current task due to error: " << s.ToString();
    // If there was an error, abort any mutations started by the current task.
    // NOTE: Lock order should be lock_ -> table -> tablet.
    // We currently have a bunch of tablets locked and need to unlock first to ensure this holds.

    std::sort(new_tablets.begin(), new_tablets.end(), [](const auto& lhs, const auto& rhs) {
      return lhs->table().get() < rhs->table().get();
    });
    {
      std::string current_table_name;
      TableInfoPtr current_table;
      for (auto& tablet_to_remove : new_tablets) {
        if (tablet_to_remove->table()->RemoveTablet(tablet_to_remove->tablet_id())) {
          if (VLOG_IS_ON(1)) {
            if (current_table != tablet_to_remove->table()) {
              current_table = tablet_to_remove->table();
              current_table_name = current_table->name();
            }
            LOG(INFO) << "Removed tablet " << tablet_to_remove->tablet_id() << " from table "
                      << current_table_name;
          }
        }
      }
    }

    unlocker_out.Abort();  // tablet.unlock
    unlocker_in.Abort();

    {
      LockGuard lock(mutex_); // lock_.lock
      auto tablet_map_checkout = tablet_map_.CheckOut();
      for (auto& tablet_to_remove : new_tablets) {
        // Potential race condition above, but it's okay if a background thread deleted this.
        tablet_map_checkout->erase(tablet_to_remove->tablet_id());
      }
    }
    return s;
  }

  // Send DeleteTablet requests to tablet servers serving deleted tablets.
  // This is asynchronous / non-blocking.
  for (auto* tablet : deferred.modified_tablets)8.28k {
    if (tablet->metadata().dirty().is_deleted()) {
      // Actual delete, because we delete tablet replica.
      DeleteTabletReplicas(tablet, tablet->metadata().dirty().pb.state_msg(), HideOnly::kFalse);
    }
  }
  // Send the CreateTablet() requests to the servers. This is asynchronous / non-blocking.
  return SendCreateTabletRequests(deferred.needs_create_rpc);
}

Status CatalogManager::SelectReplicasForTablet(
    const TSDescriptorVector& ts_descs, TabletInfo* tablet,
    CMPerTableLoadState* per_table_state, CMGlobalLoadState* global_state) {
  auto table_guard = tablet->table()->LockForRead();

  if (!table_guard->pb.IsInitialized()) {
    return STATUS_SUBSTITUTE(InvalidArgument,
        "TableInfo for tablet $0 is not initialized (aborted CreateTable attempt?)",
        tablet->tablet_id());
  }

  const auto& replication_info =
    VERIFY_RESULT(GetTableReplicationInfo(table_guard->pb.replication_info(),
          tablet->table()->TablespaceIdForTableCreation()));

  // Select the set of replicas for the tablet.
  ConsensusStatePB* cstate = tablet->mutable_metadata()->mutable_dirty()
          ->pb.mutable_committed_consensus_state();
  VLOG_WITH_FUNC0(3) << "Committed consensus state: " << AsString(cstate)0;
  cstate->set_current_term(kMinimumTerm);
  consensus::RaftConfigPB *config = cstate->mutable_config();
  config->set_opid_index(consensus::kInvalidOpIdIndex);

  Status s = HandlePlacementUsingReplicationInfo(
      replication_info, ts_descs, config, per_table_state, global_state);
  if (!s.ok()) {
    return s;
  }

  std::ostringstream out;
  out << "Initial tserver uuids for tablet " << tablet->tablet_id() << ": ";
  for (const RaftPeerPB& peer : config->peers()) {
    out << peer.permanent_uuid() << " ";
  }

  if (VLOG_IS_ON(0)) {
    out.str();
  }

  VLOG_WITH_FUNC1(3) << "Committed consensus state has been updated to: " << AsString(cstate)1;

  return Status::OK();
}

void CatalogManager::GetTsDescsFromPlacementInfo(const PlacementInfoPB& placement_info,
                                                 const TSDescriptorVector& all_ts_descs,
                                                 TSDescriptorVector* ts_descs) {
  ts_descs->clear();
  for (const auto& ts_desc : all_ts_descs) {
    if (placement_info.has_placement_uuid()) {
      string placement_uuid = placement_info.placement_uuid();
      if (ts_desc->placement_uuid() == placement_uuid) {
        ts_descs->push_back(ts_desc);
      }
    } else if (ts_desc->placement_uuid() == "") {
      // Since the placement info has no placement id, we know it is live, so we add this ts.
      ts_descs->push_back(ts_desc);
    }
  }
}

Status CatalogManager::HandlePlacementUsingReplicationInfo(
    const ReplicationInfoPB& replication_info,
    const TSDescriptorVector& all_ts_descs,
    consensus::RaftConfigPB* config,
    CMPerTableLoadState* per_table_state,
    CMGlobalLoadState* global_state) {
  // Validate if we have enough tservers to put the replicas.
  ValidateReplicationInfoRequestPB req;
  req.mutable_replication_info()->CopyFrom(replication_info);
  ValidateReplicationInfoResponsePB resp;
  RETURN_NOT_OK(ValidateReplicationInfo(&req, &resp));

  TSDescriptorVector ts_descs;
  GetTsDescsFromPlacementInfo(replication_info.live_replicas(), all_ts_descs, &ts_descs);
  RETURN_NOT_OK(HandlePlacementUsingPlacementInfo(
      replication_info.live_replicas(), ts_descs, PeerMemberType::VOTER,
      config, per_table_state, global_state));
  for (int i = 0; 48.4ki < replication_info.read_replicas_size(); i++148) {
    GetTsDescsFromPlacementInfo(replication_info.read_replicas(i), all_ts_descs, &ts_descs);
    RETURN_NOT_OK(HandlePlacementUsingPlacementInfo(
        replication_info.read_replicas(i), ts_descs, PeerMemberType::OBSERVER,
        config, per_table_state, global_state));
  }
  return Status::OK();
}

Status CatalogManager::HandlePlacementUsingPlacementInfo(const PlacementInfoPB& placement_info,
                                                         const TSDescriptorVector& ts_descs,
                                                         PeerMemberType member_type,
                                                         consensus::RaftConfigPB* config,
                                                         CMPerTableLoadState* per_table_state,
                                                         CMGlobalLoadState* global_state) {
  size_t nreplicas = GetNumReplicasFromPlacementInfo(placement_info);
  size_t ntservers = ts_descs.size();
  // Keep track of servers we've already selected, so that we don't attempt to
  // put two replicas on the same host.
  set<TabletServerId> already_selected_ts;
  if (placement_info.placement_blocks().empty()) {
    // If we don't have placement info, just place the replicas as before, distributed across the
    // whole cluster.
    // We cannot put more than ntservers replicas.
    nreplicas = min(nreplicas, ntservers);
    SelectReplicas(ts_descs, nreplicas, config, &already_selected_ts, member_type,
                   per_table_state, global_state);
  } else {
    // TODO(bogdan): move to separate function
    //
    // If we do have placement info, we'll try to use the same power of two algorithm, but also
    // match the requested policies. We'll assign the minimum requested replicas in each combination
    // of cloud.region.zone and then if we still have leftover replicas, we'll assign those
    // in any of the allowed areas.
    auto all_allowed_ts = VERIFY_RESULT(FindTServersForPlacementInfo(placement_info, ts_descs));

    // Loop through placements and assign to respective available TSs.
    size_t min_replica_count_sum = 0;
    for (const auto& pb : placement_info.placement_blocks()) {
      // This works because currently we don't allow placement blocks to overlap.
      auto available_ts_descs = VERIFY_RESULT(FindTServersForPlacementBlock(pb, ts_descs));
      size_t available_ts_descs_size = available_ts_descs.size();
      size_t min_num_replicas = pb.min_num_replicas();
      // We cannot put more than the available tablet servers in that placement block.
      size_t num_replicas = min(min_num_replicas, available_ts_descs_size);
      min_replica_count_sum += min_num_replicas;
      SelectReplicas(available_ts_descs, num_replicas, config, &already_selected_ts, member_type,
                     per_table_state, global_state);
    }

    size_t replicas_left = nreplicas - min_replica_count_sum;
    size_t max_tservers_left = all_allowed_ts.size() - already_selected_ts.size();
    // Upper bounded by the tservers left.
    replicas_left = min(replicas_left, max_tservers_left);
    DCHECK_GE(replicas_left, 0);
    if (replicas_left > 0) {
      // No need to do an extra check here, as we checked early if we have enough to cover all
      // requested placements and checked individually per placement info, if we could cover the
      // minimums.
      SelectReplicas(all_allowed_ts, replicas_left, config, &already_selected_ts, member_type,
                     per_table_state, global_state);
    }
  }
  return Status::OK();
}

Result<vector<shared_ptr<TSDescriptor>>> CatalogManager::FindTServersForPlacementInfo(
    const PlacementInfoPB& placement_info,
    const TSDescriptorVector& ts_descs) const {

  vector<shared_ptr<TSDescriptor>> all_allowed_ts;
  for (const auto& ts : ts_descs) {
    for (const auto& pb : placement_info.placement_blocks()) {
      if (ts->MatchesCloudInfo(pb.cloud_info())) {
        all_allowed_ts.push_back(ts);
        break;
      }
    }
  }

  return all_allowed_ts;
}

Result<vector<shared_ptr<TSDescriptor>>> CatalogManager::FindTServersForPlacementBlock(
    const PlacementBlockPB& placement_block,
    const TSDescriptorVector& ts_descs) {

  vector<shared_ptr<TSDescriptor>> allowed_ts;
  const auto& cloud_info = placement_block.cloud_info();
  for (const auto& ts : ts_descs) {
    if (ts->MatchesCloudInfo(cloud_info)) {
      allowed_ts.push_back(ts);
    }
  }

  return allowed_ts;
}

Status CatalogManager::SendCreateTabletRequests(const vector<TabletInfo*>& tablets) {
  auto schedules_to_tablets_map = VERIFY_RESULT(MakeSnapshotSchedulesToObjectIdsMap(
      SysRowEntryType::TABLET));
  for (TabletInfo *tablet : tablets) {
    const consensus::RaftConfigPB& config =
        tablet->metadata().dirty().pb.committed_consensus_state().config();
    tablet->set_last_update_time(MonoTime::Now());
    std::vector<SnapshotScheduleId> schedules;
    for (const auto& pair : schedules_to_tablets_map) {
      if (std::binary_search(pair.second.begin(), pair.second.end(), tablet->id())) {
        schedules.push_back(pair.first);
      }
    }
    for (const RaftPeerPB& peer : config.peers()) {
      auto task = std::make_shared<AsyncCreateReplica>(master_, AsyncTaskPool(),
          peer.permanent_uuid(), tablet, schedules);
      tablet->table()->AddTask(task);
      WARN_NOT_OK(ScheduleTask(task), "Failed to send new tablet request");
    }
  }

  return Status::OK();
}

// If responses have been received from sufficient replicas (including hinted leader),
// pick proposed leader and start election.
void CatalogManager::StartElectionIfReady(
    const consensus::ConsensusStatePB& cstate, TabletInfo* tablet) {
  auto replicas = tablet->GetReplicaLocations();
  int num_voters = 0;
  for (const auto& peer : cstate.config().peers()) {
    if (peer.member_type() == PeerMemberType::VOTER) {
      ++num_voters;
    }
  }
  int majority_size = num_voters / 2 + 1;
  int running_voters = 0;
  for (const auto& replica : *replicas) {
    if (replica.second.member_type == PeerMemberType::VOTER) {
      ++running_voters;
    }
  }

  VLOG_WITH_PREFIX0(4)
      << __func__ << ": T " << tablet->tablet_id() << ": " << AsString(*replicas) << ", voters: "
      << running_voters << "/" << majority_size;

  if (running_voters < majority_size) {
    VLOG_WITH_PREFIX(4) << __func__ << ": Not enough voters";
    return;
  }

  ReplicationInfoPB replication_info;
  {
    auto l = ClusterConfig()->LockForRead();
    replication_info = l->pb.replication_info();
  }

  // Find tservers that can be leaders for a tablet.
  TSDescriptorVector ts_descs = GetAllLiveNotBlacklistedTServers();

  std::vector<std::string> possible_leaders;
  for (const auto& replica : *replicas) {
    for (const auto& ts_desc : ts_descs) {
      if (ts_desc->permanent_uuid() == replica.first) {
        if (ts_desc->IsAcceptingLeaderLoad(replication_info)) {
          possible_leaders.push_back(replica.first);
        }
        break;
      }
    }
  }

  if (FLAGS_TEST_create_table_leader_hint_min_lexicographic) {
    std::string min_lexicographic;
    for (const auto& peer : cstate.config().peers()) {
      if (peer.member_type() == PeerMemberType::VOTER) {
        if (min_lexicographic.empty() || peer.permanent_uuid() < min_lexicographic12) {
          min_lexicographic = peer.permanent_uuid();
        }
      }
    }
    if (min_lexicographic.empty() || !replicas->count(min_lexicographic)) {
      LOG_WITH_PREFIX(INFO)
          << __func__ << ": Min lexicographic is not yet ready: " << min_lexicographic;
      return;
    }
    possible_leaders = { min_lexicographic };
  }

  if (possible_leaders.empty()) {
    VLOG_WITH_PREFIX0(4) << __func__ << ": Cannot pick candidate"0;
    return;
  }

  if (!tablet->InitiateElection()) {
    VLOG_WITH_PREFIX0(4) << __func__ << ": Already initiated"0;
    return;
  }

  const auto& protege = RandomElement(possible_leaders);

  LOG_WITH_PREFIX(INFO)
      << "Starting election at " << tablet->tablet_id() << " in favor of " << protege;

  auto task = std::make_shared<AsyncStartElection>(master_, AsyncTaskPool(), protege, tablet);
  tablet->table()->AddTask(task);
  WARN_NOT_OK(task->Run(), "Failed to send new tablet start election request");
}

shared_ptr<TSDescriptor> CatalogManager::SelectReplica(
    const TSDescriptorVector& ts_descs,
    set<TabletServerId>* excluded,
    CMPerTableLoadState* per_table_state, CMGlobalLoadState* global_state) {
  shared_ptr<TSDescriptor> found_ts;
  for (const auto& sorted_load : per_table_state->sorted_load_) {
    // Don't consider a tserver that has already been considered for this tablet.
    if (excluded->count(sorted_load)) {
      continue;
    }
    // Only choose from the set of allowed tservers for this tablet.
    auto it = std::find_if(ts_descs.begin(), ts_descs.end(), [&sorted_load](const auto& ts) 144k{
      return ts->permanent_uuid() == sorted_load;
    });

    if (it != ts_descs.end()) {
      found_ts = *it;
      break;
    }
  }

  return found_ts;
}

void CatalogManager::SelectReplicas(
    const TSDescriptorVector& ts_descs, size_t nreplicas, consensus::RaftConfigPB* config,
    set<TabletServerId>* already_selected_ts, PeerMemberType member_type,
    CMPerTableLoadState* per_table_state, CMGlobalLoadState* global_state) {
  DCHECK_LE(nreplicas, ts_descs.size());

  for (size_t i = 0; i < nreplicas; ++i140k) {
    shared_ptr<TSDescriptor> ts = SelectReplica(
        ts_descs, already_selected_ts, per_table_state, global_state);
    InsertOrDie(already_selected_ts, ts->permanent_uuid());
    // Update the load state at global and table level.
    per_table_state->per_ts_load_[ts->permanent_uuid()]++;
    global_state->per_ts_load_[ts->permanent_uuid()]++;
    per_table_state->SortLoad();

    // Increment the number of pending replicas so that we take this selection into
    // account when assigning replicas for other tablets of the same table. This
    // value decays back to 0 over time.
    ts->IncrementRecentReplicaCreations();

    TSRegistrationPB reg = ts->GetRegistration();

    RaftPeerPB *peer = config->add_peers();
    peer->set_permanent_uuid(ts->permanent_uuid());

    // TODO: This is temporary, we will use only UUIDs.
    TakeRegistration(reg.mutable_common(), peer);
    peer->set_member_type(member_type);
  }
}

Status CatalogManager::ConsensusStateToTabletLocations(const consensus::ConsensusStatePB& cstate,
                                                       TabletLocationsPB* locs_pb) {
  for (const consensus::RaftPeerPB& peer : cstate.config().peers()) {
    TabletLocationsPB_ReplicaPB* replica_pb = locs_pb->add_replicas();
    if (!peer.has_permanent_uuid()) {
      return STATUS_SUBSTITUTE(IllegalState, "Missing UUID $0", peer.ShortDebugString());
    }
    replica_pb->set_role(GetConsensusRole(peer.permanent_uuid(), cstate));
    if (peer.has_member_type()559k) {
      replica_pb->set_member_type(peer.member_type());
    } else {
      replica_pb->set_member_type(PeerMemberType::UNKNOWN_MEMBER_TYPE);
    }
    TSInfoPB* tsinfo_pb = replica_pb->mutable_ts_info();
    tsinfo_pb->set_permanent_uuid(peer.permanent_uuid());
    CopyRegistration(peer, tsinfo_pb);
  }
  return Status::OK();
}

Status CatalogManager::BuildLocationsForTablet(const scoped_refptr<TabletInfo>& tablet,
                                               TabletLocationsPB* locs_pb,
                                               IncludeInactive include_inactive) {
  {
    auto l_tablet = tablet->LockForRead();
    if (l_tablet->is_hidden() && !include_inactive0) {
      return STATUS_FORMAT(NotFound, "Tablet hidden", tablet->id());
    }
    locs_pb->set_table_id(l_tablet->pb.table_id());
    *locs_pb->mutable_table_ids() = l_tablet->pb.table_ids();
  }

  // For system tables, the set of replicas is always the set of masters.
  if (system_tablets_.find(tablet->id()) != system_tablets_.end()) {
    consensus::ConsensusStatePB master_consensus;
    RETURN_NOT_OK(GetCurrentConfig(&master_consensus));
    locs_pb->set_tablet_id(tablet->tablet_id());
    locs_pb->set_stale(false);
    const auto initial_size = locs_pb->replicas_size();
    RETURN_NOT_OK(ConsensusStateToTabletLocations(master_consensus, locs_pb));
    const auto capabilities = Capabilities();
    // Set capabilities of master node for all newly created system table locations.
    for (auto i = locs_pb->mutable_replicas()->begin() + initial_size,
        end = locs_pb->mutable_replicas()->end(); i != end; ++i558k) {
      *i->mutable_ts_info()->mutable_capabilities() = google::protobuf::RepeatedField<CapabilityId>(
          capabilities.begin(), capabilities.end());
    }
    return Status::OK();
  }

  TSRegistrationPB reg;

  std::shared_ptr<const TabletReplicaMap> locs;
  consensus::ConsensusStatePB cstate;
  {
    auto l_tablet = tablet->LockForRead();
    if (PREDICT_FALSE(l_tablet->is_deleted())) {
      std::vector<TabletId> split_tablet_ids;
      for (const auto& split_tablet_id : l_tablet->pb.split_tablet_ids()) {
        split_tablet_ids.push_back(split_tablet_id);
      }
      return STATUS(
          NotFound, "Tablet deleted", l_tablet->pb.state_msg(),
          SplitChildTabletIdsData(split_tablet_ids));
    }

    if (PREDICT_FALSE(!l_tablet->is_running())) {
      return STATUS_FORMAT(ServiceUnavailable, "Tablet $0 not running", tablet->id());
    }

    locs = tablet->GetReplicaLocations();
    if (locs->empty() && l_tablet->pb.has_committed_consensus_state()398) {
      cstate = l_tablet->pb.committed_consensus_state();
    }

    const auto& metadata = tablet->metadata().state().pb;
    locs_pb->mutable_partition()->CopyFrom(metadata.partition());
    locs_pb->set_split_depth(metadata.split_depth());
    locs_pb->set_split_parent_tablet_id(metadata.split_parent_tablet_id());
    for (const auto& split_tablet_id : metadata.split_tablet_ids()) {
      *locs_pb->add_split_tablet_ids() = split_tablet_id;
    }
  }

  locs_pb->set_tablet_id(tablet->tablet_id());
  locs_pb->set_stale(locs->empty());

  // If the locations are cached.
  if (!locs->empty()) {
    if (cstate.IsInitialized() &&
            locs->size() != implicit_cast<size_t>(cstate.config().peers_size())0) {
      LOG(WARNING) << "Cached tablet replicas " << locs->size() << " does not match consensus "
                   << cstate.config().peers_size();
    }

    for (const auto& replica : *locs) {
      TabletLocationsPB_ReplicaPB* replica_pb = locs_pb->add_replicas();
      replica_pb->set_role(replica.second.role);
      replica_pb->set_member_type(replica.second.member_type);
      auto tsinfo_pb = replica.second.ts_desc->GetTSInformationPB();

      TSInfoPB* out_ts_info = replica_pb->mutable_ts_info();
      out_ts_info->set_permanent_uuid(tsinfo_pb->tserver_instance().permanent_uuid());
      CopyRegistration(tsinfo_pb->registration().common(), out_ts_info);
      out_ts_info->set_placement_uuid(tsinfo_pb->registration().common().placement_uuid());
      *out_ts_info->mutable_capabilities() = tsinfo_pb->registration().capabilities();
    }
    return Status::OK();
  }

  // If the locations were not cached.
  // TODO: Why would this ever happen? See KUDU-759.
  if (cstate.IsInitialized()) {
    RETURN_NOT_OK(ConsensusStateToTabletLocations(cstate, locs_pb));
  }

  return Status::OK();
}

Result<shared_ptr<tablet::AbstractTablet>> CatalogManager::GetSystemTablet(const TabletId& id) {
  const auto iter = system_tablets_.find(id);
  if (iter == system_tablets_.end()) {
    return STATUS_SUBSTITUTE(InvalidArgument, "$0 is not a valid system tablet id", id);
  }
  return iter->second;
}

Status CatalogManager::GetTabletLocations(
    const TabletId& tablet_id, TabletLocationsPB* locs_pb, IncludeInactive include_inactive) {
  scoped_refptr<TabletInfo> tablet_info;
  {
    SharedLock lock(mutex_);
    if (!FindCopy(*tablet_map_, tablet_id, &tablet_info)) {
      return STATUS_SUBSTITUTE(NotFound, "Unknown tablet $0", tablet_id);
    }
  }
  Status s = GetTabletLocations(tablet_info, locs_pb, include_inactive);

  auto num_replicas = GetReplicationFactorForTablet(tablet_info);
  if (num_replicas.ok()16.3k && *num_replicas > 0 &&
      implicit_cast<size_t>(locs_pb->replicas().size()) != *num_replicas) {
    YB_LOG_EVERY_N_SECS(WARNING, 1)
        << "Expected replicas " << num_replicas << " but found "
        << locs_pb->replicas().size() << " for tablet " << tablet_info->id() << ": "
        << locs_pb->ShortDebugString() << THROTTLE_MSG;
  }
  return s;
}

Status CatalogManager::GetTabletLocations(
    scoped_refptr<TabletInfo> tablet_info,
    TabletLocationsPB* locs_pb,
    IncludeInactive include_inactive) {
  DCHECK_EQ(locs_pb->replicas().size(), 0);
  locs_pb->mutable_replicas()->Clear();
  return BuildLocationsForTablet(tablet_info, locs_pb, include_inactive);
}

Status CatalogManager::GetTableLocations(
    const GetTableLocationsRequestPB* req,
    GetTableLocationsResponsePB* resp) {
  VLOG(4) << "GetTableLocations: " << req->ShortDebugString()3;

  // If start-key is > end-key report an error instead of swap the two
  // since probably there is something wrong app-side.
  if (req->has_partition_key_start() && req->has_partition_key_end()72.7k
      && req->partition_key_start() > req->partition_key_end()1) {
    return STATUS(InvalidArgument, "start partition key is greater than the end partition key");
  }

  if (req->max_returned_locations() <= 0) {
    return STATUS(InvalidArgument, "max_returned_locations must be greater than 0");
  }

  scoped_refptr<TableInfo> table = VERIFY_RESULT228k(FindTable(req->table()));228k

  if (table->IsCreateInProgress()) {
    resp->set_creating(true);
  }

  auto l = table->LockForRead();
  RETURN_NOT_OK(CheckIfTableDeletedOrNotVisibleToClient(l, resp));

  vector<scoped_refptr<TabletInfo>> tablets;
  table->GetTabletsInRange(req, &tablets);

  IncludeInactive include_inactive(req->has_include_inactive() && req->include_inactive()492);
  bool require_tablets_runnings = req->require_tablets_running();

  int expected_live_replicas = 0;
  int expected_read_replicas = 0;
  GetExpectedNumberOfReplicas(&expected_live_replicas, &expected_read_replicas);
  for (const scoped_refptr<TabletInfo>& tablet : tablets) {
    TabletLocationsPB* locs_pb = resp->add_tablet_locations();
    locs_pb->set_expected_live_replicas(expected_live_replicas);
    locs_pb->set_expected_read_replicas(expected_read_replicas);
    auto status = BuildLocationsForTablet(tablet, locs_pb, include_inactive);
    if (!status.ok()) {
      // Not running.
      if (require_tablets_runnings) {
        resp->mutable_tablet_locations()->Clear();
        return SetupError(resp->mutable_error(), MasterErrorPB::OBJECT_NOT_FOUND, status);
      }
      resp->mutable_tablet_locations()->RemoveLast();
    }
  }

  resp->set_table_type(l->pb.table_type());
  resp->set_partition_list_version(l->pb.partition_list_version());

  return Status::OK();
}

Status CatalogManager::GetCurrentConfig(consensus::ConsensusStatePB* cpb) const {
  auto tablet_peer = sys_catalog_->tablet_peer();
  auto consensus = tablet_peer ? tablet_peer->shared_consensus()5.41M : nullptr18.0k;
  if (!consensus) {
    std::string uuid = master_->fs_manager()->uuid();
    return STATUS_FORMAT(IllegalState, "Node $0 peer not initialized.", uuid);
  }

  *cpb = consensus->ConsensusState(CONSENSUS_CONFIG_COMMITTED);

  return Status::OK();
}

void CatalogManager::DumpState(std::ostream* out, bool on_disk_dump) const {
  NamespaceInfoMap namespace_ids_copy;
  TableInfoMap ids_copy;
  TableInfoByNameMap names_copy;
  TabletInfoMap tablets_copy;

  // Copy the internal state so that, if the output stream blocks,
  // we don't end up holding the lock for a long time.
  {
    SharedLock lock(mutex_);
    namespace_ids_copy = namespace_ids_map_;
    ids_copy = *table_ids_map_;
    names_copy = table_names_map_;
    tablets_copy = *tablet_map_;
  }

  *out << "Dumping current state of master.\nNamespaces:\n";
  for (const NamespaceInfoMap::value_type& e : namespace_ids_copy) {
    NamespaceInfo* t = e.second.get();
    auto l = t->LockForRead();
    const NamespaceName& name = l->name();

    *out << t->id() << ":\n";
    *out << "  name: \"" << strings::CHexEscape(name) << "\"\n";
    *out << "  metadata: " << l->pb.ShortDebugString() << "\n";
  }

  *out << "Tables:\n";
  for (const TableInfoMap::value_type& e : ids_copy) {
    TableInfo* t = e.second.get();
    TabletInfos table_tablets;
    {
      auto l = t->LockForRead();
      const TableName& name = l->name();
      const NamespaceId& namespace_id = l->namespace_id();
      // Find namespace by its ID.
      scoped_refptr<NamespaceInfo> ns = FindPtrOrNull(namespace_ids_copy, namespace_id);

      *out << t->id() << ":\n";
      *out << "  namespace id: \"" << strings::CHexEscape(namespace_id) << "\"\n";

      if (ns != nullptr) {
        *out << "  namespace name: \"" << strings::CHexEscape(ns->name()) << "\"\n";
      }

      *out << "  name: \"" << strings::CHexEscape(name) << "\"\n";
      // Erase from the map, so later we can check that we don't have
      // any orphaned tables in the by-name map that aren't in the
      // by-id map.
      if (names_copy.erase({namespace_id, name}) != 1) {
        *out << "  [not present in by-name map]\n";
      }
      *out << "  metadata: " << l->pb.ShortDebugString() << "\n";

      *out << "  tablets:\n";
      table_tablets = t->GetTablets();
    }
    for (const scoped_refptr<TabletInfo>& tablet : table_tablets) {
      auto l_tablet = tablet->LockForRead();
      *out << "    " << tablet->tablet_id() << ": "
           << l_tablet->pb.ShortDebugString() << "\n";

      if (tablets_copy.erase(tablet->tablet_id()) != 1) {
        *out << "  [ERROR: not present in CM tablet map!]\n";
      }
    }
  }

  if (!tablets_copy.empty()) {
    *out << "Orphaned tablets (not referenced by any table):\n";
    for (const TabletInfoMap::value_type& entry : tablets_copy) {
      const scoped_refptr<TabletInfo>& tablet = entry.second;
      auto l_tablet = tablet->LockForRead();
      *out << "    " << tablet->tablet_id() << ": "
           << l_tablet->pb.ShortDebugString() << "\n";
    }
  }

  if (!names_copy.empty()) {
    *out << "Orphaned tables (in by-name map, but not id map):\n";
    for (const TableInfoByNameMap::value_type& e : names_copy) {
      *out << e.second->id() << ":\n";
      *out << "  namespace id: \"" << strings::CHexEscape(e.first.first) << "\"\n";
      *out << "  name: \"" << CHexEscape(e.first.second) << "\"\n";
    }
  }

  master_->DumpMasterOptionsInfo(out);

  if (on_disk_dump) {
    consensus::ConsensusStatePB cur_consensus_state;
    // TODO: proper error handling below.
    CHECK_OK(GetCurrentConfig(&cur_consensus_state));
    *out << "Current raft config: " << cur_consensus_state.ShortDebugString() << "\n";
  }
}

Status CatalogManager::PeerStateDump(const vector<RaftPeerPB>& peers,
                                     const DumpMasterStateRequestPB* req,
                                     DumpMasterStateResponsePB* resp) {
  std::unique_ptr<MasterClusterProxy> peer_proxy;
  Endpoint sockaddr;
  MonoTime timeout = MonoTime::Now();
  DumpMasterStateRequestPB peer_req;
  rpc::RpcController rpc;

  timeout.AddDelta(MonoDelta::FromMilliseconds(FLAGS_master_ts_rpc_timeout_ms));
  rpc.set_deadline(timeout);
  peer_req.set_on_disk(req->on_disk());
  peer_req.set_return_dump_as_string(req->return_dump_as_string());
  string dump;

  for (const RaftPeerPB& peer : peers) {
    HostPort hostport = HostPortFromPB(DesiredHostPort(peer, master_->MakeCloudInfoPB()));
    peer_proxy = std::make_unique<MasterClusterProxy>(&master_->proxy_cache(), hostport);

    DumpMasterStateResponsePB peer_resp;
    rpc.Reset();

    RETURN_NOT_OK(peer_proxy->DumpState(peer_req, &peer_resp, &rpc));

    if (peer_resp.has_error()) {
      LOG(WARNING) << "Hit err " << peer_resp.ShortDebugString() << " during peer "
        << peer.ShortDebugString() << " state dump.";
      return StatusFromPB(peer_resp.error().status());
    } else if (req->return_dump_as_string()) {
      dump += peer_resp.dump();
    }
  }

  if (req->return_dump_as_string()) {
    resp->set_dump(resp->dump() + dump);
  }
  return Status::OK();
}

void CatalogManager::ReportMetrics() {
  // Report metrics on how many tservers are alive.
  TSDescriptorVector ts_descs;
  master_->ts_manager()->GetAllLiveDescriptors(&ts_descs);
  const auto num_live_servers = ts_descs.size();
  metric_num_tablet_servers_live_->set_value(narrow_cast<uint32_t>(num_live_servers));

  master_->ts_manager()->GetAllDescriptors(&ts_descs);
  metric_num_tablet_servers_dead_->set_value(
      narrow_cast<uint32_t>(ts_descs.size() - num_live_servers));
}

void CatalogManager::ResetMetrics() {
  metric_num_tablet_servers_live_->set_value(0);
  metric_num_tablet_servers_dead_->set_value(0);
}


std::string CatalogManager::LogPrefix() const {
  if (tablet_peer()) {
    return consensus::MakeTabletLogPrefix(
        tablet_peer()->tablet_id(), tablet_peer()->permanent_uuid());
  } else {
    return consensus::MakeTabletLogPrefix(
        kSysCatalogTabletId, master_->fs_manager()->uuid());
  }
}

void CatalogManager::SetLoadBalancerEnabled(bool is_enabled) {
  load_balance_policy_->SetLoadBalancerEnabled(is_enabled);
}

bool CatalogManager::IsLoadBalancerEnabled() {
  return load_balance_policy_->IsLoadBalancerEnabled();
}

MonoDelta CatalogManager::TimeSinceElectedLeader() {
  return MonoTime::Now() - time_elected_leader_.load();
}

Status CatalogManager::GoIntoShellMode() {
  if (master_->IsShellMode()) {
    return STATUS(IllegalState, "Master is already in shell mode.");
  }

  LOG(INFO) << "Starting going into shell mode.";
  master_->SetShellMode(true);

  {
    LockGuard lock(mutex_);
    RETURN_NOT_OK(sys_catalog_->GoIntoShellMode());
    background_tasks_->Shutdown();
    background_tasks_.reset();
  }
  {
    std::lock_guard<std::mutex> l(remote_bootstrap_mtx_);
    tablet_exists_ = false;
  }

  LOG(INFO) << "Done going into shell mode.";

  return Status::OK();
}

Status CatalogManager::GetClusterConfig(GetMasterClusterConfigResponsePB* resp) {
  return GetClusterConfig(resp->mutable_cluster_config());
}

Status CatalogManager::GetClusterConfig(SysClusterConfigEntryPB* config) {
  auto cluster_config = ClusterConfig();
  DCHECK(cluster_config) << "Missing cluster config for master!"934;
  auto l = cluster_config->LockForRead();
  *config = l->pb;
  return Status::OK();
}

Status CatalogManager::SetClusterConfig(
    const ChangeMasterClusterConfigRequestPB* req, ChangeMasterClusterConfigResponsePB* resp) {
  SysClusterConfigEntryPB config(req->cluster_config());

  if (config.has_server_blacklist()) {
    config.mutable_server_blacklist()->set_initial_replica_load(narrow_cast<int32_t>(
        GetNumRelevantReplicas(config.server_blacklist(), false /* leaders_only */)));
    LOG(INFO) << Format("Set blacklist of total tservers: $0, with initial load: $1",
                    config.server_blacklist().hosts().size(),
                    config.server_blacklist().initial_replica_load());
  }
  if (config.has_leader_blacklist()) {
    config.mutable_leader_blacklist()->set_initial_leader_load(narrow_cast<int32_t>(
        GetNumRelevantReplicas(config.leader_blacklist(), true /* leaders_only */)));
    LOG(INFO) << Format("Set leader blacklist of total tservers: $0, with initial load: $1",
                    config.leader_blacklist().hosts().size(),
                    config.leader_blacklist().initial_leader_load());
  }

  auto cluster_config = ClusterConfig();
  auto l = cluster_config->LockForWrite();
  // We should only set the config, if the caller provided us with a valid update to the
  // existing config.
  if (l->pb.version() != config.version()) {
    Status s = STATUS_SUBSTITUTE(IllegalState,
      "Config version does not match, got $0, but most recent one is $1. Should call Get again",
      config.version(), l->pb.version());
    return SetupError(resp->mutable_error(), MasterErrorPB::CONFIG_VERSION_MISMATCH, s);
  }

  if (config.cluster_uuid() != l->pb.cluster_uuid()) {
    Status s = STATUS(InvalidArgument, "Config cluster UUID cannot be updated");
    return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_CLUSTER_CONFIG, s);
  }

  // TODO(bogdan): should this live here?
  const ReplicationInfoPB& replication_info = config.replication_info();
  for (int i = 0; i < replication_info.read_replicas_size(); i++17) {
    if (!replication_info.read_replicas(i).has_placement_uuid()) {
      Status s = STATUS(IllegalState,
                        "All read-only clusters must have a placement uuid specified");
      return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_CLUSTER_CONFIG, s);
    }
  }

  // Validate placement information according to rules defined.
  if (replication_info.has_live_replicas()) {
    Status s = CatalogManagerUtil::IsPlacementInfoValid(replication_info.live_replicas());
    if (!s.ok()) {
      return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_CLUSTER_CONFIG, s);
    }
  }

  l.mutable_data()->pb.CopyFrom(config);
  // Bump the config version, to indicate an update.
  l.mutable_data()->pb.set_version(config.version() + 1);

  LOG(INFO) << "Updating cluster config to " << config.version() + 1;

  RETURN_NOT_OK(sys_catalog_->Upsert(leader_ready_term(), cluster_config.get()));

  l.Commit();

  return Status::OK();
}

Status CatalogManager::ValidateReplicationInfo(
    const ValidateReplicationInfoRequestPB* req, ValidateReplicationInfoResponsePB* resp) {
  TSDescriptorVector all_ts_descs;
  {
    BlacklistSet blacklist = VERIFY_RESULT(BlacklistSetFromPB());
    master_->ts_manager()->GetAllLiveDescriptors(&all_ts_descs, blacklist);
  }
  // We don't need any validation checks for read replica placements
  // because they aren't a part of any raft quorum underneath.
  // Technically, it is ok to have even 0 read replica nodes for them upfront.
  // We only need it for the primary cluster replicas.
  TSDescriptorVector ts_descs;
  GetTsDescsFromPlacementInfo(req->replication_info().live_replicas(), all_ts_descs, &ts_descs);
  Status s = CheckValidPlacementInfo(req->replication_info().live_replicas(), all_ts_descs, resp);
  if (!s.ok()) {
    return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_TABLE_REPLICATION_INFO, s);
  }
  return Status::OK();
}

Status CatalogManager::SetPreferredZones(
    const SetPreferredZonesRequestPB* req, SetPreferredZonesResponsePB* resp) {
  auto cluster_config = ClusterConfig();
  auto l = cluster_config->LockForWrite();
  auto replication_info = l.mutable_data()->pb.mutable_replication_info();
  replication_info->clear_affinitized_leaders();

  for (const auto& cloud_info : req->preferred_zones()) {
    const auto& placement_info = replication_info->live_replicas();
    if (!CatalogManagerUtil::DoesPlacementInfoContainCloudInfo(placement_info, cloud_info)) {
      Status s = STATUS_FORMAT(InvalidArgument, "Placement info $0 does not contain cloud info $1",
                               placement_info, TSDescriptor::generate_placement_id(cloud_info));
      return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_CLUSTER_CONFIG, s);
    }
    *replication_info->add_affinitized_leaders() = cloud_info;
  }

  l.mutable_data()->pb.set_version(l.mutable_data()->pb.version() + 1);

  LOG(INFO) << "Updating cluster config to " << l.mutable_data()->pb.version();

  Status s = sys_catalog_->Upsert(leader_ready_term(), cluster_config.get());
  if (!s.ok()) {
    return SetupError(resp->mutable_error(), MasterErrorPB::INVALID_CLUSTER_CONFIG, s);
  }

  l.Commit();

  return Status::OK();
}

Result<size_t> CatalogManager::GetReplicationFactor() {
  auto cluster_config = ClusterConfig();
  DCHECK(cluster_config) << "Missing cluster config for master!"0;
  auto l = cluster_config->LockForRead();
  const ReplicationInfoPB& replication_info = l->pb.replication_info();
  return GetNumReplicasFromPlacementInfo(replication_info.live_replicas());
}

Result<size_t> CatalogManager::GetReplicationFactorForTablet(
    const scoped_refptr<TabletInfo>& tablet) {
  // For system tables, the set of replicas is always the set of masters.
  if (system_tablets_.find(tablet->id()) != system_tablets_.end()) {
    consensus::ConsensusStatePB master_consensus;
    RETURN_NOT_OK(GetCurrentConfig(&master_consensus));
    return master_consensus.config().peers().size();
  }
  int num_live_replicas = 0, num_read_replicas = 0;
  GetExpectedNumberOfReplicas(&num_live_replicas, &num_read_replicas);
  return num_live_replicas + num_read_replicas;
}

void CatalogManager::GetExpectedNumberOfReplicas(int* num_live_replicas, int* num_read_replicas) {
  auto l = ClusterConfig()->LockForRead();
  const ReplicationInfoPB& replication_info = l->pb.replication_info();
  *num_live_replicas = narrow_cast<int>(GetNumReplicasFromPlacementInfo(
      replication_info.live_replicas()));
  for (const auto& read_replica_placement_info : replication_info.read_replicas()) {
    *num_read_replicas += read_replica_placement_info.num_replicas();
  }
}

Result<string> CatalogManager::placement_uuid() const {
  auto cluster_config = ClusterConfig();
  if (!cluster_config) {
    return STATUS(IllegalState, "Missing cluster config for master!");
  }
  auto l = cluster_config->LockForRead();
  const ReplicationInfoPB& replication_info = l->pb.replication_info();
  return replication_info.live_replicas().placement_uuid();
}

Status CatalogManager::IsLoadBalanced(const IsLoadBalancedRequestPB* req,
                                      IsLoadBalancedResponsePB* resp) {
  if (req->has_expected_num_servers()) {
    TSDescriptorVector ts_descs;
    master_->ts_manager()->GetAllLiveDescriptors(&ts_descs);

    if (implicit_cast<size_t>(req->expected_num_servers()) > ts_descs.size()) {
      Status s = STATUS_SUBSTITUTE(IllegalState,
          "Found $0, which is below the expected number of servers $1.",
          ts_descs.size(), req->expected_num_servers());
      return SetupError(resp->mutable_error(), MasterErrorPB::CAN_RETRY_LOAD_BALANCE_CHECK, s);
    }
  }

  Status s = load_balance_policy_->IsIdle();
  if (!s.ok()) {
    return SetupError(resp->mutable_error(), MasterErrorPB::CAN_RETRY_LOAD_BALANCE_CHECK, s);
  }

  return Status::OK();
}

Status CatalogManager::IsLoadBalancerIdle(const IsLoadBalancerIdleRequestPB* req,
                                          IsLoadBalancerIdleResponsePB* resp) {
  Status s = load_balance_policy_->IsIdle();
  if (!s.ok()) {
    return SetupError(resp->mutable_error(), MasterErrorPB::LOAD_BALANCER_RECENTLY_ACTIVE, s);
  }

  return Status::OK();
}

Status CatalogManager::AreLeadersOnPreferredOnly(const AreLeadersOnPreferredOnlyRequestPB* req,
                                                 AreLeadersOnPreferredOnlyResponsePB* resp) {
  // If we have cluster replication info, then only fetch live tservers (ignore read replicas).
  TSDescriptorVector ts_descs;
  string live_replicas_placement_uuid = "";
  {
    auto l = ClusterConfig()->LockForRead();
    const ReplicationInfoPB& cluster_replication_info = l->pb.replication_info();
    if (cluster_replication_info.has_live_replicas()) {
      live_replicas_placement_uuid = cluster_replication_info.live_replicas().placement_uuid();
    }
  }

  {
    BlacklistSet blacklist = VERIFY_RESULT(BlacklistSetFromPB());
    if (live_replicas_placement_uuid.empty()) {
      master_->ts_manager()->GetAllLiveDescriptors(&ts_descs, blacklist);
    } else {
      master_->ts_manager()->GetAllLiveDescriptorsInCluster(
          &ts_descs, live_replicas_placement_uuid,
          blacklist);
    }
  }

  // Only need to fetch if txn tables are not using preferred zones.
  vector<TableInfoPtr> tables;
  if (!FLAGS_transaction_tables_use_preferred_zones) {
    tables = master_->catalog_manager()->GetTables(GetTablesMode::kRunning);
  }

  auto l = ClusterConfig()->LockForRead();
  Status s = CatalogManagerUtil::AreLeadersOnPreferredOnly(
      ts_descs, l->pb.replication_info(), tables);
  if (!s.ok()) {
    return SetupError(
        resp->mutable_error(), MasterErrorPB::CAN_RETRY_ARE_LEADERS_ON_PREFERRED_ONLY_CHECK, s);
  }

  return Status::OK();
}

int64_t CatalogManager::GetNumRelevantReplicas(const BlacklistPB& blacklist, bool leaders_only) {
  int64_t res = 0;
  SharedLock lock(mutex_);
  for (const TabletInfoMap::value_type& entry : *tablet_map_) {
    scoped_refptr<TabletInfo> tablet = entry.second;
    auto l = tablet->LockForRead();
    // Not checking being created on purpose as we do not want initial load to be under accounted.
    if (!tablet->table() ||
        PREDICT_FALSE(l->is_deleted())) {
      continue;
    }

    auto locs = tablet->GetReplicaLocations();
    for (const auto& replica : *locs) {
      if (leaders_only && replica.second.role != PeerRole::LEADER21.9k) {
        continue;
      }
      for (int i = 0; 119ki < blacklist.hosts_size(); i++248k) {
        if (replica.second.ts_desc->IsRunningOn(blacklist.hosts(i))) {
          ++res;
          break;
        }
      }
    }
  }

  return res;
}

Status CatalogManager::FillHeartbeatResponse(const TSHeartbeatRequestPB* req,
                                             TSHeartbeatResponsePB* resp) {
  return Status::OK();
}

Status CatalogManager::GetLoadMoveCompletionPercent(GetLoadMovePercentResponsePB* resp) {
  return GetLoadMoveCompletionPercent(resp, false);
}

Status CatalogManager::GetLeaderBlacklistCompletionPercent(GetLoadMovePercentResponsePB* resp) {
  return GetLoadMoveCompletionPercent(resp, true);
}

Status CatalogManager::GetLoadMoveCompletionPercent(GetLoadMovePercentResponsePB* resp,
                                                    bool blacklist_leader) {
  auto l = ClusterConfig()->LockForRead();

  // Fine to pass in empty defaults if server_blacklist or leader_blacklist is not filled.
  const BlacklistPB& state = blacklist_leader ? l->pb.leader_blacklist()388 : l->pb.server_blacklist()2.06k;
  int64_t blacklist_replicas = GetNumRelevantReplicas(state, blacklist_leader);
  int64_t initial_load = (blacklist_leader) ?
                                state.initial_leader_load()388: state.initial_replica_load();
  // If we are starting up and don't find any load on the tservers, return progress as 0.
  // We expect that by blacklist_progress_initial_delay_secs time, this should go away and if the
  // load is reported as 0 on the blacklisted tservers after this time then it means that
  // the transfer is successfully complete.
  if (blacklist_replicas == 0 &&
  TimeSinceElectedLeader() <= MonoDelta::FromSeconds(FLAGS_blacklist_progress_initial_delay_secs)1.19k) {
      LOG(INFO) << "Master leadership has changed. Reporting progress as 0 until the catalog " <<
                   "manager gets the correct estimates of the remaining load on the blacklisted" <<
                   "tservers.";
      resp->set_percent(0);
      resp->set_total(initial_load);
      resp->set_remaining(initial_load);
      return Status::OK();
  }

  // On change of master leader, initial_load_ information may be lost temporarily. Reset to
  // current value to avoid reporting progress percent as 100. Note that doing so will report
  // progress percent as 0 instead.
  // TODO(Sanket): This might be no longer relevant after we persist and load the initial load
  // on failover. Need to investigate.
  if (initial_load < blacklist_replicas) {
    LOG(INFO) << Format("Initial load: $0, current load: $1."
              " Initial load is less than the current load. Probably a master leader change."
              " Reporting progress as 0", state.initial_replica_load(),
              blacklist_replicas);
    initial_load = blacklist_replicas;
  }

  LOG(INFO) << "Blacklisted count " << blacklist_replicas
            << " across " << state.hosts_size()
            << " servers, with initial load " << initial_load;

  // Case when a blacklisted servers did not have any starting load.
  if (initial_load == 0) {
    resp->set_percent(100);
    return Status::OK();
  }

  resp->set_percent(
      100 - (static_cast<double>(blacklist_replicas) * 100 / initial_load));
  resp->set_remaining(blacklist_replicas);
  resp->set_total(initial_load);

  return Status::OK();
}

void CatalogManager::AbortAndWaitForAllTasks(const vector<scoped_refptr<TableInfo>>& tables) {
  for (const auto& t : tables) {
    VLOG(1) << "Aborting tasks for table " << t->ToString()0;
    t->AbortTasksAndClose();
  }
  for (const auto& t : tables) {
    VLOG(1) << "Waiting on Aborting tasks for table " << t->ToString()0;
    t->WaitTasksCompletion();
  }
  VLOG(1) << "Waiting on Aborting tasks done"0;
}

void CatalogManager::HandleNewTableId(const TableId& table_id) {
  if (table_id == kPgProcTableId) {
    // Needed to track whether initdb has started running.
    pg_proc_exists_.store(true, std::memory_order_release);
  }
}

scoped_refptr<TableInfo> CatalogManager::NewTableInfo(TableId id) {
  return make_scoped_refptr<TableInfo>(id, tasks_tracker_);
}

Status CatalogManager::ScheduleTask(std::shared_ptr<RetryingTSRpcTask> task) {
  Status s = async_task_pool_->SubmitFunc([task]() {
      WARN_NOT_OK(task->Run(), "Failed task");
  });
  // If we are not able to enqueue, abort the task.
  if (!s.ok()) {
    task->AbortAndReturnPrevState(s);
  }
  return s;
}

Status CatalogManager::CollectTable(
    const TableDescription& table_description,
    CollectFlags flags,
    std::vector<TableDescription>* all_tables,
    std::unordered_set<NamespaceId>* parent_colocated_table_ids) {
  auto lock = table_description.table_info->LockForRead();
  if (lock->started_hiding()) {
    VLOG_WITH_PREFIX_AND_FUNC0(4)
        << "Rejected hidden table: " << AsString(table_description.table_info);
    return Status::OK();
  }
  if (lock->started_deleting()) {
    VLOG_WITH_PREFIX_AND_FUNC(4)
        << "Rejected deleted table: " << AsString(table_description.table_info);
    return Status::OK();
  }
  if (flags.Test(CollectFlag::kIncludeParentColocatedTable) && lock->pb.colocated()30) {
    // If a table is colocated, add its parent colocated table as well.
    const auto parent_table_id =
        table_description.namespace_info->id() + kColocatedParentTableIdSuffix;
    auto result = parent_colocated_table_ids->insert(parent_table_id);
    if (result.second) {
      // We have not processed this parent table id yet, so do that now.
      TableIdentifierPB parent_table_pb;
      parent_table_pb.set_table_id(parent_table_id);
      parent_table_pb.mutable_namespace_()->set_id(table_description.namespace_info->id());
      all_tables->push_back(VERIFY_RESULT(DescribeTable(
          parent_table_pb, flags.Test(CollectFlag::kSucceedIfCreateInProgress))));
    }
  }
  all_tables->push_back(table_description);

  if (flags.Test(CollectFlag::kAddIndexes)) {
    TRACE(Substitute("Locking object with id $0", table_description.table_info->id()));

    if (lock->is_index()) {
      return STATUS(InvalidArgument, "Expected table, but found index",
                    table_description.table_info->id(),
                    MasterError(MasterErrorPB::INVALID_TABLE_TYPE));
    }

    if (lock->table_type() == PGSQL_TABLE_TYPE) {
      return STATUS(InvalidArgument, "Getting indexes for YSQL table is not supported",
                    table_description.table_info->id(),
                    MasterError(MasterErrorPB::INVALID_TABLE_TYPE));
    }

    auto collect_index_flags = flags;
    // Don't need to collect indexes for index.
    collect_index_flags.Reset(CollectFlag::kAddIndexes);
    for (const auto& index_info : lock->pb.indexes()) {
      LOG_IF(DFATAL, table_description.table_info->id() != index_info.indexed_table_id())
              << "Wrong indexed table id in index descriptor";
      TableIdentifierPB index_id_pb;
      index_id_pb.set_table_id(index_info.table_id());
      index_id_pb.mutable_namespace_()->set_id(table_description.namespace_info->id());
      auto index_description = VERIFY_RESULT(DescribeTable(
          index_id_pb, flags.Test(CollectFlag::kSucceedIfCreateInProgress)));
      RETURN_NOT_OK(CollectTable(
          index_description, collect_index_flags, all_tables, parent_colocated_table_ids));
    }
  }

  return Status::OK();
}

Result<vector<TableDescription>> CatalogManager::CollectTables(
    const google::protobuf::RepeatedPtrField<TableIdentifierPB>& table_identifiers,
    CollectFlags flags,
    std::unordered_set<NamespaceId>* namespaces) {
  std::vector<std::pair<TableInfoPtr, CollectFlags>> table_with_flags;

  {
    SharedLock lock(mutex_);
    for (const auto& table_id_pb : table_identifiers) {
      if (table_id_pb.table_name().empty() && table_id_pb.table_id().empty()47 &&
          table_id_pb.has_namespace_()39) {
        auto namespace_info = FindNamespaceUnlocked(table_id_pb.namespace_());
        if (!namespace_info.ok()) {
          if (namespace_info.status().IsNotFound()) {
            continue;
          }
          return namespace_info.status();
        }
        if (namespaces) {
          namespaces->insert((**namespace_info).id());
        }


        auto ns_collect_flags = flags;
        // Don't collect indexes, since they should be in the same namespace and will be collected
        // as regular tables.
        // It is necessary because we don't support kAddIndexes for YSQL tables.
        ns_collect_flags.Reset(CollectFlag::kAddIndexes);
        VLOG_WITH_PREFIX_AND_FUNC0(1)
            << "Collecting all tables from: " << (**namespace_info).ToString() << ", specified as: "
            << table_id_pb.namespace_().ShortDebugString();
        for (const auto& id_and_table : *table_ids_map_) {
          if (id_and_table.second->is_system()) {
            VLOG_WITH_PREFIX_AND_FUNC0(4) << "Rejected system table: " << AsString(id_and_table)0;
            continue;
          }
          auto lock = id_and_table.second->LockForRead();
          if (lock->namespace_id() != (**namespace_info).id()) {
            VLOG_WITH_PREFIX_AND_FUNC0(4)
                << "Rejected table from other namespace: " << AsString(id_and_table);
            continue;
          }
          VLOG_WITH_PREFIX_AND_FUNC0(4) << "Accepted: " << AsString(id_and_table)0;
          table_with_flags.emplace_back(id_and_table.second, ns_collect_flags);
        }
      } else {
        auto table = VERIFY_RESULT(FindTableUnlocked(table_id_pb));
        VLOG_WITH_PREFIX_AND_FUNC(1) << "Collecting table: " << table->ToString();
        table_with_flags.emplace_back(table, flags);
      }
    }
  }

  std::sort(table_with_flags.begin(), table_with_flags.end(), [](const auto& p1, const auto& p2) {
    return p1.first->id() < p2.first->id();
  });
  std::vector<TableDescription> all_tables;
  std::unordered_set<NamespaceId> parent_colocated_table_ids;
  const TableId* table_id = nullptr;
  for (auto& table_and_flags : table_with_flags) {
    if (table_id && *table_id == table_and_flags.first->id()7) {
      return STATUS_FORMAT(InternalError, "Table collected twice $0", *table_id);
    }
    auto description = VERIFY_RESULT(DescribeTable(
        table_and_flags.first,
        table_and_flags.second.Test(CollectFlag::kSucceedIfCreateInProgress)));
    RETURN_NOT_OK(CollectTable(
        description, table_and_flags.second, &all_tables, &parent_colocated_table_ids));
    table_id = &table_and_flags.first->id();
  }

  return all_tables;
}

Result<std::vector<TableDescription>> CatalogManager::CollectTables(
    const google::protobuf::RepeatedPtrField<TableIdentifierPB>& table_identifiers,
    bool add_indexes,
    bool include_parent_colocated_table) {
  CollectFlags flags;
  flags.SetIf(CollectFlag::kAddIndexes, add_indexes);
  flags.SetIf(CollectFlag::kIncludeParentColocatedTable, include_parent_colocated_table);
  return CollectTables(table_identifiers, flags);
}

Status CatalogManager::GetYQLPartitionsVTable(std::shared_ptr<SystemTablet>* tablet) {
  scoped_refptr<TableInfo> table = FindPtrOrNull(table_names_map_,
      std::make_pair(kSystemNamespaceId, kSystemPartitionsTableName));
  SCHECK(table != nullptr, NotFound, "YQL system.partitions table not found");

  auto tablets = table->GetTablets();
  SCHECK(tablets.size() == 1, NotFound, "YQL system.partitions tablet not found");
  *tablet = std::dynamic_pointer_cast<SystemTablet>(
      VERIFY_RESULT(GetSystemTablet(tablets[0]->tablet_id())));
  return Status::OK();
}

void CatalogManager::RebuildYQLSystemPartitions() {
  if (YQLPartitionsVTable::GeneratePartitionsVTableWithBgTask() ||
      YQLPartitionsVTable::GeneratePartitionsVTableOnChanges()245k) {
    SCOPED_LEADER_SHARED_LOCK(l, this);
    if (l.catalog_status().ok() && l.leader_status().ok()243k) {
      if (system_partitions_tablet_ != nullptr) {
        Status s;
        if (YQLPartitionsVTable::GeneratePartitionsVTableWithBgTask()) {
          // If we are not generating the vtable on changes, then we need to do a full refresh.
          s = ResultToStatus(GetYqlPartitionsVtable().GenerateAndCacheData());
        } else {
          // Otherwise, we can simply update the cached vtable with the internal map.
          s = GetYqlPartitionsVtable().UpdateCache();
        }
        if (!s.ok()) {
          LOG(ERROR) << "Error rebuilding system.partitions: " << s.ToString();
        }
      } else {
        LOG(ERROR) << "Error finding system.partitions vtable.";
      }
    }
  }

  auto wait_time = FLAGS_partitions_vtable_cache_refresh_secs * 1s;
  if (wait_time <= 0s) {
    wait_time = kDefaultYQLPartitionsRefreshBgTaskSleep;
  }
  refresh_yql_partitions_task_.Schedule([this](const Status& status) {
    WARN_NOT_OK(
        background_tasks_thread_pool_->SubmitFunc([this]() { RebuildYQLSystemPartitions(); }),
        "Failed to schedule: RebuildYQLSystemPartitions");
  }, wait_time);
}

Status CatalogManager::SysCatalogRespectLeaderAffinity() {
  auto l = ClusterConfig()->LockForRead();

  const auto& affinitized_leaders = l->pb.replication_info().affinitized_leaders();
  if (affinitized_leaders.empty()) {
    return Status::OK();
  }

  for (const CloudInfoPB& cloud_info : affinitized_leaders)244 {
    // Do nothing if already in an affinitized zone.
    if (CatalogManagerUtil::IsCloudInfoEqual(cloud_info, server_registration_.cloud_info())) {
      return Status::OK();
    }
  }

  // Not in affinitized zone, try finding a master to send a step down request to.
  std::vector<ServerEntryPB> masters;
  RETURN_NOT_OK(master_->ListMasters(&masters));

  for (const ServerEntryPB& master : masters)92 {
    auto master_cloud_info = master.registration().cloud_info();

    for (const CloudInfoPB& config_cloud_info : affinitized_leaders) {
      if (CatalogManagerUtil::IsCloudInfoEqual(config_cloud_info, master_cloud_info)) {
        if (PREDICT_FALSE(
            GetAtomicFlag(&FLAGS_TEST_crash_server_on_sys_catalog_leader_affinity_move))) {
          LOG_WITH_PREFIX(FATAL) << "For test: Crashing the server instead of performing sys "
                                    "catalog leader affinity move.";
        }
        YB_LOG_WITH_PREFIX_EVERY_N_SECS(INFO, 10)
            << "Sys catalog tablet is not in an affinitized zone, "
            << "sending step down request to master uuid "
            << master.instance_id().permanent_uuid()
            << " in zone "
            << TSDescriptor::generate_placement_id(master_cloud_info);
        std::shared_ptr<TabletPeer> tablet_peer;
        RETURN_NOT_OK(GetTabletPeer(sys_catalog_->tablet_id(), &tablet_peer));

        consensus::LeaderStepDownRequestPB req;
        req.set_tablet_id(sys_catalog_->tablet_id());
        req.set_dest_uuid(sys_catalog_->tablet_peer()->permanent_uuid());
        req.set_new_leader_uuid(master.instance_id().permanent_uuid());

        consensus::LeaderStepDownResponsePB resp;
        RETURN_NOT_OK(tablet_peer->consensus()->StepDown(&req, &resp));
        if (resp.has_error()) {
          YB_LOG_WITH_PREFIX_EVERY_N_SECS(INFO, 10) << "Step down failed: "
                                                    << resp.error().status().message();
          break;
        }
        LOG_WITH_PREFIX(INFO) << "Successfully stepped down to new master";
        return Status::OK();
      }
    }
  }

  return STATUS(NotFound, "Couldn't step down to a master in an affinitized zone");
}

Result<BlacklistSet> CatalogManager::BlacklistSetFromPB() const {
  auto cluster_config = ClusterConfig();
  if (!cluster_config) {
    return STATUS(IllegalState, "Cluster config not found.");
  }
  auto l = cluster_config->LockForRead();

  const auto& blacklist_pb = l->pb.server_blacklist();
  BlacklistSet blacklist_set;
  for (int i = 0; i < blacklist_pb.hosts_size(); i++110) {
    blacklist_set.insert(HostPortFromPB(blacklist_pb.hosts(i)));
  }

  return blacklist_set;
}

void CatalogManager::ProcessTabletStorageMetadata(
    const std::string& ts_uuid,
    const TabletDriveStorageMetadataPB& storage_metadata) {
  const string& tablet_id = storage_metadata.tablet_id();
  scoped_refptr<TabletInfo> tablet;
  {
    SharedLock lock(mutex_);
    tablet = FindPtrOrNull(*tablet_map_, tablet_id);
  }
  if (!tablet) {
    VLOG(1) << Format("Tablet $0 not found on ts $1", tablet_id, ts_uuid);
    return;
  }
  TabletReplicaDriveInfo drive_info{
        storage_metadata.sst_file_size(),
        storage_metadata.wal_file_size(),
        storage_metadata.uncompressed_sst_file_size(),
        storage_metadata.may_have_orphaned_post_split_data()};
  tablet->UpdateReplicaDriveInfo(ts_uuid, drive_info);
}

void CatalogManager::CheckTableDeleted(const TableInfoPtr& table) {
  if (!FLAGS_master_drop_table_after_task_response) {
    return;
  }
  // Since this is called after every successful async DeleteTablet, it's possible if all tasks
  // complete, for us to mark the table as DELETED/HIDDEN asap. This is desirable as clients will
  // wait for this before returning success to the user.
  //
  // However, if tasks fail, timeout, or are aborted, we still have the background thread as a
  // catch all.
  auto lock = MaybeTransitionTableToDeleted(table);
  if (!lock.locked()) {
    return;
  }
  Status s = sys_catalog_->Upsert(leader_ready_term(), table);
  if (!s.ok()) {
    LOG_WITH_PREFIX(WARNING)
        << "Error marking table as "
        << (table->LockForRead()->started_deleting() ? "DELETED" : "HIDDEN"0) << ": " << s;
    return;
  }
  lock.Commit();
}

const YQLPartitionsVTable& CatalogManager::GetYqlPartitionsVtable() const {
  return down_cast<const YQLPartitionsVTable&>(system_partitions_tablet_->QLStorage());
}

void CatalogManager::InitializeTableLoadState(
    const TableId& table_id, TSDescriptorVector ts_descs, CMPerTableLoadState* state) {
  for (const auto& ts : ts_descs) {
    // Touch every tserver with 0 load.
    state->per_ts_load_[ts->permanent_uuid()];
    // Insert into the sorted list.
    state->sorted_load_.emplace_back(ts->permanent_uuid());
  }

  auto table_info = GetTableInfo(table_id);

  if (!table_info) {
    return;
  }
  CatalogManagerUtil::FillTableLoadState(table_info, state);
}

void CatalogManager::InitializeGlobalLoadState(
    TSDescriptorVector ts_descs, CMGlobalLoadState* state) {
  for (const auto& ts : ts_descs) {
    // Touch every tserver with 0 load.
    state->per_ts_load_[ts->permanent_uuid()];
  }

  SharedLock l(mutex_);
  for (const auto& id_and_info : *table_ids_map_) {
    // Ignore system, colocated and deleting/deleted tables.
    {
      auto l = id_and_info.second->LockForRead();
      if (IsSystemTable(*(id_and_info.second)) ||
          id_and_info.second->IsColocatedUserTable()298k ||
          l->started_deleting()297k) {
        continue;
      }
    }
    CatalogManagerUtil::FillTableLoadState(id_and_info.second, state);
  }
}

std::shared_ptr<ClusterConfigInfo> CatalogManager::ClusterConfig() const {
  yb::SharedLock<decltype(config_mutex_)> lock(config_mutex_);
  return cluster_config_;
}

}  // namespace master
}  // namespace yb

YugabyteDB (2.13.1.0-b60, 21121d69985fbf76aa6958d8f04a9bfa936293b5)

Coverage Report

Created: 2022-03-22 16:43